From: Chao Gao <chao.gao@intel.com>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Kevin Tian <kevin.tian@intel.com>, Wei Liu <wei.liu2@citrix.com>,
Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>,
xen-devel@lists.xenproject.org,
Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@suse.de>, Ashok Raj <ashok.raj@intel.com>
Subject: Re: [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading
Date: Fri, 30 Nov 2018 17:01:31 +0800 [thread overview]
Message-ID: <20181130090131.GC32365@gao-cwp> (raw)
In-Reply-To: <20181129095653.d2jwozb7xbuq6cq2@mac>
On Thu, Nov 29, 2018 at 10:56:53AM +0100, Roger Pau Monné wrote:
>On Thu, Nov 29, 2018 at 12:43:25PM +0800, Chao Gao wrote:
>> On Wed, Nov 28, 2018 at 04:22:09PM +0100, Roger Pau Monné wrote:
>> >On Wed, Nov 28, 2018 at 01:34:16PM +0800, Chao Gao wrote:
>> >> This patch ports microcode improvement patches from linux kernel.
>> >>
>> >> Before you read any further: the early loading method is still the
>> >> preferred one and you should always do that. The following patch is
>> >> improving the late loading mechanism for long running jobs and cloud use
>> >> cases.
>> >>
>> >> Gather all cores and serialize the microcode update on them by doing it
>> >> one-by-one to make the late update process as reliable as possible and
>> >> avoid potential issues caused by the microcode update.
>> >>
>> >> Signed-off-by: Chao Gao <chao.gao@intel.com>
>> >> Tested-by: Chao Gao <chao.gao@intel.com>
>> >> [linux commit: a5321aec6412b20b5ad15db2d6b916c05349dbff]
>> >> [linux commit: bb8c13d61a629276a162c1d2b1a20a815cbcfbb7]
>> >
>> >If this patch is the squash of two Linux commits, please post the
>> >ported versions of the two commits separately.
>>
>> I don't understand this one.
>
>You reference two Linux commits above, why is this done?
>
>I assume this is because you are porting two Linux commits to Xen, in
>which case I think that should be done in two different patches, or a
>note needs to be added to why you merge two Linux commits into a
>single Xen patch.
The latter fixed a severe bug introduced the first one. Maybe I need
to add a note to clarify this.
Thanks
Chao
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-11-30 8:58 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-28 5:34 [PATCH v4 0/6] improve late microcode loading Chao Gao
2018-11-28 5:34 ` [PATCH v4 1/6] microcode/intel: extend microcode_update_match() Chao Gao
2018-11-28 10:58 ` Roger Pau Monné
2018-11-29 2:00 ` Chao Gao
2018-11-29 9:14 ` Roger Pau Monné
2018-11-28 5:34 ` [PATCH v4 2/6] microcode: save all microcodes which pass sanity check Chao Gao
2018-11-28 12:00 ` Roger Pau Monné
2018-11-29 2:40 ` Chao Gao
2018-11-29 9:22 ` Roger Pau Monné
2018-11-30 7:55 ` Chao Gao
2018-11-30 9:32 ` Jan Beulich
2019-01-15 15:07 ` Andrew Cooper
2018-12-04 22:39 ` Woods, Brian
2018-12-05 7:38 ` Chao Gao
2018-11-29 10:19 ` Jan Beulich
2019-01-15 15:15 ` Andrew Cooper
2018-11-28 5:34 ` [PATCH v4 3/6] microcode: delete 'mc' field from struct ucode_cpu_info Chao Gao
2018-11-28 12:32 ` Roger Pau Monné
2018-11-28 5:34 ` [PATCH v4 4/6] microcode: don't call apply_microcode() in cpu_request_microcode() Chao Gao
2018-11-28 15:02 ` Roger Pau Monné
2018-11-29 4:28 ` Chao Gao
2018-11-29 9:46 ` Roger Pau Monné
2018-11-30 8:57 ` Chao Gao
2018-11-30 9:38 ` Jan Beulich
2018-11-28 5:34 ` [PATCH v4 5/6] microcode: delete microcode pointer and size from microcode_info Chao Gao
2018-11-28 15:04 ` Roger Pau Monné
2018-11-28 5:34 ` [PATCH v4 6/6] x86/microcode: Synchronize late microcode loading Chao Gao
2018-11-28 15:22 ` Roger Pau Monné
2018-11-29 4:43 ` Chao Gao
2018-11-29 9:56 ` Roger Pau Monné
2018-11-29 22:43 ` Boris Ostrovsky
2018-11-30 9:46 ` Jan Beulich
2018-11-30 16:49 ` Boris Ostrovsky
2018-11-30 9:01 ` Chao Gao [this message]
2019-01-15 15:24 ` Andrew Cooper
2019-01-15 16:24 ` Roger Pau Monné
2018-12-11 17:01 ` Jan Beulich
2018-12-11 18:16 ` Raj, Ashok
2018-12-12 7:26 ` Jan Beulich
2018-12-13 2:10 ` Boris Ostrovsky
2018-12-12 4:53 ` Chao Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181130090131.GC32365@gao-cwp \
--to=chao.gao@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=ashok.raj@intel.com \
--cc=bp@suse.de \
--cc=jbeulich@suse.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=roger.pau@citrix.com \
--cc=tglx@linutronix.de \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.