From: Keith Busch <keith.busch@intel.com> To: Christoph Hellwig <hch@lst.de> Cc: Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>, Max Gurtovoy <maxg@mellanox.com>, "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org> Subject: Re: [PATCH 01/13] block: move queues types to the block layer Date: Fri, 30 Nov 2018 07:40:20 -0700 [thread overview] Message-ID: <20181130144020.GH9377@localhost.localdomain> (raw) In-Reply-To: <20181130080013.GB18936@lst.de> On Fri, Nov 30, 2018 at 12:00:13AM -0800, Christoph Hellwig wrote: > On Thu, Nov 29, 2018 at 01:19:14PM -0700, Keith Busch wrote: > > On Thu, Nov 29, 2018 at 08:12:58PM +0100, Christoph Hellwig wrote: > > > +enum hctx_type { > > > + HCTX_TYPE_DEFAULT, /* all I/O not otherwise accounted for */ > > > + HCTX_TYPE_READ, /* just for READ I/O */ > > > + HCTX_TYPE_POLL, /* polled I/O of any kind */ > > > + > > > + HCTX_MAX_TYPES, > > > }; > > > > Well, there goes my plan to use this with Weighted-Round-Robin NVMe IO > > queues! > > Wo between what do you even want to round robin? If it is between > reads and writes that's easy. If we want priority reads or writes > (separate from polling) that's also still fairly easily. I was considering the IOPRIO_PRIO_CLASS. There are four of them, which may roughly correspond to the four NVMe IO queues weights. Maybe even through HIPRI flagged IOs with the RT class. > Btw, one thing I wanted to try once I get hold of the right hardware > is to mark the poll queues as priority queues and see if that makes > any differents in poll IOPS/latency. I doubt it will make much difference in IOPS, but should improve latency on hipri IOs at the expense of normal IO since hipri will be fetched ahead during command arbitrarion.
WARNING: multiple messages have this Message-ID (diff)
From: keith.busch@intel.com (Keith Busch) Subject: [PATCH 01/13] block: move queues types to the block layer Date: Fri, 30 Nov 2018 07:40:20 -0700 [thread overview] Message-ID: <20181130144020.GH9377@localhost.localdomain> (raw) In-Reply-To: <20181130080013.GB18936@lst.de> On Fri, Nov 30, 2018@12:00:13AM -0800, Christoph Hellwig wrote: > On Thu, Nov 29, 2018@01:19:14PM -0700, Keith Busch wrote: > > On Thu, Nov 29, 2018@08:12:58PM +0100, Christoph Hellwig wrote: > > > +enum hctx_type { > > > + HCTX_TYPE_DEFAULT, /* all I/O not otherwise accounted for */ > > > + HCTX_TYPE_READ, /* just for READ I/O */ > > > + HCTX_TYPE_POLL, /* polled I/O of any kind */ > > > + > > > + HCTX_MAX_TYPES, > > > }; > > > > Well, there goes my plan to use this with Weighted-Round-Robin NVMe IO > > queues! > > Wo between what do you even want to round robin? If it is between > reads and writes that's easy. If we want priority reads or writes > (separate from polling) that's also still fairly easily. I was considering the IOPRIO_PRIO_CLASS. There are four of them, which may roughly correspond to the four NVMe IO queues weights. Maybe even through HIPRI flagged IOs with the RT class. > Btw, one thing I wanted to try once I get hold of the right hardware > is to mark the poll queues as priority queues and see if that makes > any differents in poll IOPS/latency. I doubt it will make much difference in IOPS, but should improve latency on hipri IOs at the expense of normal IO since hipri will be fetched ahead during command arbitrarion.
next prev parent reply other threads:[~2018-11-30 14:43 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-29 19:12 block and nvme polling improvements V2 Christoph Hellwig 2018-11-29 19:12 ` Christoph Hellwig 2018-11-29 19:12 ` [PATCH 01/13] block: move queues types to the block layer Christoph Hellwig 2018-11-29 19:12 ` Christoph Hellwig 2018-11-29 19:50 ` Jens Axboe 2018-11-29 19:50 ` Jens Axboe 2018-11-30 7:56 ` Christoph Hellwig 2018-11-30 7:56 ` Christoph Hellwig 2018-11-30 15:20 ` Jens Axboe 2018-11-30 15:20 ` Jens Axboe 2018-11-30 15:21 ` Christoph Hellwig 2018-11-30 15:21 ` Christoph Hellwig 2018-11-29 20:19 ` Keith Busch 2018-11-29 20:19 ` Keith Busch 2018-11-29 20:25 ` Jens Axboe 2018-11-29 20:25 ` Jens Axboe 2018-11-30 8:00 ` Christoph Hellwig 2018-11-30 8:00 ` Christoph Hellwig 2018-11-30 14:40 ` Keith Busch [this message] 2018-11-30 14:40 ` Keith Busch 2018-11-30 15:20 ` Jens Axboe 2018-11-30 15:20 ` Jens Axboe 2018-11-29 19:12 ` [PATCH 02/13] nvme-pci: use atomic bitops to mark a queue enabled Christoph Hellwig 2018-11-29 19:12 ` Christoph Hellwig 2018-11-29 20:19 ` Keith Busch 2018-11-29 20:19 ` Keith Busch 2018-11-29 19:13 ` [PATCH 03/13] nvme-pci: cleanup SQ allocation a bit Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 20:22 ` Keith Busch 2018-11-29 20:22 ` Keith Busch 2018-11-29 19:13 ` [PATCH 04/13] nvme-pci: only allow polling with separate poll queues Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 05/13] nvme-pci: consolidate code for polling non-dedicated queues Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 06/13] nvme-pci: refactor nvme_disable_io_queues Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 20:37 ` Keith Busch 2018-11-29 20:37 ` Keith Busch 2018-11-29 19:13 ` [PATCH 07/13] nvme-pci: don't poll from irq context when deleting queues Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 20:36 ` Keith Busch 2018-11-29 20:36 ` Keith Busch 2018-11-30 8:08 ` Christoph Hellwig 2018-11-30 8:08 ` Christoph Hellwig 2018-11-30 14:45 ` Keith Busch 2018-11-30 14:45 ` Keith Busch 2018-11-29 19:13 ` [PATCH 08/13] nvme-pci: remove the CQ lock for interrupt driven queues Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 21:08 ` Keith Busch 2018-11-29 21:08 ` Keith Busch 2018-11-30 8:16 ` Christoph Hellwig 2018-11-30 8:16 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 09/13] nvme-rdma: remove I/O polling support Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 10/13] nvme-mpath: " Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 11/13] block: remove ->poll_fn Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 12/13] block: only allow polling if a poll queue_map exists Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig 2018-11-29 19:13 ` [PATCH 13/13] block: enable polling by default if a poll map is initalized Christoph Hellwig 2018-11-29 19:13 ` Christoph Hellwig -- strict thread matches above, loose matches on Subject: below -- 2018-12-02 16:46 block and nvme polling improvements V3 Christoph Hellwig 2018-12-02 16:46 ` [PATCH 01/13] block: move queues types to the block layer Christoph Hellwig 2018-12-02 16:46 ` Christoph Hellwig 2018-12-04 0:49 ` Sagi Grimberg 2018-12-04 0:49 ` Sagi Grimberg 2018-12-04 15:00 ` Christoph Hellwig 2018-12-04 15:00 ` Christoph Hellwig 2018-12-04 17:08 ` Sagi Grimberg 2018-12-04 17:08 ` Sagi Grimberg 2018-11-21 16:23 block and nvme polling improvements Christoph Hellwig 2018-11-21 16:23 ` [PATCH 01/13] block: move queues types to the block layer Christoph Hellwig 2018-11-21 16:23 ` Christoph Hellwig
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181130144020.GH9377@localhost.localdomain \ --to=keith.busch@intel.com \ --cc=axboe@fb.com \ --cc=hch@lst.de \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=maxg@mellanox.com \ --cc=sagi@grimberg.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.