* [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
@ 2018-12-01 2:06 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2018-12-01 1:57 UTC (permalink / raw)
To: jglisse, akpm, sfr, dan.j.williams
Cc: YueHaibing, linux-mm, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
mm/hmm.c: In function 'hmm_devmem_ref_kill':
mm/hmm.c:995:21: warning:
variable 'devmem' set but not used [-Wunused-but-set-variable]
It not used any more since commit 35d39f953d4e ("mm, hmm: replace
hmm_devmem_pages_create() with devm_memremap_pages()")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
mm/hmm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mm/hmm.c b/mm/hmm.c
index 50fbaf8..361f370 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
static void hmm_devmem_ref_kill(struct percpu_ref *ref)
{
- struct hmm_devmem *devmem;
-
- devmem = container_of(ref, struct hmm_devmem, ref);
percpu_ref_kill(ref);
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
@ 2018-12-01 2:06 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2018-12-01 2:06 UTC (permalink / raw)
To: jglisse, akpm, sfr, dan.j.williams
Cc: YueHaibing, linux-mm, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
mm/hmm.c: In function 'hmm_devmem_ref_kill':
mm/hmm.c:995:21: warning:
variable 'devmem' set but not used [-Wunused-but-set-variable]
It not used any more since commit 35d39f953d4e ("mm, hmm: replace
hmm_devmem_pages_create() with devm_memremap_pages()")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
mm/hmm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mm/hmm.c b/mm/hmm.c
index 50fbaf8..361f370 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
static void hmm_devmem_ref_kill(struct percpu_ref *ref)
{
- struct hmm_devmem *devmem;
-
- devmem = container_of(ref, struct hmm_devmem, ref);
percpu_ref_kill(ref);
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
@ 2018-12-01 2:06 ` YueHaibing
0 siblings, 0 replies; 8+ messages in thread
From: YueHaibing @ 2018-12-01 2:06 UTC (permalink / raw)
To: jglisse, akpm, sfr, dan.j.williams
Cc: YueHaibing, linux-mm, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
mm/hmm.c: In function 'hmm_devmem_ref_kill':
mm/hmm.c:995:21: warning:
variable 'devmem' set but not used [-Wunused-but-set-variable]
It not used any more since commit 35d39f953d4e ("mm, hmm: replace
hmm_devmem_pages_create() with devm_memremap_pages()")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
mm/hmm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mm/hmm.c b/mm/hmm.c
index 50fbaf8..361f370 100644
--- a/mm/hmm.c
+++ b/mm/hmm.c
@@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
static void hmm_devmem_ref_kill(struct percpu_ref *ref)
{
- struct hmm_devmem *devmem;
-
- devmem = container_of(ref, struct hmm_devmem, ref);
percpu_ref_kill(ref);
}
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
2018-12-01 2:06 ` YueHaibing
(?)
@ 2018-12-03 0:48 ` Jerome Glisse
-1 siblings, 0 replies; 8+ messages in thread
From: Jerome Glisse @ 2018-12-03 0:48 UTC (permalink / raw)
To: YueHaibing
Cc: akpm, sfr, dan.j.williams, linux-mm, linux-kernel, kernel-janitors
On Sat, Dec 01, 2018 at 02:06:11AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> mm/hmm.c: In function 'hmm_devmem_ref_kill':
> mm/hmm.c:995:21: warning:
> variable 'devmem' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit 35d39f953d4e ("mm, hmm: replace
> hmm_devmem_pages_create() with devm_memremap_pages()")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
> ---
> mm/hmm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 50fbaf8..361f370 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
>
> static void hmm_devmem_ref_kill(struct percpu_ref *ref)
> {
> - struct hmm_devmem *devmem;
> -
> - devmem = container_of(ref, struct hmm_devmem, ref);
> percpu_ref_kill(ref);
> }
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
@ 2018-12-03 0:48 ` Jerome Glisse
0 siblings, 0 replies; 8+ messages in thread
From: Jerome Glisse @ 2018-12-03 0:48 UTC (permalink / raw)
To: YueHaibing
Cc: akpm, sfr, dan.j.williams, linux-mm, linux-kernel, kernel-janitors
On Sat, Dec 01, 2018 at 02:06:11AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> mm/hmm.c: In function 'hmm_devmem_ref_kill':
> mm/hmm.c:995:21: warning:
> variable 'devmem' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit 35d39f953d4e ("mm, hmm: replace
> hmm_devmem_pages_create() with devm_memremap_pages()")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Jérôme Glisse <jglisse@redhat.com>
> ---
> mm/hmm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 50fbaf8..361f370 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
>
> static void hmm_devmem_ref_kill(struct percpu_ref *ref)
> {
> - struct hmm_devmem *devmem;
> -
> - devmem = container_of(ref, struct hmm_devmem, ref);
> percpu_ref_kill(ref);
> }
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
@ 2018-12-03 0:48 ` Jerome Glisse
0 siblings, 0 replies; 8+ messages in thread
From: Jerome Glisse @ 2018-12-03 0:48 UTC (permalink / raw)
To: YueHaibing
Cc: akpm, sfr, dan.j.williams, linux-mm, linux-kernel, kernel-janitors
On Sat, Dec 01, 2018 at 02:06:11AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> mm/hmm.c: In function 'hmm_devmem_ref_kill':
> mm/hmm.c:995:21: warning:
> variable 'devmem' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit 35d39f953d4e ("mm, hmm: replace
> hmm_devmem_pages_create() with devm_memremap_pages()")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: J�r�me Glisse <jglisse@redhat.com>
> ---
> mm/hmm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 50fbaf8..361f370 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
>
> static void hmm_devmem_ref_kill(struct percpu_ref *ref)
> {
> - struct hmm_devmem *devmem;
> -
> - devmem = container_of(ref, struct hmm_devmem, ref);
> percpu_ref_kill(ref);
> }
>
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
2018-12-01 2:06 ` YueHaibing
@ 2018-12-03 11:11 ` David Hildenbrand
-1 siblings, 0 replies; 8+ messages in thread
From: David Hildenbrand @ 2018-12-03 11:11 UTC (permalink / raw)
To: YueHaibing, jglisse, akpm, sfr, dan.j.williams
Cc: linux-mm, linux-kernel, kernel-janitors
On 01.12.18 03:06, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> mm/hmm.c: In function 'hmm_devmem_ref_kill':
> mm/hmm.c:995:21: warning:
> variable 'devmem' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit 35d39f953d4e ("mm, hmm: replace
> hmm_devmem_pages_create() with devm_memremap_pages()")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> mm/hmm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 50fbaf8..361f370 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
>
> static void hmm_devmem_ref_kill(struct percpu_ref *ref)
> {
> - struct hmm_devmem *devmem;
> -
> - devmem = container_of(ref, struct hmm_devmem, ref);
> percpu_ref_kill(ref);
> }
>
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH -next] mm/hmm: remove set but not used variable 'devmem'
@ 2018-12-03 11:11 ` David Hildenbrand
0 siblings, 0 replies; 8+ messages in thread
From: David Hildenbrand @ 2018-12-03 11:11 UTC (permalink / raw)
To: YueHaibing, jglisse, akpm, sfr, dan.j.williams
Cc: linux-mm, linux-kernel, kernel-janitors
On 01.12.18 03:06, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> mm/hmm.c: In function 'hmm_devmem_ref_kill':
> mm/hmm.c:995:21: warning:
> variable 'devmem' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit 35d39f953d4e ("mm, hmm: replace
> hmm_devmem_pages_create() with devm_memremap_pages()")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> mm/hmm.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/mm/hmm.c b/mm/hmm.c
> index 50fbaf8..361f370 100644
> --- a/mm/hmm.c
> +++ b/mm/hmm.c
> @@ -992,9 +992,6 @@ static void hmm_devmem_ref_exit(void *data)
>
> static void hmm_devmem_ref_kill(struct percpu_ref *ref)
> {
> - struct hmm_devmem *devmem;
> -
> - devmem = container_of(ref, struct hmm_devmem, ref);
> percpu_ref_kill(ref);
> }
>
>
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-12-03 11:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-01 1:57 [PATCH -next] mm/hmm: remove set but not used variable 'devmem' YueHaibing
2018-12-01 2:06 ` YueHaibing
2018-12-01 2:06 ` YueHaibing
2018-12-03 0:48 ` Jerome Glisse
2018-12-03 0:48 ` Jerome Glisse
2018-12-03 0:48 ` Jerome Glisse
2018-12-03 11:11 ` David Hildenbrand
2018-12-03 11:11 ` David Hildenbrand
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.