* [Buildroot] [PATCH 1/1] libbsd: fix display of comment
@ 2018-12-02 10:25 Fabrice Fontaine
2018-12-03 8:14 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2018-12-02 10:25 UTC (permalink / raw)
To: buildroot
Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added
depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
to display the comment "libbsd needs a toolchain w/ threads, wchar"
Set the correct dependency:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/libbsd/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/libbsd/Config.in b/package/libbsd/Config.in
index ba5e5cbcfa..ce50ec37de 100644
--- a/package/libbsd/Config.in
+++ b/package/libbsd/Config.in
@@ -24,5 +24,5 @@ config BR2_PACKAGE_LIBBSD
comment "libbsd needs a toolchain w/ threads, wchar"
depends on BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
- depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
+ depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_USE_WCHAR
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH 1/1] libbsd: fix display of comment
2018-12-02 10:25 [Buildroot] [PATCH 1/1] libbsd: fix display of comment Fabrice Fontaine
@ 2018-12-03 8:14 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2018-12-03 8:14 UTC (permalink / raw)
To: buildroot
Hello Fabrice,
On Sun, 2 Dec 2018 11:25:51 +0100, Fabrice Fontaine wrote:
> Commit e13855c48f21eaee07a81f8b02678839be274a45 wrongly added
> depends on BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU
> to display the comment "libbsd needs a toolchain w/ threads, wchar"
>
> Set the correct dependency:
> depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Instead of this (and the related minizip change), what about moving the:
depends on !(BR2_TOOLCHAIN_USES_UCLIBC && !BR2_USE_MMU)
to BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS ?
Since we don't display a comment about it, it is effectively treated
like an architecture dependency, and it kind of is, since anyway the
only C library that supports noMMU systems is uClibc (yes, musl
supports noMMU on SH2, but we don't support that in Buildroot).
Having this dependency directly in BR2_PACKAGE_LIBBSD_ARCH_SUPPORTS
avoid the need to replicate it to all reverse dependencies of libbsd
(and therefore the reverse dependencies should be changed as well).
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-03 8:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-02 10:25 [Buildroot] [PATCH 1/1] libbsd: fix display of comment Fabrice Fontaine
2018-12-03 8:14 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.