* [PATCH v2] drm/i915/gvt: Fix tiled memory decoding bug on BDW
@ 2018-12-03 8:29 Tina Zhang
2018-12-03 9:23 ` Zhenyu Wang
0 siblings, 1 reply; 2+ messages in thread
From: Tina Zhang @ 2018-12-03 8:29 UTC (permalink / raw)
Cc: Tina Zhang, intel-gvt-dev, stable, #, v4.19+, Zhenyu Wang
Commit b244ffa15c8b ("drm/i915/gvt: Fix drm_format_mod value for vGPU
plane") introduced a regression issue to the tiled memory decoding on BDW.
This patch can fix this issue.
Here is the issue detail: https://github.com/intel/gvt-linux/issues/61
v1->v2:
- Refine the commit message. (Zhenyu)
Fixes: b244ffa15c8b("drm/i915/gvt: Fix drm_format_mod value for vGPU plane")
Signed-off-by: Tina Zhang <tina.zhang@intel.com>
Cc: stable@vger.kernel.org # v4.19+
Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
---
drivers/gpu/drm/i915/gvt/fb_decoder.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gvt/fb_decoder.c b/drivers/gpu/drm/i915/gvt/fb_decoder.c
index 481896f..85e6736 100644
--- a/drivers/gpu/drm/i915/gvt/fb_decoder.c
+++ b/drivers/gpu/drm/i915/gvt/fb_decoder.c
@@ -235,7 +235,7 @@ int intel_vgpu_decode_primary_plane(struct intel_vgpu *vgpu,
plane->bpp = skl_pixel_formats[fmt].bpp;
plane->drm_format = skl_pixel_formats[fmt].drm_format;
} else {
- plane->tiled = !!(val & DISPPLANE_TILED);
+ plane->tiled = val & DISPPLANE_TILED;
fmt = bdw_format_to_drm(val & DISPPLANE_PIXFORMAT_MASK);
plane->bpp = bdw_pixel_formats[fmt].bpp;
plane->drm_format = bdw_pixel_formats[fmt].drm_format;
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] drm/i915/gvt: Fix tiled memory decoding bug on BDW
2018-12-03 8:29 [PATCH v2] drm/i915/gvt: Fix tiled memory decoding bug on BDW Tina Zhang
@ 2018-12-03 9:23 ` Zhenyu Wang
0 siblings, 0 replies; 2+ messages in thread
From: Zhenyu Wang @ 2018-12-03 9:23 UTC (permalink / raw)
To: Tina Zhang; +Cc: intel-gvt-dev, stable
[-- Attachment #1: Type: text/plain, Size: 1538 bytes --]
On 2018.12.03 16:29:23 +0800, Tina Zhang wrote:
> Commit b244ffa15c8b ("drm/i915/gvt: Fix drm_format_mod value for vGPU
> plane") introduced a regression issue to the tiled memory decoding on BDW.
>
> This patch can fix this issue.
>
> Here is the issue detail: https://github.com/intel/gvt-linux/issues/61
>
> v1->v2:
> - Refine the commit message. (Zhenyu)
>
> Fixes: b244ffa15c8b("drm/i915/gvt: Fix drm_format_mod value for vGPU plane")
> Signed-off-by: Tina Zhang <tina.zhang@intel.com>
> Cc: stable@vger.kernel.org # v4.19+
> Cc: Zhenyu Wang <zhenyuw@linux.intel.com>
> ---
> drivers/gpu/drm/i915/gvt/fb_decoder.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/fb_decoder.c b/drivers/gpu/drm/i915/gvt/fb_decoder.c
> index 481896f..85e6736 100644
> --- a/drivers/gpu/drm/i915/gvt/fb_decoder.c
> +++ b/drivers/gpu/drm/i915/gvt/fb_decoder.c
> @@ -235,7 +235,7 @@ int intel_vgpu_decode_primary_plane(struct intel_vgpu *vgpu,
> plane->bpp = skl_pixel_formats[fmt].bpp;
> plane->drm_format = skl_pixel_formats[fmt].drm_format;
> } else {
> - plane->tiled = !!(val & DISPPLANE_TILED);
> + plane->tiled = val & DISPPLANE_TILED;
> fmt = bdw_format_to_drm(val & DISPPLANE_PIXFORMAT_MASK);
> plane->bpp = bdw_pixel_formats[fmt].bpp;
> plane->drm_format = bdw_pixel_formats[fmt].drm_format;
> --
> 2.7.4
>
Applied. Thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-03 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-03 8:29 [PATCH v2] drm/i915/gvt: Fix tiled memory decoding bug on BDW Tina Zhang
2018-12-03 9:23 ` Zhenyu Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.