From: Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> To: Andrew Morton <akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> Cc: "linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Andy Shevchenko <andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>, linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Tony Battersby <tonyb-vFAe+i1/wJI5UWNf+nJyDw@public.gmane.org> Subject: Re: [PATCH v4 9/9] dmapool: debug: prevent endless loop in case of corruption Date: Tue, 4 Dec 2018 12:18:01 -0800 [thread overview] Message-ID: <20181204201801.GS10377@bombadil.infradead.org> (raw) In-Reply-To: <20181204121443.1430883634a6ecf5f4a6a4a2-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> On Tue, Dec 04, 2018 at 12:14:43PM -0800, Andrew Morton wrote: > On Tue, 4 Dec 2018 11:22:34 -0500 Tony Battersby <tonyb-vFAe+i1/wJI5UWNf+nJyDw@public.gmane.org> wrote: > > > On 11/13/18 1:36 AM, Matthew Wilcox wrote: > > > On Mon, Nov 12, 2018 at 10:46:35AM -0500, Tony Battersby wrote: > > >> Prevent a possible endless loop with DMAPOOL_DEBUG enabled if a buggy > > >> driver corrupts DMA pool memory. > > >> > > >> Signed-off-by: Tony Battersby <tonyb-vFAe+i1/wJI5UWNf+nJyDw@public.gmane.org> > > > I like it! Also, here you're using blks_per_alloc in a way which isn't > > > normally in the performance path, but might be with the right config > > > options. With that, I withdraw my objection to the previous patch and > > > > > > Acked-by: Matthew Wilcox <willy-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> > > > > > > Andrew, can you funnel these in through your tree? If you'd rather not, > > > I don't mind stuffing them into a git tree and asking Linus to pull > > > for 4.21. > > > > > No reply for 3 weeks, so adding Andrew Morton to recipient list. > > > > Andrew, I have 9 dmapool patches ready for merging in 4.21. See Matthew > > Wilcox's request above. > > > > I'll take a look, but I see that this v4 series has several review > comments from Matthew which remain unresponded to. Please attend to > that. I only had a review comment on 8/9, which I then withdrew during my review of patch 9/9. Unless I missed something during my re-review of my responses? > Also, Andy had issues with the v2 series so it would be good to hear an > update from him? Certainly.
WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox <willy@infradead.org> To: Andrew Morton <akpm@linux-foundation.org> Cc: Tony Battersby <tonyb@cybernetics.com>, Christoph Hellwig <hch@lst.de>, Marek Szyprowski <m.szyprowski@samsung.com>, iommu@lists.linux-foundation.org, linux-mm@kvack.org, "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>, Andy Shevchenko <andy.shevchenko@gmail.com> Subject: Re: [PATCH v4 9/9] dmapool: debug: prevent endless loop in case of corruption Date: Tue, 4 Dec 2018 12:18:01 -0800 [thread overview] Message-ID: <20181204201801.GS10377@bombadil.infradead.org> (raw) In-Reply-To: <20181204121443.1430883634a6ecf5f4a6a4a2@linux-foundation.org> On Tue, Dec 04, 2018 at 12:14:43PM -0800, Andrew Morton wrote: > On Tue, 4 Dec 2018 11:22:34 -0500 Tony Battersby <tonyb@cybernetics.com> wrote: > > > On 11/13/18 1:36 AM, Matthew Wilcox wrote: > > > On Mon, Nov 12, 2018 at 10:46:35AM -0500, Tony Battersby wrote: > > >> Prevent a possible endless loop with DMAPOOL_DEBUG enabled if a buggy > > >> driver corrupts DMA pool memory. > > >> > > >> Signed-off-by: Tony Battersby <tonyb@cybernetics.com> > > > I like it! Also, here you're using blks_per_alloc in a way which isn't > > > normally in the performance path, but might be with the right config > > > options. With that, I withdraw my objection to the previous patch and > > > > > > Acked-by: Matthew Wilcox <willy@infradead.org> > > > > > > Andrew, can you funnel these in through your tree? If you'd rather not, > > > I don't mind stuffing them into a git tree and asking Linus to pull > > > for 4.21. > > > > > No reply for 3 weeks, so adding Andrew Morton to recipient list. > > > > Andrew, I have 9 dmapool patches ready for merging in 4.21.� See Matthew > > Wilcox's request above. > > > > I'll take a look, but I see that this v4 series has several review > comments from Matthew which remain unresponded to. Please attend to > that. I only had a review comment on 8/9, which I then withdrew during my review of patch 9/9. Unless I missed something during my re-review of my responses? > Also, Andy had issues with the v2 series so it would be good to hear an > update from him? Certainly.
next prev parent reply other threads:[~2018-12-04 20:18 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-12 15:46 [PATCH v4 9/9] dmapool: debug: prevent endless loop in case of corruption Tony Battersby 2018-11-12 15:46 ` Tony Battersby [not found] ` <9e65ec2e-5e22-4f65-7b92-ca2af0c555f3-vFAe+i1/wJI5UWNf+nJyDw@public.gmane.org> 2018-11-13 6:36 ` Matthew Wilcox 2018-11-13 6:36 ` Matthew Wilcox [not found] ` <20181113063601.GT21824-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org> 2018-12-04 16:22 ` Tony Battersby 2018-12-04 16:22 ` Tony Battersby [not found] ` <4dcb22b0-a348-841d-8175-e368f67f33c3-vFAe+i1/wJI5UWNf+nJyDw@public.gmane.org> 2018-12-04 20:14 ` Andrew Morton 2018-12-04 20:14 ` Andrew Morton [not found] ` <20181204121443.1430883634a6ecf5f4a6a4a2-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> 2018-12-04 20:18 ` Matthew Wilcox [this message] 2018-12-04 20:18 ` Matthew Wilcox [not found] ` <20181204201801.GS10377-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org> 2018-12-04 20:28 ` Andrew Morton 2018-12-04 20:28 ` Andrew Morton [not found] ` <20181204122854.339503ccbbdc638940c9e1d0-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org> 2018-12-04 20:35 ` Matthew Wilcox 2018-12-04 20:35 ` Matthew Wilcox 2018-12-04 20:30 ` Andy Shevchenko 2018-12-04 20:30 ` Andy Shevchenko [not found] ` <CAHp75VeCHnUcE8mfUkx_uXz9_ZoA+hAvVtFiFP+nLj4rJevBdw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-12-04 21:26 ` Tony Battersby 2018-12-04 21:26 ` Tony Battersby [not found] ` <495c7e22-9332-1654-9ee0-63c33fae980e-vFAe+i1/wJI5UWNf+nJyDw@public.gmane.org> 2018-12-04 22:05 ` Andy Shevchenko 2018-12-04 22:05 ` Andy Shevchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181204201801.GS10377@bombadil.infradead.org \ --to=willy-wegcikhe2lqwvfeawa7xhq@public.gmane.org \ --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \ --cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ --cc=hch-jcswGhMUV9g@public.gmane.org \ --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \ --cc=linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org \ --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=tonyb-vFAe+i1/wJI5UWNf+nJyDw@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.