All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const
@ 2018-12-04 12:22 Daniel Vetter
  2018-12-04 12:51 ` Petri Latvala
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Daniel Vetter @ 2018-12-04 12:22 UTC (permalink / raw)
  To: IGT development; +Cc: Daniel Vetter

My gcc is unhappy otherwise:

[191/829] Compiling C object 'tests/te...otation_crc@exe/kms_rotation_crc.c.o'.
../tests/kms_rotation_crc.c: In function ‘test_multi_plane_rotation’:
../tests/kms_rotation_crc.c:497:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
  const static struct {
  ^~~~~
../tests/kms_rotation_crc.c:524:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
  const static uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
  ^~~~~

Fixes

commit 14c1b132c8f829637c55fb071a9a2e5ce00e7ed8
Author: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Date:   Fri Nov 30 15:34:36 2018 +0200

    tests/kms_rotation_crc: Add multi plane tests

Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com
Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/kms_rotation_crc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index 369936f94528..05349dab5f79 100644
--- a/tests/kms_rotation_crc.c
+++ b/tests/kms_rotation_crc.c
@@ -494,7 +494,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
 	struct p_struct *oldplanes;
 	drmModeModeInfo *mode;
 
-	const static struct {
+	static const struct {
 		igt_rotation_t rotation;
 		float_t width;
 		float_t height;
@@ -521,7 +521,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
 	* TODO:
 	* Built support for NV12 here.
 	*/
-	const static uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
+	static const uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
 					       DRM_FORMAT_XRGB8888};
 
 	for_each_valid_output_on_pipe(display, pipe, output) {
-- 
2.20.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const
  2018-12-04 12:22 [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const Daniel Vetter
@ 2018-12-04 12:51 ` Petri Latvala
  2018-12-04 13:43   ` Daniel Vetter
  2018-12-04 13:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Petri Latvala @ 2018-12-04 12:51 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: IGT development, Daniel Vetter

On Tue, Dec 04, 2018 at 01:22:15PM +0100, Daniel Vetter wrote:
> My gcc is unhappy otherwise:
> 
> [191/829] Compiling C object 'tests/te...otation_crc@exe/kms_rotation_crc.c.o'.
> ../tests/kms_rotation_crc.c: In function ‘test_multi_plane_rotation’:
> ../tests/kms_rotation_crc.c:497:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>   const static struct {
>   ^~~~~
> ../tests/kms_rotation_crc.c:524:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>   const static uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
>   ^~~~~
> 
> Fixes
> 
> commit 14c1b132c8f829637c55fb071a9a2e5ce00e7ed8
> Author: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Date:   Fri Nov 30 15:34:36 2018 +0200
> 
>     tests/kms_rotation_crc: Add multi plane tests
> 
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  tests/kms_rotation_crc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 369936f94528..05349dab5f79 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -494,7 +494,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
>  	struct p_struct *oldplanes;
>  	drmModeModeInfo *mode;
>  
> -	const static struct {
> +	static const struct {
>  		igt_rotation_t rotation;
>  		float_t width;
>  		float_t height;
> @@ -521,7 +521,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
>  	* TODO:
>  	* Built support for NV12 here.
>  	*/
> -	const static uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
> +	static const uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
>  					       DRM_FORMAT_XRGB8888};

                             ^
Trim this extra space while at it too.



Reviewed-by: Petri Latvala <petri.latvala@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const
  2018-12-04 12:51 ` Petri Latvala
@ 2018-12-04 13:43   ` Daniel Vetter
  0 siblings, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2018-12-04 13:43 UTC (permalink / raw)
  To: Daniel Vetter, IGT development, Daniel Vetter

On Tue, Dec 04, 2018 at 02:51:45PM +0200, Petri Latvala wrote:
> On Tue, Dec 04, 2018 at 01:22:15PM +0100, Daniel Vetter wrote:
> > My gcc is unhappy otherwise:
> > 
> > [191/829] Compiling C object 'tests/te...otation_crc@exe/kms_rotation_crc.c.o'.
> > ../tests/kms_rotation_crc.c: In function ‘test_multi_plane_rotation’:
> > ../tests/kms_rotation_crc.c:497:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> >   const static struct {
> >   ^~~~~
> > ../tests/kms_rotation_crc.c:524:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> >   const static uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
> >   ^~~~~
> > 
> > Fixes
> > 
> > commit 14c1b132c8f829637c55fb071a9a2e5ce00e7ed8
> > Author: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> > Date:   Fri Nov 30 15:34:36 2018 +0200
> > 
> >     tests/kms_rotation_crc: Add multi plane tests
> > 
> > Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com
> > Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  tests/kms_rotation_crc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> > index 369936f94528..05349dab5f79 100644
> > --- a/tests/kms_rotation_crc.c
> > +++ b/tests/kms_rotation_crc.c
> > @@ -494,7 +494,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
> >  	struct p_struct *oldplanes;
> >  	drmModeModeInfo *mode;
> >  
> > -	const static struct {
> > +	static const struct {
> >  		igt_rotation_t rotation;
> >  		float_t width;
> >  		float_t height;
> > @@ -521,7 +521,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
> >  	* TODO:
> >  	* Built support for NV12 here.
> >  	*/
> > -	const static uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
> > +	static const uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
> >  					       DRM_FORMAT_XRGB8888};
> 
>                              ^
> Trim this extra space while at it too.

Trimmed and pushed, thanks for your review.
-Daniel

> 
> 
> 
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_rotation_crc: static before const
  2018-12-04 12:22 [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const Daniel Vetter
  2018-12-04 12:51 ` Petri Latvala
@ 2018-12-04 13:50 ` Patchwork
  2018-12-04 20:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  2018-12-05 12:28 ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-12-04 13:50 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: igt-dev

== Series Details ==

Series: tests/kms_rotation_crc: static before const
URL   : https://patchwork.freedesktop.org/series/53473/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5255 -> IGTPW_2117
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/53473/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2117 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-ivb-3520m:       PASS -> FAIL [fdo#108880]

  * igt@kms_busy@basic-flip-a:
    - fi-glk-j4005:       PASS -> FAIL [fdo#103182]

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       PASS -> DMESG-WARN [fdo#102614]

  
  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#108880]: https://bugs.freedesktop.org/show_bug.cgi?id=108880


Participating hosts (48 -> 43)
------------------------------

  Missing    (5): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


Build changes
-------------

    * IGT: IGT_4739 -> IGTPW_2117

  CI_DRM_5255: 085f0fb4cca0fced1338135c828dc8a609cd807a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2117/
  IGT_4739: 6a965853560b2f8070d639b61506506842f87ff5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2117/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_rotation_crc: static before const
  2018-12-04 12:22 [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const Daniel Vetter
  2018-12-04 12:51 ` Petri Latvala
  2018-12-04 13:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-12-04 20:23 ` Patchwork
  2018-12-05 12:28 ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-12-04 20:23 UTC (permalink / raw)
  To: Daniel Vetter; +Cc: igt-dev

== Series Details ==

Series: tests/kms_rotation_crc: static before const
URL   : https://patchwork.freedesktop.org/series/53473/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5255_full -> IGTPW_2117_full
====================================================

Summary
-------

  **WARNING**

  Minor unknown changes coming with IGTPW_2117_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2117_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/53473/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2117_full:

### IGT changes ###

#### Possible regressions ####

  * {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
    - shard-glk:          PASS -> FAIL

  
#### Warnings ####

  * igt@perf_pmu@rc6:
    - shard-kbl:          SKIP -> PASS

  * igt@pm_rc6_residency@rc6-accuracy:
    - shard-snb:          PASS -> SKIP

  
Known issues
------------

  Here are the changes found in IGTPW_2117_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_workarounds@suspend-resume-context:
    - shard-kbl:          PASS -> INCOMPLETE [fdo#103665]

  * igt@kms_available_modes_crc@available_mode_test_crc:
    - shard-apl:          PASS -> FAIL [fdo#106641]

  * igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
    - shard-kbl:          PASS -> FAIL [fdo#107725] / [fdo#108145]

  * igt@kms_color@pipe-c-degamma:
    - shard-apl:          PASS -> FAIL [fdo#104782]

  * igt@kms_cursor_crc@cursor-128x128-sliding:
    - shard-kbl:          PASS -> FAIL [fdo#103232]

  * igt@kms_cursor_crc@cursor-128x128-suspend:
    - shard-apl:          PASS -> FAIL [fdo#103191] / [fdo#103232]
    - shard-kbl:          PASS -> FAIL [fdo#103191] / [fdo#103232]

  * igt@kms_cursor_crc@cursor-128x42-onscreen:
    - shard-glk:          PASS -> FAIL [fdo#103232] +3

  * igt@kms_cursor_crc@cursor-64x21-sliding:
    - shard-apl:          PASS -> FAIL [fdo#103232] +6

  * igt@kms_cursor_legacy@long-nonblocking-modeset-vs-cursor-atomic:
    - shard-apl:          PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +15

  * igt@kms_flip@basic-flip-vs-modeset:
    - shard-hsw:          PASS -> DMESG-WARN [fdo#102614]

  * igt@kms_flip@modeset-vs-vblank-race-interruptible:
    - shard-glk:          PASS -> FAIL [fdo#103060]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
    - shard-apl:          PASS -> FAIL [fdo#103167] +1
    - shard-kbl:          PASS -> FAIL [fdo#103167] +2

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
    - shard-apl:          NOTRUN -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
    - shard-glk:          PASS -> FAIL [fdo#103167] +13

  * igt@kms_plane@plane-position-covered-pipe-c-planes:
    - shard-apl:          PASS -> FAIL [fdo#103166] +6

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
    - shard-glk:          PASS -> FAIL [fdo#103166] +6

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
    - shard-kbl:          PASS -> FAIL [fdo#103166]

  * {igt@kms_rotation_crc@multiplane-rotation-cropping-top}:
    - shard-glk:          PASS -> DMESG-FAIL [fdo#105763] / [fdo#106538]

  * igt@perf@blocking:
    - shard-hsw:          PASS -> FAIL [fdo#102252]

  * igt@perf_pmu@event-wait-rcs0:
    - shard-snb:          SKIP -> INCOMPLETE [fdo#105411] / [fdo#107469]

  
#### Possible fixes ####

  * igt@gem_userptr_blits@readonly-unsync:
    - shard-apl:          INCOMPLETE [fdo#103927] -> PASS +1

  * igt@kms_available_modes_crc@available_mode_test_crc:
    - shard-snb:          FAIL [fdo#106641] -> PASS

  * igt@kms_color@pipe-b-legacy-gamma:
    - shard-apl:          FAIL [fdo#104782] -> PASS

  * igt@kms_cursor_crc@cursor-256x256-onscreen:
    - shard-glk:          FAIL [fdo#103232] -> PASS +1

  * igt@kms_cursor_crc@cursor-256x85-sliding:
    - shard-kbl:          FAIL [fdo#103232] -> PASS

  * igt@kms_cursor_crc@cursor-64x21-random:
    - shard-apl:          FAIL [fdo#103232] -> PASS

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-apl:          FAIL [fdo#103191] / [fdo#103232] -> PASS
    - shard-kbl:          FAIL [fdo#103191] / [fdo#103232] -> PASS

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
    - shard-hsw:          FAIL [fdo#105767] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
    - shard-glk:          FAIL [fdo#103167] -> PASS +2

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
    - shard-apl:          FAIL [fdo#103167] -> PASS +1
    - shard-kbl:          FAIL [fdo#103167] -> PASS

  * igt@kms_plane@plane-position-covered-pipe-b-planes:
    - shard-glk:          FAIL [fdo#103166] -> PASS +1

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
    - shard-apl:          FAIL [fdo#103166] -> PASS +1

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
    - shard-kbl:          FAIL [fdo#103166] -> PASS +1

  
#### Warnings ####

  * igt@kms_content_protection@legacy:
    - shard-apl:          FAIL [fdo#108597] -> DMESG-FAIL [fdo#103558] / [fdo#105602]

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
    - shard-apl:          FAIL [fdo#103166] -> DMESG-FAIL [fdo#103166] / [fdo#103558] / [fdo#105602]

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102252]: https://bugs.freedesktop.org/show_bug.cgi?id=102252
  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
  [fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
  [fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
  [fdo#107725]: https://bugs.freedesktop.org/show_bug.cgi?id=107725
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * IGT: IGT_4739 -> IGTPW_2117
    * Piglit: piglit_4509 -> None

  CI_DRM_5255: 085f0fb4cca0fced1338135c828dc8a609cd807a @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2117: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2117/
  IGT_4739: 6a965853560b2f8070d639b61506506842f87ff5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2117/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const
  2018-12-04 12:22 [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const Daniel Vetter
                   ` (2 preceding siblings ...)
  2018-12-04 20:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-12-05 12:28 ` Juha-Pekka Heikkila
  3 siblings, 0 replies; 6+ messages in thread
From: Juha-Pekka Heikkila @ 2018-12-05 12:28 UTC (permalink / raw)
  To: Daniel Vetter, IGT development; +Cc: Daniel Vetter

On 4.12.2018 14.22, Daniel Vetter wrote:
> My gcc is unhappy otherwise:
> 
> [191/829] Compiling C object 'tests/te...otation_crc@exe/kms_rotation_crc.c.o'.
> ../tests/kms_rotation_crc.c: In function ‘test_multi_plane_rotation’:
> ../tests/kms_rotation_crc.c:497:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>    const static struct {
>    ^~~~~
> ../tests/kms_rotation_crc.c:524:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>    const static uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
>    ^~~~~
> 
> Fixes

Look like autotools didn't use same flags for gcc as to those meson 
does. At least for me autotools build doesn't give any warnings but now 
saw those from meson.

Thanks for fixing it for me.

> 
> commit 14c1b132c8f829637c55fb071a9a2e5ce00e7ed8
> Author: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Date:   Fri Nov 30 15:34:36 2018 +0200
> 
>      tests/kms_rotation_crc: Add multi plane tests
> 
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>   tests/kms_rotation_crc.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 369936f94528..05349dab5f79 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -494,7 +494,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
>   	struct p_struct *oldplanes;
>   	drmModeModeInfo *mode;
>   
> -	const static struct {
> +	static const struct {
>   		igt_rotation_t rotation;
>   		float_t width;
>   		float_t height;
> @@ -521,7 +521,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
>   	* TODO:
>   	* Built support for NV12 here.
>   	*/
> -	const static uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
> +	static const uint32_t  formatlist[] = {DRM_FORMAT_RGB565,
>   					       DRM_FORMAT_XRGB8888};
>   
>   	for_each_valid_output_on_pipe(display, pipe, output) {
> 

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-05 12:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-04 12:22 [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const Daniel Vetter
2018-12-04 12:51 ` Petri Latvala
2018-12-04 13:43   ` Daniel Vetter
2018-12-04 13:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-04 20:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-05 12:28 ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.