All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/umip: Make the UMIP activated message generic
@ 2018-12-04 22:27 Lendacky, Thomas
  2018-12-05  7:47 ` Ingo Molnar
  0 siblings, 1 reply; 3+ messages in thread
From: Lendacky, Thomas @ 2018-12-04 22:27 UTC (permalink / raw)
  To: linux-kernel
  Cc: Ricardo Neri, x86, Ingo Molnar, Borislav Petkov, H. Peter Anvin,
	Thomas Gleixner

The User Mode Instruction Prevention (UMIP) feature is part of the x86_64
instruction set architecture and not specific to Intel.  Make the message
generic.

Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
---

This patch is against the x86/cpu branch of the tip tree:
  git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cpu

 arch/x86/kernel/cpu/common.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
index 2c56b80..cb28e98 100644
--- a/arch/x86/kernel/cpu/common.c
+++ b/arch/x86/kernel/cpu/common.c
@@ -353,7 +353,7 @@ static __always_inline void setup_umip(struct cpuinfo_x86 *c)
 
 	cr4_set_bits(X86_CR4_UMIP);
 
-	pr_info_once("x86/cpu: Intel User Mode Instruction Prevention (UMIP) activated\n");
+	pr_info_once("x86/cpu: User Mode Instruction Prevention (UMIP) activated\n");
 
 	return;
 


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86/umip: Make the UMIP activated message generic
  2018-12-04 22:27 [PATCH] x86/umip: Make the UMIP activated message generic Lendacky, Thomas
@ 2018-12-05  7:47 ` Ingo Molnar
  2018-12-05 14:43   ` Lendacky, Thomas
  0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2018-12-05  7:47 UTC (permalink / raw)
  To: Lendacky, Thomas
  Cc: linux-kernel, Ricardo Neri, x86, Ingo Molnar, Borislav Petkov,
	H. Peter Anvin, Thomas Gleixner


* Lendacky, Thomas <Thomas.Lendacky@amd.com> wrote:

> The User Mode Instruction Prevention (UMIP) feature is part of the x86_64
> instruction set architecture and not specific to Intel.  Make the message
> generic.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> 
> This patch is against the x86/cpu branch of the tip tree:
>   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cpu
> 
>  arch/x86/kernel/cpu/common.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
> index 2c56b80..cb28e98 100644
> --- a/arch/x86/kernel/cpu/common.c
> +++ b/arch/x86/kernel/cpu/common.c
> @@ -353,7 +353,7 @@ static __always_inline void setup_umip(struct cpuinfo_x86 *c)
>  
>  	cr4_set_bits(X86_CR4_UMIP);
>  
> -	pr_info_once("x86/cpu: Intel User Mode Instruction Prevention (UMIP) activated\n");
> +	pr_info_once("x86/cpu: User Mode Instruction Prevention (UMIP) activated\n");

Is there any public information about which AMD CPUs are going to support 
it?

The latest AMD CPU I can test on is a Ryzen Threadripper 1950X, and that 
doesn't have UMIP.

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86/umip: Make the UMIP activated message generic
  2018-12-05  7:47 ` Ingo Molnar
@ 2018-12-05 14:43   ` Lendacky, Thomas
  0 siblings, 0 replies; 3+ messages in thread
From: Lendacky, Thomas @ 2018-12-05 14:43 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: linux-kernel, Ricardo Neri, x86, Ingo Molnar, Borislav Petkov,
	H. Peter Anvin, Thomas Gleixner

On 12/05/2018 01:47 AM, Ingo Molnar wrote:
> 
> * Lendacky, Thomas <Thomas.Lendacky@amd.com> wrote:
> 
>> The User Mode Instruction Prevention (UMIP) feature is part of the x86_64
>> instruction set architecture and not specific to Intel.  Make the message
>> generic.
>>
>> Signed-off-by: Tom Lendacky <thomas.lendacky@amd.com>
>> ---
>>
>> This patch is against the x86/cpu branch of the tip tree:
>>   git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/cpu
>>
>>  arch/x86/kernel/cpu/common.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/kernel/cpu/common.c b/arch/x86/kernel/cpu/common.c
>> index 2c56b80..cb28e98 100644
>> --- a/arch/x86/kernel/cpu/common.c
>> +++ b/arch/x86/kernel/cpu/common.c
>> @@ -353,7 +353,7 @@ static __always_inline void setup_umip(struct cpuinfo_x86 *c)
>>  
>>  	cr4_set_bits(X86_CR4_UMIP);
>>  
>> -	pr_info_once("x86/cpu: Intel User Mode Instruction Prevention (UMIP) activated\n");
>> +	pr_info_once("x86/cpu: User Mode Instruction Prevention (UMIP) activated\n");
> 
> Is there any public information about which AMD CPUs are going to support 
> it?

No public information yet...

Thanks,
Tom

> 
> The latest AMD CPU I can test on is a Ryzen Threadripper 1950X, and that 
> doesn't have UMIP.
> 
> Thanks,
> 
> 	Ingo
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-05 14:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-04 22:27 [PATCH] x86/umip: Make the UMIP activated message generic Lendacky, Thomas
2018-12-05  7:47 ` Ingo Molnar
2018-12-05 14:43   ` Lendacky, Thomas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.