From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next v6 07/10] core: implement per-package SDK and target
Date: Thu, 6 Dec 2018 11:58:22 +0100 [thread overview]
Message-ID: <20181206115822.4df83e17@windsurf> (raw)
In-Reply-To: <f9730d54-6360-6144-8461-afa25bf32727@andin.de>
Hello Andreas,
On Thu, 6 Dec 2018 11:42:37 +0100, Andreas Naumann wrote:
> > Nope, this is expected. During the build output/host/lib doesn't exist,
>
> of course
>
> > it's only populated at the very end of the build in host-finalize. So
> > indeed the RPATH of binaries point to various per-package host/lib
> > folders. This is totally expected.
>
> Hmm, at this stage the host-finalize step was already run, so now
> output/host does exist.
Yes, but the RPATH of host binaries are not fixed up in host-finalize.
They are fixed up as part of prepare-sdk:
prepare-sdk: world
@$(call MESSAGE,"Rendering the SDK relocatable")
$(TOPDIR)/support/scripts/fix-rpath host
$(TOPDIR)/support/scripts/fix-rpath staging
so it is totally expected that at the end of the build the host
binaries carry those RPATH pointing to per-package host/lib folders.
And it is not a problem: those folders exist, they contain the right
libraries, so it's perfectly fine.
> >> After 'make prepare-sdk'
> >> $ readelf -d output/host/sbin/mkfs.ext3
> >> shows
> >> 0x000000000000001d (RUNPATH) Bibliothek runpath: []
> >
> > This is obviously not good :-)
> >
> > Thanks for reporting that, I'll have a look. I guess it's simply the
> > fixup of RPATH from absolute to relative that goes wrong.
>
> Would moving the fix-rpath step from prepare-sdk to host-finalize hurt?
It would not fix your problem: this fix-rpath step is currently broken
as it doesn't understand how to rewrite those RPATHs that point to
per-package host/lib.
So there are really two separate things:
- Fixing the fix-rpath logic so that it works with per-package
host/lib RPATHs. This is mandatory. After doing that, at the end of
the build, the RPATH would still point to per-package host/lib, but
after prepare-sdk you will have again the correct relative RPATH you
used to have before the per-package stuff.
- Moving fix-rpath at the end of the build so that instead of those
weird per-package host/lib RPATH, you have nice relative RPATHs,
without the need to run prepare-sdk. This is not mandatory at all,
and would be just for convenience/beauty.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-06 10:58 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 14:58 [Buildroot] [PATCH next v6 00/10] Per-package host/target directory support Thomas Petazzoni
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 01/10] Makefile: evaluate CCACHE and HOST{CC, CXX} at time of use Thomas Petazzoni
2018-11-26 18:14 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 02/10] support/scripts/check-host-rpath: split condition on two statements Thomas Petazzoni
2018-11-26 18:14 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 03/10] Makefile: rework main directory creation logic Thomas Petazzoni
2018-11-23 18:07 ` Yann E. MORIN
2018-11-26 18:14 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 04/10] Makefile: move .NOTPARALLEL statement after including .config file Thomas Petazzoni
2018-11-26 18:15 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 05/10] Makefile: define TARGET_DIR_WARNING_FILE relative to TARGET_DIR Thomas Petazzoni
2018-11-26 18:15 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 06/10] package/pkg-generic: adjust config scripts tweaks for per-package directories Thomas Petazzoni
2018-11-23 18:09 ` Yann E. MORIN
2018-11-26 18:15 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 07/10] core: implement per-package SDK and target Thomas Petazzoni
2018-11-23 21:50 ` Yann E. MORIN
2018-12-04 22:24 ` Arnout Vandecappelle
2018-12-05 8:04 ` Thomas Petazzoni
2018-12-05 9:18 ` Arnout Vandecappelle
2018-12-05 9:44 ` Thomas Petazzoni
2018-12-05 10:41 ` Arnout Vandecappelle
2018-12-05 16:08 ` Andreas Naumann
2018-12-05 16:31 ` Thomas Petazzoni
2018-12-05 16:52 ` Andreas Naumann
2018-12-06 10:21 ` Andreas Naumann
2018-12-06 10:28 ` Thomas Petazzoni
2018-12-06 10:42 ` Andreas Naumann
2018-12-06 10:58 ` Thomas Petazzoni [this message]
2018-12-06 13:31 ` Andreas Naumann
2018-12-26 17:34 ` Thomas Petazzoni
2018-12-26 18:33 ` Thomas De Schampheleire
2019-01-10 21:25 ` Arnout Vandecappelle
2019-01-11 20:09 ` Thomas De Schampheleire
2019-01-13 22:10 ` Arnout Vandecappelle
2019-01-14 16:01 ` Thomas De Schampheleire
2019-01-14 16:33 ` Thomas Petazzoni
2019-01-14 20:19 ` Thomas De Schampheleire
2019-01-14 20:43 ` Thomas De Schampheleire
2018-12-26 18:58 ` Yann E. MORIN
2018-12-27 16:17 ` Thomas Petazzoni
2019-01-10 21:14 ` Arnout Vandecappelle
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 08/10] Makefile: allow top-level parallel build with BR2_PER_PACKAGE_DIRECTORIES=y Thomas Petazzoni
2018-11-23 18:11 ` Yann E. MORIN
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 09/10] package/pkg-generic: make libtool .la files compatible with per-package directories Thomas Petazzoni
2018-11-25 17:57 ` Yann E. MORIN
2018-11-30 10:20 ` Thomas Petazzoni
2018-12-01 10:59 ` Yann E. MORIN
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 10/10] package/pkg-kconfig: handle KCONFIG_DEPENDENCIES " Thomas Petazzoni
2018-11-25 17:57 ` Yann E. MORIN
2018-12-05 15:23 ` Andreas Naumann
2018-12-06 14:07 ` Andreas Naumann
2018-12-06 14:25 ` Thomas Petazzoni
2018-12-26 16:40 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206115822.4df83e17@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.