From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH next v6 02/10] support/scripts/check-host-rpath: split condition on two statements
Date: Mon, 26 Nov 2018 19:14:51 +0100 [thread overview]
Message-ID: <871s77u2n8.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20181123145815.13008-3-thomas.petazzoni@bootlin.com> (Thomas Petazzoni's message of "Fri, 23 Nov 2018 15:58:07 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Inside the check_elf_has_rpath(), we check if the host binary has a
> correct RPATH, which should be either an absolute path to
> $(HOST_DIR)/lib, or a relative path using $ORIGIN. Those two
> conditions are checked in a single statements, but as we are going to
> add a third condition, let's split this up a bit:
> - If we have a RPATH to $(HOST_DIR)/lib -> we're good, return 0
> - If we have a RPATH to $ORIGIN/../lib -> we're good, return 0
> - Otherwise, we will exit the loop, and return 1
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Committed to next, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-11-26 18:14 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-23 14:58 [Buildroot] [PATCH next v6 00/10] Per-package host/target directory support Thomas Petazzoni
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 01/10] Makefile: evaluate CCACHE and HOST{CC, CXX} at time of use Thomas Petazzoni
2018-11-26 18:14 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 02/10] support/scripts/check-host-rpath: split condition on two statements Thomas Petazzoni
2018-11-26 18:14 ` Peter Korsgaard [this message]
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 03/10] Makefile: rework main directory creation logic Thomas Petazzoni
2018-11-23 18:07 ` Yann E. MORIN
2018-11-26 18:14 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 04/10] Makefile: move .NOTPARALLEL statement after including .config file Thomas Petazzoni
2018-11-26 18:15 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 05/10] Makefile: define TARGET_DIR_WARNING_FILE relative to TARGET_DIR Thomas Petazzoni
2018-11-26 18:15 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 06/10] package/pkg-generic: adjust config scripts tweaks for per-package directories Thomas Petazzoni
2018-11-23 18:09 ` Yann E. MORIN
2018-11-26 18:15 ` Peter Korsgaard
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 07/10] core: implement per-package SDK and target Thomas Petazzoni
2018-11-23 21:50 ` Yann E. MORIN
2018-12-04 22:24 ` Arnout Vandecappelle
2018-12-05 8:04 ` Thomas Petazzoni
2018-12-05 9:18 ` Arnout Vandecappelle
2018-12-05 9:44 ` Thomas Petazzoni
2018-12-05 10:41 ` Arnout Vandecappelle
2018-12-05 16:08 ` Andreas Naumann
2018-12-05 16:31 ` Thomas Petazzoni
2018-12-05 16:52 ` Andreas Naumann
2018-12-06 10:21 ` Andreas Naumann
2018-12-06 10:28 ` Thomas Petazzoni
2018-12-06 10:42 ` Andreas Naumann
2018-12-06 10:58 ` Thomas Petazzoni
2018-12-06 13:31 ` Andreas Naumann
2018-12-26 17:34 ` Thomas Petazzoni
2018-12-26 18:33 ` Thomas De Schampheleire
2019-01-10 21:25 ` Arnout Vandecappelle
2019-01-11 20:09 ` Thomas De Schampheleire
2019-01-13 22:10 ` Arnout Vandecappelle
2019-01-14 16:01 ` Thomas De Schampheleire
2019-01-14 16:33 ` Thomas Petazzoni
2019-01-14 20:19 ` Thomas De Schampheleire
2019-01-14 20:43 ` Thomas De Schampheleire
2018-12-26 18:58 ` Yann E. MORIN
2018-12-27 16:17 ` Thomas Petazzoni
2019-01-10 21:14 ` Arnout Vandecappelle
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 08/10] Makefile: allow top-level parallel build with BR2_PER_PACKAGE_DIRECTORIES=y Thomas Petazzoni
2018-11-23 18:11 ` Yann E. MORIN
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 09/10] package/pkg-generic: make libtool .la files compatible with per-package directories Thomas Petazzoni
2018-11-25 17:57 ` Yann E. MORIN
2018-11-30 10:20 ` Thomas Petazzoni
2018-12-01 10:59 ` Yann E. MORIN
2018-11-23 14:58 ` [Buildroot] [PATCH next v6 10/10] package/pkg-kconfig: handle KCONFIG_DEPENDENCIES " Thomas Petazzoni
2018-11-25 17:57 ` Yann E. MORIN
2018-12-05 15:23 ` Andreas Naumann
2018-12-06 14:07 ` Andreas Naumann
2018-12-06 14:25 ` Thomas Petazzoni
2018-12-26 16:40 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871s77u2n8.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.