From: Andrew Lunn <andrew@lunn.ch>
To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
Cc: "jocke@infinera.com" <joakim.tjernlund@infinera.com>,
"netdev @ vger . kernel . org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] dpaa_eth: Add dpaa_change_carrier()
Date: Fri, 7 Dec 2018 10:15:22 +0100 [thread overview]
Message-ID: <20181207091522.GA14223@lunn.ch> (raw)
In-Reply-To: <VI1PR04MB5567EBAB7DBF3A5E09388319ECAA0@VI1PR04MB5567.eurprd04.prod.outlook.com>
On Fri, Dec 07, 2018 at 08:36:48AM +0000, Madalin-cristian Bucur wrote:
> > -----Original Message-----
> > From: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> > Sent: Thursday, December 6, 2018 5:32 PM
> > To: netdev @ vger . kernel . org <netdev@vger.kernel.org>; Madalin-
> > cristian Bucur <madalin.bucur@nxp.com>
> > Cc: jocke@infinera.com <joakim.tjernlund@infinera.com>
> > Subject: [PATCH] dpaa_eth: Add dpaa_change_carrier()
> >
> > This allows to control carrier from /sys/class/net/ethX/carrier
>
> Hi,
>
> can you please explain why it's needed?
Hi Madelin
See the patch:
[PATCH] gianfar: Add gfar_change_carrier()
Which is basically the same.
A better approach is being discussed. So for the moment, to stop DaveM
from merging this not knowing it is related to that patch:
NACK
Andrew
prev parent reply other threads:[~2018-12-07 9:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 15:32 [PATCH] dpaa_eth: Add dpaa_change_carrier() Joakim Tjernlund
2018-12-07 8:36 ` Madalin-cristian Bucur
2018-12-07 9:15 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207091522.GA14223@lunn.ch \
--to=andrew@lunn.ch \
--cc=joakim.tjernlund@infinera.com \
--cc=madalin.bucur@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.