* [PATCH] dpaa_eth: Add dpaa_change_carrier()
@ 2018-12-06 15:32 Joakim Tjernlund
2018-12-07 8:36 ` Madalin-cristian Bucur
0 siblings, 1 reply; 3+ messages in thread
From: Joakim Tjernlund @ 2018-12-06 15:32 UTC (permalink / raw)
To: netdev @ vger . kernel . org, Madalin-cristian Bucur; +Cc: Joakim Tjernlund
This allows to control carrier from /sys/class/net/ethX/carrier
Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
---
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 11 +++++++++++
1 file changed, 11 insertions(+)
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index a202c50d6fc7..0e93dfa6df0a 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -2502,12 +2502,23 @@ static int dpaa_ioctl(struct net_device *net_dev, struct ifreq *rq, int cmd)
return phy_mii_ioctl(net_dev->phydev, rq, cmd);
}
+static int dpaa_change_carrier(struct net_device *dev, bool new_carrier)
+{
+ struct phy_device *phydev = dev->phydev;
+
+ if (phydev && phydev->phy_link_change)
+ phydev->phy_link_change(phydev, new_carrier, 1);
+
+ return 0;
+}
+
static const struct net_device_ops dpaa_ops = {
.ndo_open = dpaa_open,
.ndo_start_xmit = dpaa_start_xmit,
.ndo_stop = dpaa_eth_stop,
.ndo_tx_timeout = dpaa_tx_timeout,
.ndo_get_stats64 = dpaa_get_stats64,
+ .ndo_change_carrier = dpaa_change_carrier,
.ndo_set_mac_address = dpaa_set_mac_address,
.ndo_validate_addr = eth_validate_addr,
.ndo_set_rx_mode = dpaa_set_rx_mode,
--
2.18.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] dpaa_eth: Add dpaa_change_carrier()
2018-12-06 15:32 [PATCH] dpaa_eth: Add dpaa_change_carrier() Joakim Tjernlund
@ 2018-12-07 8:36 ` Madalin-cristian Bucur
2018-12-07 9:15 ` Andrew Lunn
0 siblings, 1 reply; 3+ messages in thread
From: Madalin-cristian Bucur @ 2018-12-07 8:36 UTC (permalink / raw)
To: jocke@infinera.com, netdev @ vger . kernel . org; +Cc: jocke@infinera.com
> -----Original Message-----
> From: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> Sent: Thursday, December 6, 2018 5:32 PM
> To: netdev @ vger . kernel . org <netdev@vger.kernel.org>; Madalin-
> cristian Bucur <madalin.bucur@nxp.com>
> Cc: jocke@infinera.com <joakim.tjernlund@infinera.com>
> Subject: [PATCH] dpaa_eth: Add dpaa_change_carrier()
>
> This allows to control carrier from /sys/class/net/ethX/carrier
Hi,
can you please explain why it's needed?
Thanks,
Madalin
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> ---
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index a202c50d6fc7..0e93dfa6df0a 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -2502,12 +2502,23 @@ static int dpaa_ioctl(struct net_device *net_dev,
> struct ifreq *rq, int cmd)
> return phy_mii_ioctl(net_dev->phydev, rq, cmd);
> }
>
> +static int dpaa_change_carrier(struct net_device *dev, bool new_carrier)
> +{
> + struct phy_device *phydev = dev->phydev;
> +
> + if (phydev && phydev->phy_link_change)
> + phydev->phy_link_change(phydev, new_carrier, 1);
> +
> + return 0;
> +}
> +
> static const struct net_device_ops dpaa_ops = {
> .ndo_open = dpaa_open,
> .ndo_start_xmit = dpaa_start_xmit,
> .ndo_stop = dpaa_eth_stop,
> .ndo_tx_timeout = dpaa_tx_timeout,
> .ndo_get_stats64 = dpaa_get_stats64,
> + .ndo_change_carrier = dpaa_change_carrier,
> .ndo_set_mac_address = dpaa_set_mac_address,
> .ndo_validate_addr = eth_validate_addr,
> .ndo_set_rx_mode = dpaa_set_rx_mode,
> --
> 2.18.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dpaa_eth: Add dpaa_change_carrier()
2018-12-07 8:36 ` Madalin-cristian Bucur
@ 2018-12-07 9:15 ` Andrew Lunn
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2018-12-07 9:15 UTC (permalink / raw)
To: Madalin-cristian Bucur; +Cc: jocke@infinera.com, netdev @ vger . kernel . org
On Fri, Dec 07, 2018 at 08:36:48AM +0000, Madalin-cristian Bucur wrote:
> > -----Original Message-----
> > From: Joakim Tjernlund <joakim.tjernlund@infinera.com>
> > Sent: Thursday, December 6, 2018 5:32 PM
> > To: netdev @ vger . kernel . org <netdev@vger.kernel.org>; Madalin-
> > cristian Bucur <madalin.bucur@nxp.com>
> > Cc: jocke@infinera.com <joakim.tjernlund@infinera.com>
> > Subject: [PATCH] dpaa_eth: Add dpaa_change_carrier()
> >
> > This allows to control carrier from /sys/class/net/ethX/carrier
>
> Hi,
>
> can you please explain why it's needed?
Hi Madelin
See the patch:
[PATCH] gianfar: Add gfar_change_carrier()
Which is basically the same.
A better approach is being discussed. So for the moment, to stop DaveM
from merging this not knowing it is related to that patch:
NACK
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-07 9:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-06 15:32 [PATCH] dpaa_eth: Add dpaa_change_carrier() Joakim Tjernlund
2018-12-07 8:36 ` Madalin-cristian Bucur
2018-12-07 9:15 ` Andrew Lunn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.