All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] ensure active menuitem is inside menu
@ 2018-12-03 10:23 Frank Wunderlich
  2018-12-03 10:50 ` Simon Goldschmidt
  2018-12-07 20:34 ` Tom Rini
  0 siblings, 2 replies; 5+ messages in thread
From: Frank Wunderlich @ 2018-12-03 10:23 UTC (permalink / raw)
  To: u-boot

Hi,

setting active menuitem currently can be outside of menu which results in invisible selection

attached Patch fixes this

regards Frank
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ensure-active-menuitem-is-inside-menu.patch
Type: text/x-patch
Size: 957 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181203/c02fd9b3/attachment.bin>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] ensure active menuitem is inside menu
  2018-12-03 10:23 [U-Boot] ensure active menuitem is inside menu Frank Wunderlich
@ 2018-12-03 10:50 ` Simon Goldschmidt
  2018-12-03 10:57   ` Frank Wunderlich
  2018-12-07 20:34 ` Tom Rini
  1 sibling, 1 reply; 5+ messages in thread
From: Simon Goldschmidt @ 2018-12-03 10:50 UTC (permalink / raw)
  To: u-boot

On Mon, Dec 3, 2018 at 11:23 AM Frank Wunderlich
<frank-w@public-files.de> wrote:
>
> Hi,
>
> setting active menuitem currently can be outside of menu which results in invisible selection
>
> attached Patch fixes this

Have you read the section "Submitting Patches" in the README file?

https://github.com/u-boot/u-boot/blob/master/README#L4980

In short, patches should be send inline, not as attachment. I guess
patchwork cannot extract the patches either when sent as attachment.

Regards,
Simon

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] ensure active menuitem is inside menu
  2018-12-03 10:50 ` Simon Goldschmidt
@ 2018-12-03 10:57   ` Frank Wunderlich
  2018-12-03 11:16     ` Simon Goldschmidt
  0 siblings, 1 reply; 5+ messages in thread
From: Frank Wunderlich @ 2018-12-03 10:57 UTC (permalink / raw)
  To: u-boot

Hi

Patchwork had extracted the Patch...

https://patchwork.ozlabs.org/patch/1006783/

but next time i append Patch in the Mail-text

Regards Frank

> Gesendet: Montag, 03. Dezember 2018 um 11:50 Uhr
> Von: "Simon Goldschmidt" <simon.k.r.goldschmidt@gmail.com>
> An: "Frank Wunderlich" <frank-w@public-files.de>
> Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>
> Betreff: Re: [U-Boot] ensure active menuitem is inside menu
>
> On Mon, Dec 3, 2018 at 11:23 AM Frank Wunderlich
> <frank-w@public-files.de> wrote:
> >
> > Hi,
> >
> > setting active menuitem currently can be outside of menu which results in invisible selection
> >
> > attached Patch fixes this
> 
> Have you read the section "Submitting Patches" in the README file?
> 
> https://github.com/u-boot/u-boot/blob/master/README#L4980
> 
> In short, patches should be send inline, not as attachment. I guess
> patchwork cannot extract the patches either when sent as attachment.
> 
> Regards,
> Simon
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] ensure active menuitem is inside menu
  2018-12-03 10:57   ` Frank Wunderlich
@ 2018-12-03 11:16     ` Simon Goldschmidt
  0 siblings, 0 replies; 5+ messages in thread
From: Simon Goldschmidt @ 2018-12-03 11:16 UTC (permalink / raw)
  To: u-boot

On Mon, Dec 3, 2018 at 11:58 AM Frank Wunderlich
<frank-w@public-files.de> wrote:
>
> Hi
>
> Patchwork had extracted the Patch...
>
> https://patchwork.ozlabs.org/patch/1006783/

Oh, sorry then. Somehow I failed to find it :-/

Regards,
Simon

>
> but next time i append Patch in the Mail-text
>
> Regards Frank
>
> > Gesendet: Montag, 03. Dezember 2018 um 11:50 Uhr
> > Von: "Simon Goldschmidt" <simon.k.r.goldschmidt@gmail.com>
> > An: "Frank Wunderlich" <frank-w@public-files.de>
> > Cc: "U-Boot Mailing List" <u-boot@lists.denx.de>
> > Betreff: Re: [U-Boot] ensure active menuitem is inside menu
> >
> > On Mon, Dec 3, 2018 at 11:23 AM Frank Wunderlich
> > <frank-w@public-files.de> wrote:
> > >
> > > Hi,
> > >
> > > setting active menuitem currently can be outside of menu which results in invisible selection
> > >
> > > attached Patch fixes this
> >
> > Have you read the section "Submitting Patches" in the README file?
> >
> > https://github.com/u-boot/u-boot/blob/master/README#L4980
> >
> > In short, patches should be send inline, not as attachment. I guess
> > patchwork cannot extract the patches either when sent as attachment.
> >
> > Regards,
> > Simon
> >

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] ensure active menuitem is inside menu
  2018-12-03 10:23 [U-Boot] ensure active menuitem is inside menu Frank Wunderlich
  2018-12-03 10:50 ` Simon Goldschmidt
@ 2018-12-07 20:34 ` Tom Rini
  1 sibling, 0 replies; 5+ messages in thread
From: Tom Rini @ 2018-12-07 20:34 UTC (permalink / raw)
  To: u-boot

On Mon, Dec 03, 2018 at 11:23:41AM +0100, Frank Wunderlich wrote:

> Hi,
> 
> setting active menuitem currently can be outside of menu which results in invisible selection
> 
> attached Patch fixes this
> 
> regards Frank
> 
> >From 1d9c4cb8b3e2dd9b0a7a6a2d4a21684d0a099dbf Mon Sep 17 00:00:00 2001
> From: Frank Wunderlich <frank-w@public-files.de>
> Date: Sun, 2 Dec 2018 11:23:53 +0100
> Subject: [PATCH] ensure active menuitem is inside menu
> 
> if active menuitem is defined via environment var it can be outside the menu (>=menuitem-count)
> 
> this patch resets this definition back to 0
> 
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181207/4fc73ae6/attachment.sig>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-12-07 20:34 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-03 10:23 [U-Boot] ensure active menuitem is inside menu Frank Wunderlich
2018-12-03 10:50 ` Simon Goldschmidt
2018-12-03 10:57   ` Frank Wunderlich
2018-12-03 11:16     ` Simon Goldschmidt
2018-12-07 20:34 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.