* [U-Boot] [RFC PATCH] spl/tpl: change banner into upper case
@ 2018-12-05 10:29 Heiko Schocher
2018-12-06 1:31 ` Simon Glass
2018-12-07 20:35 ` [U-Boot] [U-Boot,RFC] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Heiko Schocher @ 2018-12-05 10:29 UTC (permalink / raw)
To: u-boot
commit d6330064634a ("spl: Add a define for SPL_TPL_PROMPT")
changes the SPL/TPL banner from upper case into lower
case. As SPL and TPL are three-letter acronyms and they
are written in upper case, change it back to upper case.
Signed-off-by: Heiko Schocher <hs@denx.de>
---
include/spl.h | 4 ++--
test/py/u_boot_console_base.py | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/spl.h b/include/spl.h
index ee92832f0a..ff4e6277d3 100644
--- a/include/spl.h
+++ b/include/spl.h
@@ -52,9 +52,9 @@ static inline bool u_boot_first_phase(void)
/* A string name for SPL or TPL */
#ifdef CONFIG_SPL_BUILD
# ifdef CONFIG_TPL_BUILD
-# define SPL_TPL_NAME "tpl"
+# define SPL_TPL_NAME "TPL"
# else
-# define SPL_TPL_NAME "spl"
+# define SPL_TPL_NAME "SPL"
# endif
# define SPL_TPL_PROMPT SPL_TPL_NAME ": "
#else
diff --git a/test/py/u_boot_console_base.py b/test/py/u_boot_console_base.py
index e044eb3ea1..326b2ac51f 100644
--- a/test/py/u_boot_console_base.py
+++ b/test/py/u_boot_console_base.py
@@ -16,7 +16,7 @@ import sys
import u_boot_spawn
# Regexes for text we expect U-Boot to send to the console.
-pattern_u_boot_spl_signon = re.compile('(U-Boot spl \\d{4}\\.\\d{2}[^\r\n]*\\))')
+pattern_u_boot_spl_signon = re.compile('(U-Boot SPL \\d{4}\\.\\d{2}[^\r\n]*\\))')
pattern_u_boot_main_signon = re.compile('(U-Boot \\d{4}\\.\\d{2}[^\r\n]*\\))')
pattern_stop_autoboot_prompt = re.compile('Hit any key to stop autoboot: ')
pattern_unknown_command = re.compile('Unknown command \'.*\' - try \'help\'')
--
2.17.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [RFC PATCH] spl/tpl: change banner into upper case
2018-12-05 10:29 [U-Boot] [RFC PATCH] spl/tpl: change banner into upper case Heiko Schocher
@ 2018-12-06 1:31 ` Simon Glass
2018-12-07 20:35 ` [U-Boot] [U-Boot,RFC] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2018-12-06 1:31 UTC (permalink / raw)
To: u-boot
On Wed, 5 Dec 2018 at 03:30, Heiko Schocher <hs@denx.de> wrote:
>
> commit d6330064634a ("spl: Add a define for SPL_TPL_PROMPT")
>
> changes the SPL/TPL banner from upper case into lower
> case. As SPL and TPL are three-letter acronyms and they
> are written in upper case, change it back to upper case.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
>
> include/spl.h | 4 ++--
> test/py/u_boot_console_base.py | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
Oh well, I liked them like that :-)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [U-Boot,RFC] spl/tpl: change banner into upper case
2018-12-05 10:29 [U-Boot] [RFC PATCH] spl/tpl: change banner into upper case Heiko Schocher
2018-12-06 1:31 ` Simon Glass
@ 2018-12-07 20:35 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2018-12-07 20:35 UTC (permalink / raw)
To: u-boot
On Wed, Dec 05, 2018 at 11:29:54AM +0100, Heiko Schocher wrote:
> commit d6330064634a ("spl: Add a define for SPL_TPL_PROMPT")
>
> changes the SPL/TPL banner from upper case into lower
> case. As SPL and TPL are three-letter acronyms and they
> are written in upper case, change it back to upper case.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> Reviewed-by: Simon Glass <sjg@chromium.org>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181207/4a5b8cb6/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-07 20:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-05 10:29 [U-Boot] [RFC PATCH] spl/tpl: change banner into upper case Heiko Schocher
2018-12-06 1:31 ` Simon Glass
2018-12-07 20:35 ` [U-Boot] [U-Boot,RFC] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.