[Buildroot] [PATCH] dl-wrapper: Fix urlencode option never being sent to backend

[Buildroot] [PATCH] dl-wrapper: Fix urlencode option never being sent to backend

[Damien Thébault]

The urlencode parameter is lost in dl-wrapper, because we try to get it
from backend instead of backend_urlencode.

We must get the urlencode information from backend_urlencode.

Signed-off-by: Damien Th?bault <damien.thebault@vitec.com>
---
 support/download/dl-wrapper | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/support/download/dl-wrapper b/support/download/dl-wrapper
index bb70c98253..3315bd410e 100755
--- a/support/download/dl-wrapper
+++ b/support/download/dl-wrapper
@@ -93,7 +93,7 @@ main() {
         esac
         uri=${uri#*+}
 
-        urlencode=${backend#*|}
+        urlencode=${backend_urlencode#*|}
         # urlencode must be "urlencode"
         [ "${urlencode}" != "urlencode" ] && urlencode=""
 
-- 
2.19.1

[Buildroot] [PATCH] dl-wrapper: Fix urlencode option never being sent to backend

[Yann E. MORIN]

Damien, All,

On 2018-12-07 12:41 +0000, Damien Th?bault spake thusly:
> The urlencode parameter is lost in dl-wrapper, because we try to get it
> from backend instead of backend_urlencode.
> 
> We must get the urlencode information from backend_urlencode.

What is this trying to fix, actually? We have no download issue in the
autobuilders, as far as I can see... Do you have a test-case to share?

But true, this is incorrect, and was broken by commit 38de434123
(download: fix file:// BR2_PRIMARY_SITE (download cache)).

Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> Signed-off-by: Damien Th?bault <damien.thebault@vitec.com>
> ---
>  support/download/dl-wrapper | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/support/download/dl-wrapper b/support/download/dl-wrapper
> index bb70c98253..3315bd410e 100755
> --- a/support/download/dl-wrapper
> +++ b/support/download/dl-wrapper
> @@ -93,7 +93,7 @@ main() {
>          esac
>          uri=${uri#*+}
>  
> -        urlencode=${backend#*|}
> +        urlencode=${backend_urlencode#*|}
>          # urlencode must be "urlencode"
>          [ "${urlencode}" != "urlencode" ] && urlencode=""
>  
> -- 
> 2.19.1
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] dl-wrapper: Fix urlencode option never being sent to backend

[Thomas Petazzoni]

Hello,

On Fri, 7 Dec 2018 12:41:08 +0000, Damien Th?bault wrote:
> The urlencode parameter is lost in dl-wrapper, because we try to get it
> from backend instead of backend_urlencode.
> 
> We must get the urlencode information from backend_urlencode.
> 
> Signed-off-by: Damien Th?bault <damien.thebault@vitec.com>
> ---
>  support/download/dl-wrapper | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] dl-wrapper: Fix urlencode option never being sent to backend

[Damien Thébault]

On Fri, 2018-12-07 at 18:35 +0100, Yann E. MORIN wrote:
> On 2018-12-07 12:41 +0000, Damien Th?bault spake thusly:
> > The urlencode parameter is lost in dl-wrapper, because we try to
> > get it
> > from backend instead of backend_urlencode.
> > 
> > We must get the urlencode information from backend_urlencode.
> 
> What is this trying to fix, actually? We have no download issue in
> the autobuilders, as far as I can see... Do you have a test-case to
> share?

Hello Yann,

I have a build configured with a primary site and
BR2_PRIMARY_SITE_ONLY=y that failed to download libopenssl patches from
the mirror.

If the autobuilders are directly using the original URLs or are falling
back to the original URLs they should work fine.

On Sun, 2018-12-09 at 17:18 +0100, Thomas Petazzoni wrote:
> Applied to master, thanks.

Thank you !
-- 
Damien Th?bault

[Buildroot] [PATCH] dl-wrapper: Fix urlencode option never being sent to backend

[Thomas Petazzoni]

Hello,

On Mon, 10 Dec 2018 08:03:27 +0000, Damien Th?bault wrote:

> I have a build configured with a primary site and
> BR2_PRIMARY_SITE_ONLY=y that failed to download libopenssl patches from
> the mirror.
> 
> If the autobuilders are directly using the original URLs or are falling
> back to the original URLs they should work fine.

Thanks! We really need to add some test cases in support/testing/ for
those "corner" cases, since they are not tested by the autobuilders or
in the most usual situations, they tend to be forgotten, and therefore
broken.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] dl-wrapper: Fix urlencode option never being sent to backend

[Yann E. MORIN]

Damien, All,

On 2018-12-10 08:03 +0000, Damien Th?bault spake thusly:
> On Fri, 2018-12-07 at 18:35 +0100, Yann E. MORIN wrote:
> > On 2018-12-07 12:41 +0000, Damien Th?bault spake thusly:
> > > The urlencode parameter is lost in dl-wrapper, because we try to
> > > get it
> > > from backend instead of backend_urlencode.
> > > 
> > > We must get the urlencode information from backend_urlencode.
> > 
> > What is this trying to fix, actually? We have no download issue in
> > the autobuilders, as far as I can see... Do you have a test-case to
> > share?
> I have a build configured with a primary site and
> BR2_PRIMARY_SITE_ONLY=y that failed to download libopenssl patches from
> the mirror.

OK, makes sense, thanks for the feedback. :-)

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH] dl-wrapper: Fix urlencode option never being sent to backend

[Peter Korsgaard]

>>>>> "Damien" == Damien Th?bault <damien.thebault@vitec.com> writes:

 > The urlencode parameter is lost in dl-wrapper, because we try to get it
 > from backend instead of backend_urlencode.

 > We must get the urlencode information from backend_urlencode.

 > Signed-off-by: Damien Th?bault <damien.thebault@vitec.com>

Committed to 2018.08.x and 2018.11.x, thanks.

-- 
Bye, Peter Korsgaard