All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: linux-omap@vger.kernel.org, "Tero Kristo" <t-kristo@ti.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: Add am335x mcasp with l3 data port ranges
Date: Mon, 10 Dec 2018 09:23:27 -0800	[thread overview]
Message-ID: <20181210172327.GE6707@atomide.com> (raw)
In-Reply-To: <2b736366-7d16-3cd5-0216-1072784a5d36@ti.com>

* Peter Ujfalusi <peter.ujfalusi@ti.com> [181210 17:00]:
> On 10/12/2018 18.38, Tony Lindgren wrote:
> > OK so to prevent the hwmod code from resetting gpios very
> > early, this now might become necessary. Care to try with
> > this also applied?
> 
> With this applied there is life on the console, however it ends up badly:

OK thanks for testing. I'll take a look on how to skip
early reset for omap_hwmod.c for the dts case instead of
dropping the sysc platform data.

For the LCDC, does the following revert fix it? If so,
I need to check the flags for am33xx_lcdc_hwmod
HWMOD_SWSUP_SIDLE | HWMOD_SWSUP_MSTANDBY.

Regards,

Tony

8< -------------------------
diff --git a/arch/arm/boot/dts/am33xx-l4.dtsi b/arch/arm/boot/dts/am33xx-l4.dtsi
--- a/arch/arm/boot/dts/am33xx-l4.dtsi
+++ b/arch/arm/boot/dts/am33xx-l4.dtsi
@@ -2053,13 +2053,7 @@
 			#address-cells = <1>;
 			#size-cells = <1>;
 			ranges = <0x0 0xe000 0x1000>;
-
-			lcdc: lcdc@0 {
-				compatible = "ti,am33xx-tilcdc";
-				reg = <0x0 0x1000>;
-				interrupts = <36>;
-				status = "disabled";
-			};
+			status = "disabled";
 		};
 
 		target-module@10000 {			/* 0x48310000, ap 76 4e.1 */
diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -393,6 +393,14 @@
 			};
 		};
 
+		lcdc: lcdc@4830e000 {
+			compatible = "ti,am33xx-tilcdc";
+			reg = <0x4830e000 0x1000>;
+			interrupts = <36>;
+			ti,hwmods = "lcdc";
+			status = "disabled";
+		};
+
 		emif: emif@4c000000 {
 			compatible = "ti,emif-am3352";
 			reg = <0x4c000000 0x1000000>;

  reply	other threads:[~2018-12-10 17:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 23:03 [PATCH] ARM: dts: Add am335x mcasp with l3 data port ranges Tony Lindgren
2018-12-10  7:05 ` Peter Ujfalusi
2018-12-10  9:53   ` Peter Ujfalusi
2018-12-10 13:46     ` Peter Ujfalusi
2018-12-10 14:50       ` Tony Lindgren
2018-12-10 15:12         ` Tero Kristo
2018-12-10 15:28           ` Peter Ujfalusi
2018-12-10 14:48     ` Tony Lindgren
2018-12-10 15:44       ` Tony Lindgren
2018-12-10 16:14         ` Peter Ujfalusi
2018-12-10 16:21           ` Tony Lindgren
2018-12-10 16:38             ` Tony Lindgren
2018-12-10 17:01               ` Peter Ujfalusi
2018-12-10 17:23                 ` Tony Lindgren [this message]
2018-12-11  7:11                   ` Peter Ujfalusi
2018-12-11  8:20                     ` Peter Ujfalusi
2018-12-11 10:55                       ` Peter Ujfalusi
2018-12-11 14:18                         ` Tony Lindgren
2018-12-10 22:20               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181210172327.GE6707@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.