All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: linux-omap@vger.kernel.org, "Tero Kristo" <t-kristo@ti.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: Add am335x mcasp with l3 data port ranges
Date: Mon, 10 Dec 2018 14:20:40 -0800	[thread overview]
Message-ID: <20181210222040.GG6707@atomide.com> (raw)
In-Reply-To: <20181210163830.GD6707@atomide.com>

* Tony Lindgren <tony@atomide.com> [181210 16:38]:
> * Tony Lindgren <tony@atomide.com> [181210 16:21]:
> > * Peter Ujfalusi <peter.ujfalusi@ti.com> [181210 16:13]:
> > > am335x-evmsk is still not booting with this patch on top of next-20181210.
> > 
> > Oh interesting.
> 
> OK so to prevent the hwmod code from resetting gpios very
> early, this now might become necessary. Care to try with
> this also applied?

I posted two patches adding more checks for the module flags
so the patch below should no be needed any longer.

Regards,

Tony

> 8< ------------------------
> diff --git a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c
> --- a/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c
> @@ -516,24 +516,8 @@ struct omap_hwmod am33xx_epwmss2_hwmod = {
>  	},
>  };
>  
> -/*
> - * 'gpio' class: for gpio 0,1,2,3
> - */
> -static struct omap_hwmod_class_sysconfig am33xx_gpio_sysc = {
> -	.rev_offs	= 0x0000,
> -	.sysc_offs	= 0x0010,
> -	.syss_offs	= 0x0114,
> -	.sysc_flags	= (SYSC_HAS_AUTOIDLE | SYSC_HAS_ENAWAKEUP |
> -			  SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET |
> -			  SYSS_HAS_RESET_STATUS),
> -	.idlemodes	= (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
> -			  SIDLE_SMART_WKUP),
> -	.sysc_fields	= &omap_hwmod_sysc_type1,
> -};
> -
>  struct omap_hwmod_class am33xx_gpio_hwmod_class = {
>  	.name		= "gpio",
> -	.sysc		= &am33xx_gpio_sysc,
>  	.rev		= 2,
>  };
>  

      parent reply	other threads:[~2018-12-10 22:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 23:03 [PATCH] ARM: dts: Add am335x mcasp with l3 data port ranges Tony Lindgren
2018-12-10  7:05 ` Peter Ujfalusi
2018-12-10  9:53   ` Peter Ujfalusi
2018-12-10 13:46     ` Peter Ujfalusi
2018-12-10 14:50       ` Tony Lindgren
2018-12-10 15:12         ` Tero Kristo
2018-12-10 15:28           ` Peter Ujfalusi
2018-12-10 14:48     ` Tony Lindgren
2018-12-10 15:44       ` Tony Lindgren
2018-12-10 16:14         ` Peter Ujfalusi
2018-12-10 16:21           ` Tony Lindgren
2018-12-10 16:38             ` Tony Lindgren
2018-12-10 17:01               ` Peter Ujfalusi
2018-12-10 17:23                 ` Tony Lindgren
2018-12-11  7:11                   ` Peter Ujfalusi
2018-12-11  8:20                     ` Peter Ujfalusi
2018-12-11 10:55                       ` Peter Ujfalusi
2018-12-11 14:18                         ` Tony Lindgren
2018-12-10 22:20               ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181210222040.GG6707@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=t-kristo@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.