All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jiangyiwen@huawei.com
Cc: kvm@vger.kernel.org, mst@redhat.com, netdev@vger.kernel.org,
	virtualization@lists.linux-foundation.org, stefanha@redhat.com
Subject: Re: [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host
Date: Wed, 12 Dec 2018 11:09:44 -0800 (PST)	[thread overview]
Message-ID: <20181212.110944.1077302806391053539.davem__5792.48075741834$1544641685$gmane$org@davemloft.net> (raw)
In-Reply-To: <5C10D4FB.6070009@huawei.com>

From: jiangyiwen <jiangyiwen@huawei.com>
Date: Wed, 12 Dec 2018 17:29:31 +0800

> diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h
> index 1d57ed3..2292f30 100644
> --- a/include/uapi/linux/virtio_vsock.h
> +++ b/include/uapi/linux/virtio_vsock.h
> @@ -63,6 +63,11 @@ struct virtio_vsock_hdr {
>  	__le32	fwd_cnt;
>  } __attribute__((packed));
> 
> +/* It add mergeable rx buffers feature */
> +struct virtio_vsock_mrg_rxbuf_hdr {
> +	__le16  num_buffers;    /* number of mergeable rx buffers */
> +} __attribute__((packed));
> +

I know the rest of this file uses 'packed' but this attribute should
only be used if absolutely necessary as it incurs a
non-trivial performance penalty for some architectures.

  parent reply	other threads:[~2018-12-12 19:09 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12  9:29 [PATCH v2 2/5] VSOCK: support fill data to mergeable rx buffer in host jiangyiwen
2018-12-12 15:37 ` Michael S. Tsirkin
2018-12-12 15:37 ` Michael S. Tsirkin
2018-12-13  3:08   ` jiangyiwen
2018-12-13 14:48     ` Michael S. Tsirkin
2018-12-13 14:48     ` Michael S. Tsirkin
2018-12-14  7:41       ` jiangyiwen
2018-12-14  7:41       ` jiangyiwen
2018-12-13 15:49     ` Stefan Hajnoczi
2018-12-14  7:49       ` jiangyiwen
2018-12-14  7:49       ` jiangyiwen
2018-12-13 15:49     ` Stefan Hajnoczi
2018-12-12 19:09 ` David Miller [this message]
2018-12-12 19:09 ` David Miller
2018-12-13  3:11   ` jiangyiwen
2018-12-13  3:11   ` jiangyiwen
2018-12-13  5:59     ` David Miller
2018-12-13  5:59     ` David Miller
2018-12-13  7:42       ` jiangyiwen
2018-12-13  7:42       ` jiangyiwen
2018-12-13 15:46         ` Stefan Hajnoczi
2018-12-13 15:46         ` Stefan Hajnoczi
2018-12-13 14:50     ` Michael S. Tsirkin
2018-12-14  7:47       ` jiangyiwen
2018-12-14  7:47       ` jiangyiwen
2018-12-13 14:50     ` Michael S. Tsirkin
  -- strict thread matches above, loose matches on Subject: below --
2018-12-12  9:29 jiangyiwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='20181212.110944.1077302806391053539.davem__5792.48075741834$1544641685$gmane$org@davemloft.net' \
    --to=davem@davemloft.net \
    --cc=jiangyiwen@huawei.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.