* [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
@ 2018-12-13 9:52 Maarten Lankhorst
2018-12-13 10:00 ` Daniel Vetter
` (4 more replies)
0 siblings, 5 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2018-12-13 9:52 UTC (permalink / raw)
To: igt-dev; +Cc: Dhinakaran Pandiyan
Typically PSR enables in around 136 ms, but on some tests the we have
to explicitly make sure that the gpu is idle before rendering.
Otherwise, sometimes we wait for the background flusher to finish,
which will take at least a second longer, and causes the wait for
PSR to timeout.
On kms_frontbuffer_tracking:
Starting subtest: psr-2p-scndscrn-shrfb-plflip-blt
psr_active(debugfs_fd, true) took 136ms
psr_active(debugfs_fd, true) took 136ms
psr_active(debugfs_fd, true) took 350ms
psr_active(debugfs_fd, true) took 136ms
psr_active(debugfs_fd, true) took 1598ms
Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108733
Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/kms_frontbuffer_tracking.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
index 276ef83ce386..7924bb902a2a 100644
--- a/tests/kms_frontbuffer_tracking.c
+++ b/tests/kms_frontbuffer_tracking.c
@@ -1642,6 +1642,9 @@ static void __do_assertions(const struct test_mode *t, int flags,
{
flags = adjust_assertion_flags(t, flags);
+ /* Make sure any submitted rendering is now idle. */
+ gem_quiescent_gpu(drm.fd);
+
igt_debug("checking asserts in line %i\n", line);
wait_user(2, "Paused before assertions.");
--
2.19.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-13 9:52 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions Maarten Lankhorst
@ 2018-12-13 10:00 ` Daniel Vetter
2018-12-13 10:05 ` Chris Wilson
2018-12-14 0:18 ` Dhinakaran Pandiyan
2018-12-13 10:20 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
` (3 subsequent siblings)
4 siblings, 2 replies; 12+ messages in thread
From: Daniel Vetter @ 2018-12-13 10:00 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev, Dhinakaran Pandiyan
On Thu, Dec 13, 2018 at 10:52:34AM +0100, Maarten Lankhorst wrote:
> Typically PSR enables in around 136 ms, but on some tests the we have
> to explicitly make sure that the gpu is idle before rendering.
>
> Otherwise, sometimes we wait for the background flusher to finish,
> which will take at least a second longer, and causes the wait for
> PSR to timeout.
>
> On kms_frontbuffer_tracking:
> Starting subtest: psr-2p-scndscrn-shrfb-plflip-blt
> psr_active(debugfs_fd, true) took 136ms
> psr_active(debugfs_fd, true) took 136ms
> psr_active(debugfs_fd, true) took 350ms
> psr_active(debugfs_fd, true) took 136ms
> psr_active(debugfs_fd, true) took 1598ms
>
> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108733
> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/kms_frontbuffer_tracking.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> index 276ef83ce386..7924bb902a2a 100644
> --- a/tests/kms_frontbuffer_tracking.c
> +++ b/tests/kms_frontbuffer_tracking.c
> @@ -1642,6 +1642,9 @@ static void __do_assertions(const struct test_mode *t, int flags,
> {
> flags = adjust_assertion_flags(t, flags);
>
> + /* Make sure any submitted rendering is now idle. */
> + gem_quiescent_gpu(drm.fd);
Hm, I thought we do this already at open time, but oh well, makes sense.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> +
> igt_debug("checking asserts in line %i\n", line);
>
> wait_user(2, "Paused before assertions.");
> --
> 2.19.2
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-13 10:00 ` Daniel Vetter
@ 2018-12-13 10:05 ` Chris Wilson
2018-12-14 0:18 ` Dhinakaran Pandiyan
1 sibling, 0 replies; 12+ messages in thread
From: Chris Wilson @ 2018-12-13 10:05 UTC (permalink / raw)
To: Daniel Vetter, Maarten Lankhorst; +Cc: igt-dev, Dhinakaran Pandiyan
Quoting Daniel Vetter (2018-12-13 10:00:10)
> On Thu, Dec 13, 2018 at 10:52:34AM +0100, Maarten Lankhorst wrote:
> > Typically PSR enables in around 136 ms, but on some tests the we have
> > to explicitly make sure that the gpu is idle before rendering.
> >
> > Otherwise, sometimes we wait for the background flusher to finish,
> > which will take at least a second longer, and causes the wait for
> > PSR to timeout.
> >
> > On kms_frontbuffer_tracking:
> > Starting subtest: psr-2p-scndscrn-shrfb-plflip-blt
> > psr_active(debugfs_fd, true) took 136ms
> > psr_active(debugfs_fd, true) took 136ms
> > psr_active(debugfs_fd, true) took 350ms
> > psr_active(debugfs_fd, true) took 136ms
> > psr_active(debugfs_fd, true) took 1598ms
> >
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Cc: José Roberto de Souza <jose.souza@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108733
> > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/kms_frontbuffer_tracking.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/kms_frontbuffer_tracking.c b/tests/kms_frontbuffer_tracking.c
> > index 276ef83ce386..7924bb902a2a 100644
> > --- a/tests/kms_frontbuffer_tracking.c
> > +++ b/tests/kms_frontbuffer_tracking.c
> > @@ -1642,6 +1642,9 @@ static void __do_assertions(const struct test_mode *t, int flags,
> > {
> > flags = adjust_assertion_flags(t, flags);
> >
> > + /* Make sure any submitted rendering is now idle. */
> > + gem_quiescent_gpu(drm.fd);
>
> Hm, I thought we do this already at open time, but oh well, makes sense.
I presumed it was for the frontbuffer rendering tests.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-13 9:52 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions Maarten Lankhorst
2018-12-13 10:00 ` Daniel Vetter
@ 2018-12-13 10:20 ` Patchwork
2018-12-13 11:44 ` Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2018-12-13 10:20 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
URL : https://patchwork.freedesktop.org/series/53981/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5310 -> IGTPW_2146
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2146 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2146, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53981/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2146:
### IGT changes ###
#### Possible regressions ####
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL
#### Warnings ####
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: SKIP -> PASS +2
Known issues
------------
Here are the changes found in IGTPW_2146 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]
* igt@kms_flip@basic-flip-vs-dpms:
- fi-icl-u3: NOTRUN -> DMESG-WARN [fdo#108924] / [fdo#109044]
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362] +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-blb-e6850: NOTRUN -> INCOMPLETE [fdo#107718]
* {igt@runner@aborted}:
- fi-icl-u3: NOTRUN -> FAIL [fdo#108924]
- fi-icl-y: NOTRUN -> FAIL [fdo#108070]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: DMESG-FAIL [fdo#108735] -> PASS
- fi-kbl-7560u: INCOMPLETE [fdo#108044] -> PASS
* igt@kms_busy@basic-flip-b:
- fi-bdw-gvtdvm: FAIL [fdo#103182] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044
[fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108924]: https://bugs.freedesktop.org/show_bug.cgi?id=108924
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109044]: https://bugs.freedesktop.org/show_bug.cgi?id=109044
Participating hosts (47 -> 45)
------------------------------
Additional (2): fi-icl-y fi-icl-u3
Missing (4): fi-kbl-soraka fi-ctg-p8600 fi-ilk-m540 fi-hsw-4200u
Build changes
-------------
* IGT: IGT_4746 -> IGTPW_2146
CI_DRM_5310: 1f86f1fb70f082ed93450c328e518d8013d23953 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2146: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2146/
IGT_4746: 2c793666d8c8328733f5769b16ae5858fee97f3f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2146/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-13 9:52 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions Maarten Lankhorst
2018-12-13 10:00 ` Daniel Vetter
2018-12-13 10:20 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-12-13 11:44 ` Patchwork
2018-12-13 11:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-12-13 12:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2018-12-13 11:44 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
URL : https://patchwork.freedesktop.org/series/53981/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5310 -> IGTPW_2146
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2146 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2146, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53981/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2146:
### IGT changes ###
#### Possible regressions ####
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL
#### Warnings ####
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: SKIP -> PASS +2
Known issues
------------
Here are the changes found in IGTPW_2146 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]
* igt@kms_flip@basic-flip-vs-dpms:
- fi-icl-u3: NOTRUN -> DMESG-WARN [fdo#108924] / [fdo#109044]
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362] +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-blb-e6850: NOTRUN -> INCOMPLETE [fdo#107718]
* {igt@runner@aborted}:
- fi-icl-u3: NOTRUN -> FAIL [fdo#108924]
- fi-icl-y: NOTRUN -> FAIL [fdo#108070]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: DMESG-FAIL [fdo#108735] -> PASS
- fi-kbl-7560u: INCOMPLETE [fdo#108044] -> PASS
* igt@kms_busy@basic-flip-b:
- fi-bdw-gvtdvm: FAIL [fdo#103182] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044
[fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108924]: https://bugs.freedesktop.org/show_bug.cgi?id=108924
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109044]: https://bugs.freedesktop.org/show_bug.cgi?id=109044
Participating hosts (47 -> 45)
------------------------------
Additional (2): fi-icl-y fi-icl-u3
Missing (4): fi-kbl-soraka fi-ctg-p8600 fi-ilk-m540 fi-hsw-4200u
Build changes
-------------
* IGT: IGT_4746 -> IGTPW_2146
CI_DRM_5310: 1f86f1fb70f082ed93450c328e518d8013d23953 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2146: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2146/
IGT_4746: 2c793666d8c8328733f5769b16ae5858fee97f3f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2146/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-13 9:52 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions Maarten Lankhorst
` (2 preceding siblings ...)
2018-12-13 11:44 ` Patchwork
@ 2018-12-13 11:47 ` Patchwork
2018-12-13 12:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
4 siblings, 0 replies; 12+ messages in thread
From: Patchwork @ 2018-12-13 11:47 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
URL : https://patchwork.freedesktop.org/series/53981/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5310 -> IGTPW_2146
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2146 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2146, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53981/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2146:
### IGT changes ###
#### Warnings ####
* igt@kms_busy@basic-flip-a:
- fi-kbl-7567u: SKIP -> PASS +2
Known issues
------------
Here are the changes found in IGTPW_2146 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@amdgpu/amd_basic@cs-compute:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#108094]
* igt@amdgpu/amd_prime@amd-to-i915:
- fi-kbl-8809g: NOTRUN -> FAIL [fdo#109049]
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: PASS -> FAIL [fdo#108767]
* igt@kms_flip@basic-flip-vs-dpms:
- fi-icl-u3: NOTRUN -> DMESG-WARN [fdo#108924] / [fdo#109044]
* igt@kms_pipe_crc_basic@read-crc-pipe-b:
- fi-byt-clapper: PASS -> FAIL [fdo#107362] +1
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
- fi-blb-e6850: NOTRUN -> INCOMPLETE [fdo#107718]
* {igt@runner@aborted}:
- fi-icl-u3: NOTRUN -> FAIL [fdo#108924]
- fi-icl-y: NOTRUN -> FAIL [fdo#108070]
#### Possible fixes ####
* igt@amdgpu/amd_basic@userptr:
- fi-kbl-8809g: DMESG-WARN [fdo#108965] -> PASS
* igt@gem_exec_suspend@basic-s4-devices:
- fi-blb-e6850: INCOMPLETE [fdo#107718] -> PASS
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: DMESG-FAIL [fdo#108735] -> PASS
- fi-kbl-7560u: INCOMPLETE [fdo#108044] -> PASS
* igt@kms_busy@basic-flip-b:
- fi-bdw-gvtdvm: FAIL [fdo#103182] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044
[fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070
[fdo#108094]: https://bugs.freedesktop.org/show_bug.cgi?id=108094
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
[fdo#108924]: https://bugs.freedesktop.org/show_bug.cgi?id=108924
[fdo#108965]: https://bugs.freedesktop.org/show_bug.cgi?id=108965
[fdo#109044]: https://bugs.freedesktop.org/show_bug.cgi?id=109044
[fdo#109049]: https://bugs.freedesktop.org/show_bug.cgi?id=109049
Participating hosts (47 -> 45)
------------------------------
Additional (2): fi-icl-y fi-icl-u3
Missing (4): fi-kbl-soraka fi-ctg-p8600 fi-ilk-m540 fi-hsw-4200u
Build changes
-------------
* IGT: IGT_4746 -> IGTPW_2146
CI_DRM_5310: 1f86f1fb70f082ed93450c328e518d8013d23953 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2146: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2146/
IGT_4746: 2c793666d8c8328733f5769b16ae5858fee97f3f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2146/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-13 9:52 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions Maarten Lankhorst
` (3 preceding siblings ...)
2018-12-13 11:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2018-12-13 12:39 ` Patchwork
2018-12-13 12:49 ` Chris Wilson
4 siblings, 1 reply; 12+ messages in thread
From: Patchwork @ 2018-12-13 12:39 UTC (permalink / raw)
To: Maarten Lankhorst; +Cc: igt-dev
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
URL : https://patchwork.freedesktop.org/series/53981/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_5310_full -> IGTPW_2146_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_2146_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2146_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/53981/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2146_full:
### IGT changes ###
#### Possible regressions ####
* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-glk: PASS -> TIMEOUT
- shard-hsw: PASS -> TIMEOUT
- shard-kbl: PASS -> TIMEOUT
- shard-snb: PASS -> TIMEOUT
#### Warnings ####
* igt@pm_rc6_residency@rc6-accuracy:
- shard-snb: PASS -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2146_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_double_irq_loop:
- shard-hsw: PASS -> DMESG-WARN [fdo#102614]
* igt@i915_suspend@fence-restore-untiled:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-apl: PASS -> FAIL [fdo#106641]
* igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
- shard-kbl: PASS -> DMESG-WARN [fdo#107956] +1
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_chv_cursor_fail@pipe-b-128x128-right-edge:
- shard-hsw: PASS -> FAIL [fdo#107814]
* igt@kms_color@pipe-a-ctm-max:
- shard-apl: PASS -> FAIL [fdo#108147]
* igt@kms_color@pipe-a-degamma:
- shard-apl: PASS -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_cursor_crc@cursor-128x128-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-128x128-suspend:
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-64x64-dpms:
- shard-apl: PASS -> FAIL [fdo#103232] +5
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-glk: PASS -> FAIL [fdo#103232] +5
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_legacy@2x-nonblocking-modeset-vs-cursor-atomic:
- shard-glk: PASS -> FAIL [fdo#105454] / [fdo#106509]
* igt@kms_flip@2x-plain-flip-ts-check-interruptible:
- shard-hsw: PASS -> DMESG-FAIL [fdo#102614]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-onoff:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
- shard-glk: PASS -> FAIL [fdo#103167] +1
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
- shard-apl: PASS -> INCOMPLETE [fdo#103927]
* igt@kms_plane@pixel-format-pipe-c-planes:
- shard-apl: PASS -> FAIL [fdo#103166] +2
* igt@kms_setmode@basic:
- shard-apl: PASS -> FAIL [fdo#99912]
* igt@kms_universal_plane@universal-plane-pipe-c-functional:
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@syncobj_wait@invalid-wait-bad-flags:
- shard-snb: PASS -> INCOMPLETE [fdo#105411] / [fdo#107469]
#### Possible fixes ####
* igt@gem_exec_fence@basic-await-default:
- shard-hsw: FAIL [fdo#108888] -> PASS
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
- shard-apl: FAIL [fdo#103232] -> PASS
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-onoff:
- shard-apl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
- shard-glk: FAIL [fdo#103167] -> PASS
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-apl: FAIL [fdo#103166] -> PASS +2
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-glk: FAIL [fdo#103166] -> PASS +3
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-kbl: DMESG-WARN [fdo#105604] -> PASS
* igt@kms_vblank@pipe-b-ts-continuation-suspend:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@syncobj_wait@multi-wait-for-submit-unsubmitted-signaled:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
#### Warnings ####
* igt@kms_cursor_crc@cursor-256x256-random:
- shard-apl: INCOMPLETE [fdo#103927] -> FAIL [fdo#103232]
[fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105454]: https://bugs.freedesktop.org/show_bug.cgi?id=105454
[fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
[fdo#106509]: https://bugs.freedesktop.org/show_bug.cgi?id=106509
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#107814]: https://bugs.freedesktop.org/show_bug.cgi?id=107814
[fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
[fdo#108888]: https://bugs.freedesktop.org/show_bug.cgi?id=108888
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4746 -> IGTPW_2146
* Piglit: piglit_4509 -> None
CI_DRM_5310: 1f86f1fb70f082ed93450c328e518d8013d23953 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2146: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2146/
IGT_4746: 2c793666d8c8328733f5769b16ae5858fee97f3f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2146/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-13 12:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2018-12-13 12:49 ` Chris Wilson
2018-12-13 13:39 ` Maarten Lankhorst
0 siblings, 1 reply; 12+ messages in thread
From: Chris Wilson @ 2018-12-13 12:49 UTC (permalink / raw)
To: Maarten Lankhorst, Patchwork, igt-dev
Quoting Patchwork (2018-12-13 12:39:18)
> #### Possible regressions ####
>
> * igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
> - shard-glk: PASS -> TIMEOUT
> - shard-hsw: PASS -> TIMEOUT
> - shard-kbl: PASS -> TIMEOUT
> - shard-snb: PASS -> TIMEOUT
Ah, the modesetfrombusy will never idle as it does
while (1) igt_draw_rect(IGT_DRAW_BLT); and gem_quiescent_gpu() calls
DROP_IDLE under the belief that nothing is queueing more work and will
eventually idle.
/o\
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-13 12:49 ` Chris Wilson
@ 2018-12-13 13:39 ` Maarten Lankhorst
0 siblings, 0 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2018-12-13 13:39 UTC (permalink / raw)
To: Chris Wilson, Patchwork, igt-dev
Op 13-12-2018 om 13:49 schreef Chris Wilson:
> Quoting Patchwork (2018-12-13 12:39:18)
>> #### Possible regressions ####
>>
>> * igt@kms_frontbuffer_tracking@fbc-modesetfrombusy:
>> - shard-glk: PASS -> TIMEOUT
>> - shard-hsw: PASS -> TIMEOUT
>> - shard-kbl: PASS -> TIMEOUT
>> - shard-snb: PASS -> TIMEOUT
> Ah, the modesetfrombusy will never idle as it does
> while (1) igt_draw_rect(IGT_DRAW_BLT); and gem_quiescent_gpu() calls
> DROP_IDLE under the belief that nothing is queueing more work and will
> eventually idle.
>
> /o\
> -Chris
Right, v2 sent. :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-13 10:00 ` Daniel Vetter
2018-12-13 10:05 ` Chris Wilson
@ 2018-12-14 0:18 ` Dhinakaran Pandiyan
2018-12-14 0:22 ` Dhinakaran Pandiyan
1 sibling, 1 reply; 12+ messages in thread
From: Dhinakaran Pandiyan @ 2018-12-14 0:18 UTC (permalink / raw)
To: Daniel Vetter, Maarten Lankhorst, Chris Wilson; +Cc: igt-dev
On Thu, 2018-12-13 at 11:00 +0100, Daniel Vetter wrote:
> On Thu, Dec 13, 2018 at 10:52:34AM +0100, Maarten Lankhorst wrote:
> > Typically PSR enables in around 136 ms, but on some tests the we
> > have
> > to explicitly make sure that the gpu is idle before rendering.
> >
> > Otherwise, sometimes we wait for the background flusher to finish,
> > which will take at least a second longer, and causes the wait for
> > PSR to timeout.
> >
> > On kms_frontbuffer_tracking:
> > Starting subtest: psr-2p-scndscrn-shrfb-plflip-blt
> > psr_active(debugfs_fd, true) took 136ms
> > psr_active(debugfs_fd, true) took 136ms
> > psr_active(debugfs_fd, true) took 350ms
> > psr_active(debugfs_fd, true) took 136ms
> > psr_active(debugfs_fd, true) took 1598ms
> >
> > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > Cc: José Roberto de Souza <jose.souza@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108733
> > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> > tests/kms_frontbuffer_tracking.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/tests/kms_frontbuffer_tracking.c
> > b/tests/kms_frontbuffer_tracking.c
> > index 276ef83ce386..7924bb902a2a 100644
> > --- a/tests/kms_frontbuffer_tracking.c
> > +++ b/tests/kms_frontbuffer_tracking.c
> > @@ -1642,6 +1642,9 @@ static void __do_assertions(const struct
> > test_mode *t, int flags,
> > {
> > flags = adjust_assertion_flags(t, flags);
> >
> > + /* Make sure any submitted rendering is now idle. */
> > + gem_quiescent_gpu(drm.fd);
Shouldn't this be called from draw_rect() so that the flip is done
after rendering is complete?
>
> Hm, I thought we do this already at open time, but oh well, makes
> sense.
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > +
> > igt_debug("checking asserts in line %i\n", line);
> >
> > wait_user(2, "Paused before assertions.");
> > --
> > 2.19.2
> >
> > _______________________________________________
> > igt-dev mailing list
> > igt-dev@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/igt-dev
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-14 0:18 ` Dhinakaran Pandiyan
@ 2018-12-14 0:22 ` Dhinakaran Pandiyan
2018-12-14 9:31 ` Maarten Lankhorst
0 siblings, 1 reply; 12+ messages in thread
From: Dhinakaran Pandiyan @ 2018-12-14 0:22 UTC (permalink / raw)
To: Daniel Vetter, Maarten Lankhorst, Chris Wilson; +Cc: igt-dev
On Thu, 2018-12-13 at 16:18 -0800, Dhinakaran Pandiyan wrote:
> On Thu, 2018-12-13 at 11:00 +0100, Daniel Vetter wrote:
> > On Thu, Dec 13, 2018 at 10:52:34AM +0100, Maarten Lankhorst wrote:
> > > Typically PSR enables in around 136 ms, but on some tests the we
> > > have
> > > to explicitly make sure that the gpu is idle before rendering.
> > >
> > > Otherwise, sometimes we wait for the background flusher to
> > > finish,
> > > which will take at least a second longer, and causes the wait for
> > > PSR to timeout.
> > >
> > > On kms_frontbuffer_tracking:
> > > Starting subtest: psr-2p-scndscrn-shrfb-plflip-blt
> > > psr_active(debugfs_fd, true) took 136ms
> > > psr_active(debugfs_fd, true) took 136ms
> > > psr_active(debugfs_fd, true) took 350ms
> > > psr_active(debugfs_fd, true) took 136ms
> > > psr_active(debugfs_fd, true) took 1598ms
Now that I read this again, we should be checking for PSR exit after a
flip but instead we are waiting for PSR to become active again.
However, this is a different issue that we should fix separately.
> > >
> > > Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> > > Cc: José Roberto de Souza <jose.souza@intel.com>
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108733
> > > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > ---
> > > tests/kms_frontbuffer_tracking.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/tests/kms_frontbuffer_tracking.c
> > > b/tests/kms_frontbuffer_tracking.c
> > > index 276ef83ce386..7924bb902a2a 100644
> > > --- a/tests/kms_frontbuffer_tracking.c
> > > +++ b/tests/kms_frontbuffer_tracking.c
> > > @@ -1642,6 +1642,9 @@ static void __do_assertions(const struct
> > > test_mode *t, int flags,
> > > {
> > > flags = adjust_assertion_flags(t, flags);
> > >
> > > + /* Make sure any submitted rendering is now idle. */
> > > + gem_quiescent_gpu(drm.fd);
>
> Shouldn't this be called from draw_rect() so that the flip is done
> after rendering is complete?
>
>
>
>
> >
> > Hm, I thought we do this already at open time, but oh well, makes
> > sense.
> >
> > Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > +
> > > igt_debug("checking asserts in line %i\n", line);
> > >
> > > wait_user(2, "Paused before assertions.");
> > > --
> > > 2.19.2
> > >
> > > _______________________________________________
> > > igt-dev mailing list
> > > igt-dev@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/igt-dev
> >
> >
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions.
2018-12-14 0:22 ` Dhinakaran Pandiyan
@ 2018-12-14 9:31 ` Maarten Lankhorst
0 siblings, 0 replies; 12+ messages in thread
From: Maarten Lankhorst @ 2018-12-14 9:31 UTC (permalink / raw)
To: dhinakaran.pandiyan, Daniel Vetter, Chris Wilson; +Cc: igt-dev
Op 14-12-2018 om 01:22 schreef Dhinakaran Pandiyan:
> On Thu, 2018-12-13 at 16:18 -0800, Dhinakaran Pandiyan wrote:
>> On Thu, 2018-12-13 at 11:00 +0100, Daniel Vetter wrote:
>>> On Thu, Dec 13, 2018 at 10:52:34AM +0100, Maarten Lankhorst wrote:
>>>> Typically PSR enables in around 136 ms, but on some tests the we
>>>> have
>>>> to explicitly make sure that the gpu is idle before rendering.
>>>>
>>>> Otherwise, sometimes we wait for the background flusher to
>>>> finish,
>>>> which will take at least a second longer, and causes the wait for
>>>> PSR to timeout.
>>>>
>>>> On kms_frontbuffer_tracking:
>>>> Starting subtest: psr-2p-scndscrn-shrfb-plflip-blt
>>>> psr_active(debugfs_fd, true) took 136ms
>>>> psr_active(debugfs_fd, true) took 136ms
>>>> psr_active(debugfs_fd, true) took 350ms
>>>> psr_active(debugfs_fd, true) took 136ms
>>>> psr_active(debugfs_fd, true) took 1598ms
> Now that I read this again, we should be checking for PSR exit after a
> flip but instead we are waiting for PSR to become active again.
> However, this is a different issue that we should fix separately.
In that case wouldn't we better off not idling the GPU and just waiting for PSR exit?
>>>> Cc: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
>>>> Cc: José Roberto de Souza <jose.souza@intel.com>
>>>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108733
>>>> Suggested-by: Chris Wilson <chris@chris-wilson.co.uk>
>>>> ---
>>>> tests/kms_frontbuffer_tracking.c | 3 +++
>>>> 1 file changed, 3 insertions(+)
>>>>
>>>> diff --git a/tests/kms_frontbuffer_tracking.c
>>>> b/tests/kms_frontbuffer_tracking.c
>>>> index 276ef83ce386..7924bb902a2a 100644
>>>> --- a/tests/kms_frontbuffer_tracking.c
>>>> +++ b/tests/kms_frontbuffer_tracking.c
>>>> @@ -1642,6 +1642,9 @@ static void __do_assertions(const struct
>>>> test_mode *t, int flags,
>>>> {
>>>> flags = adjust_assertion_flags(t, flags);
>>>>
>>>> + /* Make sure any submitted rendering is now idle. */
>>>> + gem_quiescent_gpu(drm.fd);
>> Shouldn't this be called from draw_rect() so that the flip is done
>> after rendering is complete?
Hmm, I thought the point was to make sure the gpu was busy when flipping to trigger any race of
draw vs flip. Hence putting the idle in the assertions. :)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-12-14 9:31 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 9:52 [igt-dev] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Make sure GPU is quiescent before handling assertions Maarten Lankhorst
2018-12-13 10:00 ` Daniel Vetter
2018-12-13 10:05 ` Chris Wilson
2018-12-14 0:18 ` Dhinakaran Pandiyan
2018-12-14 0:22 ` Dhinakaran Pandiyan
2018-12-14 9:31 ` Maarten Lankhorst
2018-12-13 10:20 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2018-12-13 11:44 ` Patchwork
2018-12-13 11:47 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-12-13 12:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2018-12-13 12:49 ` Chris Wilson
2018-12-13 13:39 ` Maarten Lankhorst
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.