* [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' @ 2018-12-13 12:42 Kashyap Chamarthy 2018-12-13 12:42 ` [Qemu-devel] [PATCH 1/3] qemu-deprecated.texi: Rename the HMP section Kashyap Chamarthy ` (3 more replies) 0 siblings, 4 replies; 12+ messages in thread From: Kashyap Chamarthy @ 2018-12-13 12:42 UTC (permalink / raw) To: qemu-devel; +Cc: eblake, armbru, ehabkost, imammedo, thuth, Kashyap Chamarthy Kashyap Chamarthy (3): qemu-deprecated.texi: Rename the HMP section Update that HMP 'cpu_add' is deprecated in 4.0 Mention that QMP 'cpu-add' will be deprecated qemu-deprecated.texi | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) -- 2.17.2 ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH 1/3] qemu-deprecated.texi: Rename the HMP section 2018-12-13 12:42 [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' Kashyap Chamarthy @ 2018-12-13 12:42 ` Kashyap Chamarthy 2018-12-13 20:01 ` Thomas Huth 2018-12-13 12:42 ` [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 Kashyap Chamarthy ` (2 subsequent siblings) 3 siblings, 1 reply; 12+ messages in thread From: Kashyap Chamarthy @ 2018-12-13 12:42 UTC (permalink / raw) To: qemu-devel; +Cc: eblake, armbru, ehabkost, imammedo, thuth, Kashyap Chamarthy So that it is consistent with the naming of QMP's Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> --- qemu-deprecated.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 72b8191d60..46bec688db 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -114,7 +114,7 @@ The ``query-cpus'' command is replaced by the ``query-cpus-fast'' command. The ``arch'' output member of the ``query-cpus-fast'' command is replaced by the ``target'' output member. -@section System emulator human monitor commands +@section Human Monitor Protocol (HMP) commands @subsection The hub_id parameter of 'hostfwd_add' / 'hostfwd_remove' (since 3.1) -- 2.17.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 1/3] qemu-deprecated.texi: Rename the HMP section 2018-12-13 12:42 ` [Qemu-devel] [PATCH 1/3] qemu-deprecated.texi: Rename the HMP section Kashyap Chamarthy @ 2018-12-13 20:01 ` Thomas Huth 0 siblings, 0 replies; 12+ messages in thread From: Thomas Huth @ 2018-12-13 20:01 UTC (permalink / raw) To: Kashyap Chamarthy, qemu-devel; +Cc: eblake, armbru, ehabkost, imammedo On 2018-12-13 13:42, Kashyap Chamarthy wrote: > So that it is consistent with the naming of QMP's > > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> > --- > qemu-deprecated.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > index 72b8191d60..46bec688db 100644 > --- a/qemu-deprecated.texi > +++ b/qemu-deprecated.texi > @@ -114,7 +114,7 @@ The ``query-cpus'' command is replaced by the ``query-cpus-fast'' command. > The ``arch'' output member of the ``query-cpus-fast'' command is > replaced by the ``target'' output member. > > -@section System emulator human monitor commands > +@section Human Monitor Protocol (HMP) commands Reviewed-by: Thomas Huth <thuth@redhat.com> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 2018-12-13 12:42 [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' Kashyap Chamarthy 2018-12-13 12:42 ` [Qemu-devel] [PATCH 1/3] qemu-deprecated.texi: Rename the HMP section Kashyap Chamarthy @ 2018-12-13 12:42 ` Kashyap Chamarthy 2018-12-13 14:51 ` Igor Mammedov 2018-12-13 20:03 ` Thomas Huth 2018-12-13 12:42 ` [Qemu-devel] [PATCH 3/3] Mention that QMP 'cpu-add' will be deprecated Kashyap Chamarthy 2018-12-13 21:59 ` [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' Eduardo Habkost 3 siblings, 2 replies; 12+ messages in thread From: Kashyap Chamarthy @ 2018-12-13 12:42 UTC (permalink / raw) To: qemu-devel; +Cc: eblake, armbru, ehabkost, imammedo, thuth, Kashyap Chamarthy Also fix the wrong spelling of it: s/cpu-add/cpu_add/ Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> --- qemu-deprecated.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 46bec688db..79743ab8bd 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -121,9 +121,9 @@ replaced by the ``target'' output member. The @option{[hub_id name]} parameter tuple of the 'hostfwd_add' and 'hostfwd_remove' HMP commands has been replaced by @option{netdev_id}. -@subsection cpu-add (since 3.1) +@subsection cpu_add (since 4.0) -Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See +Use ``device_add'' for hotplugging vCPUs instead of ``cpu_add''. See documentation of ``query-hotpluggable-cpus'' for additional details. @section System emulator devices -- 2.17.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 2018-12-13 12:42 ` [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 Kashyap Chamarthy @ 2018-12-13 14:51 ` Igor Mammedov 2018-12-13 20:03 ` Thomas Huth 1 sibling, 0 replies; 12+ messages in thread From: Igor Mammedov @ 2018-12-13 14:51 UTC (permalink / raw) To: Kashyap Chamarthy; +Cc: qemu-devel, eblake, armbru, ehabkost, thuth On Thu, 13 Dec 2018 13:42:23 +0100 Kashyap Chamarthy <kchamart@redhat.com> wrote: > Also fix the wrong spelling of it: s/cpu-add/cpu_add/ > > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > qemu-deprecated.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > index 46bec688db..79743ab8bd 100644 > --- a/qemu-deprecated.texi > +++ b/qemu-deprecated.texi > @@ -121,9 +121,9 @@ replaced by the ``target'' output member. > The @option{[hub_id name]} parameter tuple of the 'hostfwd_add' and > 'hostfwd_remove' HMP commands has been replaced by @option{netdev_id}. > > -@subsection cpu-add (since 3.1) > +@subsection cpu_add (since 4.0) > > -Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See > +Use ``device_add'' for hotplugging vCPUs instead of ``cpu_add''. See > documentation of ``query-hotpluggable-cpus'' for additional details. > > @section System emulator devices ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 2018-12-13 12:42 ` [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 Kashyap Chamarthy 2018-12-13 14:51 ` Igor Mammedov @ 2018-12-13 20:03 ` Thomas Huth 2018-12-13 21:58 ` Eduardo Habkost 2018-12-14 12:16 ` Kashyap Chamarthy 1 sibling, 2 replies; 12+ messages in thread From: Thomas Huth @ 2018-12-13 20:03 UTC (permalink / raw) To: Kashyap Chamarthy, qemu-devel; +Cc: eblake, armbru, ehabkost, imammedo On 2018-12-13 13:42, Kashyap Chamarthy wrote: > Also fix the wrong spelling of it: s/cpu-add/cpu_add/ > > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> > --- > qemu-deprecated.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > index 46bec688db..79743ab8bd 100644 > --- a/qemu-deprecated.texi > +++ b/qemu-deprecated.texi > @@ -121,9 +121,9 @@ replaced by the ``target'' output member. > The @option{[hub_id name]} parameter tuple of the 'hostfwd_add' and > 'hostfwd_remove' HMP commands has been replaced by @option{netdev_id}. > > -@subsection cpu-add (since 3.1) > +@subsection cpu_add (since 4.0) > > -Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See > +Use ``device_add'' for hotplugging vCPUs instead of ``cpu_add''. See AFAIK the spelling was right. It's "cpu-add" ... only device_add is using the underscore. Welcome to the wonderful world of QEMU inconsistencies... Thomas ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 2018-12-13 20:03 ` Thomas Huth @ 2018-12-13 21:58 ` Eduardo Habkost 2018-12-14 12:16 ` Kashyap Chamarthy 1 sibling, 0 replies; 12+ messages in thread From: Eduardo Habkost @ 2018-12-13 21:58 UTC (permalink / raw) To: Thomas Huth; +Cc: Kashyap Chamarthy, qemu-devel, eblake, armbru, imammedo On Thu, Dec 13, 2018 at 09:03:23PM +0100, Thomas Huth wrote: > On 2018-12-13 13:42, Kashyap Chamarthy wrote: > > Also fix the wrong spelling of it: s/cpu-add/cpu_add/ > > > > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> > > --- > > qemu-deprecated.texi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > > index 46bec688db..79743ab8bd 100644 > > --- a/qemu-deprecated.texi > > +++ b/qemu-deprecated.texi > > @@ -121,9 +121,9 @@ replaced by the ``target'' output member. > > The @option{[hub_id name]} parameter tuple of the 'hostfwd_add' and > > 'hostfwd_remove' HMP commands has been replaced by @option{netdev_id}. > > > > -@subsection cpu-add (since 3.1) > > +@subsection cpu_add (since 4.0) > > > > -Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See > > +Use ``device_add'' for hotplugging vCPUs instead of ``cpu_add''. See > > AFAIK the spelling was right. It's "cpu-add" ... only device_add is > using the underscore. Welcome to the wonderful world of QEMU > inconsistencies... Thanks for noting. I have fixed it while committing. -- Eduardo ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 2018-12-13 20:03 ` Thomas Huth 2018-12-13 21:58 ` Eduardo Habkost @ 2018-12-14 12:16 ` Kashyap Chamarthy 1 sibling, 0 replies; 12+ messages in thread From: Kashyap Chamarthy @ 2018-12-14 12:16 UTC (permalink / raw) To: Thomas Huth; +Cc: qemu-devel, eblake, armbru, ehabkost, imammedo On Thu, Dec 13, 2018 at 09:03:23PM +0100, Thomas Huth wrote: > On 2018-12-13 13:42, Kashyap Chamarthy wrote: > > Also fix the wrong spelling of it: s/cpu-add/cpu_add/ > > > > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> > > --- > > qemu-deprecated.texi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > > index 46bec688db..79743ab8bd 100644 > > --- a/qemu-deprecated.texi > > +++ b/qemu-deprecated.texi > > @@ -121,9 +121,9 @@ replaced by the ``target'' output member. > > The @option{[hub_id name]} parameter tuple of the 'hostfwd_add' and > > 'hostfwd_remove' HMP commands has been replaced by @option{netdev_id}. > > > > -@subsection cpu-add (since 3.1) > > +@subsection cpu_add (since 4.0) > > > > -Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See > > +Use ``device_add'' for hotplugging vCPUs instead of ``cpu_add''. See > > AFAIK the spelling was right. It's "cpu-add" ... only device_add is > using the underscore. Welcome to the wonderful world of QEMU > inconsistencies... Huh...I thought I checked the HMP spelling; but indeed you're right! Confusingly enough, the QMP spelling _doesn't_ have underscore: [...] ETEXI { .name = "cpu-add", .args_type = "id:i", .params = "id", .help = "add cpu (deprecated, use device_add instead)", .cmd = hmp_cpu_add, }, STEXI @item cpu-add @var{id} @findex cpu-add Add CPU with id @var{id}. This command is deprecated, please +use @code{device_add} instead. For details, refer to 'docs/cpu-hotplug.rst'. [...] Thanks for the eagle eyes, Thomas. -- /kashyap ^ permalink raw reply [flat|nested] 12+ messages in thread
* [Qemu-devel] [PATCH 3/3] Mention that QMP 'cpu-add' will be deprecated 2018-12-13 12:42 [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' Kashyap Chamarthy 2018-12-13 12:42 ` [Qemu-devel] [PATCH 1/3] qemu-deprecated.texi: Rename the HMP section Kashyap Chamarthy 2018-12-13 12:42 ` [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 Kashyap Chamarthy @ 2018-12-13 12:42 ` Kashyap Chamarthy 2018-12-13 14:52 ` Igor Mammedov 2018-12-13 20:04 ` Thomas Huth 2018-12-13 21:59 ` [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' Eduardo Habkost 3 siblings, 2 replies; 12+ messages in thread From: Kashyap Chamarthy @ 2018-12-13 12:42 UTC (permalink / raw) To: qemu-devel; +Cc: eblake, armbru, ehabkost, imammedo, thuth, Kashyap Chamarthy Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> --- qemu-deprecated.texi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi index 79743ab8bd..2505e1f47f 100644 --- a/qemu-deprecated.texi +++ b/qemu-deprecated.texi @@ -114,6 +114,12 @@ The ``query-cpus'' command is replaced by the ``query-cpus-fast'' command. The ``arch'' output member of the ``query-cpus-fast'' command is replaced by the ``target'' output member. +@subsection cpu-add (since 4.0) + +Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See +documentation of ``query-hotpluggable-cpus'' for additional +details. + @section Human Monitor Protocol (HMP) commands @subsection The hub_id parameter of 'hostfwd_add' / 'hostfwd_remove' (since 3.1) -- 2.17.2 ^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 3/3] Mention that QMP 'cpu-add' will be deprecated 2018-12-13 12:42 ` [Qemu-devel] [PATCH 3/3] Mention that QMP 'cpu-add' will be deprecated Kashyap Chamarthy @ 2018-12-13 14:52 ` Igor Mammedov 2018-12-13 20:04 ` Thomas Huth 1 sibling, 0 replies; 12+ messages in thread From: Igor Mammedov @ 2018-12-13 14:52 UTC (permalink / raw) To: Kashyap Chamarthy; +Cc: qemu-devel, eblake, armbru, ehabkost, thuth On Thu, 13 Dec 2018 13:42:24 +0100 Kashyap Chamarthy <kchamart@redhat.com> wrote: > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> > --- > qemu-deprecated.texi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > index 79743ab8bd..2505e1f47f 100644 > --- a/qemu-deprecated.texi > +++ b/qemu-deprecated.texi > @@ -114,6 +114,12 @@ The ``query-cpus'' command is replaced by the ``query-cpus-fast'' command. > The ``arch'' output member of the ``query-cpus-fast'' command is > replaced by the ``target'' output member. > > +@subsection cpu-add (since 4.0) > + > +Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See > +documentation of ``query-hotpluggable-cpus'' for additional > +details. > + > @section Human Monitor Protocol (HMP) commands > > @subsection The hub_id parameter of 'hostfwd_add' / 'hostfwd_remove' (since 3.1) ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 3/3] Mention that QMP 'cpu-add' will be deprecated 2018-12-13 12:42 ` [Qemu-devel] [PATCH 3/3] Mention that QMP 'cpu-add' will be deprecated Kashyap Chamarthy 2018-12-13 14:52 ` Igor Mammedov @ 2018-12-13 20:04 ` Thomas Huth 1 sibling, 0 replies; 12+ messages in thread From: Thomas Huth @ 2018-12-13 20:04 UTC (permalink / raw) To: Kashyap Chamarthy, qemu-devel; +Cc: eblake, armbru, ehabkost, imammedo On 2018-12-13 13:42, Kashyap Chamarthy wrote: > Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com> > --- > qemu-deprecated.texi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > index 79743ab8bd..2505e1f47f 100644 > --- a/qemu-deprecated.texi > +++ b/qemu-deprecated.texi > @@ -114,6 +114,12 @@ The ``query-cpus'' command is replaced by the ``query-cpus-fast'' command. > The ``arch'' output member of the ``query-cpus-fast'' command is > replaced by the ``target'' output member. > > +@subsection cpu-add (since 4.0) > + > +Use ``device_add'' for hotplugging vCPUs instead of ``cpu-add''. See > +documentation of ``query-hotpluggable-cpus'' for additional > +details. > + > @section Human Monitor Protocol (HMP) commands > > @subsection The hub_id parameter of 'hostfwd_add' / 'hostfwd_remove' (since 3.1) > Reviewed-by: Thomas Huth <thuth@redhat.com> ^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' 2018-12-13 12:42 [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' Kashyap Chamarthy ` (2 preceding siblings ...) 2018-12-13 12:42 ` [Qemu-devel] [PATCH 3/3] Mention that QMP 'cpu-add' will be deprecated Kashyap Chamarthy @ 2018-12-13 21:59 ` Eduardo Habkost 3 siblings, 0 replies; 12+ messages in thread From: Eduardo Habkost @ 2018-12-13 21:59 UTC (permalink / raw) To: Kashyap Chamarthy; +Cc: qemu-devel, eblake, armbru, imammedo, thuth Queued. Thanks, and sorry for making the original series miss the 3.1 release. -- Eduardo ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-12-14 12:16 UTC | newest] Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-12-13 12:42 [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' Kashyap Chamarthy 2018-12-13 12:42 ` [Qemu-devel] [PATCH 1/3] qemu-deprecated.texi: Rename the HMP section Kashyap Chamarthy 2018-12-13 20:01 ` Thomas Huth 2018-12-13 12:42 ` [Qemu-devel] [PATCH 2/3] Update that HMP 'cpu_add' is deprecated in 4.0 Kashyap Chamarthy 2018-12-13 14:51 ` Igor Mammedov 2018-12-13 20:03 ` Thomas Huth 2018-12-13 21:58 ` Eduardo Habkost 2018-12-14 12:16 ` Kashyap Chamarthy 2018-12-13 12:42 ` [Qemu-devel] [PATCH 3/3] Mention that QMP 'cpu-add' will be deprecated Kashyap Chamarthy 2018-12-13 14:52 ` Igor Mammedov 2018-12-13 20:04 ` Thomas Huth 2018-12-13 21:59 ` [Qemu-devel] [PATCH 0/3] Update deprecation notes for QMP 'cpu-add' & HMP 'cpu_add' Eduardo Habkost
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.