* [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl
@ 2018-12-13 14:13 Andrea Adami
2018-12-13 16:23 ` Burton, Ross
` (3 more replies)
0 siblings, 4 replies; 9+ messages in thread
From: Andrea Adami @ 2018-12-13 14:13 UTC (permalink / raw)
To: openembedded-core
Add the missing triplets (not considering uclibc) for do_configure.
Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
---
.../python3/powerpc-musl-triplets.patch | 43 +++++++++++++++++++
meta/recipes-devtools/python/python3_3.5.6.bb | 1 +
2 files changed, 44 insertions(+)
create mode 100644 meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
diff --git a/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch b/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
new file mode 100644
index 0000000000..477d049858
--- /dev/null
+++ b/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
@@ -0,0 +1,43 @@
+Using musl libc the task do_configure fails on powerpc*.
+
+ checking build system type... x86_64-pc-linux-gnu
+ checking host system type... powerpc-oe-linux-musl
+ checking for python3.5... python3.5
+ ...
+ checking for the platform triplet based on compiler characteristics...
+ powerpc-linux-gnu
+ configure: error: internal configure error for the platform triplet
+
+Fix this by adding the musl triplets.
+Note: uclibc is purposedly not considered (unsupported in oe-core).
+
+Upstream-Status: Pending
+Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
+
+--- a/configure.ac 2018-12-13 14:44:55.414309610 +0100
++++ b/configure.ac 2018-12-13 13:22:37.546497547 +0100
+@@ -831,14 +831,22 @@
+ or1k-linux-gnu
+ # elif defined(__powerpc__) && defined(__SPE__)
+ powerpc-linux-gnuspe
++# elif defined(__powerpc__) && !defined(__GLIBC__)
++ powerpc-linux-musl
++# elif defined(__powerpc__)
++ powerpc-linux-gnu
++# elif defined(__powerpc64__) && !defined(__GLIBC__)
++# if defined(__LITTLE_ENDIAN__)
++ powerpc64le-linux-musl
++# else
++ powerpc64-linux-musl
++# endif
+ # elif defined(__powerpc64__)
+ # if defined(__LITTLE_ENDIAN__)
+ powerpc64le-linux-gnu
+ # else
+ powerpc64-linux-gnu
+ # endif
+-# elif defined(__powerpc__)
+- powerpc-linux-gnu
+ # elif defined(__s390x__)
+ s390x-linux-gnu
+ # elif defined(__s390__)
diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb b/meta/recipes-devtools/python/python3_3.5.6.bb
index cd7991e7f8..2e8ae711d5 100644
--- a/meta/recipes-devtools/python/python3_3.5.6.bb
+++ b/meta/recipes-devtools/python/python3_3.5.6.bb
@@ -44,6 +44,7 @@ SRC_URI += "\
file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
file://run-ptest \
"
+SRC_URI_append_libc-musl = " file://powerpc-musl-triplets.patch"
inherit multilib_header python3native update-alternatives qemu ptest
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl
2018-12-13 14:13 [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl Andrea Adami
@ 2018-12-13 16:23 ` Burton, Ross
2018-12-13 16:25 ` Burton, Ross
2018-12-13 16:26 ` Richard Purdie
` (2 subsequent siblings)
3 siblings, 1 reply; 9+ messages in thread
From: Burton, Ross @ 2018-12-13 16:23 UTC (permalink / raw)
To: Andrea Adami; +Cc: OE-core
On Thu, 13 Dec 2018 at 14:13, Andrea Adami <andrea.adami@gmail.com> wrote:
> +SRC_URI_append_libc-musl = " file://powerpc-musl-triplets.patch"
Whilst this is musl specific it doesn't break glibc, so apply it universally.
Also seems that assuming !glibc == musl isn't safe, is there a better define?
Ross
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl
2018-12-13 16:23 ` Burton, Ross
@ 2018-12-13 16:25 ` Burton, Ross
0 siblings, 0 replies; 9+ messages in thread
From: Burton, Ross @ 2018-12-13 16:25 UTC (permalink / raw)
To: Andrea Adami; +Cc: OE-core
Also, why does this appear to be powerpc-specific?
Ross
On Thu, 13 Dec 2018 at 16:23, Burton, Ross <ross.burton@intel.com> wrote:
>
> On Thu, 13 Dec 2018 at 14:13, Andrea Adami <andrea.adami@gmail.com> wrote:
> > +SRC_URI_append_libc-musl = " file://powerpc-musl-triplets.patch"
>
> Whilst this is musl specific it doesn't break glibc, so apply it universally.
>
> Also seems that assuming !glibc == musl isn't safe, is there a better define?
>
> Ross
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl
2018-12-13 14:13 [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl Andrea Adami
2018-12-13 16:23 ` Burton, Ross
@ 2018-12-13 16:26 ` Richard Purdie
2018-12-13 16:49 ` Andrea Adami
2018-12-13 17:01 ` Serhey Popovych
2018-12-14 3:13 ` Khem Raj
3 siblings, 1 reply; 9+ messages in thread
From: Richard Purdie @ 2018-12-13 16:26 UTC (permalink / raw)
To: Andrea Adami, openembedded-core
On Thu, 2018-12-13 at 15:13 +0100, Andrea Adami wrote:
> Add the missing triplets (not considering uclibc) for do_configure.
>
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
> .../python3/powerpc-musl-triplets.patch | 43
> +++++++++++++++++++
> meta/recipes-devtools/python/python3_3.5.6.bb | 1 +
> 2 files changed, 44 insertions(+)
> create mode 100644 meta/recipes-devtools/python/python3/powerpc-
> musl-triplets.patch
>
> diff --git a/meta/recipes-devtools/python/python3/powerpc-musl-
> triplets.patch b/meta/recipes-devtools/python/python3/powerpc-musl-
> triplets.patch
> new file mode 100644
> index 0000000000..477d049858
> --- /dev/null
> +++ b/meta/recipes-devtools/python/python3/powerpc-musl-
> triplets.patch
> @@ -0,0 +1,43 @@
> +Using musl libc the task do_configure fails on powerpc*.
> +
> + checking build system type... x86_64-pc-linux-gnu
> + checking host system type... powerpc-oe-linux-musl
> + checking for python3.5... python3.5
> + ...
> + checking for the platform triplet based on compiler
> characteristics...
> + powerpc-linux-gnu
> + configure: error: internal configure error for the platform
> triplet
> +
> +Fix this by adding the musl triplets.
> +Note: uclibc is purposedly not considered (unsupported in oe-core).
> +
> +Upstream-Status: Pending
> +Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> +
> +--- a/configure.ac 2018-12-13 14:44:55.414309610 +0100
> ++++ b/configure.ac 2018-12-13 13:22:37.546497547 +0100
> +@@ -831,14 +831,22 @@
> + or1k-linux-gnu
> + # elif defined(__powerpc__) && defined(__SPE__)
> + powerpc-linux-gnuspe
> ++# elif defined(__powerpc__) && !defined(__GLIBC__)
> ++ powerpc-linux-musl
> ++# elif defined(__powerpc__)
> ++ powerpc-linux-gnu
> ++# elif defined(__powerpc64__) && !defined(__GLIBC__)
> ++# if defined(__LITTLE_ENDIAN__)
> ++ powerpc64le-linux-musl
> ++# else
> ++ powerpc64-linux-musl
> ++# endif
> + # elif defined(__powerpc64__)
> + # if defined(__LITTLE_ENDIAN__)
> + powerpc64le-linux-gnu
> + # else
> + powerpc64-linux-gnu
> + # endif
> +-# elif defined(__powerpc__)
> +- powerpc-linux-gnu
> + # elif defined(__s390x__)
> + s390x-linux-gnu
> + # elif defined(__s390__)
> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
> b/meta/recipes-devtools/python/python3_3.5.6.bb
> index cd7991e7f8..2e8ae711d5 100644
> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> @@ -44,6 +44,7 @@ SRC_URI += "\
> file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-
> 2305.patch \
> file://run-ptest \
> "
> +SRC_URI_append_libc-musl = " file://powerpc-musl-triplets.patch"
>
> inherit multilib_header python3native update-alternatives qemu ptest
Do we need to make the patch application musl only? This tends to make
it more painful for recipe upgrading and we should only do that if the
patch would have an adverse affect on non-musl. Would also be good to
get tweaks like this submitted upstream...
Cheers,
Richard
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl
2018-12-13 16:26 ` Richard Purdie
@ 2018-12-13 16:49 ` Andrea Adami
2018-12-13 17:07 ` Serhey Popovych
0 siblings, 1 reply; 9+ messages in thread
From: Andrea Adami @ 2018-12-13 16:49 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
On Thu, Dec 13, 2018 at 5:26 PM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Thu, 2018-12-13 at 15:13 +0100, Andrea Adami wrote:
> > Add the missing triplets (not considering uclibc) for do_configure.
> >
> > Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> > ---
> > .../python3/powerpc-musl-triplets.patch | 43
> > +++++++++++++++++++
> > meta/recipes-devtools/python/python3_3.5.6.bb | 1 +
> > 2 files changed, 44 insertions(+)
> > create mode 100644 meta/recipes-devtools/python/python3/powerpc-
> > musl-triplets.patch
> >
> > diff --git a/meta/recipes-devtools/python/python3/powerpc-musl-
> > triplets.patch b/meta/recipes-devtools/python/python3/powerpc-musl-
> > triplets.patch
> > new file mode 100644
> > index 0000000000..477d049858
> > --- /dev/null
> > +++ b/meta/recipes-devtools/python/python3/powerpc-musl-
> > triplets.patch
> > @@ -0,0 +1,43 @@
> > +Using musl libc the task do_configure fails on powerpc*.
> > +
> > + checking build system type... x86_64-pc-linux-gnu
> > + checking host system type... powerpc-oe-linux-musl
> > + checking for python3.5... python3.5
> > + ...
> > + checking for the platform triplet based on compiler
> > characteristics...
> > + powerpc-linux-gnu
> > + configure: error: internal configure error for the platform
> > triplet
> > +
> > +Fix this by adding the musl triplets.
> > +Note: uclibc is purposedly not considered (unsupported in oe-core).
> > +
> > +Upstream-Status: Pending
> > +Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> > +
> > +--- a/configure.ac 2018-12-13 14:44:55.414309610 +0100
> > ++++ b/configure.ac 2018-12-13 13:22:37.546497547 +0100
> > +@@ -831,14 +831,22 @@
> > + or1k-linux-gnu
> > + # elif defined(__powerpc__) && defined(__SPE__)
> > + powerpc-linux-gnuspe
> > ++# elif defined(__powerpc__) && !defined(__GLIBC__)
> > ++ powerpc-linux-musl
> > ++# elif defined(__powerpc__)
> > ++ powerpc-linux-gnu
> > ++# elif defined(__powerpc64__) && !defined(__GLIBC__)
> > ++# if defined(__LITTLE_ENDIAN__)
> > ++ powerpc64le-linux-musl
> > ++# else
> > ++ powerpc64-linux-musl
> > ++# endif
> > + # elif defined(__powerpc64__)
> > + # if defined(__LITTLE_ENDIAN__)
> > + powerpc64le-linux-gnu
> > + # else
> > + powerpc64-linux-gnu
> > + # endif
> > +-# elif defined(__powerpc__)
> > +- powerpc-linux-gnu
> > + # elif defined(__s390x__)
> > + s390x-linux-gnu
> > + # elif defined(__s390__)
> > diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
> > b/meta/recipes-devtools/python/python3_3.5.6.bb
> > index cd7991e7f8..2e8ae711d5 100644
> > --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> > +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> > @@ -44,6 +44,7 @@ SRC_URI += "\
> > file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-
> > 2305.patch \
> > file://run-ptest \
> > "
> > +SRC_URI_append_libc-musl = " file://powerpc-musl-triplets.patch"
> >
> > inherit multilib_header python3native update-alternatives qemu ptest
>
> Do we need to make the patch application musl only? This tends to make
> it more painful for recipe upgrading and we should only do that if the
> patch would have an adverse affect on non-musl. Would also be good to
> get tweaks like this submitted upstream...
>
> Cheers,
>
> Richard
>
If you prefert I add it unconditionally.
This error with musl is not seen for other archs, I could not test the
ppc64 but imagined it would suffer as well.
Does your autobuilder succeed?
Cheers
Andrea
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl
2018-12-13 14:13 [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl Andrea Adami
2018-12-13 16:23 ` Burton, Ross
2018-12-13 16:26 ` Richard Purdie
@ 2018-12-13 17:01 ` Serhey Popovych
2018-12-14 3:13 ` Khem Raj
3 siblings, 0 replies; 9+ messages in thread
From: Serhey Popovych @ 2018-12-13 17:01 UTC (permalink / raw)
To: Andrea Adami, openembedded-core
[-- Attachment #1.1: Type: text/plain, Size: 3041 bytes --]
Andrea Adami wrote:
> Add the missing triplets (not considering uclibc) for do_configure.
>
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
> .../python3/powerpc-musl-triplets.patch | 43 +++++++++++++++++++
> meta/recipes-devtools/python/python3_3.5.6.bb | 1 +
> 2 files changed, 44 insertions(+)
> create mode 100644 meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
>
> diff --git a/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch b/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
> new file mode 100644
> index 0000000000..477d049858
> --- /dev/null
> +++ b/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
> @@ -0,0 +1,43 @@
> +Using musl libc the task do_configure fails on powerpc*.
> +
> + checking build system type... x86_64-pc-linux-gnu
> + checking host system type... powerpc-oe-linux-musl
> + checking for python3.5... python3.5
> + ...
> + checking for the platform triplet based on compiler characteristics...
> + powerpc-linux-gnu
> + configure: error: internal configure error for the platform triplet
> +
> +Fix this by adding the musl triplets.
> +Note: uclibc is purposedly not considered (unsupported in oe-core).
> +
> +Upstream-Status: Pending
> +Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> +
> +--- a/configure.ac 2018-12-13 14:44:55.414309610 +0100
> ++++ b/configure.ac 2018-12-13 13:22:37.546497547 +0100
> +@@ -831,14 +831,22 @@
> + or1k-linux-gnu
> + # elif defined(__powerpc__) && defined(__SPE__)
> + powerpc-linux-gnuspe
> ++# elif defined(__powerpc__) && !defined(__GLIBC__)
> ++ powerpc-linux-musl
> ++# elif defined(__powerpc__)
> ++ powerpc-linux-gnu
> ++# elif defined(__powerpc64__) && !defined(__GLIBC__)
> ++# if defined(__LITTLE_ENDIAN__)
> ++ powerpc64le-linux-musl
> ++# else
> ++ powerpc64-linux-musl
> ++# endif
> + # elif defined(__powerpc64__)
> + # if defined(__LITTLE_ENDIAN__)
> + powerpc64le-linux-gnu
> + # else
> + powerpc64-linux-gnu
> + # endif
> +-# elif defined(__powerpc__)
> +- powerpc-linux-gnu
> + # elif defined(__s390x__)
> + s390x-linux-gnu
> + # elif defined(__s390__)
> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb b/meta/recipes-devtools/python/python3_3.5.6.bb
> index cd7991e7f8..2e8ae711d5 100644
> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> @@ -44,6 +44,7 @@ SRC_URI += "\
> file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
> file://run-ptest \
> "
> +SRC_URI_append_libc-musl = " file://powerpc-musl-triplets.patch"
>
> inherit multilib_header python3native update-alternatives qemu ptest
>
>
Have you looked at approach implemented in commit cda0ef61d373
("python3: fix do_configure check platform triplet error")?
Maybe we should add same tweak for musl?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 501 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl
2018-12-13 16:49 ` Andrea Adami
@ 2018-12-13 17:07 ` Serhey Popovych
0 siblings, 0 replies; 9+ messages in thread
From: Serhey Popovych @ 2018-12-13 17:07 UTC (permalink / raw)
To: Andrea Adami, Richard Purdie
Cc: Patches and discussions about the oe-core layer
[-- Attachment #1.1: Type: text/plain, Size: 4043 bytes --]
Andrea Adami wrote:
> On Thu, Dec 13, 2018 at 5:26 PM Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
>>
>> On Thu, 2018-12-13 at 15:13 +0100, Andrea Adami wrote:
>>> Add the missing triplets (not considering uclibc) for do_configure.
>>>
>>> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
>>> ---
>>> .../python3/powerpc-musl-triplets.patch | 43
>>> +++++++++++++++++++
>>> meta/recipes-devtools/python/python3_3.5.6.bb | 1 +
>>> 2 files changed, 44 insertions(+)
>>> create mode 100644 meta/recipes-devtools/python/python3/powerpc-
>>> musl-triplets.patch
>>>
>>> diff --git a/meta/recipes-devtools/python/python3/powerpc-musl-
>>> triplets.patch b/meta/recipes-devtools/python/python3/powerpc-musl-
>>> triplets.patch
>>> new file mode 100644
>>> index 0000000000..477d049858
>>> --- /dev/null
>>> +++ b/meta/recipes-devtools/python/python3/powerpc-musl-
>>> triplets.patch
>>> @@ -0,0 +1,43 @@
>>> +Using musl libc the task do_configure fails on powerpc*.
>>> +
>>> + checking build system type... x86_64-pc-linux-gnu
>>> + checking host system type... powerpc-oe-linux-musl
>>> + checking for python3.5... python3.5
>>> + ...
>>> + checking for the platform triplet based on compiler
>>> characteristics...
>>> + powerpc-linux-gnu
>>> + configure: error: internal configure error for the platform
>>> triplet
>>> +
>>> +Fix this by adding the musl triplets.
>>> +Note: uclibc is purposedly not considered (unsupported in oe-core).
>>> +
>>> +Upstream-Status: Pending
>>> +Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
>>> +
>>> +--- a/configure.ac 2018-12-13 14:44:55.414309610 +0100
>>> ++++ b/configure.ac 2018-12-13 13:22:37.546497547 +0100
>>> +@@ -831,14 +831,22 @@
>>> + or1k-linux-gnu
>>> + # elif defined(__powerpc__) && defined(__SPE__)
>>> + powerpc-linux-gnuspe
>>> ++# elif defined(__powerpc__) && !defined(__GLIBC__)
>>> ++ powerpc-linux-musl
>>> ++# elif defined(__powerpc__)
>>> ++ powerpc-linux-gnu
>>> ++# elif defined(__powerpc64__) && !defined(__GLIBC__)
>>> ++# if defined(__LITTLE_ENDIAN__)
>>> ++ powerpc64le-linux-musl
>>> ++# else
>>> ++ powerpc64-linux-musl
>>> ++# endif
>>> + # elif defined(__powerpc64__)
>>> + # if defined(__LITTLE_ENDIAN__)
>>> + powerpc64le-linux-gnu
>>> + # else
>>> + powerpc64-linux-gnu
>>> + # endif
>>> +-# elif defined(__powerpc__)
>>> +- powerpc-linux-gnu
>>> + # elif defined(__s390x__)
>>> + s390x-linux-gnu
>>> + # elif defined(__s390__)
>>> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb
>>> b/meta/recipes-devtools/python/python3_3.5.6.bb
>>> index cd7991e7f8..2e8ae711d5 100644
>>> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
>>> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
>>> @@ -44,6 +44,7 @@ SRC_URI += "\
>>> file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-
>>> 2305.patch \
>>> file://run-ptest \
>>> "
>>> +SRC_URI_append_libc-musl = " file://powerpc-musl-triplets.patch"
>>>
>>> inherit multilib_header python3native update-alternatives qemu ptest
>>
>> Do we need to make the patch application musl only? This tends to make
>> it more painful for recipe upgrading and we should only do that if the
>> patch would have an adverse affect on non-musl. Would also be good to
>> get tweaks like this submitted upstream...
>>
>> Cheers,
>>
>> Richard
>>
>
> If you prefert I add it unconditionally.
> This error with musl is not seen for other archs, I could not test the
> ppc64 but imagined it would suffer as well.
I have tested on ppc64 fix based on commit cda0ef61d373
("python3: fix do_configure check platform triplet error") and it
works.
BTW on ppc64 we have much more problems with musl. Starting from ELFv2
ABI only support in musl and ending with broken LDSO pathes in final image.
>
> Does your autobuilder succeed?
>
> Cheers
> Andrea
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 501 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl
2018-12-13 14:13 [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl Andrea Adami
` (2 preceding siblings ...)
2018-12-13 17:01 ` Serhey Popovych
@ 2018-12-14 3:13 ` Khem Raj
2018-12-14 20:37 ` Andrea Adami
3 siblings, 1 reply; 9+ messages in thread
From: Khem Raj @ 2018-12-14 3:13 UTC (permalink / raw)
To: Andrea Adami; +Cc: Patches and discussions about the oe-core layer
Hi Andrea
Sigh, while I dont like what configury is doing here, we can probably
instead surgically check for
$CC --print-multiarch on ppc/musl
and then update the tweak-MULTIARCH-for-powerpc-linux-gnuspe.patch
patch to consider musl multiarch triplets. Maybe do it for ppc64 while here
but I will not hold you accountable for that.
On Thu, Dec 13, 2018 at 6:13 AM Andrea Adami <andrea.adami@gmail.com> wrote:
>
> Add the missing triplets (not considering uclibc) for do_configure.
>
> Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> ---
> .../python3/powerpc-musl-triplets.patch | 43 +++++++++++++++++++
> meta/recipes-devtools/python/python3_3.5.6.bb | 1 +
> 2 files changed, 44 insertions(+)
> create mode 100644 meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
>
> diff --git a/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch b/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
> new file mode 100644
> index 0000000000..477d049858
> --- /dev/null
> +++ b/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
> @@ -0,0 +1,43 @@
> +Using musl libc the task do_configure fails on powerpc*.
> +
> + checking build system type... x86_64-pc-linux-gnu
> + checking host system type... powerpc-oe-linux-musl
> + checking for python3.5... python3.5
> + ...
> + checking for the platform triplet based on compiler characteristics...
> + powerpc-linux-gnu
> + configure: error: internal configure error for the platform triplet
> +
> +Fix this by adding the musl triplets.
> +Note: uclibc is purposedly not considered (unsupported in oe-core).
> +
> +Upstream-Status: Pending
> +Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> +
> +--- a/configure.ac 2018-12-13 14:44:55.414309610 +0100
> ++++ b/configure.ac 2018-12-13 13:22:37.546497547 +0100
> +@@ -831,14 +831,22 @@
> + or1k-linux-gnu
> + # elif defined(__powerpc__) && defined(__SPE__)
> + powerpc-linux-gnuspe
> ++# elif defined(__powerpc__) && !defined(__GLIBC__)
> ++ powerpc-linux-musl
> ++# elif defined(__powerpc__)
> ++ powerpc-linux-gnu
> ++# elif defined(__powerpc64__) && !defined(__GLIBC__)
> ++# if defined(__LITTLE_ENDIAN__)
> ++ powerpc64le-linux-musl
> ++# else
> ++ powerpc64-linux-musl
> ++# endif
> + # elif defined(__powerpc64__)
> + # if defined(__LITTLE_ENDIAN__)
> + powerpc64le-linux-gnu
> + # else
> + powerpc64-linux-gnu
> + # endif
> +-# elif defined(__powerpc__)
> +- powerpc-linux-gnu
> + # elif defined(__s390x__)
> + s390x-linux-gnu
> + # elif defined(__s390__)
> diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb b/meta/recipes-devtools/python/python3_3.5.6.bb
> index cd7991e7f8..2e8ae711d5 100644
> --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> @@ -44,6 +44,7 @@ SRC_URI += "\
> file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
> file://run-ptest \
> "
> +SRC_URI_append_libc-musl = " file://powerpc-musl-triplets.patch"
>
> inherit multilib_header python3native update-alternatives qemu ptest
>
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl
2018-12-14 3:13 ` Khem Raj
@ 2018-12-14 20:37 ` Andrea Adami
0 siblings, 0 replies; 9+ messages in thread
From: Andrea Adami @ 2018-12-14 20:37 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
Hi,
the patch is now superseeded.
Serhey sent a new patch-serie containing the fix for powerpc/musl,
please review that.
Thanks!
Regards
Andrea
On Fri, Dec 14, 2018 at 4:13 AM Khem Raj <raj.khem@gmail.com> wrote:
>
> Hi Andrea
>
> Sigh, while I dont like what configury is doing here, we can probably
> instead surgically check for
>
> $CC --print-multiarch on ppc/musl
>
> and then update the tweak-MULTIARCH-for-powerpc-linux-gnuspe.patch
> patch to consider musl multiarch triplets. Maybe do it for ppc64 while here
> but I will not hold you accountable for that.
> On Thu, Dec 13, 2018 at 6:13 AM Andrea Adami <andrea.adami@gmail.com> wrote:
> >
> > Add the missing triplets (not considering uclibc) for do_configure.
> >
> > Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> > ---
> > .../python3/powerpc-musl-triplets.patch | 43 +++++++++++++++++++
> > meta/recipes-devtools/python/python3_3.5.6.bb | 1 +
> > 2 files changed, 44 insertions(+)
> > create mode 100644 meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
> >
> > diff --git a/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch b/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
> > new file mode 100644
> > index 0000000000..477d049858
> > --- /dev/null
> > +++ b/meta/recipes-devtools/python/python3/powerpc-musl-triplets.patch
> > @@ -0,0 +1,43 @@
> > +Using musl libc the task do_configure fails on powerpc*.
> > +
> > + checking build system type... x86_64-pc-linux-gnu
> > + checking host system type... powerpc-oe-linux-musl
> > + checking for python3.5... python3.5
> > + ...
> > + checking for the platform triplet based on compiler characteristics...
> > + powerpc-linux-gnu
> > + configure: error: internal configure error for the platform triplet
> > +
> > +Fix this by adding the musl triplets.
> > +Note: uclibc is purposedly not considered (unsupported in oe-core).
> > +
> > +Upstream-Status: Pending
> > +Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
> > +
> > +--- a/configure.ac 2018-12-13 14:44:55.414309610 +0100
> > ++++ b/configure.ac 2018-12-13 13:22:37.546497547 +0100
> > +@@ -831,14 +831,22 @@
> > + or1k-linux-gnu
> > + # elif defined(__powerpc__) && defined(__SPE__)
> > + powerpc-linux-gnuspe
> > ++# elif defined(__powerpc__) && !defined(__GLIBC__)
> > ++ powerpc-linux-musl
> > ++# elif defined(__powerpc__)
> > ++ powerpc-linux-gnu
> > ++# elif defined(__powerpc64__) && !defined(__GLIBC__)
> > ++# if defined(__LITTLE_ENDIAN__)
> > ++ powerpc64le-linux-musl
> > ++# else
> > ++ powerpc64-linux-musl
> > ++# endif
> > + # elif defined(__powerpc64__)
> > + # if defined(__LITTLE_ENDIAN__)
> > + powerpc64le-linux-gnu
> > + # else
> > + powerpc64-linux-gnu
> > + # endif
> > +-# elif defined(__powerpc__)
> > +- powerpc-linux-gnu
> > + # elif defined(__s390x__)
> > + s390x-linux-gnu
> > + # elif defined(__s390__)
> > diff --git a/meta/recipes-devtools/python/python3_3.5.6.bb b/meta/recipes-devtools/python/python3_3.5.6.bb
> > index cd7991e7f8..2e8ae711d5 100644
> > --- a/meta/recipes-devtools/python/python3_3.5.6.bb
> > +++ b/meta/recipes-devtools/python/python3_3.5.6.bb
> > @@ -44,6 +44,7 @@ SRC_URI += "\
> > file://0005-bpo-30714-ALPN-changes-for-OpenSSL-1.1.0f-2305.patch \
> > file://run-ptest \
> > "
> > +SRC_URI_append_libc-musl = " file://powerpc-musl-triplets.patch"
> >
> > inherit multilib_header python3native update-alternatives qemu ptest
> >
> > --
> > 2.17.1
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-12-14 20:37 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 14:13 [PATCH] python3: fix build for powerpc-linux.musl and powerpc64-linux-musl Andrea Adami
2018-12-13 16:23 ` Burton, Ross
2018-12-13 16:25 ` Burton, Ross
2018-12-13 16:26 ` Richard Purdie
2018-12-13 16:49 ` Andrea Adami
2018-12-13 17:07 ` Serhey Popovych
2018-12-13 17:01 ` Serhey Popovych
2018-12-14 3:13 ` Khem Raj
2018-12-14 20:37 ` Andrea Adami
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.