From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@fb.com>
Subject: Re: [PATCH 4/4] block: expose devt for GENHD_FL_HIDDEN disks
Date: Thu, 13 Dec 2018 15:32:18 +0100 [thread overview]
Message-ID: <20181213143218.GA8723@lst.de> (raw)
In-Reply-To: <b3ef062d-3bc3-fdf8-f395-31d1822a3192@suse.de>
On Thu, Dec 13, 2018 at 10:18:40AM +0100, Hannes Reinecke wrote:
> Welll ... this is not just 'lsblk', but more importantly this will force
> udev to create _block_ device nodes for the hidden devices, essentially
> 'unhide' them.
>
> Is this what we want?
> Christoph?
> I thought the entire _point_ of having hidden devices is that the are ...
> well ... hidden ...
Yes, that is why I really don't like the last two patches.
And I've checked back - lsblk actually works just fine at the moment.
But it turns out once we create the slave links it stops working,
which is a really good argument against the first two patches, which
would otherwise seem nice..
WARNING: multiple messages have this Message-ID (diff)
From: hch@lst.de (Christoph Hellwig)
Subject: [PATCH 4/4] block: expose devt for GENHD_FL_HIDDEN disks
Date: Thu, 13 Dec 2018 15:32:18 +0100 [thread overview]
Message-ID: <20181213143218.GA8723@lst.de> (raw)
In-Reply-To: <b3ef062d-3bc3-fdf8-f395-31d1822a3192@suse.de>
On Thu, Dec 13, 2018@10:18:40AM +0100, Hannes Reinecke wrote:
> Welll ... this is not just 'lsblk', but more importantly this will force
> udev to create _block_ device nodes for the hidden devices, essentially
> 'unhide' them.
>
> Is this what we want?
> Christoph?
> I thought the entire _point_ of having hidden devices is that the are ...
> well ... hidden ...
Yes, that is why I really don't like the last two patches.
And I've checked back - lsblk actually works just fine at the moment.
But it turns out once we create the slave links it stops working,
which is a really good argument against the first two patches, which
would otherwise seem nice..
next prev parent reply other threads:[~2018-12-13 14:32 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 16:48 [PATCH 0/4] nvme multipath: expose slaves/holders Thadeu Lima de Souza Cascardo
2018-12-06 16:48 ` Thadeu Lima de Souza Cascardo
2018-12-06 16:48 ` [PATCH 1/4] block: move holder tracking from struct block_device to hd_struct Thadeu Lima de Souza Cascardo
2018-12-06 16:48 ` Thadeu Lima de Souza Cascardo
2018-12-13 9:14 ` Hannes Reinecke
2018-12-13 9:14 ` Hannes Reinecke
2018-12-06 16:48 ` [PATCH 2/4] nvme: create slaves/holder entries for multipath devices Thadeu Lima de Souza Cascardo
2018-12-06 16:48 ` Thadeu Lima de Souza Cascardo
2018-12-13 9:15 ` Hannes Reinecke
2018-12-13 9:15 ` Hannes Reinecke
2018-12-06 16:48 ` [PATCH 3/4] nvme: Should not warn when a disk path is opened Thadeu Lima de Souza Cascardo
2018-12-06 16:48 ` Thadeu Lima de Souza Cascardo
2018-12-13 9:16 ` Hannes Reinecke
2018-12-13 9:16 ` Hannes Reinecke
2018-12-06 16:48 ` [PATCH 4/4] block: expose devt for GENHD_FL_HIDDEN disks Thadeu Lima de Souza Cascardo
2018-12-06 16:48 ` Thadeu Lima de Souza Cascardo
2018-12-06 20:22 ` Christoph Hellwig
2018-12-06 20:22 ` Christoph Hellwig
2018-12-12 8:32 ` Christoph Hellwig
2018-12-12 8:32 ` Christoph Hellwig
2018-12-12 12:39 ` Thadeu Lima de Souza Cascardo
2018-12-12 12:39 ` Thadeu Lima de Souza Cascardo
2018-12-13 9:18 ` Hannes Reinecke
2018-12-13 9:18 ` Hannes Reinecke
2018-12-13 11:41 ` Thadeu Lima de Souza Cascardo
2018-12-13 11:41 ` Thadeu Lima de Souza Cascardo
2018-12-13 12:19 ` Hannes Reinecke
2018-12-13 12:19 ` Hannes Reinecke
2018-12-13 16:08 ` Thadeu Lima de Souza Cascardo
2018-12-13 16:08 ` Thadeu Lima de Souza Cascardo
2018-12-13 14:32 ` Christoph Hellwig [this message]
2018-12-13 14:32 ` Christoph Hellwig
2018-12-13 15:25 ` Thadeu Lima de Souza Cascardo
2018-12-13 15:25 ` Thadeu Lima de Souza Cascardo
2018-12-13 20:20 ` Christoph Hellwig
2018-12-13 20:20 ` Christoph Hellwig
2018-12-13 21:00 ` Thadeu Lima de Souza Cascardo
2018-12-13 21:00 ` Thadeu Lima de Souza Cascardo
2018-12-14 7:47 ` Hannes Reinecke
2018-12-14 7:47 ` Hannes Reinecke
2018-12-14 8:56 ` Thadeu Lima de Souza Cascardo
2018-12-14 8:56 ` Thadeu Lima de Souza Cascardo
2018-12-14 9:06 ` Thadeu Lima de Souza Cascardo
2018-12-14 9:06 ` Thadeu Lima de Souza Cascardo
2018-12-14 9:54 ` Hannes Reinecke
2018-12-14 9:54 ` Hannes Reinecke
2018-12-14 10:18 ` Hannes Reinecke
2018-12-14 10:18 ` Hannes Reinecke
2018-12-14 11:09 ` Thadeu Lima de Souza Cascardo
2018-12-14 11:09 ` Thadeu Lima de Souza Cascardo
2018-12-14 9:44 ` Hannes Reinecke
2018-12-14 9:44 ` Hannes Reinecke
2018-12-13 9:33 ` [PATCH 0/4] nvme multipath: expose slaves/holders Johannes Thumshirn
2018-12-13 9:33 ` Johannes Thumshirn
2018-12-13 11:35 ` Thadeu Lima de Souza Cascardo
2018-12-13 11:35 ` Thadeu Lima de Souza Cascardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213143218.GA8723@lst.de \
--to=hch@lst.de \
--cc=axboe@fb.com \
--cc=cascardo@canonical.com \
--cc=hare@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.