Re: [PATCH v4] Input: i8042 add i8042_is_mr_coffee() helper to avoid refconut leak

From: kbuild test robot <lkp@intel.com>
To: Yangtao Li <tiny.windzz@gmail.com>
Cc: kbuild-all@01.org, dmitry.torokhov@gmail.com,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yangtao Li <tiny.windzz@gmail.com>
Subject: Re: [PATCH v4] Input: i8042 add i8042_is_mr_coffee() helper to avoid refconut leak
Date: Fri, 14 Dec 2018 10:27:00 +0800	[thread overview]
Message-ID: <201812141020.Gxl2fAJA%fengguang.wu@intel.com> (raw)
In-Reply-To: <20181212163548.23723-1-tiny.windzz@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1975 bytes --]

Hi Yangtao,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on input/next]
[also build test ERROR on v4.20-rc6 next-20181213]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Yangtao-Li/Input-i8042-add-i8042_is_mr_coffee-helper-to-avoid-refconut-leak/20181214-043211
base:   https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   In file included from drivers/input/serio/i8042.h:26:0,
                    from drivers/input/serio/i8042.c:132:
   drivers/input/serio/i8042-sparcio.h: In function 'i8042_is_mr_coffee':
>> drivers/input/serio/i8042-sparcio.h:115:2: error: 'is_mr_coffree' undeclared (first use in this function); did you mean 'is_mr_coffee'?
     is_mr_coffree = !strcmp(root->name, "SUNW,JavaStation-1");
     ^~~~~~~~~~~~~
     is_mr_coffee
   drivers/input/serio/i8042-sparcio.h:115:2: note: each undeclared identifier is reported only once for each function it appears in

vim +115 drivers/input/serio/i8042-sparcio.h

   108	
   109	static inline bool i8042_is_mr_coffee(void)
   110	{
   111		struct device_node *root;
   112		bool is_mr_coffee;
   113	
   114		root = of_find_node_by_path("/");
 > 115		is_mr_coffree = !strcmp(root->name, "SUNW,JavaStation-1");
   116		of_node_put(root);
   117	
   118		return is_mr_coffee;
   119	}
   120	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 53105 bytes --]