From: Maxime Ripard <maxime.ripard@bootlin.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] arm: sunxi: Add NULL pointer check
Date: Fri, 14 Dec 2018 11:49:26 +0100 [thread overview]
Message-ID: <20181214104926.li2kyz7i2tgcu5wc@flea> (raw)
In-Reply-To: <CAMty3ZD5WnGJURUHaoazPwYzJ0P0p4cLij1q47oyV0JuXtiAwA@mail.gmail.com>
On Fri, Dec 14, 2018 at 03:48:18PM +0530, Jagan Teki wrote:
> On Wed, Dec 5, 2018 at 5:58 PM Stefan Mavrodiev <stefan@olimex.com> wrote:
> >
> > Current driver doesn't check if the destination pointer is NULL.
> > This cause the data from the FIFO to be stored inside the internal
> > SDRAM ( address 0 ).
> >
> > The patch add simple check if the destination pointer is NULL.
> >
> > Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
> > ---
> > drivers/spi/sun4i_spi.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/spi/sun4i_spi.c b/drivers/spi/sun4i_spi.c
> > index b86b5a00ad..38cc743c61 100644
> > --- a/drivers/spi/sun4i_spi.c
> > +++ b/drivers/spi/sun4i_spi.c
> > @@ -129,7 +129,8 @@ static inline void sun4i_spi_drain_fifo(struct sun4i_spi_priv *priv, int len)
> >
> > while (len--) {
> > byte = readb(&priv->regs->rxdata);
> > - *priv->rx_buf++ = byte;
> > + if (priv->rx_buf)
> > + *priv->rx_buf++ = byte;
>
> Acked-by: Jagan Teki <jagan@openedev.com>
>
> But, have you tested how much data in the fifo before drained? It's
> better we can get the available data before reading via fifo_sta
This patch shouldn't be merged in its current state. Please look at
the on-going discussion.
Maxime
--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181214/fa60dfa5/attachment.sig>
next prev parent reply other threads:[~2018-12-14 10:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 12:27 [U-Boot] [PATCH 1/1] arm: sunxi: Add NULL pointer check Stefan Mavrodiev
2018-12-05 15:46 ` Maxime Ripard
2018-12-06 6:41 ` Stefan Mavrodiev
2018-12-13 7:12 ` Stefan Mavrodiev
2018-12-14 9:25 ` Maxime Ripard
2018-12-14 14:14 ` Stefan Mavrodiev
2018-12-14 15:55 ` Maxime Ripard
2018-12-17 6:37 ` Stefan Mavrodiev
2018-12-20 6:45 ` Stefan Mavrodiev
2018-12-16 11:16 ` André Przywara
2018-12-14 10:18 ` Jagan Teki
2018-12-14 10:49 ` Maxime Ripard [this message]
2018-12-14 12:09 ` Jagan Teki
2018-12-20 10:14 ` Jagan Teki
2018-12-20 10:29 ` Stefan Mavrodiev
2018-12-20 10:45 ` Jagan Teki
2018-12-20 10:48 ` Stefan Mavrodiev
2018-12-20 10:56 ` Jagan Teki
2018-12-20 11:19 ` Stefan Mavrodiev
2018-12-20 11:54 ` Jagan Teki
2018-12-20 12:07 ` Stefan Mavrodiev
2018-12-20 12:38 ` Jagan Teki
2018-12-20 12:41 ` Stefan Mavrodiev
2018-12-20 12:44 ` Jagan Teki
2018-12-20 12:46 ` Stefan Mavrodiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214104926.li2kyz7i2tgcu5wc@flea \
--to=maxime.ripard@bootlin.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.