* [PATCH] drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
@ 2018-12-14 18:06 clinton.a.taylor
2018-12-14 18:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: clinton.a.taylor @ 2018-12-14 18:06 UTC (permalink / raw)
To: Intel-gfx; +Cc: Jani Nikula
From: Clint Taylor <clinton.a.taylor@intel.com>
Program PORT_TX_DW7 to the value specified in the DDI Buffer section of the
BSPEC.
BSEPC: 21257
Cc: Madhav Chauhan <madhav.chauhan@intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Clint Taylor <clinton.a.taylor@intel.com>
---
drivers/gpu/drm/i915/icl_dsi.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/drivers/gpu/drm/i915/icl_dsi.c b/drivers/gpu/drm/i915/icl_dsi.c
index 4dd793b..f57aa0d 100644
--- a/drivers/gpu/drm/i915/icl_dsi.c
+++ b/drivers/gpu/drm/i915/icl_dsi.c
@@ -236,6 +236,16 @@ static void dsi_program_swing_and_deemphasis(struct intel_encoder *encoder)
tmp |= RCOMP_SCALAR(0x98);
I915_WRITE(ICL_PORT_TX_DW2_AUX(port), tmp);
+ tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
+ tmp &= ~(N_SCALAR_MASK);
+ tmp |= N_SCALAR(0x7f);
+ I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
+
+ tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
+ tmp &= ~(N_SCALAR_MASK);
+ tmp |= N_SCALAR(0x7f);
+ I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
+
tmp = I915_READ(ICL_PORT_TX_DW4_AUX(port));
tmp &= ~(POST_CURSOR_1_MASK | POST_CURSOR_2_MASK |
CURSOR_COEFF_MASK);
--
1.9.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
2018-12-14 18:06 [PATCH] drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence clinton.a.taylor
@ 2018-12-14 18:15 ` Patchwork
2018-12-14 19:34 ` Clint Taylor
2018-12-15 2:58 ` [PATCH] " kbuild test robot
2018-12-16 2:33 ` kbuild test robot
2 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2018-12-14 18:15 UTC (permalink / raw)
To: clinton.a.taylor; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
URL : https://patchwork.freedesktop.org/series/54069/
State : failure
== Summary ==
CALL scripts/checksyscalls.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] drivers/gpu/drm/i915/icl_dsi.o
In file included from drivers/gpu/drm/i915/intel_drv.h:33:0,
from drivers/gpu/drm/i915/intel_dsi.h:30,
from drivers/gpu/drm/i915/icl_dsi.c:30:
drivers/gpu/drm/i915/icl_dsi.c: In function ‘dsi_program_swing_and_deemphasis’:
drivers/gpu/drm/i915/icl_dsi.c:239:19: error: implicit declaration of function ‘ICL_PORT_TX_DW7_LN0’; did you mean ‘ICL_PORT_TX_DW4_LN0’? [-Werror=implicit-function-declaration]
tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
^
drivers/gpu/drm/i915/i915_drv.h:3438:70: note: in definition of macro ‘I915_READ’
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^~~
drivers/gpu/drm/i915/i915_drv.h:3438:69: error: incompatible type for argument 2 of ‘dev_priv->uncore.funcs.mmio_readl’
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro ‘I915_READ’
tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
^~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3438:69: note: expected ‘i915_reg_t {aka struct <anonymous>}’ but argument is of type ‘int’
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro ‘I915_READ’
tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
^~~~~~~~~
drivers/gpu/drm/i915/icl_dsi.c:242:14: error: implicit declaration of function ‘ICL_PORT_TX_DW7_GRP’; did you mean ‘ICL_PORT_TX_DW5_GRP’? [-Werror=implicit-function-declaration]
I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
^
drivers/gpu/drm/i915/i915_drv.h:3439:76: note: in definition of macro ‘I915_WRITE’
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^~~
drivers/gpu/drm/i915/i915_drv.h:3439:75: error: incompatible type for argument 2 of ‘dev_priv->uncore.funcs.mmio_writel’
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro ‘I915_WRITE’
I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
^~~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3439:75: note: expected ‘i915_reg_t {aka struct <anonymous>}’ but argument is of type ‘int’
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro ‘I915_WRITE’
I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
^~~~~~~~~~
drivers/gpu/drm/i915/icl_dsi.c:244:19: error: implicit declaration of function ‘ICL_PORT_TX_DW7_AUX’; did you mean ‘ICL_PORT_TX_DW2_AUX’? [-Werror=implicit-function-declaration]
tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
^
drivers/gpu/drm/i915/i915_drv.h:3438:70: note: in definition of macro ‘I915_READ’
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^~~
drivers/gpu/drm/i915/i915_drv.h:3438:69: error: incompatible type for argument 2 of ‘dev_priv->uncore.funcs.mmio_readl’
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro ‘I915_READ’
tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
^~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3438:69: note: expected ‘i915_reg_t {aka struct <anonymous>}’ but argument is of type ‘int’
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro ‘I915_READ’
tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
^~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3439:75: error: incompatible type for argument 2 of ‘dev_priv->uncore.funcs.mmio_writel’
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro ‘I915_WRITE’
I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
^~~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3439:75: note: expected ‘i915_reg_t {aka struct <anonymous>}’ but argument is of type ‘int’
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro ‘I915_WRITE’
I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
^~~~~~~~~~
cc1: all warnings being treated as errors
scripts/Makefile.build:291: recipe for target 'drivers/gpu/drm/i915/icl_dsi.o' failed
make[4]: *** [drivers/gpu/drm/i915/icl_dsi.o] Error 1
scripts/Makefile.build:516: recipe for target 'drivers/gpu/drm/i915' failed
make[3]: *** [drivers/gpu/drm/i915] Error 2
scripts/Makefile.build:516: recipe for target 'drivers/gpu/drm' failed
make[2]: *** [drivers/gpu/drm] Error 2
scripts/Makefile.build:516: recipe for target 'drivers/gpu' failed
make[1]: *** [drivers/gpu] Error 2
Makefile:1060: recipe for target 'drivers' failed
make: *** [drivers] Error 2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
2018-12-14 18:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-12-14 19:34 ` Clint Taylor
2018-12-14 22:15 ` Rodrigo Vivi
0 siblings, 1 reply; 6+ messages in thread
From: Clint Taylor @ 2018-12-14 19:34 UTC (permalink / raw)
To: intel-gfx
[-- Attachment #1.1: Type: text/plain, Size: 6576 bytes --]
Oops, failure caused by ICL_PORT_TX_DW7 not being defined yet. Still
waiting on r-b for a patch that includes the DW7 definition.
-Clint
On 12/14/18 10:15, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
> URL : https://patchwork.freedesktop.org/series/54069/
> State : failure
>
> == Summary ==
>
> CALL scripts/checksyscalls.sh
> DESCEND objtool
> CHK include/generated/compile.h
> CC [M] drivers/gpu/drm/i915/icl_dsi.o
> In file included from drivers/gpu/drm/i915/intel_drv.h:33:0,
> from drivers/gpu/drm/i915/intel_dsi.h:30,
> from drivers/gpu/drm/i915/icl_dsi.c:30:
> drivers/gpu/drm/i915/icl_dsi.c: In function ‘dsi_program_swing_and_deemphasis’:
> drivers/gpu/drm/i915/icl_dsi.c:239:19: error: implicit declaration of function ‘ICL_PORT_TX_DW7_LN0’; did you mean ‘ICL_PORT_TX_DW4_LN0’? [-Werror=implicit-function-declaration]
> tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
> ^
> drivers/gpu/drm/i915/i915_drv.h:3438:70: note: in definition of macro ‘I915_READ’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
> ^~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: error: incompatible type for argument 2 of ‘dev_priv->uncore.funcs.mmio_readl’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro ‘I915_READ’
> tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
> ^~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: note: expected ‘i915_reg_t {aka struct <anonymous>}’ but argument is of type ‘int’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro ‘I915_READ’
> tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
> ^~~~~~~~~
> drivers/gpu/drm/i915/icl_dsi.c:242:14: error: implicit declaration of function ‘ICL_PORT_TX_DW7_GRP’; did you mean ‘ICL_PORT_TX_DW5_GRP’? [-Werror=implicit-function-declaration]
> I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
> ^
> drivers/gpu/drm/i915/i915_drv.h:3439:76: note: in definition of macro ‘I915_WRITE’
> #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
> ^~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: error: incompatible type for argument 2 of ‘dev_priv->uncore.funcs.mmio_writel’
> #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro ‘I915_WRITE’
> I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
> ^~~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: note: expected ‘i915_reg_t {aka struct <anonymous>}’ but argument is of type ‘int’
> #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro ‘I915_WRITE’
> I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
> ^~~~~~~~~~
> drivers/gpu/drm/i915/icl_dsi.c:244:19: error: implicit declaration of function ‘ICL_PORT_TX_DW7_AUX’; did you mean ‘ICL_PORT_TX_DW2_AUX’? [-Werror=implicit-function-declaration]
> tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
> ^
> drivers/gpu/drm/i915/i915_drv.h:3438:70: note: in definition of macro ‘I915_READ’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
> ^~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: error: incompatible type for argument 2 of ‘dev_priv->uncore.funcs.mmio_readl’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro ‘I915_READ’
> tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
> ^~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: note: expected ‘i915_reg_t {aka struct <anonymous>}’ but argument is of type ‘int’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro ‘I915_READ’
> tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
> ^~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: error: incompatible type for argument 2 of ‘dev_priv->uncore.funcs.mmio_writel’
> #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro ‘I915_WRITE’
> I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
> ^~~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: note: expected ‘i915_reg_t {aka struct <anonymous>}’ but argument is of type ‘int’
> #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro ‘I915_WRITE’
> I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
> ^~~~~~~~~~
> cc1: all warnings being treated as errors
> scripts/Makefile.build:291: recipe for target 'drivers/gpu/drm/i915/icl_dsi.o' failed
> make[4]: *** [drivers/gpu/drm/i915/icl_dsi.o] Error 1
> scripts/Makefile.build:516: recipe for target 'drivers/gpu/drm/i915' failed
> make[3]: *** [drivers/gpu/drm/i915] Error 2
> scripts/Makefile.build:516: recipe for target 'drivers/gpu/drm' failed
> make[2]: *** [drivers/gpu/drm] Error 2
> scripts/Makefile.build:516: recipe for target 'drivers/gpu' failed
> make[1]: *** [drivers/gpu] Error 2
> Makefile:1060: recipe for target 'drivers' failed
> make: *** [drivers] Error 2
>
[-- Attachment #1.2: Type: text/html, Size: 7053 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ✗ Fi.CI.BAT: failure for drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
2018-12-14 19:34 ` Clint Taylor
@ 2018-12-14 22:15 ` Rodrigo Vivi
0 siblings, 0 replies; 6+ messages in thread
From: Rodrigo Vivi @ 2018-12-14 22:15 UTC (permalink / raw)
To: Clint Taylor; +Cc: intel-gfx
On Fri, Dec 14, 2018 at 11:34:13AM -0800, Clint Taylor wrote:
> Oops, failure caused by ICL_PORT_TX_DW7 not being defined yet. Still
> waiting on r-b for a patch that includes the DW7 definition.
I believe it is easier to re-send both patches together. Specially
because apparently one justifies the other... Just preserve the authorship
and add your sign-off on the other patch and send as a series.
Thanks,
Rodrigo.
>
> -Clint
>
> On 12/14/18 10:15, Patchwork wrote:
>
> == Series Details ==
>
> Series: drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
> URL : [1]https://patchwork.freedesktop.org/series/54069/
> State : failure
>
> == Summary ==
>
> CALL scripts/checksyscalls.sh
> DESCEND objtool
> CHK include/generated/compile.h
> CC [M] drivers/gpu/drm/i915/icl_dsi.o
> In file included from drivers/gpu/drm/i915/intel_drv.h:33:0,
> from drivers/gpu/drm/i915/intel_dsi.h:30,
> from drivers/gpu/drm/i915/icl_dsi.c:30:
> drivers/gpu/drm/i915/icl_dsi.c: In function ‘dsi_program_swing_and_deemphasis’:
> drivers/gpu/drm/i915/icl_dsi.c:239:19: error: implicit declaration of function ‘
> ICL_PORT_TX_DW7_LN0’; did you mean ‘ICL_PORT_TX_DW4_LN0’? [-Werror=implicit-func
> tion-declaration]
> tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
> ^
> drivers/gpu/drm/i915/i915_drv.h:3438:70: note: in definition of macro ‘I915_READ
> ’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
> ^~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: error: incompatible type for argument 2
> of ‘dev_priv->uncore.funcs.mmio_readl’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
> ^
> drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro ‘I915_READ’
> tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
> ^~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: note: expected ‘i915_reg_t {aka struct
> <anonymous>}’ but argument is of type ‘int’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
> ^
> drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro ‘I915_READ’
> tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
> ^~~~~~~~~
> drivers/gpu/drm/i915/icl_dsi.c:242:14: error: implicit declaration of function ‘
> ICL_PORT_TX_DW7_GRP’; did you mean ‘ICL_PORT_TX_DW5_GRP’? [-Werror=implicit-func
> tion-declaration]
> I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
> ^
> drivers/gpu/drm/i915/i915_drv.h:3439:76: note: in definition of macro ‘I915_WRIT
> E’
> #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg)
> , (val), true)
> ^~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: error: incompatible type for argument 2
> of ‘dev_priv->uncore.funcs.mmio_writel’
> #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg)
> , (val), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro ‘I915_WRITE’
> I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
> ^~~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: note: expected ‘i915_reg_t {aka struct
> <anonymous>}’ but argument is of type ‘int’
> #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg)
> , (val), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro ‘I915_WRITE’
> I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
> ^~~~~~~~~~
> drivers/gpu/drm/i915/icl_dsi.c:244:19: error: implicit declaration of function ‘
> ICL_PORT_TX_DW7_AUX’; did you mean ‘ICL_PORT_TX_DW2_AUX’? [-Werror=implicit-func
> tion-declaration]
> tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
> ^
> drivers/gpu/drm/i915/i915_drv.h:3438:70: note: in definition of macro ‘I915_READ
> ’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
> ^~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: error: incompatible type for argument 2
> of ‘dev_priv->uncore.funcs.mmio_readl’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
> ^
> drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro ‘I915_READ’
> tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
> ^~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3438:69: note: expected ‘i915_reg_t {aka struct
> <anonymous>}’ but argument is of type ‘int’
> #define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true
> )
> ^
> drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro ‘I915_READ’
> tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
> ^~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: error: incompatible type for argument 2
> of ‘dev_priv->uncore.funcs.mmio_writel’
> #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg)
> , (val), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro ‘I915_WRITE’
> I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
> ^~~~~~~~~~
> drivers/gpu/drm/i915/i915_drv.h:3439:75: note: expected ‘i915_reg_t {aka struct
> <anonymous>}’ but argument is of type ‘int’
> #define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg)
> , (val), true)
> ^
> drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro ‘I915_WRITE’
> I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
> ^~~~~~~~~~
> cc1: all warnings being treated as errors
> scripts/Makefile.build:291: recipe for target 'drivers/gpu/drm/i915/icl_dsi.o' f
> ailed
> make[4]: *** [drivers/gpu/drm/i915/icl_dsi.o] Error 1
> scripts/Makefile.build:516: recipe for target 'drivers/gpu/drm/i915' failed
> make[3]: *** [drivers/gpu/drm/i915] Error 2
> scripts/Makefile.build:516: recipe for target 'drivers/gpu/drm' failed
> make[2]: *** [drivers/gpu/drm] Error 2
> scripts/Makefile.build:516: recipe for target 'drivers/gpu' failed
> make[1]: *** [drivers/gpu] Error 2
> Makefile:1060: recipe for target 'drivers' failed
> make: *** [drivers] Error 2
>
> References
>
> 1. https://patchwork.freedesktop.org/series/54069/
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
2018-12-14 18:06 [PATCH] drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence clinton.a.taylor
2018-12-14 18:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-12-15 2:58 ` kbuild test robot
2018-12-16 2:33 ` kbuild test robot
2 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2018-12-15 2:58 UTC (permalink / raw)
To: clinton.a.taylor; +Cc: Jani Nikula, Intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 9231 bytes --]
Hi Clint,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20181214]
[cannot apply to v4.20-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/clinton-a-taylor-intel-com/drm-i915-dsi-Add-PORT_TX_DW7-programming-to-DSI-vswing-sequence/20181215-101421
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x013-201849 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/intel_drv.h:33:0,
from drivers/gpu/drm/i915/intel_dsi.h:30,
from drivers/gpu/drm/i915/icl_dsi.c:30:
drivers/gpu/drm/i915/icl_dsi.c: In function 'dsi_program_swing_and_deemphasis':
>> drivers/gpu/drm/i915/icl_dsi.c:239:19: error: implicit declaration of function 'ICL_PORT_TX_DW7_LN0'; did you mean 'ICL_PORT_TX_DW4_LN0'? [-Werror=implicit-function-declaration]
tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
^
drivers/gpu/drm/i915/i915_drv.h:3452:70: note: in definition of macro 'I915_READ'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^~~
>> drivers/gpu/drm/i915/i915_drv.h:3452:69: error: incompatible type for argument 2 of 'dev_priv->uncore.funcs.mmio_readl'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
>> drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro 'I915_READ'
tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
^~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3452:69: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'int'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
>> drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro 'I915_READ'
tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
^~~~~~~~~
>> drivers/gpu/drm/i915/icl_dsi.c:242:14: error: implicit declaration of function 'ICL_PORT_TX_DW7_GRP'; did you mean 'ICL_PORT_TX_DW5_GRP'? [-Werror=implicit-function-declaration]
I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
^
drivers/gpu/drm/i915/i915_drv.h:3453:76: note: in definition of macro 'I915_WRITE'
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^~~
>> drivers/gpu/drm/i915/i915_drv.h:3453:75: error: incompatible type for argument 2 of 'dev_priv->uncore.funcs.mmio_writel'
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
>> drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro 'I915_WRITE'
I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
^~~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3453:75: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'int'
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
>> drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro 'I915_WRITE'
I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
^~~~~~~~~~
>> drivers/gpu/drm/i915/icl_dsi.c:244:19: error: implicit declaration of function 'ICL_PORT_TX_DW7_AUX'; did you mean 'ICL_PORT_TX_DW2_AUX'? [-Werror=implicit-function-declaration]
tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
^
drivers/gpu/drm/i915/i915_drv.h:3452:70: note: in definition of macro 'I915_READ'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^~~
>> drivers/gpu/drm/i915/i915_drv.h:3452:69: error: incompatible type for argument 2 of 'dev_priv->uncore.funcs.mmio_readl'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro 'I915_READ'
tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
^~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3452:69: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'int'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro 'I915_READ'
tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
^~~~~~~~~
>> drivers/gpu/drm/i915/i915_drv.h:3453:75: error: incompatible type for argument 2 of 'dev_priv->uncore.funcs.mmio_writel'
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro 'I915_WRITE'
I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
^~~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3453:75: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'int'
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro 'I915_WRITE'
I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
^~~~~~~~~~
cc1: some warnings being treated as errors
vim +239 drivers/gpu/drm/i915/icl_dsi.c
194
195 static void dsi_program_swing_and_deemphasis(struct intel_encoder *encoder)
196 {
197 struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
198 struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
199 enum port port;
200 u32 tmp;
201 int lane;
202
203 for_each_dsi_port(port, intel_dsi->ports) {
204
205 /*
206 * Program voltage swing and pre-emphasis level values as per
207 * table in BSPEC under DDI buffer programing
208 */
209 tmp = I915_READ(ICL_PORT_TX_DW5_LN0(port));
210 tmp &= ~(SCALING_MODE_SEL_MASK | RTERM_SELECT_MASK);
211 tmp |= SCALING_MODE_SEL(0x2);
212 tmp |= TAP2_DISABLE | TAP3_DISABLE;
213 tmp |= RTERM_SELECT(0x6);
214 I915_WRITE(ICL_PORT_TX_DW5_GRP(port), tmp);
215
216 tmp = I915_READ(ICL_PORT_TX_DW5_AUX(port));
217 tmp &= ~(SCALING_MODE_SEL_MASK | RTERM_SELECT_MASK);
218 tmp |= SCALING_MODE_SEL(0x2);
219 tmp |= TAP2_DISABLE | TAP3_DISABLE;
220 tmp |= RTERM_SELECT(0x6);
221 I915_WRITE(ICL_PORT_TX_DW5_AUX(port), tmp);
222
223 tmp = I915_READ(ICL_PORT_TX_DW2_LN0(port));
224 tmp &= ~(SWING_SEL_LOWER_MASK | SWING_SEL_UPPER_MASK |
225 RCOMP_SCALAR_MASK);
226 tmp |= SWING_SEL_UPPER(0x2);
227 tmp |= SWING_SEL_LOWER(0x2);
228 tmp |= RCOMP_SCALAR(0x98);
229 I915_WRITE(ICL_PORT_TX_DW2_GRP(port), tmp);
230
231 tmp = I915_READ(ICL_PORT_TX_DW2_AUX(port));
232 tmp &= ~(SWING_SEL_LOWER_MASK | SWING_SEL_UPPER_MASK |
233 RCOMP_SCALAR_MASK);
234 tmp |= SWING_SEL_UPPER(0x2);
235 tmp |= SWING_SEL_LOWER(0x2);
236 tmp |= RCOMP_SCALAR(0x98);
237 I915_WRITE(ICL_PORT_TX_DW2_AUX(port), tmp);
238
> 239 tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
240 tmp &= ~(N_SCALAR_MASK);
241 tmp |= N_SCALAR(0x7f);
> 242 I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
243
> 244 tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
245 tmp &= ~(N_SCALAR_MASK);
246 tmp |= N_SCALAR(0x7f);
247 I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
248
249 tmp = I915_READ(ICL_PORT_TX_DW4_AUX(port));
250 tmp &= ~(POST_CURSOR_1_MASK | POST_CURSOR_2_MASK |
251 CURSOR_COEFF_MASK);
252 tmp |= POST_CURSOR_1(0x0);
253 tmp |= POST_CURSOR_2(0x0);
254 tmp |= CURSOR_COEFF(0x3f);
255 I915_WRITE(ICL_PORT_TX_DW4_AUX(port), tmp);
256
257 for (lane = 0; lane <= 3; lane++) {
258 /* Bspec: must not use GRP register for write */
259 tmp = I915_READ(ICL_PORT_TX_DW4_LN(port, lane));
260 tmp &= ~(POST_CURSOR_1_MASK | POST_CURSOR_2_MASK |
261 CURSOR_COEFF_MASK);
262 tmp |= POST_CURSOR_1(0x0);
263 tmp |= POST_CURSOR_2(0x0);
264 tmp |= CURSOR_COEFF(0x3f);
265 I915_WRITE(ICL_PORT_TX_DW4_LN(port, lane), tmp);
266 }
267 }
268 }
269
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30243 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence
2018-12-14 18:06 [PATCH] drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence clinton.a.taylor
2018-12-14 18:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-12-15 2:58 ` [PATCH] " kbuild test robot
@ 2018-12-16 2:33 ` kbuild test robot
2 siblings, 0 replies; 6+ messages in thread
From: kbuild test robot @ 2018-12-16 2:33 UTC (permalink / raw)
To: clinton.a.taylor; +Cc: Jani Nikula, Intel-gfx, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 9213 bytes --]
Hi Clint,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on next-20181214]
[cannot apply to v4.20-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/clinton-a-taylor-intel-com/drm-i915-dsi-Add-PORT_TX_DW7-programming-to-DSI-vswing-sequence/20181215-101421
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
In file included from drivers/gpu/drm/i915/intel_drv.h:33:0,
from drivers/gpu/drm/i915/intel_dsi.h:30,
from drivers/gpu/drm/i915/icl_dsi.c:30:
drivers/gpu/drm/i915/icl_dsi.c: In function 'dsi_program_swing_and_deemphasis':
drivers/gpu/drm/i915/icl_dsi.c:239:19: error: implicit declaration of function 'ICL_PORT_TX_DW7_LN0'; did you mean 'ICL_PORT_TX_DW4_LN0'? [-Werror=implicit-function-declaration]
tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
^
drivers/gpu/drm/i915/i915_drv.h:3452:70: note: in definition of macro 'I915_READ'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^~~
drivers/gpu/drm/i915/i915_drv.h:3452:69: error: incompatible type for argument 2 of 'dev_priv->uncore.funcs.mmio_readl'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro 'I915_READ'
tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
^~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3452:69: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'int'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
drivers/gpu/drm/i915/icl_dsi.c:239:9: note: in expansion of macro 'I915_READ'
tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
^~~~~~~~~
>> drivers/gpu/drm/i915/icl_dsi.c:242:14: error: implicit declaration of function 'ICL_PORT_TX_DW7_GRP'; did you mean 'ICL_PORT_TX_DW4_GRP'? [-Werror=implicit-function-declaration]
I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
^
drivers/gpu/drm/i915/i915_drv.h:3453:76: note: in definition of macro 'I915_WRITE'
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^~~
drivers/gpu/drm/i915/i915_drv.h:3453:75: error: incompatible type for argument 2 of 'dev_priv->uncore.funcs.mmio_writel'
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro 'I915_WRITE'
I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
^~~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3453:75: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'int'
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
drivers/gpu/drm/i915/icl_dsi.c:242:3: note: in expansion of macro 'I915_WRITE'
I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
^~~~~~~~~~
drivers/gpu/drm/i915/icl_dsi.c:244:19: error: implicit declaration of function 'ICL_PORT_TX_DW7_AUX'; did you mean 'ICL_PORT_TX_DW2_AUX'? [-Werror=implicit-function-declaration]
tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
^
drivers/gpu/drm/i915/i915_drv.h:3452:70: note: in definition of macro 'I915_READ'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^~~
drivers/gpu/drm/i915/i915_drv.h:3452:69: error: incompatible type for argument 2 of 'dev_priv->uncore.funcs.mmio_readl'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro 'I915_READ'
tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
^~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3452:69: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'int'
#define I915_READ(reg) dev_priv->uncore.funcs.mmio_readl(dev_priv, (reg), true)
^
drivers/gpu/drm/i915/icl_dsi.c:244:9: note: in expansion of macro 'I915_READ'
tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
^~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3453:75: error: incompatible type for argument 2 of 'dev_priv->uncore.funcs.mmio_writel'
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro 'I915_WRITE'
I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
^~~~~~~~~~
drivers/gpu/drm/i915/i915_drv.h:3453:75: note: expected 'i915_reg_t {aka struct <anonymous>}' but argument is of type 'int'
#define I915_WRITE(reg, val) dev_priv->uncore.funcs.mmio_writel(dev_priv, (reg), (val), true)
^
drivers/gpu/drm/i915/icl_dsi.c:247:3: note: in expansion of macro 'I915_WRITE'
I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
^~~~~~~~~~
cc1: some warnings being treated as errors
vim +242 drivers/gpu/drm/i915/icl_dsi.c
194
195 static void dsi_program_swing_and_deemphasis(struct intel_encoder *encoder)
196 {
197 struct drm_i915_private *dev_priv = to_i915(encoder->base.dev);
198 struct intel_dsi *intel_dsi = enc_to_intel_dsi(&encoder->base);
199 enum port port;
200 u32 tmp;
201 int lane;
202
203 for_each_dsi_port(port, intel_dsi->ports) {
204
205 /*
206 * Program voltage swing and pre-emphasis level values as per
207 * table in BSPEC under DDI buffer programing
208 */
209 tmp = I915_READ(ICL_PORT_TX_DW5_LN0(port));
210 tmp &= ~(SCALING_MODE_SEL_MASK | RTERM_SELECT_MASK);
211 tmp |= SCALING_MODE_SEL(0x2);
212 tmp |= TAP2_DISABLE | TAP3_DISABLE;
213 tmp |= RTERM_SELECT(0x6);
214 I915_WRITE(ICL_PORT_TX_DW5_GRP(port), tmp);
215
216 tmp = I915_READ(ICL_PORT_TX_DW5_AUX(port));
217 tmp &= ~(SCALING_MODE_SEL_MASK | RTERM_SELECT_MASK);
218 tmp |= SCALING_MODE_SEL(0x2);
219 tmp |= TAP2_DISABLE | TAP3_DISABLE;
220 tmp |= RTERM_SELECT(0x6);
221 I915_WRITE(ICL_PORT_TX_DW5_AUX(port), tmp);
222
223 tmp = I915_READ(ICL_PORT_TX_DW2_LN0(port));
224 tmp &= ~(SWING_SEL_LOWER_MASK | SWING_SEL_UPPER_MASK |
225 RCOMP_SCALAR_MASK);
226 tmp |= SWING_SEL_UPPER(0x2);
227 tmp |= SWING_SEL_LOWER(0x2);
228 tmp |= RCOMP_SCALAR(0x98);
229 I915_WRITE(ICL_PORT_TX_DW2_GRP(port), tmp);
230
231 tmp = I915_READ(ICL_PORT_TX_DW2_AUX(port));
232 tmp &= ~(SWING_SEL_LOWER_MASK | SWING_SEL_UPPER_MASK |
233 RCOMP_SCALAR_MASK);
234 tmp |= SWING_SEL_UPPER(0x2);
235 tmp |= SWING_SEL_LOWER(0x2);
236 tmp |= RCOMP_SCALAR(0x98);
237 I915_WRITE(ICL_PORT_TX_DW2_AUX(port), tmp);
238
> 239 tmp = I915_READ(ICL_PORT_TX_DW7_LN0(port));
240 tmp &= ~(N_SCALAR_MASK);
241 tmp |= N_SCALAR(0x7f);
> 242 I915_WRITE(ICL_PORT_TX_DW7_GRP(port), tmp);
243
244 tmp = I915_READ(ICL_PORT_TX_DW7_AUX(port));
245 tmp &= ~(N_SCALAR_MASK);
246 tmp |= N_SCALAR(0x7f);
247 I915_WRITE(ICL_PORT_TX_DW7_AUX(port), tmp);
248
249 tmp = I915_READ(ICL_PORT_TX_DW4_AUX(port));
250 tmp &= ~(POST_CURSOR_1_MASK | POST_CURSOR_2_MASK |
251 CURSOR_COEFF_MASK);
252 tmp |= POST_CURSOR_1(0x0);
253 tmp |= POST_CURSOR_2(0x0);
254 tmp |= CURSOR_COEFF(0x3f);
255 I915_WRITE(ICL_PORT_TX_DW4_AUX(port), tmp);
256
257 for (lane = 0; lane <= 3; lane++) {
258 /* Bspec: must not use GRP register for write */
259 tmp = I915_READ(ICL_PORT_TX_DW4_LN(port, lane));
260 tmp &= ~(POST_CURSOR_1_MASK | POST_CURSOR_2_MASK |
261 CURSOR_COEFF_MASK);
262 tmp |= POST_CURSOR_1(0x0);
263 tmp |= POST_CURSOR_2(0x0);
264 tmp |= CURSOR_COEFF(0x3f);
265 I915_WRITE(ICL_PORT_TX_DW4_LN(port, lane), tmp);
266 }
267 }
268 }
269
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 66660 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-12-16 2:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-14 18:06 [PATCH] drm/i915/dsi: Add PORT_TX_DW7 programming to DSI vswing sequence clinton.a.taylor
2018-12-14 18:15 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-12-14 19:34 ` Clint Taylor
2018-12-14 22:15 ` Rodrigo Vivi
2018-12-15 2:58 ` [PATCH] " kbuild test robot
2018-12-16 2:33 ` kbuild test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.