All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] Makefile: output migration warnings to stderr
@ 2018-12-14 22:35 Chris Packham
  2018-12-17 12:16 ` [U-Boot] " Tom Rini
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Packham @ 2018-12-14 22:35 UTC (permalink / raw)
  To: u-boot

Output the device model migration warnings to stderr. This allows tools
like buildman to pick them up rather than suppressing them along with
the normal build output on stdout.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
One odd behaviour is that when a board has multiple warnings the
header/trailer lines (==...) don't appear when run under buildman. I
assume there is some de-duplication going on.

 Makefile | 58 ++++++++++++++++++++++++++++----------------------------
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/Makefile b/Makefile
index 5683714947f2..032dba5427c2 100644
--- a/Makefile
+++ b/Makefile
@@ -913,47 +913,47 @@ cmd_cfgcheck = $(srctree)/scripts/check-config.sh $2 \
 
 all:		$(ALL-y) cfg
 ifeq ($(CONFIG_DM_I2C_COMPAT)$(CONFIG_SANDBOX),y)
-	@echo "===================== WARNING ======================"
-	@echo "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
-	@echo "(possibly in a subsequent patch in your series)"
-	@echo "before sending patches to the mailing list."
-	@echo "===================================================="
+	@echo >&2 "===================== WARNING ======================"
+	@echo >&2 "This board uses CONFIG_DM_I2C_COMPAT. Please remove"
+	@echo >&2 "(possibly in a subsequent patch in your series)"
+	@echo >&2 "before sending patches to the mailing list."
+	@echo >&2 "===================================================="
 endif
 ifeq ($(CONFIG_MMC),y)
 ifneq ($(CONFIG_DM_MMC)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
-	@echo "===================== WARNING ======================"
-	@echo "This board does not use CONFIG_DM_MMC. Please update"
-	@echo "the board to use CONFIG_DM_MMC before the v2019.04 release."
-	@echo "Failure to update by the deadline may result in board removal."
-	@echo "See doc/driver-model/MIGRATION.txt for more info."
-	@echo "===================================================="
+	@echo >&2 "===================== WARNING ======================"
+	@echo >&2 "This board does not use CONFIG_DM_MMC. Please update"
+	@echo >&2 "the board to use CONFIG_DM_MMC before the v2019.04 release."
+	@echo >&2 "Failure to update by the deadline may result in board removal."
+	@echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
+	@echo >&2 "===================================================="
 endif
 endif
 ifeq ($(CONFIG_USB),y)
 ifneq ($(CONFIG_DM_USB)$(CONFIG_OF_CONTROL)$(CONFIG_BLK),yyy)
-	@echo "===================== WARNING ======================"
-	@echo "This board does not use CONFIG_DM_USB. Please update"
-	@echo "the board to use CONFIG_DM_USB before the v2019.07 release."
-	@echo "Failure to update by the deadline may result in board removal."
-	@echo "See doc/driver-model/MIGRATION.txt for more info."
-	@echo "===================================================="
+	@echo >&2 "===================== WARNING ======================"
+	@echo >&2 "This board does not use CONFIG_DM_USB. Please update"
+	@echo >&2 "the board to use CONFIG_DM_USB before the v2019.07 release."
+	@echo >&2 "Failure to update by the deadline may result in board removal."
+	@echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
+	@echo >&2 "===================================================="
 endif
 endif
 ifeq ($(CONFIG_LIBATA)$(CONFIG_DM_SCSI)$(CONFIG_MVSATA_IDE),y)
-	@echo "===================== WARNING ======================"
-	@echo "This board does not use CONFIG_DM_SCSI. Please update"
-	@echo "the storage controller to use CONFIG_DM_SCSI before the v2019.07 release."
-	@echo "Failure to update by the deadline may result in board removal."
-	@echo "See doc/driver-model/MIGRATION.txt for more info."
-	@echo "===================================================="
+	@echo >&2 "===================== WARNING ======================"
+	@echo >&2 "This board does not use CONFIG_DM_SCSI. Please update"
+	@echo >&2 "the storage controller to use CONFIG_DM_SCSI before the v2019.07 release."
+	@echo >&2 "Failure to update by the deadline may result in board removal."
+	@echo >&2 "See doc/driver-model/MIGRATION.txt for more info."
+	@echo >&2 "===================================================="
 endif
 ifeq ($(CONFIG_OF_EMBED),y)
-	@echo "===================== WARNING ======================"
-	@echo "CONFIG_OF_EMBED is enabled. This option should only"
-	@echo "be used for debugging purposes. Please use"
-	@echo "CONFIG_OF_SEPARATE for boards in mainline."
-	@echo "See doc/README.fdt-control for more info."
-	@echo "===================================================="
+	@echo >&2 "===================== WARNING ======================"
+	@echo >&2 "CONFIG_OF_EMBED is enabled. This option should only"
+	@echo >&2 "be used for debugging purposes. Please use"
+	@echo >&2 "CONFIG_OF_SEPARATE for boards in mainline."
+	@echo >&2 "See doc/README.fdt-control for more info."
+	@echo >&2 "===================================================="
 endif
 	@# Check that this build does not use CONFIG options that we do not
 	@# know about unless they are in Kconfig. All the existing CONFIG
-- 
2.19.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] Makefile: output migration warnings to stderr
  2018-12-14 22:35 [U-Boot] [PATCH] Makefile: output migration warnings to stderr Chris Packham
@ 2018-12-17 12:16 ` Tom Rini
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2018-12-17 12:16 UTC (permalink / raw)
  To: u-boot

On Sat, Dec 15, 2018 at 11:35:54AM +1300, Chris Packham wrote:

> Output the device model migration warnings to stderr. This allows tools
> like buildman to pick them up rather than suppressing them along with
> the normal build output on stdout.
> 
> Signed-off-by: Chris Packham <judge.packham@gmail.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181217/5b064457/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-17 12:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-14 22:35 [U-Boot] [PATCH] Makefile: output migration warnings to stderr Chris Packham
2018-12-17 12:16 ` [U-Boot] " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.