All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] mmc: Fix partition table init regression
Date: Mon, 17 Dec 2018 10:05:43 +0000	[thread overview]
Message-ID: <20181217100545.28369-1-andre.przywara@arm.com> (raw)

Commit d0851c893706 ("blk: Call part_init() in the post_probe() method")
in the 2019.01-rc1 merge window moved the partition init call to the
generic DM layer, leaving every non-DM driver behind. As the result all
Allwinner boards now don't read the partition table automatically
anymore:
=> fatls mmc 0
** Unrecognized filesystem type **
=> fatload mmc 0 $kernel_addr_r Image-4.20-rc3
** Unrecognized filesystem type **

A quick workaround is to explicitly read the partition table, but this is
still a regression, as it breaks existing scripts and workflows:
==========
=> mmc part

Partition Map for MMC device 0  --   Partition Type: DOS

Part    Start Sector    Num Sectors     UUID            Type
  1     8192            30873600        00000000-01     0c
=> fatls mmc 0
   852304   xen
 23544320   Image-4.20-rc3

2 file(s), 0 dir(s)
==========

These two patches are the minimal version to fix this problem, by bringing
the implicit part_init() call back just for non-DM MMC drivers.
Patch 1 is needed to keep the H6 SPL below the size limit.

The whole SPL_LIBDISK_SUPPORT symbol is now somewhat obsolete and needs
some proper fixing, but this needs more discussion and testing and
is probably nothing for this release still.

Thanks,
Andre.

Andre Przywara (2):
  sunxi: drop default SPL_LIBDISK_SUPPORT enablement
  mmc: bring back partition init for non-DM MMC drivers

 arch/arm/Kconfig  | 1 -
 drivers/mmc/mmc.c | 4 ++++
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
2.14.5

             reply	other threads:[~2018-12-17 10:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 10:05 Andre Przywara [this message]
2018-12-17 10:05 ` [U-Boot] [PATCH 1/2] sunxi: drop default SPL_LIBDISK_SUPPORT enablement Andre Przywara
2019-01-05  1:56   ` Simon Glass
2019-01-10  2:30   ` [U-Boot] [U-Boot, " Tom Rini
2018-12-17 10:05 ` [U-Boot] [PATCH 2/2] mmc: bring back partition init for non-DM MMC drivers Andre Przywara
2019-01-05  1:56   ` Simon Glass
2019-01-05 17:31     ` Soeren Moch
2019-01-05 22:22       ` Petr Štetiar
2019-01-09  3:44   ` [U-Boot] [U-Boot, " Tom Rini
2019-01-09  9:03     ` André Przywara
2019-01-09 12:11       ` Tom Rini
2019-01-10  2:30   ` Tom Rini
2018-12-17 10:12 ` [U-Boot] [PATCH 0/2] mmc: Fix partition table init regression Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217100545.28369-1-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.