All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] mmc: bring back partition init for non-DM MMC drivers
Date: Mon, 17 Dec 2018 10:05:45 +0000	[thread overview]
Message-ID: <20181217100545.28369-3-andre.przywara@arm.com> (raw)
In-Reply-To: <20181217100545.28369-1-andre.przywara@arm.com>

Commit d0851c893706 ("blk: Call part_init() in the post_probe() method")
removed the call to part_init() in mmc.c, as this is done by the DM_MMC
framework.
However Allwinner is (still) relying on a non-DM MMC driver, so we are
now missing the implicit partition init, leading to failing MMC accesses
due to the missing partition information.

Bring the call back just for non-DM MMC driver to fix this regression.

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
---
 drivers/mmc/mmc.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c
index f5c821e308..d858127132 100644
--- a/drivers/mmc/mmc.c
+++ b/drivers/mmc/mmc.c
@@ -2449,6 +2449,10 @@ static int mmc_startup(struct mmc *mmc)
 	bdesc->revision[0] = 0;
 #endif
 
+#if !defined(CONFIG_DM_MMC) && (!defined(CONFIG_SPL_BUILD) || defined(CONFIG_SPL_LIBDISK_SUPPORT))
+	part_init(bdesc);
+#endif
+
 	return 0;
 }
 
-- 
2.14.5

  parent reply	other threads:[~2018-12-17 10:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 10:05 [U-Boot] [PATCH 0/2] mmc: Fix partition table init regression Andre Przywara
2018-12-17 10:05 ` [U-Boot] [PATCH 1/2] sunxi: drop default SPL_LIBDISK_SUPPORT enablement Andre Przywara
2019-01-05  1:56   ` Simon Glass
2019-01-10  2:30   ` [U-Boot] [U-Boot, " Tom Rini
2018-12-17 10:05 ` Andre Przywara [this message]
2019-01-05  1:56   ` [U-Boot] [PATCH 2/2] mmc: bring back partition init for non-DM MMC drivers Simon Glass
2019-01-05 17:31     ` Soeren Moch
2019-01-05 22:22       ` Petr Štetiar
2019-01-09  3:44   ` [U-Boot] [U-Boot, " Tom Rini
2019-01-09  9:03     ` André Przywara
2019-01-09 12:11       ` Tom Rini
2019-01-10  2:30   ` Tom Rini
2018-12-17 10:12 ` [U-Boot] [PATCH 0/2] mmc: Fix partition table init regression Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217100545.28369-3-andre.przywara@arm.com \
    --to=andre.przywara@arm.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.