From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
linux-kernel@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH 6/7] sctp: Convert to genradix
Date: Mon, 17 Dec 2018 18:59:12 -0200 [thread overview]
Message-ID: <20181217205912.GA9487@localhost.localdomain> (raw)
In-Reply-To: <20181217125001.8e89ac2565417d55ef7a624e@linux-foundation.org>
On Mon, Dec 17, 2018 at 12:50:01PM -0800, Andrew Morton wrote:
> On Mon, 17 Dec 2018 08:19:28 -0500 Kent Overstreet <kent.overstreet@gmail.com> wrote:
>
> > @@ -535,9 +470,6 @@ int sctp_send_add_streams(struct sctp_association *asoc,
> > goto out;
> > }
> >
> > - stream->incnt = incnt;
> > - stream->outcnt = outcnt;
> > -
> > asoc->strreset_outstanding = !!out + !!in;
> >
>
> I'm seeing a reject here for some reason. Using todays's linux-next,
> but there are no changes against net/sctp/stream.c in -next. The
> assignment to stream->incnt has disappeared. I did this:
>
> @@ -535,8 +470,6 @@ int sctp_send_add_streams(struct sctp_as
> goto out;
> }
>
> - stream->outcnt = outcnt;
> -
> asoc->strreset_outstanding = !!out + !!in;
>
> out:
That's because of
e1e46479847e ("sctp: not increase stream's incnt before sending addstrm_in request")
https://www.mail-archive.com/netdev@vger.kernel.org/msg255306.html
and what you did is the right merge fix for this.
>
>
> We're at 4.20-rc7 and this series is rather large. I'll merge them all
> to see what happens, but I don't think it's 4.21-rc1 material?
Would be nice to be conservative here. It's the first time this change
is being proposed for SCTP stack and testing was probably very
limited.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
linux-kernel@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH 6/7] sctp: Convert to genradix
Date: Mon, 17 Dec 2018 20:59:12 +0000 [thread overview]
Message-ID: <20181217205912.GA9487@localhost.localdomain> (raw)
In-Reply-To: <20181217125001.8e89ac2565417d55ef7a624e@linux-foundation.org>
On Mon, Dec 17, 2018 at 12:50:01PM -0800, Andrew Morton wrote:
> On Mon, 17 Dec 2018 08:19:28 -0500 Kent Overstreet <kent.overstreet@gmail.com> wrote:
>
> > @@ -535,9 +470,6 @@ int sctp_send_add_streams(struct sctp_association *asoc,
> > goto out;
> > }
> >
> > - stream->incnt = incnt;
> > - stream->outcnt = outcnt;
> > -
> > asoc->strreset_outstanding = !!out + !!in;
> >
>
> I'm seeing a reject here for some reason. Using todays's linux-next,
> but there are no changes against net/sctp/stream.c in -next. The
> assignment to stream->incnt has disappeared. I did this:
>
> @@ -535,8 +470,6 @@ int sctp_send_add_streams(struct sctp_as
> goto out;
> }
>
> - stream->outcnt = outcnt;
> -
> asoc->strreset_outstanding = !!out + !!in;
>
> out:
That's because of
e1e46479847e ("sctp: not increase stream's incnt before sending addstrm_in request")
https://www.mail-archive.com/netdev@vger.kernel.org/msg255306.html
and what you did is the right merge fix for this.
>
>
> We're at 4.20-rc7 and this series is rather large. I'll merge them all
> to see what happens, but I don't think it's 4.21-rc1 material?
Would be nice to be conservative here. It's the first time this change
is being proposed for SCTP stack and testing was probably very
limited.
next prev parent reply other threads:[~2018-12-17 20:59 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 13:19 [PATCH 0/7] generic radix trees; drop flex arrays Kent Overstreet
2018-12-17 13:19 ` [PATCH 1/7] openvswitch: convert to kvmalloc Kent Overstreet
2018-12-17 13:19 ` [PATCH 2/7] md: " Kent Overstreet
2018-12-17 13:19 ` [PATCH 3/7] selinux: " Kent Overstreet
2018-12-17 13:44 ` Fwd: " Stephen Smalley
2018-12-18 7:44 ` peter enderborg
2018-12-17 13:19 ` [PATCH 4/7] Generic radix trees Kent Overstreet
2018-12-17 13:19 ` [PATCH 5/7] proc: commit to genradix Kent Overstreet
2018-12-17 13:19 ` [PATCH 6/7] sctp: Convert " Kent Overstreet
2018-12-17 13:19 ` Kent Overstreet
2018-12-17 20:50 ` Andrew Morton
2018-12-17 20:50 ` Andrew Morton
2018-12-17 20:59 ` Marcelo Ricardo Leitner [this message]
2018-12-17 20:59 ` Marcelo Ricardo Leitner
2018-12-17 21:00 ` Kent Overstreet
2018-12-17 21:00 ` Kent Overstreet
2019-01-15 14:29 ` Marcelo Ricardo Leitner
2019-01-15 14:29 ` Marcelo Ricardo Leitner
2019-01-18 13:10 ` Neil Horman
2019-01-18 13:10 ` Neil Horman
2019-01-18 13:35 ` Marcelo Ricardo Leitner
2019-01-18 13:35 ` Marcelo Ricardo Leitner
2019-01-18 14:51 ` Neil Horman
2019-01-18 14:51 ` Neil Horman
2018-12-17 13:19 ` [PATCH 7/7] Drop flex_arrays Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217205912.GA9487@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.