[Qemu-devel] [PATCH v2 00/12] MAINTAINERS: Add various missing entries

[Qemu-devel] [PATCH v2 00/12] MAINTAINERS: Add various missing entries

[Philippe Mathieu-Daudé]

Hi,

This cleanup effort is inspired by Markus "Full list of unmaintained files"
from the "MAINTAINERS leaves too many files uncovered" thread:
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04270.html

v1: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04994.html

Regards,

Phil.

Philippe Mathieu-Daudé (12):
  MAINTAINERS: Add missing entries to the X86 section (AMD SEV)
  MAINTAINERS: Add missing entries for the sun4u machines
  MAINTAINERS: Add missing entries for the PC machines
  MAINTAINERS: Add missing entries to VFIO and NVMe
  MAINTAINERS: Add missing entries for the QObject section
  MAINTAINERS: Add missing test entries to the Cryptography section
  MAINTAINERS: Add an entry for the Dino machine
  MAINTAINERS: Add maintainers to the Linux subsystem
  MAINTAINERS: Add maintainer to the POSIX subsystem
  MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem
  MAINTAINERS: Orphanize the 'GDB stub' subsystem
  MAINTAINERS: Add maintainer to the TCG/i386 subsystem

 MAINTAINERS | 55 ++++++++++++++++++++++++++++++++++++++++++-----------
 1 file changed, 44 insertions(+), 11 deletions(-)

-- 
2.17.2

[Qemu-devel] [PATCH v2 01/12] MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Moved from TCG to KVM section
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 83c127f0d6..771b1c7b94 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -392,7 +392,9 @@ M: Marcelo Tosatti <mtosatti@redhat.com>
 L: kvm@vger.kernel.org
 S: Supported
 F: target/i386/kvm.c
+F: include/sysemu/sev.h
 F: scripts/kvm/vmxcap
+F: docs/amd-memory-encryption.txt
 
 Guest CPU Cores (Xen):
 ----------------------
-- 
2.17.2

[Qemu-devel] [PATCH v2 02/12] MAINTAINERS: Add missing entries for the sun4u machines

[Philippe Mathieu-Daudé]

Reviewed-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Added simba
---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 771b1c7b94..dac394d125 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1056,9 +1056,13 @@ Sun4u
 M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
 S: Maintained
 F: hw/sparc64/sun4u.c
-F: pc-bios/openbios-sparc64
+F: hw/sparc64/sun4u_iommu.c
+F: include/hw/sparc/sun4u_iommu.h
 F: hw/pci-host/sabre.c
 F: include/hw/pci-host/sabre.h
+F: hw/pci-bridge/simba.c
+F: include/hw/pci-bridge/simba.h
+F: pc-bios/openbios-sparc64
 
 Sun4v
 M: Artyom Tarasenko <atar4qemu@gmail.com>
-- 
2.17.2

[Qemu-devel] [PATCH v2 03/12] MAINTAINERS: Add missing entries for the PC machines

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index dac394d125..f3305a65b6 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1141,6 +1141,10 @@ F: hw/acpi/ich9.c
 F: include/hw/acpi/ich9.h
 F: include/hw/acpi/piix4.h
 F: hw/misc/sga.c
+F: hw/isa/apm.c
+F: include/hw/isa/apm.h
+F: tests/test-x86-cpuid.c
+F: tests/test-x86-cpuid-compat.c
 
 PC Chipset
 M: Michael S. Tsirkin <mst@redhat.com>
-- 
2.17.2

[Qemu-devel] [PATCH v2 04/12] MAINTAINERS: Add missing entries to VFIO and NVMe

[Philippe Mathieu-Daudé]

The VFIO helpers are used by the NVMe block driver, add the
entries to both sections.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: add util/vfio-helpers.c, add entries to NVMe section
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f3305a65b6..7a94b0dab3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1365,7 +1365,10 @@ VFIO
 M: Alex Williamson <alex.williamson@redhat.com>
 S: Supported
 F: hw/vfio/*
+F: util/vfio-helpers.c
 F: include/hw/vfio/
+F: include/qemu/vfio-helpers.h
+F: docs/igd-assign.txt
 
 vfio-ccw
 M: Cornelia Huck <cohuck@redhat.com>
@@ -2290,6 +2293,8 @@ M: Fam Zheng <fam@euphon.net>
 L: qemu-block@nongnu.org
 S: Supported
 F: block/nvme*
+F: util/vfio-helpers.c
+F: include/qemu/vfio-helpers.h
 
 Bootdevice
 M: Gonglei <arei.gonglei@huawei.com>
-- 
2.17.2

[Qemu-devel] [PATCH v2 05/12] MAINTAINERS: Add missing entries for the QObject section

[Philippe Mathieu-Daudé]

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: Removed qdist
---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 7a94b0dab3..a381882c27 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1900,10 +1900,14 @@ F: include/qapi/qmp/
 X: include/qapi/qmp/dispatch.h
 F: scripts/coccinelle/qobject.cocci
 F: tests/check-qdict.c
-F: tests/check-qnum.c
 F: tests/check-qjson.c
 F: tests/check-qlist.c
+F: tests/check-qlit.c
+F: tests/check-qnull.c
+F: tests/check-qnum.c
+F: tests/check-qobject.c
 F: tests/check-qstring.c
+F: qdict-test-data.txt
 T: git https://repo.or.cz/qemu/armbru.git qapi-next
 
 QEMU Guest Agent
-- 
2.17.2

[Qemu-devel] [PATCH v2 06/12] MAINTAINERS: Add missing test entries to the Cryptography section

[Philippe Mathieu-Daudé]

Acked-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index a381882c27..bdf3534478 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2028,6 +2028,8 @@ F: crypto/
 F: include/crypto/
 F: tests/test-crypto-*
 F: tests/benchmark-crypto-*
+F: tests/crypto-tls-*
+F: tests/pkix_asn1_tab.c
 F: qemu.sasl
 
 Coroutines
-- 
2.17.2

[Qemu-devel] [PATCH v2 07/12] MAINTAINERS: Add an entry for the Dino machine

[Philippe Mathieu-Daudé]

Add Richard as maintainer, and Helge as reviewer.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
v2: downgrade to 'Odd fixes', add Helge
---
 MAINTAINERS | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index bdf3534478..f0fb2c74d7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -912,6 +912,16 @@ F: hw/mips/boston.c
 F: hw/pci-host/xilinx-pcie.c
 F: include/hw/pci-host/xilinx-pcie.h
 
+HP-PARISC Machines
+------------------
+
+Dino
+M: Richard Henderson <rth@twiddle.net>
+R: Helge Deller <deller@gmx.de>
+S: Odd Fixes
+F: hw/hppa/
+F: pc-bios/hppa-firmware.img
+
 OpenRISC Machines
 -----------------
 or1k-sim
-- 
2.17.2

[Qemu-devel] [PATCH v2 08/12] MAINTAINERS: Add maintainers to the Linux subsystem

[Philippe Mathieu-Daudé]

Add Michael, Cornelia and Paolo as maintainers of the Linux subsystem.

Remove the qemu-devel@nongnu.org entry because the list is always
selected by the 'All patches CC here' section.

Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index f0fb2c74d7..5f39fa4b80 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -420,9 +420,10 @@ Hosts:
 ------
 
 LINUX
-L: qemu-devel@nongnu.org
+M: Michael S. Tsirkin <mst@redhat.com>
+M: Cornelia Huck <cohuck@redhat.com>
+M: Paolo Bonzini <pbonzini@redhat.com>
 S: Maintained
-F: linux-*
 F: linux-headers/
 
 POSIX
-- 
2.17.2

[Qemu-devel] [PATCH v2 09/12] MAINTAINERS: Add maintainer to the POSIX subsystem

[Philippe Mathieu-Daudé]

Add Paolo as maintainer of the POSIX subsystem.

Remove the qemu-devel@nongnu.org entry because the list is always
selected by the 'All patches CC here' section.

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 5f39fa4b80..e50f8c6b97 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -427,9 +427,12 @@ S: Maintained
 F: linux-headers/
 
 POSIX
-L: qemu-devel@nongnu.org
+M: Paolo Bonzini <pbonzini@redhat.com>
 S: Maintained
-F: *posix*
+F: os-posix.c
+F: include/sysemu/os-posix.h
+F: util/*posix*.c
+F: include/qemu/*posix*.h
 
 NETBSD
 L: qemu-devel@nongnu.org
-- 
2.17.2

[Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Philippe Mathieu-Daudé]

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the qemu-devel@nongnu.org entry because the list is always
selected by the 'All patches CC here' section.

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e50f8c6b97..e6a73820f1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1745,8 +1745,7 @@ S: Supported
 F: scripts/coverity-model.c
 
 CPU
-L: qemu-devel@nongnu.org
-S: Supported
+S: Orphan
 F: qom/cpu.c
 F: include/qom/cpu.h
 
-- 
2.17.2

[Qemu-devel] [PATCH v2 11/12] MAINTAINERS: Orphanize the 'GDB stub' subsystem

[Philippe Mathieu-Daudé]

Nobody is looking at those files, downgrade this subsystem as orphan.

Remove the qemu-devel@nongnu.org entry because the list is always
selected by the 'All patches CC here' section.

Suggested-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
Luc: interested in stepping in? :)
---
 MAINTAINERS | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e6a73820f1..49f8f2fa37 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1776,8 +1776,7 @@ F: util/error.c
 F: util/qemu-error.c
 
 GDB stub
-L: qemu-devel@nongnu.org
-S: Odd Fixes
+S: Orphan
 F: gdbstub*
 F: gdb-xml/
 
-- 
2.17.2

[Qemu-devel] [PATCH v2 12/12] MAINTAINERS: Add maintainer to the TCG/i386 subsystem

[Philippe Mathieu-Daudé]

Richard obviously maintains this subdirectory, make this official :)

Remove the qemu-devel@nongnu.org entry because the list is always
selected by the 'All patches CC here' section.

Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 49f8f2fa37..a879ddfc53 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2175,7 +2175,7 @@ F: tcg/arm/
 F: disas/arm.c
 
 i386 target
-L: qemu-devel@nongnu.org
+M: Richard Henderson <rth@twiddle.net>
 S: Maintained
 F: tcg/i386/
 F: disas/i386.c
-- 
2.17.2

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Paolo Bonzini]

On 18/12/18 12:56, Philippe Mathieu-Daudé wrote:
> Nobody is looking at those files, downgrade this subsystem as orphan.
> 
> Remove the qemu-devel@nongnu.org entry because the list is always
> selected by the 'All patches CC here' section.
> 
> Suggested-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e50f8c6b97..e6a73820f1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1745,8 +1745,7 @@ S: Supported
>  F: scripts/coverity-model.c
>  
>  CPU
> -L: qemu-devel@nongnu.org
> -S: Supported
> +S: Orphan
>  F: qom/cpu.c
>  F: include/qom/cpu.h
>  
> 

I don't think that's accurate.  Simply there's not much going on.  If
patches are sent, get-maintainers's git fallback will do something
(probably sending the patch to Eduardo, Igor or me).

Paolo

Re: [Qemu-devel] [PATCH v2 03/12] MAINTAINERS: Add missing entries for the PC machines

[Michael S. Tsirkin]

On Tue, Dec 18, 2018 at 12:56:06PM +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
>  MAINTAINERS | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index dac394d125..f3305a65b6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1141,6 +1141,10 @@ F: hw/acpi/ich9.c
>  F: include/hw/acpi/ich9.h
>  F: include/hw/acpi/piix4.h
>  F: hw/misc/sga.c
> +F: hw/isa/apm.c
> +F: include/hw/isa/apm.h
> +F: tests/test-x86-cpuid.c
> +F: tests/test-x86-cpuid-compat.c
>  
>  PC Chipset
>  M: Michael S. Tsirkin <mst@redhat.com>
> -- 
> 2.17.2

Re: [Qemu-devel] [PATCH v2 08/12] MAINTAINERS: Add maintainers to the Linux subsystem

[Cornelia Huck]

On Tue, 18 Dec 2018 12:56:11 +0100
Philippe Mathieu-Daudé <philmd@redhat.com> wrote:

> Add Michael, Cornelia and Paolo as maintainers of the Linux subsystem.
> 
> Remove the qemu-devel@nongnu.org entry because the list is always
> selected by the 'All patches CC here' section.
> 
> Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
>  MAINTAINERS | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f0fb2c74d7..5f39fa4b80 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -420,9 +420,10 @@ Hosts:
>  ------
>  
>  LINUX
> -L: qemu-devel@nongnu.org
> +M: Michael S. Tsirkin <mst@redhat.com>
> +M: Cornelia Huck <cohuck@redhat.com>
> +M: Paolo Bonzini <pbonzini@redhat.com>
>  S: Maintained
> -F: linux-*
>  F: linux-headers/
>  
>  POSIX

As this now basically an entry for linux-headers, should this now also
include the headers update script?

Acked-by: Cornelia Huck <cohuck@redhat.com>

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Eduardo Habkost]

On Tue, Dec 18, 2018 at 01:34:52PM +0100, Paolo Bonzini wrote:
> On 18/12/18 12:56, Philippe Mathieu-Daudé wrote:
> > Nobody is looking at those files, downgrade this subsystem as orphan.
> > 
> > Remove the qemu-devel@nongnu.org entry because the list is always
> > selected by the 'All patches CC here' section.
> > 
> > Suggested-by: Markus Armbruster <armbru@redhat.com>
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> >  MAINTAINERS | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e50f8c6b97..e6a73820f1 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1745,8 +1745,7 @@ S: Supported
> >  F: scripts/coverity-model.c
> >  
> >  CPU
> > -L: qemu-devel@nongnu.org
> > -S: Supported
> > +S: Orphan
> >  F: qom/cpu.c
> >  F: include/qom/cpu.h
> >  
> > 
> 
> I don't think that's accurate.  Simply there's not much going on.  If
> patches are sent, get-maintainers's git fallback will do something
> (probably sending the patch to Eduardo, Igor or me).

Should we add our names to that section, or is it OK to leave it
as "S: Supported" even if it doesn't have any official
maintainers?

-- 
Eduardo

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Philippe Mathieu-Daudé]

Hi Paolo, Eduardo,

On 12/18/18 4:22 PM, Eduardo Habkost wrote:
> On Tue, Dec 18, 2018 at 01:34:52PM +0100, Paolo Bonzini wrote:
>> On 18/12/18 12:56, Philippe Mathieu-Daudé wrote:
>>> Nobody is looking at those files, downgrade this subsystem as orphan.
>>>
>>> Remove the qemu-devel@nongnu.org entry because the list is always
>>> selected by the 'All patches CC here' section.
>>>
>>> Suggested-by: Markus Armbruster <armbru@redhat.com>
>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> ---
>>>  MAINTAINERS | 3 +--
>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index e50f8c6b97..e6a73820f1 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1745,8 +1745,7 @@ S: Supported
>>>  F: scripts/coverity-model.c
>>>  
>>>  CPU
>>> -L: qemu-devel@nongnu.org
>>> -S: Supported
>>> +S: Orphan
>>>  F: qom/cpu.c
>>>  F: include/qom/cpu.h
>>>  
>>>
>>
>> I don't think that's accurate.  Simply there's not much going on.  If
>> patches are sent, get-maintainers's git fallback will do something
>> (probably sending the patch to Eduardo, Igor or me).

I followed Markus suggestion from
https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:

  If we take the definition of S: in MAINTAINERS seriously,
  we need to appoint a maintainer (a person, not a mailing list),
  or downgrade to S: Orphan.

> 
> Should we add our names to that section, or is it OK to leave it
> as "S: Supported" even if it doesn't have any official
> maintainers?

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Thomas Huth]

On 2018-12-18 16:31, Philippe Mathieu-Daudé wrote:
> Hi Paolo, Eduardo,
> 
> On 12/18/18 4:22 PM, Eduardo Habkost wrote:
>> On Tue, Dec 18, 2018 at 01:34:52PM +0100, Paolo Bonzini wrote:
>>> On 18/12/18 12:56, Philippe Mathieu-Daudé wrote:
>>>> Nobody is looking at those files, downgrade this subsystem as orphan.
>>>>
>>>> Remove the qemu-devel@nongnu.org entry because the list is always
>>>> selected by the 'All patches CC here' section.
>>>>
>>>> Suggested-by: Markus Armbruster <armbru@redhat.com>
>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>> ---
>>>>  MAINTAINERS | 3 +--
>>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index e50f8c6b97..e6a73820f1 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -1745,8 +1745,7 @@ S: Supported
>>>>  F: scripts/coverity-model.c
>>>>  
>>>>  CPU
>>>> -L: qemu-devel@nongnu.org
>>>> -S: Supported
>>>> +S: Orphan
>>>>  F: qom/cpu.c
>>>>  F: include/qom/cpu.h
>>>>  
>>>>
>>>
>>> I don't think that's accurate.  Simply there's not much going on.  If
>>> patches are sent, get-maintainers's git fallback will do something
>>> (probably sending the patch to Eduardo, Igor or me).
> 
> I followed Markus suggestion from
> https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:
> 
>   If we take the definition of S: in MAINTAINERS seriously,
>   we need to appoint a maintainer (a person, not a mailing list),
>   or downgrade to S: Orphan.

I agree with Markus and Philippe. Having "S: Supported" but no names
available is just confusing. So either put a maintainer name in here, or
downgrade to "Orphan".

 Thomas

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Eduardo Habkost]

On Tue, Dec 18, 2018 at 04:44:25PM +0100, Thomas Huth wrote:
> On 2018-12-18 16:31, Philippe Mathieu-Daudé wrote:
> > Hi Paolo, Eduardo,
> > 
> > On 12/18/18 4:22 PM, Eduardo Habkost wrote:
> >> On Tue, Dec 18, 2018 at 01:34:52PM +0100, Paolo Bonzini wrote:
> >>> On 18/12/18 12:56, Philippe Mathieu-Daudé wrote:
> >>>> Nobody is looking at those files, downgrade this subsystem as orphan.
> >>>>
> >>>> Remove the qemu-devel@nongnu.org entry because the list is always
> >>>> selected by the 'All patches CC here' section.
> >>>>
> >>>> Suggested-by: Markus Armbruster <armbru@redhat.com>
> >>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> >>>> ---
> >>>>  MAINTAINERS | 3 +--
> >>>>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>>>
> >>>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>>> index e50f8c6b97..e6a73820f1 100644
> >>>> --- a/MAINTAINERS
> >>>> +++ b/MAINTAINERS
> >>>> @@ -1745,8 +1745,7 @@ S: Supported
> >>>>  F: scripts/coverity-model.c
> >>>>  
> >>>>  CPU
> >>>> -L: qemu-devel@nongnu.org
> >>>> -S: Supported
> >>>> +S: Orphan
> >>>>  F: qom/cpu.c
> >>>>  F: include/qom/cpu.h
> >>>>  
> >>>>
> >>>
> >>> I don't think that's accurate.  Simply there's not much going on.  If
> >>> patches are sent, get-maintainers's git fallback will do something
> >>> (probably sending the patch to Eduardo, Igor or me).
> > 
> > I followed Markus suggestion from
> > https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:
> > 
> >   If we take the definition of S: in MAINTAINERS seriously,
> >   we need to appoint a maintainer (a person, not a mailing list),
> >   or downgrade to S: Orphan.
> 
> I agree with Markus and Philippe. Having "S: Supported" but no names
> available is just confusing. So either put a maintainer name in here, or
> downgrade to "Orphan".

I volunteer to maintain it, but I don't want to be the only
maintainer.  Any other volunteer?

-- 
Eduardo

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Paolo Bonzini]

On 18/12/18 16:57, Eduardo Habkost wrote:
> On Tue, Dec 18, 2018 at 04:44:25PM +0100, Thomas Huth wrote:
>> On 2018-12-18 16:31, Philippe Mathieu-Daudé wrote:
>>> Hi Paolo, Eduardo,
>>>
>>> On 12/18/18 4:22 PM, Eduardo Habkost wrote:
>>>> On Tue, Dec 18, 2018 at 01:34:52PM +0100, Paolo Bonzini wrote:
>>>>> On 18/12/18 12:56, Philippe Mathieu-Daudé wrote:
>>>>>> Nobody is looking at those files, downgrade this subsystem as orphan.
>>>>>>
>>>>>> Remove the qemu-devel@nongnu.org entry because the list is always
>>>>>> selected by the 'All patches CC here' section.
>>>>>>
>>>>>> Suggested-by: Markus Armbruster <armbru@redhat.com>
>>>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>>> ---
>>>>>>  MAINTAINERS | 3 +--
>>>>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>>>>
>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>> index e50f8c6b97..e6a73820f1 100644
>>>>>> --- a/MAINTAINERS
>>>>>> +++ b/MAINTAINERS
>>>>>> @@ -1745,8 +1745,7 @@ S: Supported
>>>>>>  F: scripts/coverity-model.c
>>>>>>  
>>>>>>  CPU
>>>>>> -L: qemu-devel@nongnu.org
>>>>>> -S: Supported
>>>>>> +S: Orphan
>>>>>>  F: qom/cpu.c
>>>>>>  F: include/qom/cpu.h
>>>>>>  
>>>>>>
>>>>>
>>>>> I don't think that's accurate.  Simply there's not much going on.  If
>>>>> patches are sent, get-maintainers's git fallback will do something
>>>>> (probably sending the patch to Eduardo, Igor or me).
>>>
>>> I followed Markus suggestion from
>>> https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:
>>>
>>>   If we take the definition of S: in MAINTAINERS seriously,
>>>   we need to appoint a maintainer (a person, not a mailing list),
>>>   or downgrade to S: Orphan.
>>
>> I agree with Markus and Philippe. Having "S: Supported" but no names
>> available is just confusing. So either put a maintainer name in here, or
>> downgrade to "Orphan".
> 
> I volunteer to maintain it, but I don't want to be the only
> maintainer.  Any other volunteer?

I can volunteer since I'd take the patches anyway.  We can also mark it
as Odd Fixes, and also make it a single thing with all of qom/ and
include/qom/.

Paolo

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Eduardo Habkost]

On Tue, Dec 18, 2018 at 06:15:06PM +0100, Paolo Bonzini wrote:
> On 18/12/18 16:57, Eduardo Habkost wrote:
> > On Tue, Dec 18, 2018 at 04:44:25PM +0100, Thomas Huth wrote:
> >> On 2018-12-18 16:31, Philippe Mathieu-Daudé wrote:
> >>> Hi Paolo, Eduardo,
> >>>
> >>> On 12/18/18 4:22 PM, Eduardo Habkost wrote:
> >>>> On Tue, Dec 18, 2018 at 01:34:52PM +0100, Paolo Bonzini wrote:
> >>>>> On 18/12/18 12:56, Philippe Mathieu-Daudé wrote:
> >>>>>> Nobody is looking at those files, downgrade this subsystem as orphan.
> >>>>>>
> >>>>>> Remove the qemu-devel@nongnu.org entry because the list is always
> >>>>>> selected by the 'All patches CC here' section.
> >>>>>>
> >>>>>> Suggested-by: Markus Armbruster <armbru@redhat.com>
> >>>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> >>>>>> ---
> >>>>>>  MAINTAINERS | 3 +--
> >>>>>>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>>>>>
> >>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>>>>> index e50f8c6b97..e6a73820f1 100644
> >>>>>> --- a/MAINTAINERS
> >>>>>> +++ b/MAINTAINERS
> >>>>>> @@ -1745,8 +1745,7 @@ S: Supported
> >>>>>>  F: scripts/coverity-model.c
> >>>>>>  
> >>>>>>  CPU
> >>>>>> -L: qemu-devel@nongnu.org
> >>>>>> -S: Supported
> >>>>>> +S: Orphan
> >>>>>>  F: qom/cpu.c
> >>>>>>  F: include/qom/cpu.h
> >>>>>>  
> >>>>>>
> >>>>>
> >>>>> I don't think that's accurate.  Simply there's not much going on.  If
> >>>>> patches are sent, get-maintainers's git fallback will do something
> >>>>> (probably sending the patch to Eduardo, Igor or me).
> >>>
> >>> I followed Markus suggestion from
> >>> https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:
> >>>
> >>>   If we take the definition of S: in MAINTAINERS seriously,
> >>>   we need to appoint a maintainer (a person, not a mailing list),
> >>>   or downgrade to S: Orphan.
> >>
> >> I agree with Markus and Philippe. Having "S: Supported" but no names
> >> available is just confusing. So either put a maintainer name in here, or
> >> downgrade to "Orphan".
> > 
> > I volunteer to maintain it, but I don't want to be the only
> > maintainer.  Any other volunteer?
> 
> I can volunteer since I'd take the patches anyway.  We can also mark it
> as Odd Fixes, and also make it a single thing with all of qom/ and
> include/qom/.

Actually, I consider qom/cpu.c distinct from QOM core, and I was
planning to move it to hw/cpu, and add hw/cpu/core.c to the same
section.

Anyway, I guess this means you're also volunteering to be listed
as QOM maintainer?

-- 
Eduardo

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Paolo Bonzini]

On 18/12/18 20:13, Eduardo Habkost wrote:
> On Tue, Dec 18, 2018 at 06:15:06PM +0100, Paolo Bonzini wrote:
>> On 18/12/18 16:57, Eduardo Habkost wrote:
>>> On Tue, Dec 18, 2018 at 04:44:25PM +0100, Thomas Huth wrote:
>>>> On 2018-12-18 16:31, Philippe Mathieu-Daudé wrote:
>>>>> Hi Paolo, Eduardo,
>>>>>
>>>>> On 12/18/18 4:22 PM, Eduardo Habkost wrote:
>>>>>> On Tue, Dec 18, 2018 at 01:34:52PM +0100, Paolo Bonzini wrote:
>>>>>>> On 18/12/18 12:56, Philippe Mathieu-Daudé wrote:
>>>>>>>> Nobody is looking at those files, downgrade this subsystem as orphan.
>>>>>>>>
>>>>>>>> Remove the qemu-devel@nongnu.org entry because the list is always
>>>>>>>> selected by the 'All patches CC here' section.
>>>>>>>>
>>>>>>>> Suggested-by: Markus Armbruster <armbru@redhat.com>
>>>>>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>>>>>>> ---
>>>>>>>>  MAINTAINERS | 3 +--
>>>>>>>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>>>>>>>
>>>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>>>>> index e50f8c6b97..e6a73820f1 100644
>>>>>>>> --- a/MAINTAINERS
>>>>>>>> +++ b/MAINTAINERS
>>>>>>>> @@ -1745,8 +1745,7 @@ S: Supported
>>>>>>>>  F: scripts/coverity-model.c
>>>>>>>>  
>>>>>>>>  CPU
>>>>>>>> -L: qemu-devel@nongnu.org
>>>>>>>> -S: Supported
>>>>>>>> +S: Orphan
>>>>>>>>  F: qom/cpu.c
>>>>>>>>  F: include/qom/cpu.h
>>>>>>>>  
>>>>>>>>
>>>>>>>
>>>>>>> I don't think that's accurate.  Simply there's not much going on.  If
>>>>>>> patches are sent, get-maintainers's git fallback will do something
>>>>>>> (probably sending the patch to Eduardo, Igor or me).
>>>>>
>>>>> I followed Markus suggestion from
>>>>> https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:
>>>>>
>>>>>   If we take the definition of S: in MAINTAINERS seriously,
>>>>>   we need to appoint a maintainer (a person, not a mailing list),
>>>>>   or downgrade to S: Orphan.
>>>>
>>>> I agree with Markus and Philippe. Having "S: Supported" but no names
>>>> available is just confusing. So either put a maintainer name in here, or
>>>> downgrade to "Orphan".
>>>
>>> I volunteer to maintain it, but I don't want to be the only
>>> maintainer.  Any other volunteer?
>>
>> I can volunteer since I'd take the patches anyway.  We can also mark it
>> as Odd Fixes, and also make it a single thing with all of qom/ and
>> include/qom/.
> 
> Actually, I consider qom/cpu.c distinct from QOM core, and I was
> planning to move it to hw/cpu, and add hw/cpu/core.c to the same
> section.
> 
> Anyway, I guess this means you're also volunteering to be listed
> as QOM maintainer?

Igor and Daniel, would you co-maintain or review it?

Paolo

Re: [Qemu-devel] [PATCH v2 10/12] MAINTAINERS: Orphanize the 'CPU (QOM)' subsystem

[Daniel P. Berrangé]

On Tue, Dec 18, 2018 at 10:22:39PM +0100, Paolo Bonzini wrote:
> On 18/12/18 20:13, Eduardo Habkost wrote:
> > On Tue, Dec 18, 2018 at 06:15:06PM +0100, Paolo Bonzini wrote:
> >> On 18/12/18 16:57, Eduardo Habkost wrote:
> >>> On Tue, Dec 18, 2018 at 04:44:25PM +0100, Thomas Huth wrote:
> >>>> On 2018-12-18 16:31, Philippe Mathieu-Daudé wrote:
> >>>>> Hi Paolo, Eduardo,
> >>>>>
> >>>>> On 12/18/18 4:22 PM, Eduardo Habkost wrote:
> >>>>>> On Tue, Dec 18, 2018 at 01:34:52PM +0100, Paolo Bonzini wrote:
> >>>>>>> On 18/12/18 12:56, Philippe Mathieu-Daudé wrote:
> >>>>>>>> Nobody is looking at those files, downgrade this subsystem as orphan.
> >>>>>>>>
> >>>>>>>> Remove the qemu-devel@nongnu.org entry because the list is always
> >>>>>>>> selected by the 'All patches CC here' section.
> >>>>>>>>
> >>>>>>>> Suggested-by: Markus Armbruster <armbru@redhat.com>
> >>>>>>>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> >>>>>>>> ---
> >>>>>>>>  MAINTAINERS | 3 +--
> >>>>>>>>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>>>>>>>
> >>>>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
> >>>>>>>> index e50f8c6b97..e6a73820f1 100644
> >>>>>>>> --- a/MAINTAINERS
> >>>>>>>> +++ b/MAINTAINERS
> >>>>>>>> @@ -1745,8 +1745,7 @@ S: Supported
> >>>>>>>>  F: scripts/coverity-model.c
> >>>>>>>>  
> >>>>>>>>  CPU
> >>>>>>>> -L: qemu-devel@nongnu.org
> >>>>>>>> -S: Supported
> >>>>>>>> +S: Orphan
> >>>>>>>>  F: qom/cpu.c
> >>>>>>>>  F: include/qom/cpu.h
> >>>>>>>>  
> >>>>>>>>
> >>>>>>>
> >>>>>>> I don't think that's accurate.  Simply there's not much going on.  If
> >>>>>>> patches are sent, get-maintainers's git fallback will do something
> >>>>>>> (probably sending the patch to Eduardo, Igor or me).
> >>>>>
> >>>>> I followed Markus suggestion from
> >>>>> https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg05414.html:
> >>>>>
> >>>>>   If we take the definition of S: in MAINTAINERS seriously,
> >>>>>   we need to appoint a maintainer (a person, not a mailing list),
> >>>>>   or downgrade to S: Orphan.
> >>>>
> >>>> I agree with Markus and Philippe. Having "S: Supported" but no names
> >>>> available is just confusing. So either put a maintainer name in here, or
> >>>> downgrade to "Orphan".
> >>>
> >>> I volunteer to maintain it, but I don't want to be the only
> >>> maintainer.  Any other volunteer?
> >>
> >> I can volunteer since I'd take the patches anyway.  We can also mark it
> >> as Odd Fixes, and also make it a single thing with all of qom/ and
> >> include/qom/.
> > 
> > Actually, I consider qom/cpu.c distinct from QOM core, and I was
> > planning to move it to hw/cpu, and add hw/cpu/core.c to the same
> > section.
> > 
> > Anyway, I guess this means you're also volunteering to be listed
> > as QOM maintainer?
> 
> Igor and Daniel, would you co-maintain or review it?

I'm fine being listed as a manitainer for qom/, agree with moving
qom/cpu.c to hw/cpu, as I was going to suggest that myself :-)


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

Re: [Qemu-devel] [PATCH v2 05/12] MAINTAINERS: Add missing entries for the QObject section

[Thomas Huth]

On 18/12/2018 12.56, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Removed qdist
> ---
>  MAINTAINERS | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7a94b0dab3..a381882c27 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1900,10 +1900,14 @@ F: include/qapi/qmp/
>  X: include/qapi/qmp/dispatch.h
>  F: scripts/coccinelle/qobject.cocci
>  F: tests/check-qdict.c
> -F: tests/check-qnum.c
>  F: tests/check-qjson.c
>  F: tests/check-qlist.c
> +F: tests/check-qlit.c
> +F: tests/check-qnull.c
> +F: tests/check-qnum.c
> +F: tests/check-qobject.c
>  F: tests/check-qstring.c
> +F: qdict-test-data.txt
>  T: git https://repo.or.cz/qemu/armbru.git qapi-next

Reviewed-by: Thomas Huth <thuth@redhat.com>

Re: [Qemu-devel] [PATCH v2 05/12] MAINTAINERS: Add missing entries for the QObject section

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@redhat.com> writes:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Removed qdist
> ---
>  MAINTAINERS | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 7a94b0dab3..a381882c27 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1900,10 +1900,14 @@ F: include/qapi/qmp/
>  X: include/qapi/qmp/dispatch.h
>  F: scripts/coccinelle/qobject.cocci
>  F: tests/check-qdict.c
> -F: tests/check-qnum.c
>  F: tests/check-qjson.c
>  F: tests/check-qlist.c
> +F: tests/check-qlit.c
> +F: tests/check-qnull.c
> +F: tests/check-qnum.c
> +F: tests/check-qobject.c
>  F: tests/check-qstring.c
> +F: qdict-test-data.txt
>  T: git https://repo.or.cz/qemu/armbru.git qapi-next
>  
>  QEMU Guest Agent

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Re: [Qemu-devel] [PATCH v2 01/12] MAINTAINERS: Add missing entries to the X86 section (AMD SEV)

[Thomas Huth]

On 18/12/2018 12.56, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: Moved from TCG to KVM section
> ---
>  MAINTAINERS | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 83c127f0d6..771b1c7b94 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -392,7 +392,9 @@ M: Marcelo Tosatti <mtosatti@redhat.com>
>  L: kvm@vger.kernel.org
>  S: Supported
>  F: target/i386/kvm.c
> +F: include/sysemu/sev.h

Shouldn't this then include target/i386/sev.c, too?

>  F: scripts/kvm/vmxcap
> +F: docs/amd-memory-encryption.txt

 Thomas

Re: [Qemu-devel] [PATCH v2 04/12] MAINTAINERS: Add missing entries to VFIO and NVMe

[Thomas Huth]

On 18/12/2018 12.56, Philippe Mathieu-Daudé wrote:
> The VFIO helpers are used by the NVMe block driver, add the
> entries to both sections.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> v2: add util/vfio-helpers.c, add entries to NVMe section
> ---
>  MAINTAINERS | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f3305a65b6..7a94b0dab3 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1365,7 +1365,10 @@ VFIO
>  M: Alex Williamson <alex.williamson@redhat.com>
>  S: Supported
>  F: hw/vfio/*
> +F: util/vfio-helpers.c
>  F: include/hw/vfio/
> +F: include/qemu/vfio-helpers.h
> +F: docs/igd-assign.txt
>  
>  vfio-ccw
>  M: Cornelia Huck <cohuck@redhat.com>
> @@ -2290,6 +2293,8 @@ M: Fam Zheng <fam@euphon.net>
>  L: qemu-block@nongnu.org
>  S: Supported
>  F: block/nvme*
> +F: util/vfio-helpers.c
> +F: include/qemu/vfio-helpers.h
>  
>  Bootdevice
>  M: Gonglei <arei.gonglei@huawei.com>
> 

Cornelia? Alex? ... Ack? NAck?

 Thomas

Re: [Qemu-devel] [PATCH v2 04/12] MAINTAINERS: Add missing entries to VFIO and NVMe

[Alex Williamson]

On Fri, 15 Feb 2019 18:29:19 +0100
Thomas Huth <thuth@redhat.com> wrote:

> On 18/12/2018 12.56, Philippe Mathieu-Daudé wrote:
> > The VFIO helpers are used by the NVMe block driver, add the
> > entries to both sections.
> > 
> > Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> > ---
> > v2: add util/vfio-helpers.c, add entries to NVMe section
> > ---
> >  MAINTAINERS | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index f3305a65b6..7a94b0dab3 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1365,7 +1365,10 @@ VFIO
> >  M: Alex Williamson <alex.williamson@redhat.com>
> >  S: Supported
> >  F: hw/vfio/*
> > +F: util/vfio-helpers.c
> >  F: include/hw/vfio/
> > +F: include/qemu/vfio-helpers.h
> > +F: docs/igd-assign.txt
> >  
> >  vfio-ccw
> >  M: Cornelia Huck <cohuck@redhat.com>
> > @@ -2290,6 +2293,8 @@ M: Fam Zheng <fam@euphon.net>
> >  L: qemu-block@nongnu.org
> >  S: Supported
> >  F: block/nvme*
> > +F: util/vfio-helpers.c
> > +F: include/qemu/vfio-helpers.h
> >  
> >  Bootdevice
> >  M: Gonglei <arei.gonglei@huawei.com>
> >   
> 
> Cornelia? Alex? ... Ack? NAck?

vfio-helpers consumes vfio but that's really the only tie to me having
any remote authority over it.  I think it makes more sense to tie it
with the direct consumer, which is nvme, and developer, Fam.  Thanks,

Alex