* [U-Boot] [PATCH] cmd: image_info: Add checking of default FIT config
@ 2018-12-18 14:45 Bryan O'Donoghue
2019-01-05 1:56 ` Simon Glass
0 siblings, 1 reply; 3+ messages in thread
From: Bryan O'Donoghue @ 2018-12-18 14:45 UTC (permalink / raw)
To: u-boot
This patch adds a check for the default FIT config to iminfo. Once applied
any signing of the config will show a pass fail similar to rsa+/rsa-.
Output looks like this:
Hash(es) for Image 0 (kernel at 1): sha1+
Hash(es) for Image 1 (fdt at imx7s-warp.dtb): sha1+
Hash(es) for Image 2 (ramdisk at 1): sha1+
Hash(es) for Image 3 (bootscr): sha1+
Hash for default configuration: sha1,rsa2048:mbl-fit-rot-key+
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Jun Nie <jun.nie@linaro.org>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
---
cmd/bootm.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/cmd/bootm.c b/cmd/bootm.c
index c3a063474a..b3bd236165 100644
--- a/cmd/bootm.c
+++ b/cmd/bootm.c
@@ -244,6 +244,9 @@ static int do_iminfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
static int image_info(ulong addr)
{
+#if defined(CONFIG_FIT)
+ int cfg_noffset;
+#endif
void *hdr = (void *)addr;
printf("\n## Checking Image at %08lx ...\n", addr);
@@ -294,6 +297,20 @@ static int image_info(ulong addr)
return 1;
}
+ cfg_noffset = fit_conf_get_node(hdr, NULL);
+ if (!cfg_noffset) {
+ printf("Could not find configuration node: %s\n",
+ fdt_strerror(cfg_noffset));
+ return 1;
+ }
+
+ puts(" Hash for default configuration: ");
+ if (fit_config_verify(hdr, cfg_noffset)) {
+ puts("Unable to verify default fit config\n");
+ return 1;
+ }
+ puts("\n");
+
return 0;
#endif
default:
--
2.20.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] cmd: image_info: Add checking of default FIT config
2018-12-18 14:45 [U-Boot] [PATCH] cmd: image_info: Add checking of default FIT config Bryan O'Donoghue
@ 2019-01-05 1:56 ` Simon Glass
0 siblings, 0 replies; 3+ messages in thread
From: Simon Glass @ 2019-01-05 1:56 UTC (permalink / raw)
To: u-boot
On Tue, 18 Dec 2018 at 07:46, Bryan O'Donoghue
<bryan.odonoghue@linaro.org> wrote:
>
> This patch adds a check for the default FIT config to iminfo. Once applied
> any signing of the config will show a pass fail similar to rsa+/rsa-.
>
> Output looks like this:
>
> Hash(es) for Image 0 (kernel at 1): sha1+
> Hash(es) for Image 1 (fdt at imx7s-warp.dtb): sha1+
> Hash(es) for Image 2 (ramdisk at 1): sha1+
> Hash(es) for Image 3 (bootscr): sha1+
> Hash for default configuration: sha1,rsa2048:mbl-fit-rot-key+
>
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Cc: Jun Nie <jun.nie@linaro.org>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> cmd/bootm.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
Reviewed-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] cmd: image_info: Add checking of default FIT config
@ 2019-01-18 17:17 Bryan O'Donoghue
0 siblings, 0 replies; 3+ messages in thread
From: Bryan O'Donoghue @ 2019-01-18 17:17 UTC (permalink / raw)
To: u-boot
This patch adds a check for the default FIT config to iminfo. Once applied
any signing of the config will show a pass fail similar to rsa+/rsa-.
Output looks like this:
Hash(es) for Image 0 (kernel at 1): sha1+
Hash(es) for Image 1 (fdt at imx7s-warp.dtb): sha1+
Hash(es) for Image 2 (ramdisk at 1): sha1+
Hash(es) for Image 3 (bootscr): sha1+
Hash for default configuration: sha1,rsa2048:mbl-fit-rot-key+
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: Jun Nie <jun.nie@linaro.org>
Cc: Simon Glass <sjg@chromium.org>
Cc: Tom Rini <trini@konsulko.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
cmd/bootm.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/cmd/bootm.c b/cmd/bootm.c
index c3a063474a..b3bd236165 100644
--- a/cmd/bootm.c
+++ b/cmd/bootm.c
@@ -244,6 +244,9 @@ static int do_iminfo(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
static int image_info(ulong addr)
{
+#if defined(CONFIG_FIT)
+ int cfg_noffset;
+#endif
void *hdr = (void *)addr;
printf("\n## Checking Image at %08lx ...\n", addr);
@@ -294,6 +297,20 @@ static int image_info(ulong addr)
return 1;
}
+ cfg_noffset = fit_conf_get_node(hdr, NULL);
+ if (!cfg_noffset) {
+ printf("Could not find configuration node: %s\n",
+ fdt_strerror(cfg_noffset));
+ return 1;
+ }
+
+ puts(" Hash for default configuration: ");
+ if (fit_config_verify(hdr, cfg_noffset)) {
+ puts("Unable to verify default fit config\n");
+ return 1;
+ }
+ puts("\n");
+
return 0;
#endif
default:
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-18 17:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-18 14:45 [U-Boot] [PATCH] cmd: image_info: Add checking of default FIT config Bryan O'Donoghue
2019-01-05 1:56 ` Simon Glass
2019-01-18 17:17 Bryan O'Donoghue
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.