[PATCH] dm: give req_size precisely given by user

[PATCH] dm: give req_size precisely given by user

[Jaegeuk Kim]

This patch makes dm be aware of io_pages to assign sane req_size for reads.

Cc: stable@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Mike Snitzer <snitzer@redhat.com>
Cc: dm-devel@redhat.com
Fixes: 9491ae4a ("mm: don't cap request size based on read-ahead setting")
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
 drivers/md/dm-table.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
index 9038c302d5c2..886790428241 100644
--- a/drivers/md/dm-table.c
+++ b/drivers/md/dm-table.c
@@ -1927,6 +1927,9 @@ void dm_table_set_restrictions(struct dm_table *t, struct request_queue *q,
 	 */
 	if (blk_queue_is_zoned(q))
 		blk_revalidate_disk_zones(t->md->disk);
+
+	/* io_pages is used for readahead */
+	q->backing_dev_info->io_pages = limits->max_sectors >> (PAGE_SHIFT - 9);
 }
 
 unsigned int dm_table_get_num_targets(struct dm_table *t)
-- 
2.19.0.605.g01d371f741-goog

Re: [PATCH] dm: give req_size precisely given by user

[Jens Axboe]

On 12/18/18 10:25 AM, Jaegeuk Kim wrote:
> This patch makes dm be aware of io_pages to assign sane req_size for reads.

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe

Re: dm: give req_size precisely given by user

[Mike Snitzer]

On Tue, Dec 18 2018 at 12:45pm -0500,
Jens Axboe <axboe@kernel.dk> wrote:

> On 12/18/18 10:25 AM, Jaegeuk Kim wrote:
> > This patch makes dm be aware of io_pages to assign sane req_size for reads.
> 
> Reviewed-by: Jens Axboe <axboe@kernel.dk>
> 

I've applied this, see:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.21&id=c6d6e9b0f6b4201c77f2cea3964dd122697e3543

Re: dm: give req_size precisely given by user

[Jaegeuk Kim]

On 12/18, Mike Snitzer wrote:
> On Tue, Dec 18 2018 at 12:45pm -0500,
> Jens Axboe <axboe@kernel.dk> wrote:
> 
> > On 12/18/18 10:25 AM, Jaegeuk Kim wrote:
> > > This patch makes dm be aware of io_pages to assign sane req_size for reads.
> > 
> > Reviewed-by: Jens Axboe <axboe@kernel.dk>
> > 
> 
> I've applied this, see:
> https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-4.21&id=c6d6e9b0f6b4201c77f2cea3964dd122697e3543

Got it. Thank you so much.

Re: [PATCH] dm: give req_size precisely given by user

[Sasha Levin]

Hi,

[This is an automated email]

This commit has been processed because it contains a "Fixes:" tag,
fixing commit: 9491ae4aade6 mm: don't cap request size based on read-ahead setting.

The bot has tested the following trees: v4.19.10, v4.14.89, 

v4.19.10: Failed to apply! Possible dependencies:
    5f832a395859 ("scsi: sd_zbc: Fix sd_zbc_check_zones() error checks")
    a2d6b3a2d390 ("block: Improve zone reset execution")
    a91e138022bc ("block: Introduce blkdev_nr_zones() helper")
    bf5054569653 ("block: Introduce blk_revalidate_disk_zones()")
    d2e428e49eec ("scsi: sd_zbc: Reduce boot device scan and revalidate time")
    e76239a3748c ("block: add a report_zones method")

v4.14.89: Failed to apply! Possible dependencies:
    08e18eab0c57 ("block: add bi_blkg to the bio for cgroups")
    30e5e929c7bf ("nvme: don't pass struct nvme_ns to nvme_config_discard")
    5238dcf4136f ("block: replace bio->bi_issue_stat with bio-specific type")
    53cfdc10a95d ("blk-throttle: fix null pointer dereference while throttling writeback IOs")
    5d47c89f29ea ("dm: clear all discard attributes in queue_limits when discards are disabled")
    8b904b5b6b58 ("block: Use blk_queue_flag_*() in drivers instead of queue_flag_*()")
    a2d6b3a2d390 ("block: Improve zone reset execution")
    b889bf66d001 ("blk-throttle: track read and write request individually")
    bf5054569653 ("block: Introduce blk_revalidate_disk_zones()")
    c8b5fd031a30 ("mmc: block: Factor out mmc_setup_queue()")
    d70675121546 ("block: introduce blk-iolatency io controller")
    e447a0151f7c ("zram: set BDI_CAP_STABLE_WRITES once")
    ed754e5deeb1 ("nvme: track shared namespaces")


How should we proceed with this patch?

--
Thanks,
Sasha

Re: [PATCH] dm: give req_size precisely given by user

[Sasha Levin]

Hi,

[This is an automated email]

This commit has been processed because it contains a "Fixes:" tag,
fixing commit: 9491ae4aade6 mm: don't cap request size based on read-ahead setting.

The bot has tested the following trees: v4.19.10, v4.14.89, 

v4.19.10: Failed to apply! Possible dependencies:
    5f832a395859 ("scsi: sd_zbc: Fix sd_zbc_check_zones() error checks")
    a2d6b3a2d390 ("block: Improve zone reset execution")
    a91e138022bc ("block: Introduce blkdev_nr_zones() helper")
    bf5054569653 ("block: Introduce blk_revalidate_disk_zones()")
    d2e428e49eec ("scsi: sd_zbc: Reduce boot device scan and revalidate time")
    e76239a3748c ("block: add a report_zones method")

v4.14.89: Failed to apply! Possible dependencies:
    08e18eab0c57 ("block: add bi_blkg to the bio for cgroups")
    30e5e929c7bf ("nvme: don't pass struct nvme_ns to nvme_config_discard")
    5238dcf4136f ("block: replace bio->bi_issue_stat with bio-specific type")
    53cfdc10a95d ("blk-throttle: fix null pointer dereference while throttling writeback IOs")
    5d47c89f29ea ("dm: clear all discard attributes in queue_limits when discards are disabled")
    8b904b5b6b58 ("block: Use blk_queue_flag_*() in drivers instead of queue_flag_*()")
    a2d6b3a2d390 ("block: Improve zone reset execution")
    b889bf66d001 ("blk-throttle: track read and write request individually")
    bf5054569653 ("block: Introduce blk_revalidate_disk_zones()")
    c8b5fd031a30 ("mmc: block: Factor out mmc_setup_queue()")
    d70675121546 ("block: introduce blk-iolatency io controller")
    e447a0151f7c ("zram: set BDI_CAP_STABLE_WRITES once")
    ed754e5deeb1 ("nvme: track shared namespaces")


How should we proceed with this patch?

--
Thanks,
Sasha