* [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-19 19:46 ` Sergio Paracuellos
0 siblings, 0 replies; 8+ messages in thread
From: Sergio Paracuellos @ 2018-12-19 19:46 UTC (permalink / raw)
To: Woojung.Huh
Cc: UNGLinuxDriver, andrew, vivien.didelot, f.fainelli,
driverdev-devel, davem, netdev, devicetree
Add device-tree binding example of the ksz9477 switch managed in i2c mode.
Cc: devicetree@vger.kernel.org
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
Changes v4:
- Use one tab formatting properly the binding sample.
Changes v3:
- No changes. Just resent patches together.
Changes v2:
- Use generic name for label of the switch and make sure reg and @X
have the same value.
.../devicetree/bindings/net/dsa/ksz.txt | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
index 0f407fb371ce..2f276aa42f0b 100644
--- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
+++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
@@ -74,3 +74,54 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
};
};
};
+
+Ethernet switch connected via I2C to the host, CPU port wired to eth0:
+
+ eth0: ethernet@10001000 {
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+
+ i2c0: i2c@f8008000 {
+ switch: ksz9897@5f {
+ compatible = "microchip,ksz9897";
+ reg = <5f>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "lan1";
+ };
+ port@1 {
+ reg = <1>;
+ label = "lan2";
+ };
+ port@2 {
+ reg = <2>;
+ label = "lan3";
+ };
+ port@3 {
+ reg = <3>;
+ label = "lan4";
+ };
+ port@4 {
+ reg = <4>;
+ label = "lan5";
+ };
+ port@6 {
+ reg = <6>;
+ label = "cpu";
+ ethernet = <ð0>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
+ };
--
2.19.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-19 19:46 ` Sergio Paracuellos
0 siblings, 0 replies; 8+ messages in thread
From: Sergio Paracuellos @ 2018-12-19 19:46 UTC (permalink / raw)
To: Woojung.Huh
Cc: andrew, f.fainelli, vivien.didelot, netdev, driverdev-devel,
UNGLinuxDriver, devicetree, davem
Add device-tree binding example of the ksz9477 switch managed in i2c mode.
Cc: devicetree@vger.kernel.org
Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
---
Changes v4:
- Use one tab formatting properly the binding sample.
Changes v3:
- No changes. Just resent patches together.
Changes v2:
- Use generic name for label of the switch and make sure reg and @X
have the same value.
.../devicetree/bindings/net/dsa/ksz.txt | 51 +++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
index 0f407fb371ce..2f276aa42f0b 100644
--- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
+++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
@@ -74,3 +74,54 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
};
};
};
+
+Ethernet switch connected via I2C to the host, CPU port wired to eth0:
+
+ eth0: ethernet@10001000 {
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+
+ i2c0: i2c@f8008000 {
+ switch: ksz9897@5f {
+ compatible = "microchip,ksz9897";
+ reg = <5f>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ label = "lan1";
+ };
+ port@1 {
+ reg = <1>;
+ label = "lan2";
+ };
+ port@2 {
+ reg = <2>;
+ label = "lan3";
+ };
+ port@3 {
+ reg = <3>;
+ label = "lan4";
+ };
+ port@4 {
+ reg = <4>;
+ label = "lan5";
+ };
+ port@6 {
+ reg = <6>;
+ label = "cpu";
+ ethernet = <ð0>;
+ fixed-link {
+ speed = <1000>;
+ full-duplex;
+ };
+ };
+ };
+ };
+ };
--
2.19.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
2018-12-19 19:46 ` Sergio Paracuellos
@ 2018-12-20 23:55 ` David Miller
-1 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2018-12-20 23:55 UTC (permalink / raw)
To: sergio.paracuellos
Cc: Woojung.Huh, UNGLinuxDriver, andrew, vivien.didelot, f.fainelli,
driverdev-devel, netdev, devicetree
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date: Wed, 19 Dec 2018 20:46:26 +0100
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
I am assuming the devicetree folks will take this into their tree or
similar.
If I need to take this into my tree, please let me know.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-20 23:55 ` David Miller
0 siblings, 0 replies; 8+ messages in thread
From: David Miller @ 2018-12-20 23:55 UTC (permalink / raw)
To: sergio.paracuellos
Cc: Woojung.Huh, andrew, f.fainelli, vivien.didelot, netdev,
driverdev-devel, UNGLinuxDriver, devicetree
From: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Date: Wed, 19 Dec 2018 20:46:26 +0100
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
I am assuming the devicetree folks will take this into their tree or
similar.
If I need to take this into my tree, please let me know.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
2018-12-19 19:46 ` Sergio Paracuellos
@ 2018-12-29 0:03 ` Rob Herring
-1 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2018-12-29 0:03 UTC (permalink / raw)
To: Sergio Paracuellos
Cc: Woojung.Huh, UNGLinuxDriver, andrew, vivien.didelot, f.fainelli,
driverdev-devel, davem, netdev, devicetree
On Wed, Dec 19, 2018 at 08:46:26PM +0100, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> Changes v4:
> - Use one tab formatting properly the binding sample.
>
> Changes v3:
> - No changes. Just resent patches together.
>
> Changes v2:
> - Use generic name for label of the switch and make sure reg and @X
> have the same value.
> .../devicetree/bindings/net/dsa/ksz.txt | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> index 0f407fb371ce..2f276aa42f0b 100644
> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> @@ -74,3 +74,54 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> };
> };
> };
> +
> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> +
> + eth0: ethernet@10001000 {
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> +
> + i2c0: i2c@f8008000 {
> + switch: ksz9897@5f {
> + compatible = "microchip,ksz9897";
> + reg = <5f>;
> +
I should have said this earlier, but this example doesn't really show
anything other than differences in reg and bus-specific properties which
are pretty well understood. So I don't really think it is worth adding
the example.
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + label = "lan1";
> + };
> + port@1 {
> + reg = <1>;
> + label = "lan2";
> + };
> + port@2 {
> + reg = <2>;
> + label = "lan3";
> + };
> + port@3 {
> + reg = <3>;
> + label = "lan4";
> + };
> + port@4 {
> + reg = <4>;
> + label = "lan5";
> + };
> + port@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <ð0>;
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> + };
> + };
> + };
> --
> 2.19.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-29 0:03 ` Rob Herring
0 siblings, 0 replies; 8+ messages in thread
From: Rob Herring @ 2018-12-29 0:03 UTC (permalink / raw)
To: Sergio Paracuellos
Cc: Woojung.Huh, andrew, f.fainelli, vivien.didelot, netdev,
driverdev-devel, UNGLinuxDriver, devicetree, davem
On Wed, Dec 19, 2018 at 08:46:26PM +0100, Sergio Paracuellos wrote:
> Add device-tree binding example of the ksz9477 switch managed in i2c mode.
>
> Cc: devicetree@vger.kernel.org
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> ---
> Changes v4:
> - Use one tab formatting properly the binding sample.
>
> Changes v3:
> - No changes. Just resent patches together.
>
> Changes v2:
> - Use generic name for label of the switch and make sure reg and @X
> have the same value.
> .../devicetree/bindings/net/dsa/ksz.txt | 51 +++++++++++++++++++
> 1 file changed, 51 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> index 0f407fb371ce..2f276aa42f0b 100644
> --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> @@ -74,3 +74,54 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> };
> };
> };
> +
> +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> +
> + eth0: ethernet@10001000 {
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> +
> + i2c0: i2c@f8008000 {
> + switch: ksz9897@5f {
> + compatible = "microchip,ksz9897";
> + reg = <5f>;
> +
I should have said this earlier, but this example doesn't really show
anything other than differences in reg and bus-specific properties which
are pretty well understood. So I don't really think it is worth adding
the example.
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + label = "lan1";
> + };
> + port@1 {
> + reg = <1>;
> + label = "lan2";
> + };
> + port@2 {
> + reg = <2>;
> + label = "lan3";
> + };
> + port@3 {
> + reg = <3>;
> + label = "lan4";
> + };
> + port@4 {
> + reg = <4>;
> + label = "lan5";
> + };
> + port@6 {
> + reg = <6>;
> + label = "cpu";
> + ethernet = <ð0>;
> + fixed-link {
> + speed = <1000>;
> + full-duplex;
> + };
> + };
> + };
> + };
> + };
> --
> 2.19.1
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
2018-12-29 0:03 ` Rob Herring
@ 2018-12-29 7:26 ` Sergio Paracuellos
-1 siblings, 0 replies; 8+ messages in thread
From: Sergio Paracuellos @ 2018-12-29 7:26 UTC (permalink / raw)
To: Rob Herring
Cc: Woojung.Huh, Andrew Lunn, Florian Fainelli, vivien.didelot,
netdev, driverdev-devel, UNGLinuxDriver,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
David Miller
On Sat, Dec 29, 2018 at 1:03 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Dec 19, 2018 at 08:46:26PM +0100, Sergio Paracuellos wrote:
> > Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > ---
> > Changes v4:
> > - Use one tab formatting properly the binding sample.
> >
> > Changes v3:
> > - No changes. Just resent patches together.
> >
> > Changes v2:
> > - Use generic name for label of the switch and make sure reg and @X
> > have the same value.
> > .../devicetree/bindings/net/dsa/ksz.txt | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > index 0f407fb371ce..2f276aa42f0b 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > @@ -74,3 +74,54 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> > };
> > };
> > };
> > +
> > +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> > +
> > + eth0: ethernet@10001000 {
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
> > +
> > + i2c0: i2c@f8008000 {
> > + switch: ksz9897@5f {
> > + compatible = "microchip,ksz9897";
> > + reg = <5f>;
> > +
>
> I should have said this earlier, but this example doesn't really show
> anything other than differences in reg and bus-specific properties which
> are pretty well understood. So I don't really think it is worth adding
> the example.
Fair enough. No problem at all for me. Thanks for let me know.
>
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
> > + label = "lan1";
> > + };
> > + port@1 {
> > + reg = <1>;
> > + label = "lan2";
> > + };
> > + port@2 {
> > + reg = <2>;
> > + label = "lan3";
> > + };
> > + port@3 {
> > + reg = <3>;
> > + label = "lan4";
> > + };
> > + port@4 {
> > + reg = <4>;
> > + label = "lan5";
> > + };
> > + port@6 {
> > + reg = <6>;
> > + label = "cpu";
> > + ethernet = <ð0>;
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
> > + };
> > + };
> > + };
> > --
> > 2.19.1
> >
Best regards,
Sergio Paracuellos
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode
@ 2018-12-29 7:26 ` Sergio Paracuellos
0 siblings, 0 replies; 8+ messages in thread
From: Sergio Paracuellos @ 2018-12-29 7:26 UTC (permalink / raw)
To: Rob Herring
Cc: Woojung.Huh, Andrew Lunn, Florian Fainelli, vivien.didelot,
netdev, driverdev-devel, UNGLinuxDriver,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
David Miller
On Sat, Dec 29, 2018 at 1:03 AM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, Dec 19, 2018 at 08:46:26PM +0100, Sergio Paracuellos wrote:
> > Add device-tree binding example of the ksz9477 switch managed in i2c mode.
> >
> > Cc: devicetree@vger.kernel.org
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
> > ---
> > Changes v4:
> > - Use one tab formatting properly the binding sample.
> >
> > Changes v3:
> > - No changes. Just resent patches together.
> >
> > Changes v2:
> > - Use generic name for label of the switch and make sure reg and @X
> > have the same value.
> > .../devicetree/bindings/net/dsa/ksz.txt | 51 +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/net/dsa/ksz.txt b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > index 0f407fb371ce..2f276aa42f0b 100644
> > --- a/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > +++ b/Documentation/devicetree/bindings/net/dsa/ksz.txt
> > @@ -74,3 +74,54 @@ Ethernet switch connected via SPI to the host, CPU port wired to eth0:
> > };
> > };
> > };
> > +
> > +Ethernet switch connected via I2C to the host, CPU port wired to eth0:
> > +
> > + eth0: ethernet@10001000 {
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
> > +
> > + i2c0: i2c@f8008000 {
> > + switch: ksz9897@5f {
> > + compatible = "microchip,ksz9897";
> > + reg = <5f>;
> > +
>
> I should have said this earlier, but this example doesn't really show
> anything other than differences in reg and bus-specific properties which
> are pretty well understood. So I don't really think it is worth adding
> the example.
Fair enough. No problem at all for me. Thanks for let me know.
>
> > + ports {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + port@0 {
> > + reg = <0>;
> > + label = "lan1";
> > + };
> > + port@1 {
> > + reg = <1>;
> > + label = "lan2";
> > + };
> > + port@2 {
> > + reg = <2>;
> > + label = "lan3";
> > + };
> > + port@3 {
> > + reg = <3>;
> > + label = "lan4";
> > + };
> > + port@4 {
> > + reg = <4>;
> > + label = "lan5";
> > + };
> > + port@6 {
> > + reg = <6>;
> > + label = "cpu";
> > + ethernet = <ð0>;
> > + fixed-link {
> > + speed = <1000>;
> > + full-duplex;
> > + };
> > + };
> > + };
> > + };
> > + };
> > --
> > 2.19.1
> >
Best regards,
Sergio Paracuellos
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-12-29 7:27 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-19 19:46 [PATCH v4] dt-bindings: net: dsa: ksz9477: add sample of switch bindings managed in i2c mode Sergio Paracuellos
2018-12-19 19:46 ` Sergio Paracuellos
2018-12-20 23:55 ` David Miller
2018-12-20 23:55 ` David Miller
2018-12-29 0:03 ` Rob Herring
2018-12-29 0:03 ` Rob Herring
2018-12-29 7:26 ` Sergio Paracuellos
2018-12-29 7:26 ` Sergio Paracuellos
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.