From: Eduardo Habkost <ehabkost@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Roman Kagan <rkagan@virtuozzo.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
qemu-devel@nongnu.org, Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] i386/kvm: expose HV_CPUID_ENLIGHTMENT_INFO.EAX and HV_CPUID_NESTED_FEATURES.EAX as feature words
Date: Thu, 20 Dec 2018 10:05:44 -0200 [thread overview]
Message-ID: <20181220120544.GL19442@habkost.net> (raw)
In-Reply-To: <875zvpl98t.fsf@vitty.brq.redhat.com>
On Wed, Dec 19, 2018 at 06:25:06PM +0100, Vitaly Kuznetsov wrote:
> Eduardo Habkost <ehabkost@redhat.com> writes:
>
> > On Mon, Dec 03, 2018 at 03:17:06PM +0100, Vitaly Kuznetsov wrote:
> >> Eduardo Habkost <ehabkost@redhat.com> writes:
> > [...]
> >> > But note that we might still be able to move the existing
> >> > "hyperv_*" features to feature_word_info[].feat_names. We just
> >> > need to keep the same semantics (e.g. enable
> >> > HV_HYPERCALL_AVAILABLE automatically when some features are set).
> >> >
> >> > Maybe we can make some of the feature properties read-only. This
> >> > way we can give them meaningful names for debugging and error
> >> > messages, even if we don't want to make them configurable
> >> > directly.
> >>
> >> I'd suggest (if there are no objections of course) we do this separately
> >> from this patch. [...]
> >
> > Agreed.
> >
>
> Paolo, Eduardo,
>
> in case there are no concerns here, could you please pick this patch up?
> Thanks!
Queued, thanks!
Can you please send the comment you wrote about feat_names as a
follow-up patch?
--
Eduardo
next prev parent reply other threads:[~2018-12-20 12:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 13:59 [Qemu-devel] [PATCH] i386/kvm: expose HV_CPUID_ENLIGHTMENT_INFO.EAX and HV_CPUID_NESTED_FEATURES.EAX as feature words Vitaly Kuznetsov
2018-11-27 13:10 ` Roman Kagan
2018-11-29 10:20 ` Paolo Bonzini
2018-11-29 11:51 ` Vitaly Kuznetsov
2018-11-30 18:36 ` Eduardo Habkost
2018-12-03 14:17 ` Vitaly Kuznetsov
2018-12-04 18:08 ` Eduardo Habkost
2018-12-05 13:12 ` Vitaly Kuznetsov
2018-12-19 17:25 ` Vitaly Kuznetsov
2018-12-20 12:05 ` Eduardo Habkost [this message]
2018-12-21 14:14 ` Vitaly Kuznetsov
2019-01-14 10:54 ` Vitaly Kuznetsov
2019-01-14 14:32 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220120544.GL19442@habkost.net \
--to=ehabkost@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkagan@virtuozzo.com \
--cc=rth@twiddle.net \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.