All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [RFC PATCH 1/1] Remove ADP tests
@ 2018-12-20 15:02 Petr Vorel
  2018-12-21  7:56 ` Li Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Petr Vorel @ 2018-12-20 15:02 UTC (permalink / raw)
  To: ltp

They're not used in any runtest, not using shell API.

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,

I know I cannot delete everything, but I don't see much value in these tests.

Kind regards,
Petr
---
 testscripts/adp.sh          | 89 -------------------------------------
 testscripts/adp_children.sh | 11 -----
 testscripts/adp_test.sh     |  6 ---
 3 files changed, 106 deletions(-)
 delete mode 100755 testscripts/adp.sh
 delete mode 100755 testscripts/adp_children.sh
 delete mode 100755 testscripts/adp_test.sh

diff --git a/testscripts/adp.sh b/testscripts/adp.sh
deleted file mode 100755
index d22bf8f81..000000000
--- a/testscripts/adp.sh
+++ /dev/null
@@ -1,89 +0,0 @@
-#!/bin/bash
-#
-# adp.sh -- run ADP's stress test on /proc/[0-9]*/cmdline
-#
-#
-
-usage()
-{
-  cat << EOF
-  usage: $0 options
-
-  This script runs ADP's stress test on /proc/[0-0]*/cmdline.
-
-  OPTIONS
-    -h    display this message and exit
-    -d    delay for top, in seconds
-    -n    number of iterations for top
-EOF
-}
-
-
-checkvar()
-{
-  VAR=$1
-  eval VALUE='$'$VAR
-  if [ "x$VALUE" = "x" ]; then
-      echo "`basename $0`: $VAR is not set."
-      return 1
-	else
-      return 0
-  fi
-}
-
-
-while getopts hd:n: OPTION
-do
-  case $OPTION in
-    h)
-      usage
-      exit 1
-      ;;
-    d)
-      delay=$OPTARG
-      ;;
-    n)
-      iterations=$OPTARG
-      ;;
-    ?)
-      usage
-      exit 1
-      ;;
-  esac
-done
-
-
-#check all vars
-checkvar delay && checkvar iterations || {
-  usage
-  exit 2
-}
-
-echo "-------------------------------------------------------------------------"
-date
-echo "Starting tests..."
-
-for i in 1 2 3 4 5
-do
-	./adp_children.sh &
-done
-
-echo "Stressing /proc/[0-9]*/cmdline..."
-
-for i in 1 2 3 4 5
-do
-	./adp_test.sh &
-done
-
-echo "Starting 'top', redirecting output to 'adp.log'..."
-top -b -d $delay -n $iterations > adp.log &
-
-echo "LTP ADP Test done. Killing processes..."
-killall adp_test.sh
-killall adp_children.sh
-
-echo "Done. Please check adp.log."
-date
-
-echo "-------------------------------------------------------------------------"
-
diff --git a/testscripts/adp_children.sh b/testscripts/adp_children.sh
deleted file mode 100755
index 4c1c94e36..000000000
--- a/testscripts/adp_children.sh
+++ /dev/null
@@ -1,11 +0,0 @@
-#!/bin/bash
-
-while :
-do
-	for i in 1 2 3 4 5 6 7 8 9 0
-	do
-		sleep 1 &
-	done
-
-	wait
-done
diff --git a/testscripts/adp_test.sh b/testscripts/adp_test.sh
deleted file mode 100755
index df0d48acf..000000000
--- a/testscripts/adp_test.sh
+++ /dev/null
@@ -1,6 +0,0 @@
-#!/bin/bash
-
-while :
-do
-	cat /proc/[0-9]*/cmdline > /dev/null 2>/dev/null
-done
-- 
2.19.2


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [LTP] [RFC PATCH 1/1] Remove ADP tests
  2018-12-20 15:02 [LTP] [RFC PATCH 1/1] Remove ADP tests Petr Vorel
@ 2018-12-21  7:56 ` Li Wang
  2019-01-03 10:24   ` Cyril Hrubis
  0 siblings, 1 reply; 4+ messages in thread
From: Li Wang @ 2018-12-21  7:56 UTC (permalink / raw)
  To: ltp

On Thu, Dec 20, 2018 at 11:02 PM Petr Vorel <pvorel@suse.cz> wrote:
>
> They're not used in any runtest, not using shell API.

Agree, and there is no real update for more than 10 years.

-- 
Regards,
Li Wang

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [LTP] [RFC PATCH 1/1] Remove ADP tests
  2018-12-21  7:56 ` Li Wang
@ 2019-01-03 10:24   ` Cyril Hrubis
  2019-01-03 10:41     ` Petr Vorel
  0 siblings, 1 reply; 4+ messages in thread
From: Cyril Hrubis @ 2019-01-03 10:24 UTC (permalink / raw)
  To: ltp

Hi!
> > They're not used in any runtest, not using shell API.
> 
> Agree, and there is no real update for more than 10 years.

And we have at least two maintained tests that stress proc filesystem,
so there is no value in keeping these scripts.

Acked, Peter go ahead and push this.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [LTP] [RFC PATCH 1/1] Remove ADP tests
  2019-01-03 10:24   ` Cyril Hrubis
@ 2019-01-03 10:41     ` Petr Vorel
  0 siblings, 0 replies; 4+ messages in thread
From: Petr Vorel @ 2019-01-03 10:41 UTC (permalink / raw)
  To: ltp

Hi Cyril, Li,

> > Agree, and there is no real update for more than 10 years.

> And we have at least two maintained tests that stress proc filesystem,
> so there is no value in keeping these scripts.

> Acked, Peter go ahead and push this.

Thanks for your review, pushed.


Kind regards,
Petr

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-03 10:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-20 15:02 [LTP] [RFC PATCH 1/1] Remove ADP tests Petr Vorel
2018-12-21  7:56 ` Li Wang
2019-01-03 10:24   ` Cyril Hrubis
2019-01-03 10:41     ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.