From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org, linux@roeck-us.net,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
gregkh@linuxfoundation.org
Subject: Re: [PATCH net-next] staging: octeon: fix build failure with XFRM enabled
Date: Mon, 24 Dec 2018 09:58:46 -0800 (PST) [thread overview]
Message-ID: <20181224.095846.1987517984305782151.davem@davemloft.net> (raw)
In-Reply-To: <20181221205726.2924-1-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Fri, 21 Dec 2018 21:57:26 +0100
> skb->sp doesn't exist anymore in the next-next tree, so mips defconfig
> no longer builds. Use helper instead to reset the secpath.
>
> Not even compile tested.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Fixes: 4165079ba328d ("net: switch secpath to use skb extension infrastructure")
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Greg, David:
>
> The patch will not break build for a tree that lacks the 'Fixes'
> commit, so this can also go in via staging tree.
> OTOH, net-next build is broken for mips/octeon, so I think in
> this case net-next might make more sense?
Yeah I agree, that net-next is probably the best place for this.
Because I know that Linus is sensitive to situations where he is
sent a pull request, and then what he pulls doesn't match the pull
request shortlog etc. I have asked him how he would let me handle
this.
That's the only reason I haven't integrated this yet.
Just FYI!
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux@roeck-us.net,
gregkh@linuxfoundation.org
Subject: Re: [PATCH net-next] staging: octeon: fix build failure with XFRM enabled
Date: Mon, 24 Dec 2018 09:58:46 -0800 (PST) [thread overview]
Message-ID: <20181224.095846.1987517984305782151.davem@davemloft.net> (raw)
In-Reply-To: <20181221205726.2924-1-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Fri, 21 Dec 2018 21:57:26 +0100
> skb->sp doesn't exist anymore in the next-next tree, so mips defconfig
> no longer builds. Use helper instead to reset the secpath.
>
> Not even compile tested.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reported-by: Guenter Roeck <linux@roeck-us.net>
> Fixes: 4165079ba328d ("net: switch secpath to use skb extension infrastructure")
> Signed-off-by: Florian Westphal <fw@strlen.de>
> ---
> Greg, David:
>
> The patch will not break build for a tree that lacks the 'Fixes'
> commit, so this can also go in via staging tree.
> OTOH, net-next build is broken for mips/octeon, so I think in
> this case net-next might make more sense?
Yeah I agree, that net-next is probably the best place for this.
Because I know that Linus is sensitive to situations where he is
sent a pull request, and then what he pulls doesn't match the pull
request shortlog etc. I have asked him how he would let me handle
this.
That's the only reason I haven't integrated this yet.
Just FYI!
next prev parent reply other threads:[~2018-12-24 17:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-21 20:57 [PATCH net-next] staging: octeon: fix build failure with XFRM enabled Florian Westphal
2018-12-22 8:35 ` Sergei Shtylyov
2018-12-22 8:35 ` Sergei Shtylyov
2018-12-24 17:58 ` David Miller [this message]
2018-12-24 17:58 ` David Miller
2018-12-21 23:27 Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181224.095846.1987517984305782151.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=fw@strlen.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.