All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Aring <aring@mojatatu.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Alexander Aring <alex.aring@gmail.com>,
	Jukka Rissanen <jukka.rissanen@linux.intel.com>,
	linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] 6lowpan: fix debugfs_simple_attr.cocci warnings
Date: Mon, 24 Dec 2018 11:12:58 -0500	[thread overview]
Message-ID: <20181224161258.gvvq25k3ufuyt3ej@x220t> (raw)
In-Reply-To: <1545274433-146957-1-git-send-email-yuehaibing@huawei.com>

Hi,

On Thu, Dec 20, 2018 at 02:53:53AM +0000, YueHaibing wrote:
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
> 
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
> 

Ok.

> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Alexander Aring <aring@mojatatu.com>

Reminder to myself: We should finally move this crap away which is even
not net namespace aware and introduce a stable uapi. I would love to see
it that it can be controlled by iproute2. :-)

- Alex

WARNING: multiple messages have this Message-ID (diff)
From: Alexander Aring <aring@mojatatu.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Alexander Aring <alex.aring@gmail.com>,
	Jukka Rissanen <jukka.rissanen@linux.intel.com>,
	linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] 6lowpan: fix debugfs_simple_attr.cocci warnings
Date: Mon, 24 Dec 2018 16:12:58 +0000	[thread overview]
Message-ID: <20181224161258.gvvq25k3ufuyt3ej@x220t> (raw)
In-Reply-To: <1545274433-146957-1-git-send-email-yuehaibing@huawei.com>

Hi,

On Thu, Dec 20, 2018 at 02:53:53AM +0000, YueHaibing wrote:
> Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE
> for debugfs files.
> 
> Semantic patch information:
> Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file()
> imposes some significant overhead as compared to
> DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe().
> 

Ok.

> Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Alexander Aring <aring@mojatatu.com>

Reminder to myself: We should finally move this crap away which is even
not net namespace aware and introduce a stable uapi. I would love to see
it that it can be controlled by iproute2. :-)

- Alex

  reply	other threads:[~2018-12-24 16:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-20  2:53 [PATCH net-next] 6lowpan: fix debugfs_simple_attr.cocci warnings YueHaibing
2018-12-20  2:53 ` YueHaibing
2018-12-24 16:12 ` Alexander Aring [this message]
2018-12-24 16:12   ` Alexander Aring
2019-01-14 18:52   ` Stefan Schmidt
2019-01-14 18:52     ` Stefan Schmidt
2019-01-18  9:10 ` Marcel Holtmann
2019-01-18  9:10   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181224161258.gvvq25k3ufuyt3ej@x220t \
    --to=aring@mojatatu.com \
    --cc=alex.aring@gmail.com \
    --cc=jukka.rissanen@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.