* [PATCH] hid: Add checks to fix of_led_classdev_register
@ 2018-12-24 21:39 Aditya Pakki
2019-01-03 10:30 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Pakki @ 2018-12-24 21:39 UTC (permalink / raw)
To: pakki001; +Cc: kjlu, Jiri Kosina, Benjamin Tissoires, linux-input, linux-kernel
In lenovo_probe_tpkbd(), the function of_led_classdev_register() could
return an error value that is unchecked. The fix adds these checks.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/hid/hid-lenovo.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/hid-lenovo.c b/drivers/hid/hid-lenovo.c
index 643b6eb54442..eacc76d2ab96 100644
--- a/drivers/hid/hid-lenovo.c
+++ b/drivers/hid/hid-lenovo.c
@@ -743,7 +743,9 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev)
data_pointer->led_mute.brightness_get = lenovo_led_brightness_get_tpkbd;
data_pointer->led_mute.brightness_set = lenovo_led_brightness_set_tpkbd;
data_pointer->led_mute.dev = dev;
- led_classdev_register(dev, &data_pointer->led_mute);
+ ret = led_classdev_register(dev, &data_pointer->led_mute);
+ if (ret < 0)
+ goto err;
data_pointer->led_micmute.name = name_micmute;
data_pointer->led_micmute.brightness_get =
@@ -751,7 +753,11 @@ static int lenovo_probe_tpkbd(struct hid_device *hdev)
data_pointer->led_micmute.brightness_set =
lenovo_led_brightness_set_tpkbd;
data_pointer->led_micmute.dev = dev;
- led_classdev_register(dev, &data_pointer->led_micmute);
+ ret = led_classdev_register(dev, &data_pointer->led_micmute);
+ if (ret < 0) {
+ led_classdev_unregister(&data_pointer->led_mute);
+ goto err;
+ }
lenovo_features_set_tpkbd(hdev);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hid: Add checks to fix of_led_classdev_register
2018-12-24 21:39 [PATCH] hid: Add checks to fix of_led_classdev_register Aditya Pakki
@ 2019-01-03 10:30 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2019-01-03 10:30 UTC (permalink / raw)
To: Aditya Pakki; +Cc: kjlu, Benjamin Tissoires, linux-input, linux-kernel
On Mon, 24 Dec 2018, Aditya Pakki wrote:
> In lenovo_probe_tpkbd(), the function of_led_classdev_register() could
> return an error value that is unchecked. The fix adds these checks.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-03 10:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-24 21:39 [PATCH] hid: Add checks to fix of_led_classdev_register Aditya Pakki
2019-01-03 10:30 ` Jiri Kosina
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.