From: Kangjie Lu <kjlu@umn.edu> To: kjlu@umn.edu Cc: pakki001@umn.edu, Jingoo Han <jingoohan1@gmail.com>, Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Bjorn Helgaas <bhelgaas@google.com>, Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] pci: dwc: add a check for resetting gpio Date: Tue, 25 Dec 2018 20:22:36 -0600 [thread overview] Message-ID: <20181226022236.71682-1-kjlu@umn.edu> (raw) devm_gpio_request_one() could fail. The fix checks its status and issues an error if it fails. Signed-off-by: Kangjie Lu <kjlu@umn.edu> --- drivers/pci/controller/dwc/pci-exynos.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c index cee5f2f590e2..e3a045e215d2 100644 --- a/drivers/pci/controller/dwc/pci-exynos.c +++ b/drivers/pci/controller/dwc/pci-exynos.c @@ -226,9 +226,12 @@ static void exynos_pcie_assert_reset(struct exynos_pcie *ep) struct dw_pcie *pci = ep->pci; struct device *dev = pci->dev; - if (ep->reset_gpio >= 0) - devm_gpio_request_one(dev, ep->reset_gpio, - GPIOF_OUT_INIT_HIGH, "RESET"); + if (ep->reset_gpio >= 0) { + if (devm_gpio_request_one(dev, ep->reset_gpio, + GPIOF_OUT_INIT_HIGH, "RESET")) + dev_err(dev, "Failed requesting reset gpio %d\n", + ep->reset_gpio); + } } static int exynos_pcie_establish_link(struct exynos_pcie *ep) -- 2.17.2 (Apple Git-113)
WARNING: multiple messages have this Message-ID (diff)
From: Kangjie Lu <kjlu@umn.edu> To: kjlu@umn.edu Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Jingoo Han <jingoohan1@gmail.com>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>, linux-samsung-soc@vger.kernel.org, Kukjin Kim <kgene@kernel.org>, pakki001@umn.edu, Bjorn Helgaas <bhelgaas@google.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH] pci: dwc: add a check for resetting gpio Date: Tue, 25 Dec 2018 20:22:36 -0600 [thread overview] Message-ID: <20181226022236.71682-1-kjlu@umn.edu> (raw) devm_gpio_request_one() could fail. The fix checks its status and issues an error if it fails. Signed-off-by: Kangjie Lu <kjlu@umn.edu> --- drivers/pci/controller/dwc/pci-exynos.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c index cee5f2f590e2..e3a045e215d2 100644 --- a/drivers/pci/controller/dwc/pci-exynos.c +++ b/drivers/pci/controller/dwc/pci-exynos.c @@ -226,9 +226,12 @@ static void exynos_pcie_assert_reset(struct exynos_pcie *ep) struct dw_pcie *pci = ep->pci; struct device *dev = pci->dev; - if (ep->reset_gpio >= 0) - devm_gpio_request_one(dev, ep->reset_gpio, - GPIOF_OUT_INIT_HIGH, "RESET"); + if (ep->reset_gpio >= 0) { + if (devm_gpio_request_one(dev, ep->reset_gpio, + GPIOF_OUT_INIT_HIGH, "RESET")) + dev_err(dev, "Failed requesting reset gpio %d\n", + ep->reset_gpio); + } } static int exynos_pcie_establish_link(struct exynos_pcie *ep) -- 2.17.2 (Apple Git-113) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2018-12-26 2:23 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-26 2:22 Kangjie Lu [this message] 2018-12-26 2:22 ` [PATCH] pci: dwc: add a check for resetting gpio Kangjie Lu 2018-12-31 20:40 ` Bjorn Helgaas 2018-12-31 20:40 ` Bjorn Helgaas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181226022236.71682-1-kjlu@umn.edu \ --to=kjlu@umn.edu \ --cc=bhelgaas@google.com \ --cc=jingoohan1@gmail.com \ --cc=kgene@kernel.org \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=pakki001@umn.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.