All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements
@ 2018-12-27 14:57 Paul Kocialkowski
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 1/6] chamelium: Fix inverted xr24 pattern paint dimensions Paul Kocialkowski
                   ` (8 more replies)
  0 siblings, 9 replies; 11+ messages in thread
From: Paul Kocialkowski @ 2018-12-27 14:57 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Eben Upton

Here are a few patches that were reviewed already as preliminary patches
in other series (bringing improvements to testing with the chamelium).

Since they should be ready for merge at this point, they are sent as a
standalone series to facilitate their inclusion.

Cheers!

Paul Kocialkowski (6):
  chamelium: Fix inverted xr24 pattern paint dimensions
  chamelium: Pass and use stride for xr24 pattern paint
  chamelium: Pass dimensions instead of mode to pattern generation
    helper
  chamelium: Pass the pattern block size as argument to helpers
  chamelium: Debug-print CRCs when comparing them and dumping frames
  lib/igt_fb: Add a check on stride alignment for pixman conversion

 lib/igt_chamelium.c   |  7 +++++++
 lib/igt_fb.c          |  4 ++++
 tests/kms_chamelium.c | 21 ++++++++++++---------
 3 files changed, 23 insertions(+), 9 deletions(-)

-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [igt-dev] [PATCH i-g-t 1/6] chamelium: Fix inverted xr24 pattern paint dimensions
  2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
@ 2018-12-27 14:57 ` Paul Kocialkowski
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 2/6] chamelium: Pass and use stride for xr24 pattern paint Paul Kocialkowski
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: Paul Kocialkowski @ 2018-12-27 14:57 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Eben Upton

The xr24 pattern for chamelium testing appears mangled when checking it
on an actual display. This is because the horizontal and vertical
display sizes are inverted when used as width and height.

Put them back in order.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 tests/kms_chamelium.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index 55b346a9e1c4..ee7580b54e69 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -518,7 +518,7 @@ static int chamelium_get_pattern_fb(data_t *data, drmModeModeInfo *mode,
 	ptr = igt_fb_map_buffer(fb->fd, fb);
 	igt_assert(ptr);
 
-	chamelium_paint_xr24_pattern(ptr, mode->vdisplay, mode->hdisplay);
+	chamelium_paint_xr24_pattern(ptr, mode->hdisplay, mode->vdisplay);
 	igt_fb_unmap_buffer(fb, ptr);
 
 	return fb_id;
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] [PATCH i-g-t 2/6] chamelium: Pass and use stride for xr24 pattern paint
  2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 1/6] chamelium: Fix inverted xr24 pattern paint dimensions Paul Kocialkowski
@ 2018-12-27 14:57 ` Paul Kocialkowski
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 3/6] chamelium: Pass dimensions instead of mode to pattern generation helper Paul Kocialkowski
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: Paul Kocialkowski @ 2018-12-27 14:57 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Eben Upton

Using the width from the selected mode is not sufficient to correctly
paint a pattern on the framebuffer memory: the stride also has to be
taken in account for proper line start alignment.

Pass the stride and use it in chamelium_paint_xr24_pattern.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 tests/kms_chamelium.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index ee7580b54e69..ebca5eefd222 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -489,7 +489,8 @@ enable_output(data_t *data,
 }
 
 static void chamelium_paint_xr24_pattern(uint32_t *data,
-					 size_t width, size_t height)
+					 size_t width, size_t height,
+					 size_t stride)
 {
 	uint32_t colors[] = { 0xff000000,
 			      0xffff0000,
@@ -500,7 +501,7 @@ static void chamelium_paint_xr24_pattern(uint32_t *data,
 
 	for (i = 0; i < height; i++)
 		for (j = 0; j < width; j++)
-			*(data + i * width + j) = colors[((j / 64) + (i / 64)) % 5];
+			*(data + i * stride / 4 + j) = colors[((j / 64) + (i / 64)) % 5];
 }
 
 static int chamelium_get_pattern_fb(data_t *data, drmModeModeInfo *mode,
@@ -518,7 +519,8 @@ static int chamelium_get_pattern_fb(data_t *data, drmModeModeInfo *mode,
 	ptr = igt_fb_map_buffer(fb->fd, fb);
 	igt_assert(ptr);
 
-	chamelium_paint_xr24_pattern(ptr, mode->hdisplay, mode->vdisplay);
+	chamelium_paint_xr24_pattern(ptr, mode->hdisplay, mode->vdisplay,
+				     fb->strides[0]);
 	igt_fb_unmap_buffer(fb, ptr);
 
 	return fb_id;
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] [PATCH i-g-t 3/6] chamelium: Pass dimensions instead of mode to pattern generation helper
  2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 1/6] chamelium: Fix inverted xr24 pattern paint dimensions Paul Kocialkowski
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 2/6] chamelium: Pass and use stride for xr24 pattern paint Paul Kocialkowski
@ 2018-12-27 14:57 ` Paul Kocialkowski
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 4/6] chamelium: Pass the pattern block size as argument to helpers Paul Kocialkowski
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: Paul Kocialkowski @ 2018-12-27 14:57 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Eben Upton

In order to reuse the pattern generation helper for overlay planes,
let's provide the pattern generation helper with the explicit dimensions
instead of the mode (that only applies to the primary plane).

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
 tests/kms_chamelium.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index ebca5eefd222..42ea490cf25a 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -504,7 +504,7 @@ static void chamelium_paint_xr24_pattern(uint32_t *data,
 			*(data + i * stride / 4 + j) = colors[((j / 64) + (i / 64)) % 5];
 }
 
-static int chamelium_get_pattern_fb(data_t *data, drmModeModeInfo *mode,
+static int chamelium_get_pattern_fb(data_t *data, size_t width, size_t height,
 				    uint32_t fourcc, struct igt_fb *fb)
 {
 	int fb_id;
@@ -512,15 +512,14 @@ static int chamelium_get_pattern_fb(data_t *data, drmModeModeInfo *mode,
 
 	igt_assert(fourcc == DRM_FORMAT_XRGB8888);
 
-	fb_id = igt_create_fb(data->drm_fd, mode->hdisplay, mode->vdisplay,
-			      fourcc, LOCAL_DRM_FORMAT_MOD_NONE, fb);
+	fb_id = igt_create_fb(data->drm_fd, width, height, fourcc,
+			      LOCAL_DRM_FORMAT_MOD_NONE, fb);
 	igt_assert(fb_id > 0);
 
 	ptr = igt_fb_map_buffer(fb->fd, fb);
 	igt_assert(ptr);
 
-	chamelium_paint_xr24_pattern(ptr, mode->hdisplay, mode->vdisplay,
-				     fb->strides[0]);
+	chamelium_paint_xr24_pattern(ptr, width, height, fb->strides[0]);
 	igt_fb_unmap_buffer(fb, ptr);
 
 	return fb_id;
@@ -537,7 +536,7 @@ static void do_test_display_crc(data_t *data, struct chamelium_port *port,
 	int i, fb_id, captured_frame_count;
 	int frame_id;
 
-	fb_id = chamelium_get_pattern_fb(data, mode,
+	fb_id = chamelium_get_pattern_fb(data, mode->hdisplay, mode->vdisplay,
 					 DRM_FORMAT_XRGB8888, &fb);
 	igt_assert(fb_id > 0);
 
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] [PATCH i-g-t 4/6] chamelium: Pass the pattern block size as argument to helpers
  2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
                   ` (2 preceding siblings ...)
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 3/6] chamelium: Pass dimensions instead of mode to pattern generation helper Paul Kocialkowski
@ 2018-12-27 14:57 ` Paul Kocialkowski
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 5/6] chamelium: Debug-print CRCs when comparing them and dumping frames Paul Kocialkowski
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: Paul Kocialkowski @ 2018-12-27 14:57 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Eben Upton

This adds a new block size argument to the pattern generation helpers so
that different sizes of blocks can be used.

In the future, this allows us to use different block sizes when testing
overlay planes, making it visually explicit what is part of the main
plane and what is part of the overlay plane.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
 tests/kms_chamelium.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/tests/kms_chamelium.c b/tests/kms_chamelium.c
index 42ea490cf25a..2d848c2f0620 100644
--- a/tests/kms_chamelium.c
+++ b/tests/kms_chamelium.c
@@ -490,7 +490,7 @@ enable_output(data_t *data,
 
 static void chamelium_paint_xr24_pattern(uint32_t *data,
 					 size_t width, size_t height,
-					 size_t stride)
+					 size_t stride, size_t block_size)
 {
 	uint32_t colors[] = { 0xff000000,
 			      0xffff0000,
@@ -501,11 +501,12 @@ static void chamelium_paint_xr24_pattern(uint32_t *data,
 
 	for (i = 0; i < height; i++)
 		for (j = 0; j < width; j++)
-			*(data + i * stride / 4 + j) = colors[((j / 64) + (i / 64)) % 5];
+			*(data + i * stride / 4 + j) = colors[((j / block_size) + (i / block_size)) % 5];
 }
 
 static int chamelium_get_pattern_fb(data_t *data, size_t width, size_t height,
-				    uint32_t fourcc, struct igt_fb *fb)
+				    uint32_t fourcc, size_t block_size,
+				    struct igt_fb *fb)
 {
 	int fb_id;
 	void *ptr;
@@ -519,7 +520,8 @@ static int chamelium_get_pattern_fb(data_t *data, size_t width, size_t height,
 	ptr = igt_fb_map_buffer(fb->fd, fb);
 	igt_assert(ptr);
 
-	chamelium_paint_xr24_pattern(ptr, width, height, fb->strides[0]);
+	chamelium_paint_xr24_pattern(ptr, width, height, fb->strides[0],
+				     block_size);
 	igt_fb_unmap_buffer(fb, ptr);
 
 	return fb_id;
@@ -537,7 +539,7 @@ static void do_test_display_crc(data_t *data, struct chamelium_port *port,
 	int frame_id;
 
 	fb_id = chamelium_get_pattern_fb(data, mode->hdisplay, mode->vdisplay,
-					 DRM_FORMAT_XRGB8888, &fb);
+					 DRM_FORMAT_XRGB8888, 64, &fb);
 	igt_assert(fb_id > 0);
 
 	frame_id = igt_fb_convert(&frame_fb, &fb, fourcc);
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] [PATCH i-g-t 5/6] chamelium: Debug-print CRCs when comparing them and dumping frames
  2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
                   ` (3 preceding siblings ...)
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 4/6] chamelium: Pass the pattern block size as argument to helpers Paul Kocialkowski
@ 2018-12-27 14:57 ` Paul Kocialkowski
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 6/6] lib/igt_fb: Add a check on stride alignment for pixman conversion Paul Kocialkowski
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: Paul Kocialkowski @ 2018-12-27 14:57 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Eben Upton

Add debug prints for the reference and captured CRCs when comparing them
and dumping them, which can be useful to get an idea of what is going on
(e.g. specific noise on display cables often only changes one of the
values that compose the CRC).

It's also useful to associate a test debug output with the dumped
pictures (that have the CRC in their name).

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
Reviewed-by: Lyude Paul <lyude@redhat.com>
---
 lib/igt_chamelium.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/lib/igt_chamelium.c b/lib/igt_chamelium.c
index d136fb04c342..32b859eac4a7 100644
--- a/lib/igt_chamelium.c
+++ b/lib/igt_chamelium.c
@@ -1033,6 +1033,9 @@ void chamelium_assert_crc_eq_or_dump(struct chamelium *chamelium,
 	char *capture_suffix;
 	bool eq;
 
+	igt_debug("Reference CRC: %s\n", igt_crc_to_string(reference_crc));
+	igt_debug("Captured CRC: %s\n", igt_crc_to_string(capture_crc));
+
 	eq = igt_check_crc_equal(reference_crc, capture_crc);
 	if (!eq && igt_frame_dump_is_enabled()) {
 		/* Grab the reference frame from framebuffer */
@@ -1101,6 +1104,10 @@ void chamelium_assert_analog_frame_match_or_dump(struct chamelium *chamelium,
 		capture_crc = chamelium_get_crc_for_area(chamelium, port, 0, 0,
 							 0, 0);
 
+		igt_debug("Reference CRC: %s\n",
+			  igt_crc_to_string(reference_crc));
+		igt_debug("Captured CRC: %s\n", igt_crc_to_string(capture_crc));
+
 		reference_suffix = igt_crc_to_string_extended(reference_crc,
 							      '-', 2);
 		capture_suffix = igt_crc_to_string_extended(capture_crc, '-',
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] [PATCH i-g-t 6/6] lib/igt_fb: Add a check on stride alignment for pixman conversion
  2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
                   ` (4 preceding siblings ...)
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 5/6] chamelium: Debug-print CRCs when comparing them and dumping frames Paul Kocialkowski
@ 2018-12-27 14:57 ` Paul Kocialkowski
  2018-12-27 16:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Preliminary patches for chamelium improvements Patchwork
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 11+ messages in thread
From: Paul Kocialkowski @ 2018-12-27 14:57 UTC (permalink / raw)
  To: igt-dev; +Cc: Petri Latvala, Eben Upton

Pixman requires buffer strides the be aligned to 32-bit words in order
to create internal representations of buffers. If this condition is not
met, it will fail and IGT will not be able to report the error cause,
making it hard to debug the issue.

Add an explicit check in our code prior to calling pixman when
converting buffer so that the error can be understood if it occurs.

Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Reviewed-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 lib/igt_fb.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 2f555c955acf..8244e5176a6f 100644
--- a/lib/igt_fb.c
+++ b/lib/igt_fb.c
@@ -1981,6 +1981,10 @@ static void convert_pixman(struct fb_convert *cvt)
 	igt_assert((src_pixman != PIXMAN_invalid) &&
 		   (dst_pixman != PIXMAN_invalid));
 
+	/* Pixman requires the stride to be aligned to 32 bits. */
+	igt_assert((cvt->src.fb->strides[0] % sizeof(uint32_t)) == 0);
+	igt_assert((cvt->dst.fb->strides[0] % sizeof(uint32_t)) == 0);
+
 	src_ptr = convert_src_get(cvt);
 
 	src_image = pixman_image_create_bits(src_pixman,
-- 
2.20.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for Preliminary patches for chamelium improvements
  2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
                   ` (5 preceding siblings ...)
  2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 6/6] lib/igt_fb: Add a check on stride alignment for pixman conversion Paul Kocialkowski
@ 2018-12-27 16:01 ` Patchwork
  2018-12-27 17:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  2018-12-31  8:35 ` [igt-dev] [PATCH i-g-t 0/6] " Arkadiusz Hiler
  8 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-12-27 16:01 UTC (permalink / raw)
  To: Paul Kocialkowski; +Cc: igt-dev

== Series Details ==

Series: Preliminary patches for chamelium improvements
URL   : https://patchwork.freedesktop.org/series/54501/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5343 -> IGTPW_2179
====================================================

Summary
-------

  **WARNING**

  Minor unknown changes coming with IGTPW_2179 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2179, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/54501/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2179:

### IGT changes ###

#### Warnings ####

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-c:
    - fi-kbl-7567u:       PASS -> SKIP +33

  
Known issues
------------

  Here are the changes found in IGTPW_2179 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@kms_chamelium@hdmi-hpd-fast:
    - fi-kbl-7500u:       PASS -> FAIL [fdo#108767]

  * {igt@runner@aborted}:
    - fi-icl-y:           NOTRUN -> FAIL [fdo#108915]

  
#### Possible fixes ####

  * igt@gem_ctx_create@basic-files:
    - fi-bsw-kefka:       INCOMPLETE [fdo#105876] / [fdo#108714] -> PASS

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  * igt@i915_selftest@live_contexts:
    - fi-byt-j1900:       DMESG-WARN -> PASS

  
#### Warnings ####

  * igt@i915_selftest@live_contexts:
    - fi-icl-u2:          INCOMPLETE [fdo#108315] -> DMESG-FAIL [fdo#108569]

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#105876]: https://bugs.freedesktop.org/show_bug.cgi?id=105876
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108315]: https://bugs.freedesktop.org/show_bug.cgi?id=108315
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#108714]: https://bugs.freedesktop.org/show_bug.cgi?id=108714
  [fdo#108767]: https://bugs.freedesktop.org/show_bug.cgi?id=108767
  [fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915


Participating hosts (46 -> 42)
------------------------------

  Additional (2): fi-icl-y fi-pnv-d510 
  Missing    (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


Build changes
-------------

    * IGT: IGT_4754 -> IGTPW_2179

  CI_DRM_5343: e7a162c10f4ab5e4338927ec5bc5be726ecf3e8b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2179: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2179/
  IGT_4754: a176905d46d072300ba57f29ac2b98a0228e0e2d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2179/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for Preliminary patches for chamelium improvements
  2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
                   ` (6 preceding siblings ...)
  2018-12-27 16:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Preliminary patches for chamelium improvements Patchwork
@ 2018-12-27 17:31 ` Patchwork
  2018-12-31  8:35 ` [igt-dev] [PATCH i-g-t 0/6] " Arkadiusz Hiler
  8 siblings, 0 replies; 11+ messages in thread
From: Patchwork @ 2018-12-27 17:31 UTC (permalink / raw)
  To: Paul Kocialkowski; +Cc: igt-dev

== Series Details ==

Series: Preliminary patches for chamelium improvements
URL   : https://patchwork.freedesktop.org/series/54501/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5343_full -> IGTPW_2179_full
====================================================

Summary
-------

  **WARNING**

  Minor unknown changes coming with IGTPW_2179_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2179_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/54501/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2179_full:

### IGT changes ###

#### Warnings ####

  * igt@pm_rc6_residency@rc6-accuracy:
    - shard-snb:          SKIP -> PASS

  
Known issues
------------

  Here are the changes found in IGTPW_2179_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_suspend@sysfs-reader:
    - shard-kbl:          PASS -> INCOMPLETE [fdo#103665]

  * igt@kms_cursor_crc@cursor-128x128-suspend:
    - shard-glk:          PASS -> FAIL [fdo#103232] +2
    - shard-apl:          PASS -> FAIL [fdo#103191] / [fdo#103232]

  * igt@kms_cursor_crc@cursor-256x256-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +7

  * igt@kms_cursor_crc@cursor-64x21-onscreen:
    - shard-kbl:          PASS -> FAIL [fdo#103232] +2

  * igt@kms_cursor_legacy@pipe-c-torture-bo:
    - shard-hsw:          PASS -> DMESG-WARN [fdo#107122]

  * igt@kms_draw_crc@draw-method-rgb565-render-xtiled:
    - shard-glk:          PASS -> FAIL [fdo#103184]

  * igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
    - shard-glk:          PASS -> FAIL [fdo#105363]

  * igt@kms_flip@flip-vs-modeset-vs-hang-interruptible:
    - shard-kbl:          PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +17

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-apl:          PASS -> FAIL [fdo#103167] +3

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
    - shard-glk:          PASS -> FAIL [fdo#103167] +4

  * igt@kms_frontbuffer_tracking@psr-2p-scndscrn-spr-indfb-draw-mmap-wc:
    - shard-snb:          SKIP -> INCOMPLETE [fdo#105411] / [fdo#107469]

  * igt@kms_plane_alpha_blend@pipe-a-alpha-transparant-fb:
    - shard-kbl:          NOTRUN -> FAIL [fdo#108145]

  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
    - shard-kbl:          NOTRUN -> DMESG-WARN [fdo#103558] / [fdo#105602]

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-y:
    - shard-glk:          PASS -> FAIL [fdo#103166] +1

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-apl:          PASS -> DMESG-FAIL [fdo#108950]

  * igt@kms_setmode@basic:
    - shard-kbl:          PASS -> DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#99912]

  * igt@kms_universal_plane@universal-plane-pipe-a-functional:
    - shard-apl:          PASS -> FAIL [fdo#103166]
    - shard-kbl:          PASS -> DMESG-FAIL [fdo#103166] / [fdo#103558] / [fdo#105602]

  * igt@perf_pmu@rc6-runtime-pm-long:
    - shard-kbl:          PASS -> FAIL [fdo#105010]

  
#### Possible fixes ####

  * igt@gem_ctx_isolation@vcs1-s3:
    - shard-kbl:          INCOMPLETE [fdo#103665] -> PASS +1

  * igt@gem_exec_basic@readonly-blt:
    - shard-snb:          INCOMPLETE [fdo#105411] -> PASS

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
    - shard-hsw:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_busy@extended-pageflip-hang-newfb-render-b:
    - shard-apl:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
    - shard-glk:          DMESG-WARN [fdo#107956] -> PASS

  * igt@kms_color@pipe-c-ctm-max:
    - shard-apl:          FAIL [fdo#108147] -> PASS +1

  * igt@kms_cursor_crc@cursor-64x21-sliding:
    - shard-apl:          FAIL [fdo#103232] -> PASS +3

  * igt@kms_cursor_crc@cursor-64x64-dpms:
    - shard-kbl:          FAIL [fdo#103232] -> PASS +2

  * igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled:
    - shard-glk:          FAIL [fdo#103232] -> PASS +3

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
    - shard-kbl:          FAIL [fdo#103167] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
    - shard-glk:          FAIL [fdo#103167] -> PASS +7

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
    - shard-glk:          FAIL [fdo#108145] -> PASS +1

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-yf:
    - shard-apl:          FAIL [fdo#103166] -> PASS +2

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
    - shard-glk:          FAIL [fdo#103166] -> PASS +1

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-kbl:          DMESG-WARN [fdo#105604] -> PASS
    - shard-glk:          DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS

  * igt@kms_setmode@basic:
    - shard-apl:          FAIL [fdo#99912] -> PASS

  
#### Warnings ####

  * igt@kms_color@pipe-c-ctm-max:
    - shard-kbl:          FAIL [fdo#108147] -> DMESG-WARN [fdo#103558] / [fdo#105602]

  
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103184]: https://bugs.freedesktop.org/show_bug.cgi?id=103184
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105604]: https://bugs.freedesktop.org/show_bug.cgi?id=105604
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
  [fdo#107122]: https://bugs.freedesktop.org/show_bug.cgi?id=107122
  [fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108147]: https://bugs.freedesktop.org/show_bug.cgi?id=108147
  [fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * IGT: IGT_4754 -> IGTPW_2179
    * Piglit: piglit_4509 -> None

  CI_DRM_5343: e7a162c10f4ab5e4338927ec5bc5be726ecf3e8b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2179: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2179/
  IGT_4754: a176905d46d072300ba57f29ac2b98a0228e0e2d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2179/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements
  2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
                   ` (7 preceding siblings ...)
  2018-12-27 17:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-12-31  8:35 ` Arkadiusz Hiler
  2019-01-02  8:37   ` Paul Kocialkowski
  8 siblings, 1 reply; 11+ messages in thread
From: Arkadiusz Hiler @ 2018-12-31  8:35 UTC (permalink / raw)
  To: Paul Kocialkowski; +Cc: Petri Latvala, Eben Upton, igt-dev

On Thu, Dec 27, 2018 at 03:57:35PM +0100, Paul Kocialkowski wrote:
> Here are a few patches that were reviewed already as preliminary patches
> in other series (bringing improvements to testing with the chamelium).
> 
> Since they should be ready for merge at this point, they are sent as a
> standalone series to facilitate their inclusion.
> 
> Cheers!

Thanks for the patches and the reviews. This should ease respining of
the main series, merged :-)
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements
  2018-12-31  8:35 ` [igt-dev] [PATCH i-g-t 0/6] " Arkadiusz Hiler
@ 2019-01-02  8:37   ` Paul Kocialkowski
  0 siblings, 0 replies; 11+ messages in thread
From: Paul Kocialkowski @ 2019-01-02  8:37 UTC (permalink / raw)
  To: Arkadiusz Hiler; +Cc: Petri Latvala, Eben Upton, igt-dev

Hi,

On Mon, 2018-12-31 at 10:35 +0200, Arkadiusz Hiler wrote:
> On Thu, Dec 27, 2018 at 03:57:35PM +0100, Paul Kocialkowski wrote:
> > Here are a few patches that were reviewed already as preliminary patches
> > in other series (bringing improvements to testing with the chamelium).
> > 
> > Since they should be ready for merge at this point, they are sent as a
> > standalone series to facilitate their inclusion.
> > 
> > Cheers!
> 
> Thanks for the patches and the reviews. This should ease respining of
> the main series, merged :-)

Thanks a lot for the merge, it definitely helps!

All the best,

Paul

-- 
Paul Kocialkowski, Bootlin (formerly Free Electrons)
Embedded Linux and kernel engineering
https://bootlin.com

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2019-01-02  8:37 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-27 14:57 [igt-dev] [PATCH i-g-t 0/6] Preliminary patches for chamelium improvements Paul Kocialkowski
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 1/6] chamelium: Fix inverted xr24 pattern paint dimensions Paul Kocialkowski
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 2/6] chamelium: Pass and use stride for xr24 pattern paint Paul Kocialkowski
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 3/6] chamelium: Pass dimensions instead of mode to pattern generation helper Paul Kocialkowski
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 4/6] chamelium: Pass the pattern block size as argument to helpers Paul Kocialkowski
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 5/6] chamelium: Debug-print CRCs when comparing them and dumping frames Paul Kocialkowski
2018-12-27 14:57 ` [igt-dev] [PATCH i-g-t 6/6] lib/igt_fb: Add a check on stride alignment for pixman conversion Paul Kocialkowski
2018-12-27 16:01 ` [igt-dev] ✓ Fi.CI.BAT: success for Preliminary patches for chamelium improvements Patchwork
2018-12-27 17:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-31  8:35 ` [igt-dev] [PATCH i-g-t 0/6] " Arkadiusz Hiler
2019-01-02  8:37   ` Paul Kocialkowski

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.