* [Buildroot] [PATCH 1/1] package/udisks: Fix compilation issue with missing sys/sysmacros.h
@ 2018-12-31 9:15 Vadim Kochan
2018-12-31 13:39 ` Thomas Petazzoni
2019-01-23 15:16 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Vadim Kochan @ 2018-12-31 9:15 UTC (permalink / raw)
To: buildroot
It fixes compilation error with undefined "minor", "major" and
"makedev" objects which caused by missing include of <sys/sysmacros.h>
These definitions were moved to <sys/sysmacros.h> in newer gibc.
Fixes: http://autobuild.buildroot.net/results/74a8d8c247cfc9c0024e749e1f1ac423c9e90855/
Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
---
...tion-issue-with-missing-sys-sysmacros.h-i.patch | 80 ++++++++++++++++++++++
1 file changed, 80 insertions(+)
create mode 100644 package/udisks/0003-Fix-compilation-issue-with-missing-sys-sysmacros.h-i.patch
diff --git a/package/udisks/0003-Fix-compilation-issue-with-missing-sys-sysmacros.h-i.patch b/package/udisks/0003-Fix-compilation-issue-with-missing-sys-sysmacros.h-i.patch
new file mode 100644
index 0000000000..9059a90df9
--- /dev/null
+++ b/package/udisks/0003-Fix-compilation-issue-with-missing-sys-sysmacros.h-i.patch
@@ -0,0 +1,80 @@
+From d934b0fa5ce24a8fd1987b916e435ba991c2ef64 Mon Sep 17 00:00:00 2001
+From: Vadim Kochan <vadim.kochan@petcube.com>
+Date: Mon, 31 Dec 2018 11:00:46 +0200
+Subject: [PATCH] Fix compilation issue with missing sys/sysmacros.h include
+
+Newer glibc moved linux dev definitions (major, minor, makedev) to
+<sys/sysmacros.h>
+
+Signed-off-by: Vadim Kochan <vadim.kochan@petcube.com>
+---
+ src/daemon.c | 1 +
+ src/device.c | 1 +
+ src/mount-monitor.c | 1 +
+ tools/udisks.c | 1 +
+ tools/umount-udisks.c | 1 +
+ 5 files changed, 5 insertions(+)
+
+diff --git a/src/daemon.c b/src/daemon.c
+index fafcf9a..4303a6d 100644
+--- a/src/daemon.c
++++ b/src/daemon.c
+@@ -45,6 +45,7 @@
+ #include <sys/socket.h>
+ #include <sys/un.h>
+ #include <sys/utsname.h>
++#include <sys/sysmacros.h>
+ #include <net/if_arp.h>
+ #include <fcntl.h>
+ #include <signal.h>
+diff --git a/src/device.c b/src/device.c
+index 2ae7f38..20920df 100644
+--- a/src/device.c
++++ b/src/device.c
+@@ -33,6 +33,7 @@
+ #include <sys/stat.h>
+ #include <sys/time.h>
+ #include <sys/resource.h>
++#include <sys/sysmacros.h>
+ #include <fcntl.h>
+ #include <pwd.h>
+ #include <grp.h>
+diff --git a/src/mount-monitor.c b/src/mount-monitor.c
+index 573a69c..0cfa167 100644
+--- a/src/mount-monitor.c
++++ b/src/mount-monitor.c
+@@ -29,6 +29,7 @@
+ #include <string.h>
+ #include <sys/types.h>
+ #include <sys/stat.h>
++#include <sys/sysmacros.h>
+ #include <mntent.h>
+
+ #include <glib.h>
+diff --git a/tools/udisks.c b/tools/udisks.c
+index 97e80d7..22a7d87 100644
+--- a/tools/udisks.c
++++ b/tools/udisks.c
+@@ -31,6 +31,7 @@
+ #include <sys/types.h>
+ #include <sys/stat.h>
+ #include <sys/wait.h>
++#include <sys/sysmacros.h>
+ #include <fcntl.h>
+ #include <pwd.h>
+ #include <grp.h>
+diff --git a/tools/umount-udisks.c b/tools/umount-udisks.c
+index 2813fe0..d915660 100644
+--- a/tools/umount-udisks.c
++++ b/tools/umount-udisks.c
+@@ -30,6 +30,7 @@
+ #include <string.h>
+ #include <sys/types.h>
+ #include <sys/stat.h>
++#include <sys/sysmacros.h>
+ #include <fcntl.h>
+ #include <pwd.h>
+ #include <grp.h>
+--
+2.14.1
+
--
2.14.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/udisks: Fix compilation issue with missing sys/sysmacros.h
2018-12-31 9:15 [Buildroot] [PATCH 1/1] package/udisks: Fix compilation issue with missing sys/sysmacros.h Vadim Kochan
@ 2018-12-31 13:39 ` Thomas Petazzoni
2019-01-23 15:16 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2018-12-31 13:39 UTC (permalink / raw)
To: buildroot
Hello,
On Mon, 31 Dec 2018 11:15:51 +0200, Vadim Kochan wrote:
> It fixes compilation error with undefined "minor", "major" and
> "makedev" objects which caused by missing include of <sys/sysmacros.h>
>
> These definitions were moved to <sys/sysmacros.h> in newer gibc.
It is not really that they have been moved: they were already in
sysmacros.h. However, sysmacros.h used to be included by sys/types.h,
and this inclusion got removed, so sysmacros.h must now be included
explicitly.
I fixed this in the commit log and in the patch description, made other
minor tweaks in the commit log, and applied. Thanks!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/udisks: Fix compilation issue with missing sys/sysmacros.h
2018-12-31 9:15 [Buildroot] [PATCH 1/1] package/udisks: Fix compilation issue with missing sys/sysmacros.h Vadim Kochan
2018-12-31 13:39 ` Thomas Petazzoni
@ 2019-01-23 15:16 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-01-23 15:16 UTC (permalink / raw)
To: buildroot
>>>>> "Vadim" == Vadim Kochan <vadim4j@gmail.com> writes:
> It fixes compilation error with undefined "minor", "major" and
> "makedev" objects which caused by missing include of <sys/sysmacros.h>
> These definitions were moved to <sys/sysmacros.h> in newer gibc.
> Fixes: http://autobuild.buildroot.net/results/74a8d8c247cfc9c0024e749e1f1ac423c9e90855/
> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
Committed to 2018.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-23 15:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-31 9:15 [Buildroot] [PATCH 1/1] package/udisks: Fix compilation issue with missing sys/sysmacros.h Vadim Kochan
2018-12-31 13:39 ` Thomas Petazzoni
2019-01-23 15:16 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.