* [PATCH i-g-t] i915/gem_busy: Use a non-preemptible hanging batch
@ 2018-12-31 9:22 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-12-31 9:22 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Ensure that the hangcheck notices the hanging batch by using a
non-preemptible spin batch, as some future versions of hangcheck may
allow a preemptible GPU hog to survive.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_busy.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index 76b44a5d4..eb3d3ef2b 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -427,7 +427,10 @@ static bool has_extended_busy_ioctl(int fd)
static void basic(int fd, unsigned ring, unsigned flags)
{
- igt_spin_t *spin = igt_spin_batch_new(fd, .engine = ring);
+ igt_spin_t *spin =
+ igt_spin_batch_new(fd,
+ .engine = ring,
+ .flags = IGT_SPIN_NO_PREEMPTION);
struct timespec tv;
int timeout;
bool busy;
--
2.20.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] [PATCH i-g-t] i915/gem_busy: Use a non-preemptible hanging batch
@ 2018-12-31 9:22 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2018-12-31 9:22 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Ensure that the hangcheck notices the hanging batch by using a
non-preemptible spin batch, as some future versions of hangcheck may
allow a preemptible GPU hog to survive.
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/i915/gem_busy.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
index 76b44a5d4..eb3d3ef2b 100644
--- a/tests/i915/gem_busy.c
+++ b/tests/i915/gem_busy.c
@@ -427,7 +427,10 @@ static bool has_extended_busy_ioctl(int fd)
static void basic(int fd, unsigned ring, unsigned flags)
{
- igt_spin_t *spin = igt_spin_batch_new(fd, .engine = ring);
+ igt_spin_t *spin =
+ igt_spin_batch_new(fd,
+ .engine = ring,
+ .flags = IGT_SPIN_NO_PREEMPTION);
struct timespec tv;
int timeout;
bool busy;
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for i915/gem_busy: Use a non-preemptible hanging batch
2018-12-31 9:22 ` [igt-dev] " Chris Wilson
(?)
@ 2018-12-31 10:08 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-12-31 10:08 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_busy: Use a non-preemptible hanging batch
URL : https://patchwork.freedesktop.org/series/54578/
State : success
== Summary ==
CI Bug Log - changes from IGT_4755 -> IGTPW_2181
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54578/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2181 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live_contexts:
- fi-icl-u3: NOTRUN -> DMESG-FAIL [fdo#108569]
* igt@i915_selftest@live_hangcheck:
- fi-bwr-2160: PASS -> DMESG-FAIL [fdo#108735]
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: PASS -> FAIL [fdo#103182]
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-ilk-650: PASS -> DMESG-WARN [fdo#106387]
* igt@kms_frontbuffer_tracking@basic:
- fi-icl-u2: PASS -> FAIL [fdo#103167]
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: PASS -> FAIL [fdo#103191] / [fdo#107362]
* {igt@runner@aborted}:
- fi-icl-y: NOTRUN -> FAIL [fdo#108915]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
[fdo#108735]: https://bugs.freedesktop.org/show_bug.cgi?id=108735
[fdo#108915]: https://bugs.freedesktop.org/show_bug.cgi?id=108915
Participating hosts (52 -> 47)
------------------------------
Additional (2): fi-icl-y fi-icl-u3
Missing (7): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
Build changes
-------------
* IGT: IGT_4755 -> IGTPW_2181
CI_DRM_5350: 671b7a1ef332b6a359839a5e84c1de2bd70e7899 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2181: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2181/
IGT_4755: 0ba18cf75cafb51d1e72557528de4a1be640a85c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2181/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for i915/gem_busy: Use a non-preemptible hanging batch
2018-12-31 9:22 ` [igt-dev] " Chris Wilson
(?)
(?)
@ 2018-12-31 11:36 ` Patchwork
-1 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-12-31 11:36 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: i915/gem_busy: Use a non-preemptible hanging batch
URL : https://patchwork.freedesktop.org/series/54578/
State : success
== Summary ==
CI Bug Log - changes from IGT_4755_full -> IGTPW_2181_full
====================================================
Summary
-------
**WARNING**
Minor unknown changes coming with IGTPW_2181_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_2181_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/54578/revisions/1/mbox/
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_2181_full:
### IGT changes ###
#### Possible regressions ####
* {igt@runner@aborted}:
- shard-snb: NOTRUN -> FAIL
#### Warnings ####
* igt@kms_plane_lowres@pipe-b-tiling-y:
- shard-kbl: PASS -> SKIP +3
* igt@pm_rc6_residency@rc6-accuracy:
- shard-kbl: SKIP -> PASS
- shard-snb: PASS -> SKIP
Known issues
------------
Here are the changes found in IGTPW_2181_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_suspend@debugfs-reader:
- shard-kbl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105079] / [fdo#105602]
* igt@kms_chv_cursor_fail@pipe-b-64x64-bottom-edge:
- shard-snb: PASS -> DMESG-WARN [fdo#107469]
* igt@kms_chv_cursor_fail@pipe-b-64x64-left-edge:
- shard-kbl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602]
* igt@kms_color@pipe-c-degamma:
- shard-kbl: PASS -> FAIL [fdo#104782]
- shard-apl: PASS -> FAIL [fdo#104782]
* igt@kms_cursor_crc@cursor-256x256-dpms:
- shard-glk: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_crc@cursor-256x256-suspend:
- shard-kbl: PASS -> FAIL [fdo#103191] / [fdo#103232]
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: PASS -> FAIL [fdo#103232] +3
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232] +5
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
- shard-hsw: PASS -> FAIL [fdo#105767]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
- shard-kbl: PASS -> FAIL [fdo#103167]
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
- shard-apl: PASS -> FAIL [fdo#103167] +2
* igt@kms_frontbuffer_tracking@fbc-1p-rte:
- shard-apl: PASS -> FAIL [fdo#103167] / [fdo#105682]
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: PASS -> FAIL [fdo#103167] +6
* igt@kms_plane@plane-position-covered-pipe-b-planes:
- shard-apl: PASS -> FAIL [fdo#103166]
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-max:
- shard-glk: PASS -> FAIL [fdo#108145] +1
* igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
- shard-glk: PASS -> FAIL [fdo#103166] +3
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-glk: PASS -> DMESG-FAIL [fdo#105763] / [fdo#106538]
* igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
- shard-apl: PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +2
* igt@sw_sync@sync_busy_fork:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540]
#### Possible fixes ####
* igt@i915_suspend@forcewake:
- shard-kbl: DMESG-WARN -> PASS
* igt@kms_content_protection@atomic:
- shard-kbl: FAIL [fdo#108597] -> SKIP
* igt@kms_cursor_crc@cursor-128x128-random:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: FAIL [fdo#103191] / [fdo#103232] -> PASS
- shard-kbl: FAIL [fdo#103191] / [fdo#103232] -> PASS
* igt@kms_cursor_crc@cursor-size-change:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#102887] / [fdo#105363] -> PASS
* igt@kms_flip@wf_vblank-ts-check-interruptible:
- shard-kbl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +18
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
- shard-snb: INCOMPLETE [fdo#105411] / [fdo#107469] -> PASS
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-apl: FAIL [fdo#103167] -> PASS +1
- shard-kbl: FAIL [fdo#103167] -> PASS
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-move:
- shard-glk: FAIL [fdo#103167] -> PASS +3
* igt@kms_plane@plane-position-covered-pipe-a-planes:
- shard-glk: FAIL [fdo#103166] -> PASS
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
- shard-kbl: DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#108145] -> PASS
- shard-apl: DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#108145] -> PASS
* igt@kms_plane_alpha_blend@pipe-b-alpha-opaque-fb:
- shard-glk: FAIL [fdo#108145] -> PASS +1
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +3
- shard-kbl: FAIL [fdo#103166] -> PASS +1
* igt@kms_vblank@pipe-a-query-forked-busy-hang:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> PASS +31
#### Warnings ####
* igt@kms_color@pipe-a-degamma:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> FAIL [fdo#104782] / [fdo#108145]
* igt@kms_cursor_crc@cursor-64x64-random:
- shard-apl: DMESG-WARN [fdo#103558] / [fdo#105602] -> FAIL [fdo#103232]
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-apl: DMESG-FAIL [fdo#103558] / [fdo#105602] / [fdo#108145] -> FAIL [fdo#108145]
* igt@kms_rotation_crc@multiplane-rotation-cropping-top:
- shard-apl: DMESG-WARN [fdo#108337] -> DMESG-FAIL [fdo#108950]
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#105079]: https://bugs.freedesktop.org/show_bug.cgi?id=105079
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#107469]: https://bugs.freedesktop.org/show_bug.cgi?id=107469
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108337]: https://bugs.freedesktop.org/show_bug.cgi?id=108337
[fdo#108597]: https://bugs.freedesktop.org/show_bug.cgi?id=108597
[fdo#108950]: https://bugs.freedesktop.org/show_bug.cgi?id=108950
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4755 -> IGTPW_2181
CI_DRM_5350: 671b7a1ef332b6a359839a5e84c1de2bd70e7899 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2181: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2181/
IGT_4755: 0ba18cf75cafb51d1e72557528de4a1be640a85c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2181/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH i-g-t] i915/gem_busy: Use a non-preemptible hanging batch
2018-12-31 9:22 ` [igt-dev] " Chris Wilson
@ 2019-01-02 13:03 ` Mika Kuoppala
-1 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2019-01-02 13:03 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Ensure that the hangcheck notices the hanging batch by using a
> non-preemptible spin batch, as some future versions of hangcheck may
> allow a preemptible GPU hog to survive.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> tests/i915/gem_busy.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index 76b44a5d4..eb3d3ef2b 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -427,7 +427,10 @@ static bool has_extended_busy_ioctl(int fd)
>
> static void basic(int fd, unsigned ring, unsigned flags)
> {
> - igt_spin_t *spin = igt_spin_batch_new(fd, .engine = ring);
> + igt_spin_t *spin =
> + igt_spin_batch_new(fd,
> + .engine = ring,
> + .flags = IGT_SPIN_NO_PREEMPTION);
> struct timespec tv;
> int timeout;
> bool busy;
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH i-g-t] i915/gem_busy: Use a non-preemptible hanging batch
@ 2019-01-02 13:03 ` Mika Kuoppala
0 siblings, 0 replies; 6+ messages in thread
From: Mika Kuoppala @ 2019-01-02 13:03 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
Chris Wilson <chris@chris-wilson.co.uk> writes:
> Ensure that the hangcheck notices the hanging batch by using a
> non-preemptible spin batch, as some future versions of hangcheck may
> allow a preemptible GPU hog to survive.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> ---
> tests/i915/gem_busy.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_busy.c b/tests/i915/gem_busy.c
> index 76b44a5d4..eb3d3ef2b 100644
> --- a/tests/i915/gem_busy.c
> +++ b/tests/i915/gem_busy.c
> @@ -427,7 +427,10 @@ static bool has_extended_busy_ioctl(int fd)
>
> static void basic(int fd, unsigned ring, unsigned flags)
> {
> - igt_spin_t *spin = igt_spin_batch_new(fd, .engine = ring);
> + igt_spin_t *spin =
> + igt_spin_batch_new(fd,
> + .engine = ring,
> + .flags = IGT_SPIN_NO_PREEMPTION);
> struct timespec tv;
> int timeout;
> bool busy;
> --
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-02 13:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-31 9:22 [PATCH i-g-t] i915/gem_busy: Use a non-preemptible hanging batch Chris Wilson
2018-12-31 9:22 ` [igt-dev] " Chris Wilson
2018-12-31 10:08 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-31 11:36 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-02 13:03 ` [PATCH i-g-t] " Mika Kuoppala
2019-01-02 13:03 ` [Intel-gfx] " Mika Kuoppala
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.