All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v1 0/5] WPE WebKit
@ 2018-12-31 15:49 Francois Perrad
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 1/5] libwpe: new package Francois Perrad
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Francois Perrad @ 2018-12-31 15:49 UTC (permalink / raw)
  To: buildroot

Another port of WebKit (https://wpewebkit.org/), a project started in 2018.

rfc -> v1
  - full refactor after Adrian's review
  - libwpe : version 1.0.0 (stable) instead of 1.1.0 (instable)
  - wbebackend-fdo : version 1.0.0 (stable) instead of 1.1.0 (instable)
  - add cog, a WPE WebKit launcher

Francois Perrad (5):
  libwpe: new package
  wpebackend-fdo: new package
  webkitgtk: remove GTK in WEBKITGTK_ARCH_SUPPORTS* variable names
  wpewebkit: new package
  cog: new package

 DEVELOPERS                                 |  8 +++
 package/Config.in                          |  4 ++
 package/cog/Config.in                      | 20 ++++++
 package/cog/cog.hash                       |  5 ++
 package/cog/cog.mk                         | 24 +++++++
 package/libwpe/Config.in                   | 13 ++++
 package/libwpe/libwpe.hash                 |  7 ++
 package/libwpe/libwpe.mk                   | 22 ++++++
 package/midori/Config.in                   |  4 +-
 package/webkitgtk/Config.in                |  8 +--
 package/webkitgtk/webkitgtk.mk             |  2 +-
 package/wpebackend-fdo/Config.in           | 19 +++++
 package/wpebackend-fdo/wpebackend-fdo.hash |  7 ++
 package/wpebackend-fdo/wpebackend-fdo.mk   | 15 ++++
 package/wpewebkit/Config.in                | 84 ++++++++++++++++++++++
 package/wpewebkit/wpewebkit.hash           |  8 +++
 package/wpewebkit/wpewebkit.mk             | 61 ++++++++++++++++
 17 files changed, 304 insertions(+), 7 deletions(-)
 create mode 100644 package/cog/Config.in
 create mode 100644 package/cog/cog.hash
 create mode 100644 package/cog/cog.mk
 create mode 100644 package/libwpe/Config.in
 create mode 100644 package/libwpe/libwpe.hash
 create mode 100644 package/libwpe/libwpe.mk
 create mode 100644 package/wpebackend-fdo/Config.in
 create mode 100644 package/wpebackend-fdo/wpebackend-fdo.hash
 create mode 100644 package/wpebackend-fdo/wpebackend-fdo.mk
 create mode 100644 package/wpewebkit/Config.in
 create mode 100644 package/wpewebkit/wpewebkit.hash
 create mode 100644 package/wpewebkit/wpewebkit.mk

-- 
2.17.1

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 1/5] libwpe: new package
  2018-12-31 15:49 [Buildroot] [PATCH v1 0/5] WPE WebKit Francois Perrad
@ 2018-12-31 15:49 ` Francois Perrad
  2019-02-04 14:21   ` Adrian Perez de Castro
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 2/5] wpebackend-fdo: " Francois Perrad
                   ` (4 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Francois Perrad @ 2018-12-31 15:49 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 DEVELOPERS                 |  2 ++
 package/Config.in          |  1 +
 package/libwpe/Config.in   | 13 +++++++++++++
 package/libwpe/libwpe.hash |  7 +++++++
 package/libwpe/libwpe.mk   | 22 ++++++++++++++++++++++
 5 files changed, 45 insertions(+)
 create mode 100644 package/libwpe/Config.in
 create mode 100644 package/libwpe/libwpe.hash
 create mode 100644 package/libwpe/libwpe.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 6bc0ed284..cf7e43450 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -67,6 +67,7 @@ F:	package/sngrep/
 N:	Adrian Perez de Castro <aperez@igalia.com>
 F:	package/brotli/
 F:	package/libepoxy/
+F:	package/libwpe/
 F:	package/webkitgtk/
 F:	package/woff2/
 
@@ -810,6 +811,7 @@ F:	package/gdbm/
 F:	package/libtomcrypt/
 F:	package/libtommath/
 F:	package/libump/
+F:	package/libwpe/
 F:	package/linenoise/
 F:	package/ljlinenoise/
 F:	package/lpeg/
diff --git a/package/Config.in b/package/Config.in
index 14ba545a2..ae5fefb58 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1284,6 +1284,7 @@ menu "Graphics"
 	source "package/libva-intel-driver/Config.in"
 	source "package/libvdpau/Config.in"
 	source "package/libvips/Config.in"
+	source "package/libwpe/Config.in"
 	source "package/menu-cache/Config.in"
 	source "package/opencv/Config.in"
 	source "package/opencv3/Config.in"
diff --git a/package/libwpe/Config.in b/package/libwpe/Config.in
new file mode 100644
index 000000000..c11c85398
--- /dev/null
+++ b/package/libwpe/Config.in
@@ -0,0 +1,13 @@
+comment "libwpe needs a toolchain w/ C++, dynamic library and an OpenEGL-capable backend"
+	depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS
+
+config BR2_PACKAGE_LIBWPE
+	bool "libwpe"
+	depends on !BR2_STATIC_LIBS # dlfcn.h
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_LIBXKBCOMMON
+	help
+	  Base library for the WPE WebKit port.
+
+	  https://wpewebkit.org/
diff --git a/package/libwpe/libwpe.hash b/package/libwpe/libwpe.hash
new file mode 100644
index 000000000..58dba92e6
--- /dev/null
+++ b/package/libwpe/libwpe.hash
@@ -0,0 +1,7 @@
+# From https://wpewebkit.org/releases/libwpe-1.0.0.tar.xz.sums
+md5 b5ea32bd644811d5c6433cf1439763f7 libwpe-1.0.0.tar.xz
+sha1 6e51591c00a9a6128e19920807e6874794c723fd libwpe-1.0.0.tar.xz
+sha256 aff11612123f9ab85a8b9a4bcdfb3a7503eba0a0d2d96f2cdecd30e911091719 libwpe-1.0.0.tar.xz
+
+# Hashes for license files:
+sha256 6efc9991641b47b1f4e727db7f090d0ade00117dcbbc74be622f2baceddb1f22 COPYING
diff --git a/package/libwpe/libwpe.mk b/package/libwpe/libwpe.mk
new file mode 100644
index 000000000..aad1214e1
--- /dev/null
+++ b/package/libwpe/libwpe.mk
@@ -0,0 +1,22 @@
+################################################################################
+#
+# libwpe
+#
+################################################################################
+
+LIBWPE_VERSION = 1.0.0
+LIBWPE_SITE = https://wpewebkit.org/releases
+LIBWPE_SOURCE = libwpe-$(LIBWPE_VERSION).tar.xz
+LIBWPE_INSTALL_STAGING = YES
+LIBWPE_LICENSE = BSD-2-Clause
+LIBWPE_LICENSE_FILES = COPYING
+LIBWPE_DEPENDENCIES = libegl libxkbcommon
+
+# Workaround for https://github.com/raspberrypi/userland/issues/316
+ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
+LIBWPE_CONF_OPTS += \
+	-DCMAKE_C_FLAGS='$(TARGET_CFLAGS) -D_GNU_SOURCE' \
+	-DCMAKE_CXX_FLAGS='$(TARGET_CFLAGS) -D_GNU_SOURCE'
+endif
+
+$(eval $(cmake-package))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 2/5] wpebackend-fdo: new package
  2018-12-31 15:49 [Buildroot] [PATCH v1 0/5] WPE WebKit Francois Perrad
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 1/5] libwpe: new package Francois Perrad
@ 2018-12-31 15:49 ` Francois Perrad
  2019-02-04 14:22   ` Adrian Perez de Castro
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 3/5] webkitgtk: remove GTK in WEBKITGTK_ARCH_SUPPORTS* variable names Francois Perrad
                   ` (3 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Francois Perrad @ 2018-12-31 15:49 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 DEVELOPERS                                 |  2 ++
 package/Config.in                          |  1 +
 package/wpebackend-fdo/Config.in           | 19 +++++++++++++++++++
 package/wpebackend-fdo/wpebackend-fdo.hash |  7 +++++++
 package/wpebackend-fdo/wpebackend-fdo.mk   | 15 +++++++++++++++
 5 files changed, 44 insertions(+)
 create mode 100644 package/wpebackend-fdo/Config.in
 create mode 100644 package/wpebackend-fdo/wpebackend-fdo.hash
 create mode 100644 package/wpebackend-fdo/wpebackend-fdo.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index cf7e43450..4c2fabe98 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -70,6 +70,7 @@ F:	package/libepoxy/
 F:	package/libwpe/
 F:	package/webkitgtk/
 F:	package/woff2/
+F:	package/wpebackend-fdo/
 
 N:	Adrien Gallou?t <adrien@gallouet.fr>
 F:	package/bird/
@@ -830,6 +831,7 @@ F:	package/qemu/
 F:	package/sdl2_mixer/
 F:	package/sdl2_net/
 F:	package/tekui/
+F:	package/wpebackend-fdo/
 F:	package/wsapi-fcgi/
 F:	package/wsapi-xavante/
 F:	utils/scancpan
diff --git a/package/Config.in b/package/Config.in
index ae5fefb58..e57937d57 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1303,6 +1303,7 @@ menu "Graphics"
 	source "package/webkitgtk/Config.in"
 	source "package/webp/Config.in"
 	source "package/woff2/Config.in"
+	source "package/wpebackend-fdo/Config.in"
 	source "package/zbar/Config.in"
 	source "package/zxing-cpp/Config.in"
 endmenu
diff --git a/package/wpebackend-fdo/Config.in b/package/wpebackend-fdo/Config.in
new file mode 100644
index 000000000..06392c93f
--- /dev/null
+++ b/package/wpebackend-fdo/Config.in
@@ -0,0 +1,19 @@
+comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend"
+	depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
+		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
+
+config BR2_PACKAGE_WPEBACKEND_FDO
+	bool "wpebackend-fdo"
+	depends on !BR2_STATIC_LIBS # dlfcn.h
+	depends on BR2_INSTALL_LIBSTDCPP
+	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
+	depends on BR2_USE_WCHAR # gettext
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_PACKAGE_HAS_LIBEGL
+	select BR2_PACKAGE_LIBGLIB2
+	select BR2_PACKAGE_LIBWPE
+	select BR2_PACKAGE_WAYLAND
+	help
+	  WPEBackend interface using freedesktop.org API.
+
+	  https://wpewebkit.org/
diff --git a/package/wpebackend-fdo/wpebackend-fdo.hash b/package/wpebackend-fdo/wpebackend-fdo.hash
new file mode 100644
index 000000000..20c89d324
--- /dev/null
+++ b/package/wpebackend-fdo/wpebackend-fdo.hash
@@ -0,0 +1,7 @@
+# From https://wpewebkit.org/releases/wpebackend-fdo-1.0.0.tar.xz.sums
+md5 5318728afb3bf7417293af67ce427963 wpebackend-fdo-1.0.0.tar.xz
+sha1 7ee22bc1d585616f4ad2047d8be54ec396486211 wpebackend-fdo-1.0.0.tar.xz
+sha256 7a747f87a1ae46d30144369050e3ce348b58986d04e1a139ba75c198fa636729 wpebackend-fdo-1.0.0.tar.xz
+
+# Hashes for license files:
+sha256 c9f6803371047fad3e72200ec6cd226329a5ee08ac61104c8211c2761fb46825 COPYING
diff --git a/package/wpebackend-fdo/wpebackend-fdo.mk b/package/wpebackend-fdo/wpebackend-fdo.mk
new file mode 100644
index 000000000..06c87cb9b
--- /dev/null
+++ b/package/wpebackend-fdo/wpebackend-fdo.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# wpebackend-fdo
+#
+################################################################################
+
+WPEBACKEND_FDO_VERSION = 1.0.0
+WPEBACKEND_FDO_SITE = https://wpewebkit.org/releases
+WPEBACKEND_FDO_SOURCE = wpebackend-fdo-$(WPEBACKEND_FDO_VERSION).tar.xz
+WPEBACKEND_FDO_INSTALL_STAGING = YES
+WPEBACKEND_FDO_LICENSE = BSD-2-Clause
+WPEBACKEND_FDO_LICENSE_FILES = COPYING
+WPEBACKEND_FDO_DEPENDENCIES = libglib2 libwpe wayland
+
+$(eval $(cmake-package))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 3/5] webkitgtk: remove GTK in WEBKITGTK_ARCH_SUPPORTS* variable names
  2018-12-31 15:49 [Buildroot] [PATCH v1 0/5] WPE WebKit Francois Perrad
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 1/5] libwpe: new package Francois Perrad
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 2/5] wpebackend-fdo: " Francois Perrad
@ 2018-12-31 15:49 ` Francois Perrad
  2019-02-04 14:25   ` Adrian Perez de Castro
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 4/5] wpewebkit: new package Francois Perrad
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 12+ messages in thread
From: Francois Perrad @ 2018-12-31 15:49 UTC (permalink / raw)
  To: buildroot

there are common for the GTK & WPE ports of WebKit

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/midori/Config.in       | 4 ++--
 package/webkitgtk/Config.in    | 8 ++++----
 package/webkitgtk/webkitgtk.mk | 2 +-
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/package/midori/Config.in b/package/midori/Config.in
index f0767c85f..460fc6fbf 100644
--- a/package/midori/Config.in
+++ b/package/midori/Config.in
@@ -1,5 +1,5 @@
 comment "midori needs libgtk3 and a glibc toolchain w/ C++, gcc >= 6, host gcc >= 4.8"
-	depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
 	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_LIBGTK3 || \
 		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_6 || \
 		!BR2_TOOLCHAIN_USES_GLIBC
@@ -12,7 +12,7 @@ config BR2_PACKAGE_MIDORI
 	depends on BR2_HOST_GCC_AT_LEAST_4_8 # webkitgtk -> icu
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_6 # webkitgtk
 	depends on BR2_TOOLCHAIN_USES_GLIBC # webkitgtk
-	depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
 	# GCR can only be used with the X11 backend
 	select BR2_PACKAGE_GCR if BR2_PACKAGE_LIBGTK3_X11
 	select BR2_PACKAGE_GRANITE
diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
index 8714677b6..3e5e8d7b6 100644
--- a/package/webkitgtk/Config.in
+++ b/package/webkitgtk/Config.in
@@ -1,4 +1,4 @@
-config BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
+config BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
 	bool
 	# ARM needs BLX, so v5t+, BE completely untested so disabled
 	default y if BR2_arm && !BR2_ARM_CPU_ARMV4
@@ -12,7 +12,7 @@ config BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
 	depends on BR2_TOOLCHAIN_HAS_SYNC_4
 	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt
 
-config BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS_JIT
+config BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS_JIT
 	bool
 	# ARM needs NEON for JIT.
 	default y if BR2_ARM_CPU_HAS_NEON
@@ -29,7 +29,7 @@ config BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS_JIT
 	default y if BR2_mipsel && BR2_MIPS_CPU_MIPS32R5
 
 comment "webkitgtk needs libgtk3 and a glibc toolchain w/ C++, gcc >= 6, host gcc >= 4.8"
-	depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
 	depends on !BR2_PACKAGE_LIBGTK3 || !BR2_INSTALL_LIBSTDCPP || \
 		!BR2_TOOLCHAIN_USES_GLIBC || \
 		!BR2_HOST_GCC_AT_LEAST_4_8 || \
@@ -43,7 +43,7 @@ config BR2_PACKAGE_WEBKITGTK
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_6
 	depends on BR2_TOOLCHAIN_USES_GLIBC
 	depends on BR2_PACKAGE_LIBGTK3
-	depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
+	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
 	select BR2_PACKAGE_CAIRO
 	select BR2_PACKAGE_CAIRO_PNG
 	select BR2_PACKAGE_ENCHANT
diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
index 80daadd15..53d6236ca 100644
--- a/package/webkitgtk/webkitgtk.mk
+++ b/package/webkitgtk/webkitgtk.mk
@@ -27,7 +27,7 @@ WEBKITGTK_CONF_OPTS = \
 	-DUSE_LIBHYPHEN=OFF \
 	-DUSE_WOFF2=ON
 
-ifeq ($(BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS_JIT),y)
+ifeq ($(BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS_JIT),y)
 WEBKITGTK_CONF_OPTS += -DENABLE_JIT=ON
 else
 WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 4/5] wpewebkit: new package
  2018-12-31 15:49 [Buildroot] [PATCH v1 0/5] WPE WebKit Francois Perrad
                   ` (2 preceding siblings ...)
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 3/5] webkitgtk: remove GTK in WEBKITGTK_ARCH_SUPPORTS* variable names Francois Perrad
@ 2018-12-31 15:49 ` Francois Perrad
  2019-02-04 14:28   ` Adrian Perez de Castro
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 5/5] cog: " Francois Perrad
  2019-02-04 14:18 ` [Buildroot] [PATCH v1 0/5] WPE WebKit Adrian Perez de Castro
  5 siblings, 1 reply; 12+ messages in thread
From: Francois Perrad @ 2018-12-31 15:49 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 DEVELOPERS                       |  2 +
 package/Config.in                |  1 +
 package/wpewebkit/Config.in      | 84 ++++++++++++++++++++++++++++++++
 package/wpewebkit/wpewebkit.hash |  8 +++
 package/wpewebkit/wpewebkit.mk   | 61 +++++++++++++++++++++++
 5 files changed, 156 insertions(+)
 create mode 100644 package/wpewebkit/Config.in
 create mode 100644 package/wpewebkit/wpewebkit.hash
 create mode 100644 package/wpewebkit/wpewebkit.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 4c2fabe98..af392f73f 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -71,6 +71,7 @@ F:	package/libwpe/
 F:	package/webkitgtk/
 F:	package/woff2/
 F:	package/wpebackend-fdo/
+F:	package/wpewebkit/
 
 N:	Adrien Gallou?t <adrien@gallouet.fr>
 F:	package/bird/
@@ -832,6 +833,7 @@ F:	package/sdl2_mixer/
 F:	package/sdl2_net/
 F:	package/tekui/
 F:	package/wpebackend-fdo/
+F:	package/wpewebkit/
 F:	package/wsapi-fcgi/
 F:	package/wsapi-xavante/
 F:	utils/scancpan
diff --git a/package/Config.in b/package/Config.in
index e57937d57..95a61da1c 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1304,6 +1304,7 @@ menu "Graphics"
 	source "package/webp/Config.in"
 	source "package/woff2/Config.in"
 	source "package/wpebackend-fdo/Config.in"
+	source "package/wpewebkit/Config.in"
 	source "package/zbar/Config.in"
 	source "package/zxing-cpp/Config.in"
 endmenu
diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
new file mode 100644
index 000000000..0e82c0370
--- /dev/null
+++ b/package/wpewebkit/Config.in
@@ -0,0 +1,84 @@
+comment "wpewebkit needs an OpenGL ES w/ EGL backend"
+	depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL
+
+config BR2_PACKAGE_WPEWEBKIT
+	bool "wpewebkit"
+	depends on !BR2_STATIC_LIBS # dlfcn.h
+	depends on !BR2_BINFMT_FLAT # icu
+	depends on BR2_INSTALL_LIBSTDCPP # icu
+	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
+	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu
+	depends on BR2_USE_WCHAR # gettext
+	depends on BR2_PACKAGE_HAS_LIBGLES
+	depends on BR2_PACKAGE_HAS_LIBEGL
+	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
+	select BR2_PACKAGE_CAIRO
+	select BR2_PACKAGE_CAIRO_PNG
+	select BR2_PACKAGE_HARFBUZZ
+	select BR2_PACKAGE_ICU
+	select BR2_PACKAGE_JPEG
+	select BR2_PACKAGE_LIBEPOXY
+	select BR2_PACKAGE_LIBGCRYPT
+	select BR2_PACKAGE_LIBPNG
+	select BR2_PACKAGE_LIBSOUP
+	select BR2_PACKAGE_LIBTASN1
+	select BR2_PACKAGE_LIBXSLT
+	select BR2_PACKAGE_WAYLAND_PROTOCOLS
+	select BR2_PACKAGE_WEBP
+	select BR2_PACKAGE_WEBP_DEMUX
+	select BR2_PACKAGE_WPEBACKEND_FDO
+	help
+	  WPE (Web Platform for Embedded) port of the WebKit engine,
+	  to allow embedders to create simple and performant systems
+	  based on Web platform technologies.
+
+	  https://wpewebkit.org/
+
+if BR2_PACKAGE_WPEWEBKIT
+
+config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
+	bool "multimedia support"
+	select BR2_PACKAGE_GSTREAMER1
+	select BR2_PACKAGE_GST1_PLUGINS_BAD
+	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX
+	select BR2_PACKAGE_GST1_PLUGINS_BASE
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PLAYBACK
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOCONVERT
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE
+	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ISOMP4
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_RTSP
+	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
+	select BR2_PACKAGE_GST1_LIBAV
+	help
+	  This option pulls in all of the required dependencies
+	  to enable multimedia (video/audio) support.
+
+if BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
+
+config BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL
+	bool "use gstreamer-gl"
+	default y
+	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
+	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
+	help
+	  Use the GStreamer GL elements for handling video content.
+	  This is recommended as it improves performance of video
+	  playback. In some target configurations incorrect rendering
+	  might be produced, and disabling this option may help.
+
+endif
+
+config BR2_PACKAGE_WPEWEBKIT_WEBDRIVER
+	bool "WebDriver support"
+	help
+	  Enable support for WebDriver. This will build and install the
+	  WebKitWebDriver program in the target.
+
+endif
diff --git a/package/wpewebkit/wpewebkit.hash b/package/wpewebkit/wpewebkit.hash
new file mode 100644
index 000000000..39937a346
--- /dev/null
+++ b/package/wpewebkit/wpewebkit.hash
@@ -0,0 +1,8 @@
+# From https://wpewebkit.org/releases/wpewebkit-2.22.3.tar.xz.sums
+md5 6d0c693ea49a93fc9e701cf784245ea5 wpewebkit-2.22.3.tar.xz
+sha1 d8a22bec787f38939c7922dc43bf27c9144cef74 wpewebkit-2.22.3.tar.xz
+sha256 241f177cded1a4ba3088716650eaaac25588878882170789b3c630ac45dbb2fa wpewebkit-2.22.3.tar.xz
+
+# Hashes for license files:
+sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
+sha256 f2b3bd09663381deb99721109d22b47af1213bb43007a8b56a06c6375c8050ce Source/WebCore/LICENSE-LGPL-2.1
diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
new file mode 100644
index 000000000..b305e4f07
--- /dev/null
+++ b/package/wpewebkit/wpewebkit.mk
@@ -0,0 +1,61 @@
+################################################################################
+#
+# wpewebkit
+#
+################################################################################
+
+WPEWEBKIT_VERSION = 2.22.3
+WPEWEBKIT_SITE = http://www.wpewebkit.org/releases
+WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz
+WPEWEBKIT_INSTALL_STAGING = YES
+WPEWEBKIT_LICENSE = LGPL-2.1+, BSD-2-Clause
+WPEWEBKIT_LICENSE_FILES = \
+	Source/WebCore/LICENSE-APPLE \
+	Source/WebCore/LICENSE-LGPL-2.1
+WPEWEBKIT_DEPENDENCIES = host-gperf host-python host-ruby \
+	harfbuzz cairo icu jpeg libepoxy libgcrypt libgles libsoup libtasn1 \
+	libpng libxslt wayland-protocols webp wpebackend-fdo
+
+WPEWEBKIT_CONF_OPTS = \
+	-DPORT=WPE \
+	-DENABLE_API_TESTS=OFF \
+	-DENABLE_MINIBROWSER=OFF
+
+ifeq ($(BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS_JIT),y)
+WEBKITGTK_CONF_OPTS += -DENABLE_JIT=ON
+else
+WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
+WPEWEBKIT_CONF_OPTS += \
+	-DENABLE_VIDEO=ON \
+	-DENABLE_WEB_AUDIO=ON
+WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
+else
+WPEWEBKIT_CONF_OPTS += \
+	-DENABLE_VIDEO=OFF \
+	-DENABLE_WEB_AUDIO=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL),y)
+WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=ON
+WPEWEBKIT_DEPENDENCIES += gst1-plugins-bad
+else
+WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_WPEWEBKIT_WEBDRIVER),y)
+WPEWEBKIT_CONF_OPTS += -DENABLE_WEBDRIVER=ON
+else
+WPEWEBKIT_CONF_OPTS += -DENABLE_WEBDRIVER=OFF
+endif
+
+ifeq ($(BR2_PACKAGE_WOFF2),y)
+WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=ON
+WPEWEBKIT_DEPENDENCIES += woff2
+else
+WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=OFF
+endif
+
+$(eval $(cmake-package))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 5/5] cog: new package
  2018-12-31 15:49 [Buildroot] [PATCH v1 0/5] WPE WebKit Francois Perrad
                   ` (3 preceding siblings ...)
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 4/5] wpewebkit: new package Francois Perrad
@ 2018-12-31 15:49 ` Francois Perrad
  2019-02-04 14:34   ` Adrian Perez de Castro
  2019-02-04 14:18 ` [Buildroot] [PATCH v1 0/5] WPE WebKit Adrian Perez de Castro
  5 siblings, 1 reply; 12+ messages in thread
From: Francois Perrad @ 2018-12-31 15:49 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 DEVELOPERS            |  2 ++
 package/Config.in     |  1 +
 package/cog/Config.in | 20 ++++++++++++++++++++
 package/cog/cog.hash  |  5 +++++
 package/cog/cog.mk    | 24 ++++++++++++++++++++++++
 5 files changed, 52 insertions(+)
 create mode 100644 package/cog/Config.in
 create mode 100644 package/cog/cog.hash
 create mode 100644 package/cog/cog.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index af392f73f..27dc7fe44 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -66,6 +66,7 @@ F:	package/sngrep/
 
 N:	Adrian Perez de Castro <aperez@igalia.com>
 F:	package/brotli/
+F:	package/cog/
 F:	package/libepoxy/
 F:	package/libwpe/
 F:	package/webkitgtk/
@@ -807,6 +808,7 @@ F:	configs/olimex_a20_olinuxino_*
 F:	package/4th/
 F:	package/botan/
 F:	package/chipmunk/
+F:	package/cog/
 F:	package/dado/
 F:	package/ficl/
 F:	package/gdbm/
diff --git a/package/Config.in b/package/Config.in
index 95a61da1c..88c179b0e 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -259,6 +259,7 @@ endmenu
 menu "Graphic libraries and applications (graphic/text)"
 
 comment "Graphic applications"
+	source "package/cog/Config.in"
 	source "package/fswebcam/Config.in"
 	source "package/ghostscript/Config.in"
 	source "package/glmark2/Config.in"
diff --git a/package/cog/Config.in b/package/cog/Config.in
new file mode 100644
index 000000000..bd4b6acb3
--- /dev/null
+++ b/package/cog/Config.in
@@ -0,0 +1,20 @@
+config BR2_PACKAGE_COG
+	bool "cog"
+	depends on BR2_PACKAGE_WPEWEBKIT
+	help
+	  Single "window" launcher for the WebKit WPE port, and
+	  helper library for implementing WPE launcher. It does
+	  not provide any chrome, and is suitable to be used
+	  as a Web application container.
+
+if BR2_PACKAGE_COG
+
+config BR2_PACKAGE_COG_PROGRAMS_HOME_URI
+	string "home uri"
+	default "https://wpewebkit.org"
+	help
+	  Default URI to open when "cog" is launched. If an empty
+	  string is used, there is no default and the URI to open
+	  must be always specified in the command line.
+
+endif
diff --git a/package/cog/cog.hash b/package/cog/cog.hash
new file mode 100644
index 000000000..85f242413
--- /dev/null
+++ b/package/cog/cog.hash
@@ -0,0 +1,5 @@
+# Locally generated
+sha256 562ad3db11c3340f62a51df1dba44c2acfb2cf3210b2ebd2c1e2d2284ba38c2c  cog-1b83211d939c97f12331593217d2514e2e9cf0ba.tar.gz
+
+# Hashes for license files:
+sha256 e6c42d93c68b292bcccf6d2ec3e13da85df90b718ba27c2c2a01053a9d009252  COPYING
diff --git a/package/cog/cog.mk b/package/cog/cog.mk
new file mode 100644
index 000000000..00593de95
--- /dev/null
+++ b/package/cog/cog.mk
@@ -0,0 +1,24 @@
+################################################################################
+#
+# cog
+#
+################################################################################
+
+COG_VERSION = 1b83211d939c97f12331593217d2514e2e9cf0ba
+COG_SITE = $(call github,Igalia,cog,$(COG_VERSION))
+COG_DEPENDENCIES = wpewebkit wpebackend-fdo
+COG_LICENSE = MIT
+COG_LICENSE_FILES = COPYING
+COG_CONF_OPTS = \
+	-DCOG_BUILD_PROGRAMS=ON \
+	-DCOG_PLATFORM_FDO=ON \
+	-DCOG_HOME_URI='$(call qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))'
+
+ifeq ($(BR2_PACKAGE_DBUS),y)
+COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=ON
+COG_DEPENDENCIES += dbus
+else
+COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=OFF
+endif
+
+$(eval $(cmake-package))
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 0/5] WPE WebKit
  2018-12-31 15:49 [Buildroot] [PATCH v1 0/5] WPE WebKit Francois Perrad
                   ` (4 preceding siblings ...)
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 5/5] cog: " Francois Perrad
@ 2019-02-04 14:18 ` Adrian Perez de Castro
  5 siblings, 0 replies; 12+ messages in thread
From: Adrian Perez de Castro @ 2019-02-04 14:18 UTC (permalink / raw)
  To: buildroot

Hello Fran?ois,

First of all, sorry for taking quite some time in getting back to this
patch series; it caught me around the holidays and a busy start of the
year (happy 2019, by the way!). Luckily, I have some spare cycles today
after FOSDEM :)


On Mon, 31 Dec 2018 16:49:10 +0100, Francois Perrad <fperrad@gmail.com> wrote:
> Another port of WebKit (https://wpewebkit.org/), a project started in 2018.
> 
> rfc -> v1
>   - full refactor after Adrian's review
>   - libwpe : version 1.0.0 (stable) instead of 1.1.0 (instable)
>   - wbebackend-fdo : version 1.0.0 (stable) instead of 1.1.0 (instable)
>   - add cog, a WPE WebKit launcher

Some general comments about the patch set: it is looking pretty good overall,
and I have successfully built images with Cog (and all the dependencies) for
the Raspberry Pi (AArch64) and the Wandboard (ARMv7). I don't have the boards
around to boot the images, but I trust Cog works because I have been using
myself these same versions of the source packages using BR2_EXTERNAL :)

That being said, I would like to share some configuration bits among both
WebKitGTK+ and WPE WebKit, like the Config.in bits to determine whether the
target architecture supports JIT. The reason why this can be shared is that
both WebKit ports are released from the *same* upstream branch, even if the
tarballs are different. Also, major and minor version numbers (but not the
micro version number) go in tandem so it is easy to make sure things are kept
in sync: for example all WebKitGTK+ 2.22.X releases use the same source tree
as the WPE WebKit 2.22.Y versions.

I *think* that it may be acceptable to merge this patch set first, and after
that we would make a follow-up patch to share among both packages the common
parts. We talked about this during FOSDEM (mainly with Thomas) and my
impression is that we share the goal of trying to avoid the duplicated code.
Unfortunately it seems it would be much harder to also unify the QtWebKit
bits, so at first we will not be trying to include it.

> Francois Perrad (5):
>   libwpe: new package
>   wpebackend-fdo: new package
>   webkitgtk: remove GTK in WEBKITGTK_ARCH_SUPPORTS* variable names
>   wpewebkit: new package
>   cog: new package

I'll comment on each commit separately in a few moments :)

Cheers,


-Adri?n
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190204/8e56880b/attachment.asc>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 1/5] libwpe: new package
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 1/5] libwpe: new package Francois Perrad
@ 2019-02-04 14:21   ` Adrian Perez de Castro
  0 siblings, 0 replies; 12+ messages in thread
From: Adrian Perez de Castro @ 2019-02-04 14:21 UTC (permalink / raw)
  To: buildroot

On Mon, 31 Dec 2018 16:49:11 +0100, Francois Perrad <fperrad@gmail.com> wrote:

> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  DEVELOPERS                 |  2 ++
>  package/Config.in          |  1 +
>  package/libwpe/Config.in   | 13 +++++++++++++
>  package/libwpe/libwpe.hash |  7 +++++++
>  package/libwpe/libwpe.mk   | 22 ++++++++++++++++++++++
>  5 files changed, 45 insertions(+)
>  create mode 100644 package/libwpe/Config.in
>  create mode 100644 package/libwpe/libwpe.hash
>  create mode 100644 package/libwpe/libwpe.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 6bc0ed284..cf7e43450 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -67,6 +67,7 @@ F:	package/sngrep/
>  N:	Adrian Perez de Castro <aperez@igalia.com>
>  F:	package/brotli/
>  F:	package/libepoxy/
> +F:	package/libwpe/
>  F:	package/webkitgtk/
>  F:	package/woff2/
>  
> @@ -810,6 +811,7 @@ F:	package/gdbm/
>  F:	package/libtomcrypt/
>  F:	package/libtommath/
>  F:	package/libump/
> +F:	package/libwpe/
>  F:	package/linenoise/
>  F:	package/ljlinenoise/
>  F:	package/lpeg/
> diff --git a/package/Config.in b/package/Config.in
> index 14ba545a2..ae5fefb58 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1284,6 +1284,7 @@ menu "Graphics"
>  	source "package/libva-intel-driver/Config.in"
>  	source "package/libvdpau/Config.in"
>  	source "package/libvips/Config.in"
> +	source "package/libwpe/Config.in"
>  	source "package/menu-cache/Config.in"
>  	source "package/opencv/Config.in"
>  	source "package/opencv3/Config.in"
> diff --git a/package/libwpe/Config.in b/package/libwpe/Config.in
> new file mode 100644
> index 000000000..c11c85398
> --- /dev/null
> +++ b/package/libwpe/Config.in
> @@ -0,0 +1,13 @@
> +comment "libwpe needs a toolchain w/ C++, dynamic library and an OpenEGL-capable backend"
> +	depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS
> +
> +config BR2_PACKAGE_LIBWPE
> +	bool "libwpe"
> +	depends on !BR2_STATIC_LIBS # dlfcn.h
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_PACKAGE_HAS_LIBEGL
> +	select BR2_PACKAGE_LIBXKBCOMMON
> +	help
> +	  Base library for the WPE WebKit port.
> +
> +	  https://wpewebkit.org/
> diff --git a/package/libwpe/libwpe.hash b/package/libwpe/libwpe.hash
> new file mode 100644
> index 000000000..58dba92e6
> --- /dev/null
> +++ b/package/libwpe/libwpe.hash
> @@ -0,0 +1,7 @@
> +# From https://wpewebkit.org/releases/libwpe-1.0.0.tar.xz.sums
> +md5 b5ea32bd644811d5c6433cf1439763f7 libwpe-1.0.0.tar.xz
> +sha1 6e51591c00a9a6128e19920807e6874794c723fd libwpe-1.0.0.tar.xz
> +sha256 aff11612123f9ab85a8b9a4bcdfb3a7503eba0a0d2d96f2cdecd30e911091719 libwpe-1.0.0.tar.xz
> +
> +# Hashes for license files:
> +sha256 6efc9991641b47b1f4e727db7f090d0ade00117dcbbc74be622f2baceddb1f22 COPYING
> diff --git a/package/libwpe/libwpe.mk b/package/libwpe/libwpe.mk
> new file mode 100644
> index 000000000..aad1214e1
> --- /dev/null
> +++ b/package/libwpe/libwpe.mk
> @@ -0,0 +1,22 @@
> +################################################################################
> +#
> +# libwpe
> +#
> +################################################################################
> +
> +LIBWPE_VERSION = 1.0.0
> +LIBWPE_SITE = https://wpewebkit.org/releases
> +LIBWPE_SOURCE = libwpe-$(LIBWPE_VERSION).tar.xz
> +LIBWPE_INSTALL_STAGING = YES
> +LIBWPE_LICENSE = BSD-2-Clause
> +LIBWPE_LICENSE_FILES = COPYING
> +LIBWPE_DEPENDENCIES = libegl libxkbcommon
> +
> +# Workaround for https://github.com/raspberrypi/userland/issues/316
> +ifeq ($(BR2_PACKAGE_RPI_USERLAND),y)
> +LIBWPE_CONF_OPTS += \
> +	-DCMAKE_C_FLAGS='$(TARGET_CFLAGS) -D_GNU_SOURCE' \
> +	-DCMAKE_CXX_FLAGS='$(TARGET_CFLAGS) -D_GNU_SOURCE'
> +endif

I am not super happy of having to workaround an upstream bug like this, but
there's not much else we can do, so I am for having this here for now. If
somebody can come up with a better way to workaround this, please speak up :)

> +$(eval $(cmake-package))
> -- 
> 2.17.1

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190204/e9b47831/attachment.asc>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 2/5] wpebackend-fdo: new package
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 2/5] wpebackend-fdo: " Francois Perrad
@ 2019-02-04 14:22   ` Adrian Perez de Castro
  0 siblings, 0 replies; 12+ messages in thread
From: Adrian Perez de Castro @ 2019-02-04 14:22 UTC (permalink / raw)
  To: buildroot

Hi,

On Mon, 31 Dec 2018 16:49:12 +0100, Francois Perrad <fperrad@gmail.com> wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  DEVELOPERS                                 |  2 ++
>  package/Config.in                          |  1 +
>  package/wpebackend-fdo/Config.in           | 19 +++++++++++++++++++
>  package/wpebackend-fdo/wpebackend-fdo.hash |  7 +++++++
>  package/wpebackend-fdo/wpebackend-fdo.mk   | 15 +++++++++++++++
>  5 files changed, 44 insertions(+)
>  create mode 100644 package/wpebackend-fdo/Config.in
>  create mode 100644 package/wpebackend-fdo/wpebackend-fdo.hash
>  create mode 100644 package/wpebackend-fdo/wpebackend-fdo.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index cf7e43450..4c2fabe98 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -70,6 +70,7 @@ F:	package/libepoxy/
>  F:	package/libwpe/
>  F:	package/webkitgtk/
>  F:	package/woff2/
> +F:	package/wpebackend-fdo/
>  
>  N:	Adrien Gallou?t <adrien@gallouet.fr>
>  F:	package/bird/
> @@ -830,6 +831,7 @@ F:	package/qemu/
>  F:	package/sdl2_mixer/
>  F:	package/sdl2_net/
>  F:	package/tekui/
> +F:	package/wpebackend-fdo/
>  F:	package/wsapi-fcgi/
>  F:	package/wsapi-xavante/
>  F:	utils/scancpan
> diff --git a/package/Config.in b/package/Config.in
> index ae5fefb58..e57937d57 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1303,6 +1303,7 @@ menu "Graphics"
>  	source "package/webkitgtk/Config.in"
>  	source "package/webp/Config.in"
>  	source "package/woff2/Config.in"
> +	source "package/wpebackend-fdo/Config.in"
>  	source "package/zbar/Config.in"
>  	source "package/zxing-cpp/Config.in"
>  endmenu
> diff --git a/package/wpebackend-fdo/Config.in b/package/wpebackend-fdo/Config.in
> new file mode 100644
> index 000000000..06392c93f
> --- /dev/null
> +++ b/package/wpebackend-fdo/Config.in
> @@ -0,0 +1,19 @@
> +comment "wpebackend-fdo needs a toolchain w/ C++, wchar, threads, dynamic library and an OpenEGL-capable backend"
> +	depends on !BR2_PACKAGE_HAS_LIBEGL || !BR2_INSTALL_LIBSTDCPP || !BR2_USE_WCHAR \
> +		|| !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
> +
> +config BR2_PACKAGE_WPEBACKEND_FDO
> +	bool "wpebackend-fdo"
> +	depends on !BR2_STATIC_LIBS # dlfcn.h
> +	depends on BR2_INSTALL_LIBSTDCPP
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
> +	depends on BR2_USE_WCHAR # gettext
> +	depends on BR2_USE_MMU # fork()
> +	depends on BR2_PACKAGE_HAS_LIBEGL
> +	select BR2_PACKAGE_LIBGLIB2
> +	select BR2_PACKAGE_LIBWPE
> +	select BR2_PACKAGE_WAYLAND
> +	help
> +	  WPEBackend interface using freedesktop.org API.
> +
> +	  https://wpewebkit.org/
> diff --git a/package/wpebackend-fdo/wpebackend-fdo.hash b/package/wpebackend-fdo/wpebackend-fdo.hash
> new file mode 100644
> index 000000000..20c89d324
> --- /dev/null
> +++ b/package/wpebackend-fdo/wpebackend-fdo.hash
> @@ -0,0 +1,7 @@
> +# From https://wpewebkit.org/releases/wpebackend-fdo-1.0.0.tar.xz.sums
> +md5 5318728afb3bf7417293af67ce427963 wpebackend-fdo-1.0.0.tar.xz
> +sha1 7ee22bc1d585616f4ad2047d8be54ec396486211 wpebackend-fdo-1.0.0.tar.xz
> +sha256 7a747f87a1ae46d30144369050e3ce348b58986d04e1a139ba75c198fa636729 wpebackend-fdo-1.0.0.tar.xz
> +
> +# Hashes for license files:
> +sha256 c9f6803371047fad3e72200ec6cd226329a5ee08ac61104c8211c2761fb46825 COPYING
> diff --git a/package/wpebackend-fdo/wpebackend-fdo.mk b/package/wpebackend-fdo/wpebackend-fdo.mk
> new file mode 100644
> index 000000000..06c87cb9b
> --- /dev/null
> +++ b/package/wpebackend-fdo/wpebackend-fdo.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# wpebackend-fdo
> +#
> +################################################################################
> +
> +WPEBACKEND_FDO_VERSION = 1.0.0
> +WPEBACKEND_FDO_SITE = https://wpewebkit.org/releases
> +WPEBACKEND_FDO_SOURCE = wpebackend-fdo-$(WPEBACKEND_FDO_VERSION).tar.xz
> +WPEBACKEND_FDO_INSTALL_STAGING = YES
> +WPEBACKEND_FDO_LICENSE = BSD-2-Clause
> +WPEBACKEND_FDO_LICENSE_FILES = COPYING
> +WPEBACKEND_FDO_DEPENDENCIES = libglib2 libwpe wayland
> +
> +$(eval $(cmake-package))
> -- 
> 2.17.1

Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>

-Adri?n
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190204/706971bf/attachment.asc>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 3/5] webkitgtk: remove GTK in WEBKITGTK_ARCH_SUPPORTS* variable names
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 3/5] webkitgtk: remove GTK in WEBKITGTK_ARCH_SUPPORTS* variable names Francois Perrad
@ 2019-02-04 14:25   ` Adrian Perez de Castro
  0 siblings, 0 replies; 12+ messages in thread
From: Adrian Perez de Castro @ 2019-02-04 14:25 UTC (permalink / raw)
  To: buildroot

Hi,

On Mon, 31 Dec 2018 16:49:13 +0100, Francois Perrad <fperrad@gmail.com> wrote:
> there are common for the GTK & WPE ports of WebKit
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  package/midori/Config.in       | 4 ++--
>  package/webkitgtk/Config.in    | 8 ++++----
>  package/webkitgtk/webkitgtk.mk | 2 +-
>  3 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/package/midori/Config.in b/package/midori/Config.in
> index f0767c85f..460fc6fbf 100644
> --- a/package/midori/Config.in
> +++ b/package/midori/Config.in
> @@ -1,5 +1,5 @@
>  comment "midori needs libgtk3 and a glibc toolchain w/ C++, gcc >= 6, host gcc >= 4.8"
> -	depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS

In the end let's *not* rename this with this patch set, and unify the
configuration of both ?wpewebkit? and ?webkitgtk? packages in a different
patch set later.

>  	depends on !BR2_INSTALL_LIBSTDCPP || !BR2_PACKAGE_LIBGTK3 || \
>  		!BR2_HOST_GCC_AT_LEAST_4_8 || !BR2_TOOLCHAIN_GCC_AT_LEAST_6 || \
>  		!BR2_TOOLCHAIN_USES_GLIBC
> @@ -12,7 +12,7 @@ config BR2_PACKAGE_MIDORI
>  	depends on BR2_HOST_GCC_AT_LEAST_4_8 # webkitgtk -> icu
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_6 # webkitgtk
>  	depends on BR2_TOOLCHAIN_USES_GLIBC # webkitgtk
> -	depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
>  	# GCR can only be used with the X11 backend
>  	select BR2_PACKAGE_GCR if BR2_PACKAGE_LIBGTK3_X11
>  	select BR2_PACKAGE_GRANITE
> diff --git a/package/webkitgtk/Config.in b/package/webkitgtk/Config.in
> index 8714677b6..3e5e8d7b6 100644
> --- a/package/webkitgtk/Config.in
> +++ b/package/webkitgtk/Config.in
> @@ -1,4 +1,4 @@
> -config BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
> +config BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
>  	bool
>  	# ARM needs BLX, so v5t+, BE completely untested so disabled
>  	default y if BR2_arm && !BR2_ARM_CPU_ARMV4
> @@ -12,7 +12,7 @@ config BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>  	depends on BR2_PACKAGE_LIBGPG_ERROR_ARCH_SUPPORTS # libgcrypt
>  
> -config BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS_JIT
> +config BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS_JIT
>  	bool
>  	# ARM needs NEON for JIT.
>  	default y if BR2_ARM_CPU_HAS_NEON
> @@ -29,7 +29,7 @@ config BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS_JIT
>  	default y if BR2_mipsel && BR2_MIPS_CPU_MIPS32R5
>  
>  comment "webkitgtk needs libgtk3 and a glibc toolchain w/ C++, gcc >= 6, host gcc >= 4.8"
> -	depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
>  	depends on !BR2_PACKAGE_LIBGTK3 || !BR2_INSTALL_LIBSTDCPP || \
>  		!BR2_TOOLCHAIN_USES_GLIBC || \
>  		!BR2_HOST_GCC_AT_LEAST_4_8 || \
> @@ -43,7 +43,7 @@ config BR2_PACKAGE_WEBKITGTK
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_6
>  	depends on BR2_TOOLCHAIN_USES_GLIBC
>  	depends on BR2_PACKAGE_LIBGTK3
> -	depends on BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS
> +	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
>  	select BR2_PACKAGE_CAIRO
>  	select BR2_PACKAGE_CAIRO_PNG
>  	select BR2_PACKAGE_ENCHANT
> diff --git a/package/webkitgtk/webkitgtk.mk b/package/webkitgtk/webkitgtk.mk
> index 80daadd15..53d6236ca 100644
> --- a/package/webkitgtk/webkitgtk.mk
> +++ b/package/webkitgtk/webkitgtk.mk
> @@ -27,7 +27,7 @@ WEBKITGTK_CONF_OPTS = \
>  	-DUSE_LIBHYPHEN=OFF \
>  	-DUSE_WOFF2=ON
>  
> -ifeq ($(BR2_PACKAGE_WEBKITGTK_ARCH_SUPPORTS_JIT),y)
> +ifeq ($(BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS_JIT),y)
>  WEBKITGTK_CONF_OPTS += -DENABLE_JIT=ON
>  else
>  WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF
> -- 
> 2.17.1

Cheers,

-Adri?n
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190204/426d113c/attachment.asc>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 4/5] wpewebkit: new package
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 4/5] wpewebkit: new package Francois Perrad
@ 2019-02-04 14:28   ` Adrian Perez de Castro
  0 siblings, 0 replies; 12+ messages in thread
From: Adrian Perez de Castro @ 2019-02-04 14:28 UTC (permalink / raw)
  To: buildroot

Hi,

Just one small comment below...

On Mon, 31 Dec 2018 16:49:14 +0100, Francois Perrad <fperrad@gmail.com> wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  DEVELOPERS                       |  2 +
>  package/Config.in                |  1 +
>  package/wpewebkit/Config.in      | 84 ++++++++++++++++++++++++++++++++
>  package/wpewebkit/wpewebkit.hash |  8 +++
>  package/wpewebkit/wpewebkit.mk   | 61 +++++++++++++++++++++++
>  5 files changed, 156 insertions(+)
>  create mode 100644 package/wpewebkit/Config.in
>  create mode 100644 package/wpewebkit/wpewebkit.hash
>  create mode 100644 package/wpewebkit/wpewebkit.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 4c2fabe98..af392f73f 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -71,6 +71,7 @@ F:	package/libwpe/
>  F:	package/webkitgtk/
>  F:	package/woff2/
>  F:	package/wpebackend-fdo/
> +F:	package/wpewebkit/
>  
>  N:	Adrien Gallou?t <adrien@gallouet.fr>
>  F:	package/bird/
> @@ -832,6 +833,7 @@ F:	package/sdl2_mixer/
>  F:	package/sdl2_net/
>  F:	package/tekui/
>  F:	package/wpebackend-fdo/
> +F:	package/wpewebkit/
>  F:	package/wsapi-fcgi/
>  F:	package/wsapi-xavante/
>  F:	utils/scancpan
> diff --git a/package/Config.in b/package/Config.in
> index e57937d57..95a61da1c 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -1304,6 +1304,7 @@ menu "Graphics"
>  	source "package/webp/Config.in"
>  	source "package/woff2/Config.in"
>  	source "package/wpebackend-fdo/Config.in"
> +	source "package/wpewebkit/Config.in"
>  	source "package/zbar/Config.in"
>  	source "package/zxing-cpp/Config.in"
>  endmenu
> diff --git a/package/wpewebkit/Config.in b/package/wpewebkit/Config.in
> new file mode 100644
> index 000000000..0e82c0370
> --- /dev/null
> +++ b/package/wpewebkit/Config.in
> @@ -0,0 +1,84 @@
> +comment "wpewebkit needs an OpenGL ES w/ EGL backend"
> +	depends on !BR2_PACKAGE_HAS_LIBGLES || !BR2_PACKAGE_HAS_LIBEGL
> +
> +config BR2_PACKAGE_WPEWEBKIT
> +	bool "wpewebkit"
> +	depends on !BR2_STATIC_LIBS # dlfcn.h
> +	depends on !BR2_BINFMT_FLAT # icu
> +	depends on BR2_INSTALL_LIBSTDCPP # icu
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # wayland
> +	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_8 # icu
> +	depends on BR2_USE_WCHAR # gettext
> +	depends on BR2_PACKAGE_HAS_LIBGLES
> +	depends on BR2_PACKAGE_HAS_LIBEGL
> +	depends on BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS
> +	select BR2_PACKAGE_CAIRO
> +	select BR2_PACKAGE_CAIRO_PNG
> +	select BR2_PACKAGE_HARFBUZZ
> +	select BR2_PACKAGE_ICU
> +	select BR2_PACKAGE_JPEG
> +	select BR2_PACKAGE_LIBEPOXY
> +	select BR2_PACKAGE_LIBGCRYPT
> +	select BR2_PACKAGE_LIBPNG
> +	select BR2_PACKAGE_LIBSOUP
> +	select BR2_PACKAGE_LIBTASN1
> +	select BR2_PACKAGE_LIBXSLT
> +	select BR2_PACKAGE_WAYLAND_PROTOCOLS
> +	select BR2_PACKAGE_WEBP
> +	select BR2_PACKAGE_WEBP_DEMUX
> +	select BR2_PACKAGE_WPEBACKEND_FDO
> +	help
> +	  WPE (Web Platform for Embedded) port of the WebKit engine,
> +	  to allow embedders to create simple and performant systems
> +	  based on Web platform technologies.
> +
> +	  https://wpewebkit.org/
> +
> +if BR2_PACKAGE_WPEWEBKIT
> +
> +config BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
> +	bool "multimedia support"
> +	select BR2_PACKAGE_GSTREAMER1
> +	select BR2_PACKAGE_GST1_PLUGINS_BAD
> +	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_MPEGTSDEMUX
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_ALSA
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_APP
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIOCONVERT
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_AUDIORESAMPLE
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_PLAYBACK
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOCONVERT
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VIDEOSCALE
> +	select BR2_PACKAGE_GST1_PLUGINS_BASE_PLUGIN_VOLUME
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_ISOMP4
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_MATROSKA
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_RTSP
> +	select BR2_PACKAGE_GST1_PLUGINS_GOOD_PLUGIN_VPX
> +	select BR2_PACKAGE_GST1_LIBAV
> +	help
> +	  This option pulls in all of the required dependencies
> +	  to enable multimedia (video/audio) support.
> +
> +if BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA
> +
> +config BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL
> +	bool "use gstreamer-gl"
> +	default y
> +	depends on BR2_PACKAGE_GST1_PLUGINS_BASE_HAS_LIB_OPENGL
> +	select BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_GL
> +	help
> +	  Use the GStreamer GL elements for handling video content.
> +	  This is recommended as it improves performance of video
> +	  playback. In some target configurations incorrect rendering
> +	  might be produced, and disabling this option may help.
> +
> +endif
> +
> +config BR2_PACKAGE_WPEWEBKIT_WEBDRIVER
> +	bool "WebDriver support"
> +	help
> +	  Enable support for WebDriver. This will build and install the
> +	  WebKitWebDriver program in the target.
> +
> +endif
> diff --git a/package/wpewebkit/wpewebkit.hash b/package/wpewebkit/wpewebkit.hash
> new file mode 100644
> index 000000000..39937a346
> --- /dev/null
> +++ b/package/wpewebkit/wpewebkit.hash
> @@ -0,0 +1,8 @@
> +# From https://wpewebkit.org/releases/wpewebkit-2.22.3.tar.xz.sums
> +md5 6d0c693ea49a93fc9e701cf784245ea5 wpewebkit-2.22.3.tar.xz
> +sha1 d8a22bec787f38939c7922dc43bf27c9144cef74 wpewebkit-2.22.3.tar.xz
> +sha256 241f177cded1a4ba3088716650eaaac25588878882170789b3c630ac45dbb2fa wpewebkit-2.22.3.tar.xz
> +
> +# Hashes for license files:
> +sha256 0b5d3a7cc325942567373b0ecd757d07c132e0ebd7c97bfc63f7e1a76094edb4 Source/WebCore/LICENSE-APPLE
> +sha256 f2b3bd09663381deb99721109d22b47af1213bb43007a8b56a06c6375c8050ce Source/WebCore/LICENSE-LGPL-2.1
> diff --git a/package/wpewebkit/wpewebkit.mk b/package/wpewebkit/wpewebkit.mk
> new file mode 100644
> index 000000000..b305e4f07
> --- /dev/null
> +++ b/package/wpewebkit/wpewebkit.mk
> @@ -0,0 +1,61 @@
> +################################################################################
> +#
> +# wpewebkit
> +#
> +################################################################################
> +
> +WPEWEBKIT_VERSION = 2.22.3
> +WPEWEBKIT_SITE = http://www.wpewebkit.org/releases
> +WPEWEBKIT_SOURCE = wpewebkit-$(WPEWEBKIT_VERSION).tar.xz
> +WPEWEBKIT_INSTALL_STAGING = YES
> +WPEWEBKIT_LICENSE = LGPL-2.1+, BSD-2-Clause
> +WPEWEBKIT_LICENSE_FILES = \
> +	Source/WebCore/LICENSE-APPLE \
> +	Source/WebCore/LICENSE-LGPL-2.1
> +WPEWEBKIT_DEPENDENCIES = host-gperf host-python host-ruby \
> +	harfbuzz cairo icu jpeg libepoxy libgcrypt libgles libsoup libtasn1 \
> +	libpng libxslt wayland-protocols webp wpebackend-fdo
> +
> +WPEWEBKIT_CONF_OPTS = \
> +	-DPORT=WPE \
> +	-DENABLE_API_TESTS=OFF \
> +	-DENABLE_MINIBROWSER=OFF
> +
> +ifeq ($(BR2_PACKAGE_WEBKIT_ARCH_SUPPORTS_JIT),y)

Please use BR2_PACKAGE_WPEWEBKIT_ARCH_SUPPORTS_JIT. For now you can copy
the definition from ?packages/webkitgtk/Config.in?, renamed accordingly.

As I mentioned in a previous message, we would do this kind of unification
in a different patch set later :)

> +WEBKITGTK_CONF_OPTS += -DENABLE_JIT=ON
> +else
> +WEBKITGTK_CONF_OPTS += -DENABLE_JIT=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_WPEWEBKIT_MULTIMEDIA),y)
> +WPEWEBKIT_CONF_OPTS += \
> +	-DENABLE_VIDEO=ON \
> +	-DENABLE_WEB_AUDIO=ON
> +WPEWEBKIT_DEPENDENCIES += gstreamer1 gst1-libav gst1-plugins-base gst1-plugins-good
> +else
> +WPEWEBKIT_CONF_OPTS += \
> +	-DENABLE_VIDEO=OFF \
> +	-DENABLE_WEB_AUDIO=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_WPEWEBKIT_USE_GSTREAMER_GL),y)
> +WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=ON
> +WPEWEBKIT_DEPENDENCIES += gst1-plugins-bad
> +else
> +WPEWEBKIT_CONF_OPTS += -DUSE_GSTREAMER_GL=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_WPEWEBKIT_WEBDRIVER),y)
> +WPEWEBKIT_CONF_OPTS += -DENABLE_WEBDRIVER=ON
> +else
> +WPEWEBKIT_CONF_OPTS += -DENABLE_WEBDRIVER=OFF
> +endif
> +
> +ifeq ($(BR2_PACKAGE_WOFF2),y)
> +WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=ON
> +WPEWEBKIT_DEPENDENCIES += woff2
> +else
> +WPEWEBKIT_CONF_OPTS += -DUSE_WOFF2=OFF
> +endif
> +
> +$(eval $(cmake-package))
> -- 
> 2.17.1

-Adri?n
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190204/768cc3c8/attachment.asc>

^ permalink raw reply	[flat|nested] 12+ messages in thread
* [Buildroot] [PATCH v1 5/5] cog: new package
  2018-12-31 15:49 ` [Buildroot] [PATCH v1 5/5] cog: " Francois Perrad
@ 2019-02-04 14:34   ` Adrian Perez de Castro
  0 siblings, 0 replies; 12+ messages in thread
From: Adrian Perez de Castro @ 2019-02-04 14:34 UTC (permalink / raw)
  To: buildroot

Hi,

On Mon, 31 Dec 2018 16:49:15 +0100, Francois Perrad <fperrad@gmail.com> wrote:
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>  DEVELOPERS            |  2 ++
>  package/Config.in     |  1 +
>  package/cog/Config.in | 20 ++++++++++++++++++++
>  package/cog/cog.hash  |  5 +++++
>  package/cog/cog.mk    | 24 ++++++++++++++++++++++++
>  5 files changed, 52 insertions(+)
>  create mode 100644 package/cog/Config.in
>  create mode 100644 package/cog/cog.hash
>  create mode 100644 package/cog/cog.mk
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index af392f73f..27dc7fe44 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -66,6 +66,7 @@ F:	package/sngrep/
>  
>  N:	Adrian Perez de Castro <aperez@igalia.com>
>  F:	package/brotli/
> +F:	package/cog/
>  F:	package/libepoxy/
>  F:	package/libwpe/
>  F:	package/webkitgtk/
> @@ -807,6 +808,7 @@ F:	configs/olimex_a20_olinuxino_*
>  F:	package/4th/
>  F:	package/botan/
>  F:	package/chipmunk/
> +F:	package/cog/
>  F:	package/dado/
>  F:	package/ficl/
>  F:	package/gdbm/
> diff --git a/package/Config.in b/package/Config.in
> index 95a61da1c..88c179b0e 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -259,6 +259,7 @@ endmenu
>  menu "Graphic libraries and applications (graphic/text)"
>  
>  comment "Graphic applications"
> +	source "package/cog/Config.in"
>  	source "package/fswebcam/Config.in"
>  	source "package/ghostscript/Config.in"
>  	source "package/glmark2/Config.in"
> diff --git a/package/cog/Config.in b/package/cog/Config.in
> new file mode 100644
> index 000000000..bd4b6acb3
> --- /dev/null
> +++ b/package/cog/Config.in
> @@ -0,0 +1,20 @@
> +config BR2_PACKAGE_COG
> +	bool "cog"
> +	depends on BR2_PACKAGE_WPEWEBKIT
> +	help
> +	  Single "window" launcher for the WebKit WPE port, and
> +	  helper library for implementing WPE launcher. It does

?...for implementing WPE launchers.? (note the plural ?launchers?)

> +	  not provide any chrome, and is suitable to be used
> +	  as a Web application container.
> +
> +if BR2_PACKAGE_COG
> +
> +config BR2_PACKAGE_COG_PROGRAMS_HOME_URI
> +	string "home uri"
> +	default "https://wpewebkit.org"
> +	help
> +	  Default URI to open when "cog" is launched. If an empty
> +	  string is used, there is no default and the URI to open
> +	  must be always specified in the command line.
> +
> +endif
> diff --git a/package/cog/cog.hash b/package/cog/cog.hash
> new file mode 100644
> index 000000000..85f242413
> --- /dev/null
> +++ b/package/cog/cog.hash
> @@ -0,0 +1,5 @@
> +# Locally generated
> +sha256 562ad3db11c3340f62a51df1dba44c2acfb2cf3210b2ebd2c1e2d2284ba38c2c  cog-1b83211d939c97f12331593217d2514e2e9cf0ba.tar.gz
> +
> +# Hashes for license files:
> +sha256 e6c42d93c68b292bcccf6d2ec3e13da85df90b718ba27c2c2a01053a9d009252  COPYING
> diff --git a/package/cog/cog.mk b/package/cog/cog.mk
> new file mode 100644
> index 000000000..00593de95
> --- /dev/null
> +++ b/package/cog/cog.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# cog
> +#
> +################################################################################
> +
> +COG_VERSION = 1b83211d939c97f12331593217d2514e2e9cf0ba
> +COG_SITE = $(call github,Igalia,cog,$(COG_VERSION))

We have started making releases of Cog a little while ago, so let's change
this and use the tarball for version 0.2.0 instead.

> +COG_DEPENDENCIES = wpewebkit wpebackend-fdo
> +COG_LICENSE = MIT
> +COG_LICENSE_FILES = COPYING
> +COG_CONF_OPTS = \
> +	-DCOG_BUILD_PROGRAMS=ON \
> +	-DCOG_PLATFORM_FDO=ON \
> +	-DCOG_HOME_URI='$(call qstrip,$(BR2_PACKAGE_COG_PROGRAMS_HOME_URI))'
> +
> +ifeq ($(BR2_PACKAGE_DBUS),y)
> +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=ON
> +COG_DEPENDENCIES += dbus
> +else
> +COG_CONF_OPTS += -DCOG_DBUS_SYSTEM_BUS=OFF
> +endif

Note that support for D-Bus is always built inside the ?cog? and ?cogctl?
binaries. By default Cog will attach itself to the user session bus. What
the COG_DBUS_SYSTEM_BUS=ON does is attaching to the system bus instead.

I would either add a new option in ?Config.in? to select the mode desired,
or not pass the option to CMake to let it pick the default setting.

> +$(eval $(cmake-package))
> -- 
> 2.17.1

-Adri?n
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190204/f5165c1b/attachment.asc>

^ permalink raw reply	[flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-02-04 14:34 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-31 15:49 [Buildroot] [PATCH v1 0/5] WPE WebKit Francois Perrad
2018-12-31 15:49 ` [Buildroot] [PATCH v1 1/5] libwpe: new package Francois Perrad
2019-02-04 14:21   ` Adrian Perez de Castro
2018-12-31 15:49 ` [Buildroot] [PATCH v1 2/5] wpebackend-fdo: " Francois Perrad
2019-02-04 14:22   ` Adrian Perez de Castro
2018-12-31 15:49 ` [Buildroot] [PATCH v1 3/5] webkitgtk: remove GTK in WEBKITGTK_ARCH_SUPPORTS* variable names Francois Perrad
2019-02-04 14:25   ` Adrian Perez de Castro
2018-12-31 15:49 ` [Buildroot] [PATCH v1 4/5] wpewebkit: new package Francois Perrad
2019-02-04 14:28   ` Adrian Perez de Castro
2018-12-31 15:49 ` [Buildroot] [PATCH v1 5/5] cog: " Francois Perrad
2019-02-04 14:34   ` Adrian Perez de Castro
2019-02-04 14:18 ` [Buildroot] [PATCH v1 0/5] WPE WebKit Adrian Perez de Castro

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.