✗ Fi.CI.CHECKPATCH: warning for Per context dynamic (sub)slice power-gating (rev9)

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: Per context dynamic (sub)slice power-gating (rev9)
URL   : https://patchwork.freedesktop.org/series/48194/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
6173c6db9d6e drm/i915/execlists: Move RPCS setup to context pin
b68d8d1c8271 drm/i915: Record the sseu configuration per-context & engine
7e96ce935e3e drm/i915/perf: lock powergating configuration to default when active
f330b772df88 drm/i915: Add timeline barrier support
fdbe39c9075f drm/i915: Expose RPCS (SSEU) configuration to userspace (Gen11 only)
-:47: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#47: 
v2: Fix offset of CTX_R_PWR_CLK_STATE in intel_lr_context_set_sseu() (Lionel)

-:502: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->min_eus_per_subslice !=
 		     device->max_eus_per_subslice'
#502: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1171:
+		if ((user->min_eus_per_subslice !=
+		     device->max_eus_per_subslice) ||
+		    (user->max_eus_per_subslice !=
+		     device->max_eus_per_subslice))

-:502: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'user->max_eus_per_subslice !=
 		     device->max_eus_per_subslice'
#502: FILE: drivers/gpu/drm/i915/i915_gem_context.c:1171:
+		if ((user->min_eus_per_subslice !=
+		     device->max_eus_per_subslice) ||
+		    (user->max_eus_per_subslice !=
+		     device->max_eus_per_subslice))

total: 0 errors, 1 warnings, 2 checks, 479 lines checked
87bed1f16308 drm/i915/icl: Support co-existence between per-context SSEU and OA
cf5f604addd7 drm/i915/selftests: Context SSEU reconfiguration tests
-:222: WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#222: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:784:
+int

-:404: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#404: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:966:
+			return -EINVAL;
+		} else {

-:411: CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#411: FILE: drivers/gpu/drm/i915/selftests/i915_gem_context.c:973:
+
+}

total: 0 errors, 2 warnings, 1 checks, 555 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx