* [Buildroot] [PATCH v2 0/2] Misc Lua package fixes
@ 2018-12-31 16:50 Thomas Petazzoni
2018-12-31 16:50 ` [Buildroot] [PATCH v2 1/2] package/lua*: drop redundant dependencies on BR2_PACKAGE_HAS_LUAINTERPRETER Thomas Petazzoni
2018-12-31 16:50 ` [Buildroot] [PATCH v2 2/2] package/lua-msgpack-native: adjust Config.in comment Thomas Petazzoni
0 siblings, 2 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2018-12-31 16:50 UTC (permalink / raw)
To: buildroot
Hello,
This is a new iteration of my Lua package fixes. They have been
rebased on master, following the merge of the Luarocks addon and the
changes to many existing Lua packages to match the output of the
addon. As part of this, lots of BR2_PACKAGE_HAS_LUAINTERPRETER have
been dropped, and only a few remain to be removed in this series.
Thanks,
Thomas
Thomas Petazzoni (2):
package/lua*: drop redundant dependencies on
BR2_PACKAGE_HAS_LUAINTERPRETER
package/lua-msgpack-native: adjust Config.in comment
package/lbase64/Config.in | 1 -
package/lua-ev/Config.in | 1 -
package/lua-msgpack-native/Config.in | 3 +--
package/luaposix/Config.in | 1 -
package/lutok/Config.in | 1 -
5 files changed, 1 insertion(+), 6 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [Buildroot] [PATCH v2 1/2] package/lua*: drop redundant dependencies on BR2_PACKAGE_HAS_LUAINTERPRETER
2018-12-31 16:50 [Buildroot] [PATCH v2 0/2] Misc Lua package fixes Thomas Petazzoni
@ 2018-12-31 16:50 ` Thomas Petazzoni
2019-01-01 7:29 ` François Perrad
2019-01-02 7:49 ` Peter Korsgaard
2018-12-31 16:50 ` [Buildroot] [PATCH v2 2/2] package/lua-msgpack-native: adjust Config.in comment Thomas Petazzoni
1 sibling, 2 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2018-12-31 16:50 UTC (permalink / raw)
To: buildroot
All the packages modified by this commit have their Config.in included
by package/Config.in inside a BR2_PACKAGE_HAS_LUAINTERPRETER &&
!BR2_STATIC_LIBS condition. Therefore, duplicating the
BR2_PACKAGE_HAS_LUAINTERPRETER condition in each of their Config.in
file is redundant and unnecessary. This commit drops such redundant
"depends on" statements.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/lbase64/Config.in | 1 -
package/lua-ev/Config.in | 1 -
package/lua-msgpack-native/Config.in | 1 -
package/luaposix/Config.in | 1 -
package/lutok/Config.in | 1 -
5 files changed, 5 deletions(-)
diff --git a/package/lbase64/Config.in b/package/lbase64/Config.in
index 34ef943aac..c836ffb5e2 100644
--- a/package/lbase64/Config.in
+++ b/package/lbase64/Config.in
@@ -1,6 +1,5 @@
config BR2_PACKAGE_LBASE64
bool "lbase64"
- depends on BR2_PACKAGE_HAS_LUAINTERPRETER
help
A base64 library for Lua
diff --git a/package/lua-ev/Config.in b/package/lua-ev/Config.in
index 52f82e1128..1e89c270a0 100644
--- a/package/lua-ev/Config.in
+++ b/package/lua-ev/Config.in
@@ -1,6 +1,5 @@
config BR2_PACKAGE_LUA_EV
bool "lua-ev"
- depends on BR2_PACKAGE_HAS_LUAINTERPRETER
select BR2_PACKAGE_LIBEV
help
Get access to the libev library from Lua.
diff --git a/package/lua-msgpack-native/Config.in b/package/lua-msgpack-native/Config.in
index 3837228fa0..8b6283cc95 100644
--- a/package/lua-msgpack-native/Config.in
+++ b/package/lua-msgpack-native/Config.in
@@ -1,6 +1,5 @@
config BR2_PACKAGE_LUA_MSGPACK_NATIVE
bool "lua-msgpack-native"
- depends on BR2_PACKAGE_HAS_LUAINTERPRETER
depends on BR2_PACKAGE_LUA_5_1 || BR2_PACKAGE_LUAJIT
help
This is a native, C language implementation of msgpack
diff --git a/package/luaposix/Config.in b/package/luaposix/Config.in
index d8c30e4fb2..bdc9926b1e 100644
--- a/package/luaposix/Config.in
+++ b/package/luaposix/Config.in
@@ -1,6 +1,5 @@
config BR2_PACKAGE_LUAPOSIX
bool "luaposix"
- depends on BR2_PACKAGE_HAS_LUAINTERPRETER
select BR2_PACKAGE_LUA_STD_NORMALIZE # runtime
# "bit32" is included in Lua 5.2+. luajit has an equivalent
# "bit" module, but since it has a different name, luaposix
diff --git a/package/lutok/Config.in b/package/lutok/Config.in
index ab9c32b6d5..abeaa4011d 100644
--- a/package/lutok/Config.in
+++ b/package/lutok/Config.in
@@ -9,4 +9,3 @@ config BR2_PACKAGE_LUTOK
comment "lutok needs a toolchain w/ C++ and full Lua"
depends on !BR2_INSTALL_LIBSTDCPP || BR2_PACKAGE_LUAJIT
- depends on BR2_PACKAGE_HAS_LUAINTERPRETER
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/lua*: drop redundant dependencies on BR2_PACKAGE_HAS_LUAINTERPRETER
2018-12-31 16:50 ` [Buildroot] [PATCH v2 1/2] package/lua*: drop redundant dependencies on BR2_PACKAGE_HAS_LUAINTERPRETER Thomas Petazzoni
@ 2019-01-01 7:29 ` François Perrad
2019-01-02 7:49 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: François Perrad @ 2019-01-01 7:29 UTC (permalink / raw)
To: buildroot
Le lun. 31 d?c. 2018 ? 17:50, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
a ?crit :
> All the packages modified by this commit have their Config.in included
> by package/Config.in inside a BR2_PACKAGE_HAS_LUAINTERPRETER &&
> !BR2_STATIC_LIBS condition. Therefore, duplicating the
> BR2_PACKAGE_HAS_LUAINTERPRETER condition in each of their Config.in
> file is redundant and unnecessary. This commit drops such redundant
> "depends on" statements.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>
Acked-by: Francois Perrad <francois.perrad@gadz.org>
> ---
> package/lbase64/Config.in | 1 -
> package/lua-ev/Config.in | 1 -
> package/lua-msgpack-native/Config.in | 1 -
> package/luaposix/Config.in | 1 -
> package/lutok/Config.in | 1 -
> 5 files changed, 5 deletions(-)
>
> diff --git a/package/lbase64/Config.in b/package/lbase64/Config.in
> index 34ef943aac..c836ffb5e2 100644
> --- a/package/lbase64/Config.in
> +++ b/package/lbase64/Config.in
> @@ -1,6 +1,5 @@
> config BR2_PACKAGE_LBASE64
> bool "lbase64"
> - depends on BR2_PACKAGE_HAS_LUAINTERPRETER
> help
> A base64 library for Lua
>
> diff --git a/package/lua-ev/Config.in b/package/lua-ev/Config.in
> index 52f82e1128..1e89c270a0 100644
> --- a/package/lua-ev/Config.in
> +++ b/package/lua-ev/Config.in
> @@ -1,6 +1,5 @@
> config BR2_PACKAGE_LUA_EV
> bool "lua-ev"
> - depends on BR2_PACKAGE_HAS_LUAINTERPRETER
> select BR2_PACKAGE_LIBEV
> help
> Get access to the libev library from Lua.
> diff --git a/package/lua-msgpack-native/Config.in
> b/package/lua-msgpack-native/Config.in
> index 3837228fa0..8b6283cc95 100644
> --- a/package/lua-msgpack-native/Config.in
> +++ b/package/lua-msgpack-native/Config.in
> @@ -1,6 +1,5 @@
> config BR2_PACKAGE_LUA_MSGPACK_NATIVE
> bool "lua-msgpack-native"
> - depends on BR2_PACKAGE_HAS_LUAINTERPRETER
> depends on BR2_PACKAGE_LUA_5_1 || BR2_PACKAGE_LUAJIT
> help
> This is a native, C language implementation of msgpack
> diff --git a/package/luaposix/Config.in b/package/luaposix/Config.in
> index d8c30e4fb2..bdc9926b1e 100644
> --- a/package/luaposix/Config.in
> +++ b/package/luaposix/Config.in
> @@ -1,6 +1,5 @@
> config BR2_PACKAGE_LUAPOSIX
> bool "luaposix"
> - depends on BR2_PACKAGE_HAS_LUAINTERPRETER
> select BR2_PACKAGE_LUA_STD_NORMALIZE # runtime
> # "bit32" is included in Lua 5.2+. luajit has an equivalent
> # "bit" module, but since it has a different name, luaposix
> diff --git a/package/lutok/Config.in b/package/lutok/Config.in
> index ab9c32b6d5..abeaa4011d 100644
> --- a/package/lutok/Config.in
> +++ b/package/lutok/Config.in
> @@ -9,4 +9,3 @@ config BR2_PACKAGE_LUTOK
>
> comment "lutok needs a toolchain w/ C++ and full Lua"
> depends on !BR2_INSTALL_LIBSTDCPP || BR2_PACKAGE_LUAJIT
> - depends on BR2_PACKAGE_HAS_LUAINTERPRETER
> --
> 2.20.1
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190101/6098605d/attachment.html>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 1/2] package/lua*: drop redundant dependencies on BR2_PACKAGE_HAS_LUAINTERPRETER
2018-12-31 16:50 ` [Buildroot] [PATCH v2 1/2] package/lua*: drop redundant dependencies on BR2_PACKAGE_HAS_LUAINTERPRETER Thomas Petazzoni
2019-01-01 7:29 ` François Perrad
@ 2019-01-02 7:49 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2019-01-02 7:49 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> All the packages modified by this commit have their Config.in included
> by package/Config.in inside a BR2_PACKAGE_HAS_LUAINTERPRETER &&
> !BR2_STATIC_LIBS condition. Therefore, duplicating the
> BR2_PACKAGE_HAS_LUAINTERPRETER condition in each of their Config.in
> file is redundant and unnecessary. This commit drops such redundant
> "depends on" statements.
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Committed, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2 2/2] package/lua-msgpack-native: adjust Config.in comment
2018-12-31 16:50 [Buildroot] [PATCH v2 0/2] Misc Lua package fixes Thomas Petazzoni
2018-12-31 16:50 ` [Buildroot] [PATCH v2 1/2] package/lua*: drop redundant dependencies on BR2_PACKAGE_HAS_LUAINTERPRETER Thomas Petazzoni
@ 2018-12-31 16:50 ` Thomas Petazzoni
2019-01-02 7:49 ` Peter Korsgaard
1 sibling, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2018-12-31 16:50 UTC (permalink / raw)
To: buildroot
The Config.in comment of lua-msgpack-native only indicates that it
needs Lua 5.1, while the package can actually build with LuaJIT. This
commit adjusts the comment to match the reality.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
package/lua-msgpack-native/Config.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/lua-msgpack-native/Config.in b/package/lua-msgpack-native/Config.in
index 8b6283cc95..8af508dd95 100644
--- a/package/lua-msgpack-native/Config.in
+++ b/package/lua-msgpack-native/Config.in
@@ -7,6 +7,6 @@ config BR2_PACKAGE_LUA_MSGPACK_NATIVE
https://github.com/kengonakajima/lua-msgpack-native
-comment "lua-msgpack-native needs a Lua 5.1 interpreter"
+comment "lua-msgpack-native needs Lua 5.1 or LuaJIT"
depends on !BR2_PACKAGE_LUA_5_1
depends on !BR2_PACKAGE_LUAJIT
--
2.20.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-02 7:49 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-31 16:50 [Buildroot] [PATCH v2 0/2] Misc Lua package fixes Thomas Petazzoni
2018-12-31 16:50 ` [Buildroot] [PATCH v2 1/2] package/lua*: drop redundant dependencies on BR2_PACKAGE_HAS_LUAINTERPRETER Thomas Petazzoni
2019-01-01 7:29 ` François Perrad
2019-01-02 7:49 ` Peter Korsgaard
2018-12-31 16:50 ` [Buildroot] [PATCH v2 2/2] package/lua-msgpack-native: adjust Config.in comment Thomas Petazzoni
2019-01-02 7:49 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.