All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP] [PATCH] network/busy_poll: Change the "ethtool --show-features to "ethtool -k"
@ 2018-12-31 10:31 Sun Lianwen
  2019-01-01 13:34 ` Petr Vorel
  0 siblings, 1 reply; 2+ messages in thread
From: Sun Lianwen @ 2018-12-31 10:31 UTC (permalink / raw)
  To: ltp

To keep the same struct of "ethtool -i $(tst_iface)",
change the "ethtool --show-features" to "ethtool -k".

Signed-off-by: Sun Lianwen <sun_lianwen@163.com>
---
 testcases/network/busy_poll/busy_poll_lib.sh | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/testcases/network/busy_poll/busy_poll_lib.sh b/testcases/network/busy_poll/busy_poll_lib.sh
index 5270a1bbd..2a24ff262 100755
--- a/testcases/network/busy_poll/busy_poll_lib.sh
+++ b/testcases/network/busy_poll/busy_poll_lib.sh
@@ -22,8 +22,7 @@ busy_poll_check_config()
 	fi
 
 	if tst_kvcmp -lt "4.5"; then
-		ethtool --show-features $(tst_iface) | \
-			grep -q 'busy-poll.*on' || \
+		ethtool -k  $(tst_iface) | grep -q 'busy-poll.*on' || \
 			tst_brk TCONF "busy poll not supported by driver"
 	else
 		drvs="bnx2x|bnxt|cxgb4|enic|benet|ixgbe|ixgbevf|mlx4|mlx5|myri10ge|sfc|virtio"
-- 
2.19.0



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [LTP] [PATCH] network/busy_poll: Change the "ethtool --show-features to "ethtool -k"
  2018-12-31 10:31 [LTP] [PATCH] network/busy_poll: Change the "ethtool --show-features to "ethtool -k" Sun Lianwen
@ 2019-01-01 13:34 ` Petr Vorel
  0 siblings, 0 replies; 2+ messages in thread
From: Petr Vorel @ 2019-01-01 13:34 UTC (permalink / raw)
  To: ltp

Hi Sun,

> To keep the same struct of "ethtool -i $(tst_iface)",
> change the "ethtool --show-features" to "ethtool -k".

--show-features is the same as -k, so what is the improvement?

Kind regards,
Petr

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-01 13:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-31 10:31 [LTP] [PATCH] network/busy_poll: Change the "ethtool --show-features to "ethtool -k" Sun Lianwen
2019-01-01 13:34 ` Petr Vorel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.