[Qemu-devel] [PATCH v1] sun4u: add power_mem_read routine

* [Qemu-devel] [PATCH v1] sun4u: add power_mem_read routine
@ 2019-01-04  9:49 P J P
  0 siblings, 0 replies; only message in thread
From: P J P @ 2019-01-04  9:49 UTC (permalink / raw)
  To: Mark Cave-Ayland
  Cc: QEMU Developers, Fakhri Zulkifli, Artyom Tarasenko, Prasad J Pandit

From: Prasad J Pandit <pjp@fedoraproject.org>

Define skeleton 'power_mem_read' routine. Avoid NULL dereference.

Reported-by: Fakhri Zulkifli <mohdfakhrizulkifli@gmail.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
---
 hw/sparc64/sun4u.c | 6 ++++++
 1 file changed, 6 insertions(+)

Update v1: change return value to zero(0)
  -> https://lists.gnu.org/archive/html/qemu-devel/2019-01/msg00448.html

diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c
index f76b19e4e9..5772da02cb 100644
--- a/hw/sparc64/sun4u.c
+++ b/hw/sparc64/sun4u.c
@@ -214,6 +214,11 @@ typedef struct PowerDevice {
 } PowerDevice;
 
 /* Power */
+static uint64_t power_mem_read(void *opaque, hwaddr addr, unsigned size)
+{
+    return 0;
+}
+
 static void power_mem_write(void *opaque, hwaddr addr,
                             uint64_t val, unsigned size)
 {
@@ -224,6 +229,7 @@ static void power_mem_write(void *opaque, hwaddr addr,
 }
 
 static const MemoryRegionOps power_mem_ops = {
+    .read = power_mem_read,
     .write = power_mem_write,
     .endianness = DEVICE_NATIVE_ENDIAN,
     .valid = {
-- 
2.20.1

^ permalink raw reply related	[flat|nested] only message in thread