* [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix memory leaks
@ 2019-01-04 10:47 Edgar E. Iglesias
2019-01-04 10:47 ` [Qemu-devel] [PATCH v1 1/1] hw/arm: versal: Plug " Edgar E. Iglesias
2019-01-04 15:18 ` [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix " Peter Maydell
0 siblings, 2 replies; 4+ messages in thread
From: Edgar E. Iglesias @ 2019-01-04 10:47 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: peter.maydell, frederic.konrad, alistair, luc.michel, philmd,
frasse.iglesias, figlesia, sstabellini, sai.pavan.boddu,
edgar.iglesias
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
This series fixes the memory leaks in versal board creation
reported by Peter Maydell.
Best regards,
Edgar
Edgar E. Iglesias (1):
hw/arm: versal: Plug memory leaks
hw/arm/xlnx-versal-virt.c | 2 ++
1 file changed, 2 insertions(+)
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH v1 1/1] hw/arm: versal: Plug memory leaks
2019-01-04 10:47 [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix memory leaks Edgar E. Iglesias
@ 2019-01-04 10:47 ` Edgar E. Iglesias
2019-01-04 12:10 ` Philippe Mathieu-Daudé
2019-01-04 15:18 ` [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix " Peter Maydell
1 sibling, 1 reply; 4+ messages in thread
From: Edgar E. Iglesias @ 2019-01-04 10:47 UTC (permalink / raw)
To: qemu-devel, qemu-arm
Cc: peter.maydell, frederic.konrad, alistair, luc.michel, philmd,
frasse.iglesias, figlesia, sstabellini, sai.pavan.boddu,
edgar.iglesias
From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
Plug a couple of "board creation time" memory leaks.
Reported-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
---
hw/arm/xlnx-versal-virt.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c
index c6feeac532..f95fde2309 100644
--- a/hw/arm/xlnx-versal-virt.c
+++ b/hw/arm/xlnx-versal-virt.c
@@ -130,6 +130,7 @@ static void fdt_add_gic_nodes(VersalVirt *s)
2, MM_GIC_APU_REDIST_0_SIZE);
qemu_fdt_setprop_cell(s->fdt, nodename, "#interrupt-cells", 3);
qemu_fdt_setprop_string(s->fdt, nodename, "compatible", "arm,gic-v3");
+ g_free(nodename);
}
static void fdt_add_timer_nodes(VersalVirt *s)
@@ -364,6 +365,7 @@ static void create_virtio_regions(VersalVirt *s)
sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, pic_irq);
mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0);
memory_region_add_subregion(&s->soc.mr_ps, base, mr);
+ g_free(name);
}
for (i = 0; i < NUM_VIRTIO_TRANSPORT; i++) {
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v1 1/1] hw/arm: versal: Plug memory leaks
2019-01-04 10:47 ` [Qemu-devel] [PATCH v1 1/1] hw/arm: versal: Plug " Edgar E. Iglesias
@ 2019-01-04 12:10 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-01-04 12:10 UTC (permalink / raw)
To: Edgar E. Iglesias, qemu-devel, qemu-arm
Cc: peter.maydell, frederic.konrad, alistair, luc.michel,
frasse.iglesias, figlesia, sstabellini, sai.pavan.boddu,
edgar.iglesias
On 1/4/19 11:47 AM, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> Plug a couple of "board creation time" memory leaks.
>
Fixes 6f16da53ffe
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/arm/xlnx-versal-virt.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/arm/xlnx-versal-virt.c b/hw/arm/xlnx-versal-virt.c
> index c6feeac532..f95fde2309 100644
> --- a/hw/arm/xlnx-versal-virt.c
> +++ b/hw/arm/xlnx-versal-virt.c
> @@ -130,6 +130,7 @@ static void fdt_add_gic_nodes(VersalVirt *s)
> 2, MM_GIC_APU_REDIST_0_SIZE);
> qemu_fdt_setprop_cell(s->fdt, nodename, "#interrupt-cells", 3);
> qemu_fdt_setprop_string(s->fdt, nodename, "compatible", "arm,gic-v3");
> + g_free(nodename);
> }
>
> static void fdt_add_timer_nodes(VersalVirt *s)
> @@ -364,6 +365,7 @@ static void create_virtio_regions(VersalVirt *s)
> sysbus_connect_irq(SYS_BUS_DEVICE(dev), 0, pic_irq);
> mr = sysbus_mmio_get_region(SYS_BUS_DEVICE(dev), 0);
> memory_region_add_subregion(&s->soc.mr_ps, base, mr);
> + g_free(name);
> }
>
> for (i = 0; i < NUM_VIRTIO_TRANSPORT; i++) {
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix memory leaks
2019-01-04 10:47 [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix memory leaks Edgar E. Iglesias
2019-01-04 10:47 ` [Qemu-devel] [PATCH v1 1/1] hw/arm: versal: Plug " Edgar E. Iglesias
@ 2019-01-04 15:18 ` Peter Maydell
1 sibling, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2019-01-04 15:18 UTC (permalink / raw)
To: Edgar E. Iglesias
Cc: QEMU Developers, qemu-arm, KONRAD Frederic, Alistair Francis,
Luc Michel, Philippe Mathieu-Daudé,
Francisco Iglesias, figlesia, Stefano Stabellini,
Sai Pavan Boddu, Edgar Iglesias
On Fri, 4 Jan 2019 at 10:47, Edgar E. Iglesias <edgar.iglesias@gmail.com> wrote:
>
> From: "Edgar E. Iglesias" <edgar.iglesias@xilinx.com>
>
> This series fixes the memory leaks in versal board creation
> reported by Peter Maydell.
>
> Best regards,
> Edgar
>
> Edgar E. Iglesias (1):
> hw/arm: versal: Plug memory leaks
>
Applied to target-arm.next, thanks (with a Fixes: line added)
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-04 15:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 10:47 [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix memory leaks Edgar E. Iglesias
2019-01-04 10:47 ` [Qemu-devel] [PATCH v1 1/1] hw/arm: versal: Plug " Edgar E. Iglesias
2019-01-04 12:10 ` Philippe Mathieu-Daudé
2019-01-04 15:18 ` [Qemu-devel] [PATCH v1 0/1] hw/arm: versal: Fix " Peter Maydell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.