From: Simon Horman <horms@verge.net.au> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Yoshihiro Kaneko <ykaneko0929@gmail.com>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Magnus Damm <magnus.damm@gmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Marek Vasut <marek.vasut@gmail.com> Subject: Re: [PATCH/RFT] arm64: dts: renesas: r8a77990-ebisu: Add BD9571 PMIC Date: Fri, 4 Jan 2019 14:26:56 +0100 [thread overview] Message-ID: <20190104132655.usp2mjyh2sdqds4w@verge.net.au> (raw) In-Reply-To: <CAMuHMdXvGEZpuDr6oWH0QGxVtfx-EUiQJ+_Jt33dZhn_Lw4EYQ@mail.gmail.com> On Mon, Dec 03, 2018 at 09:25:30AM +0100, Geert Uytterhoeven wrote: > Hi Kaneko-san, > > On Sat, Dec 1, 2018 at 3:43 PM Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > This patch adds the regulator definition required for operation of > > S2RAM. > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > @@ -425,6 +425,26 @@ > > }; > > }; > > > > +&i2c_dvfs { > > + status = "okay"; > > + > > + clock-frequency = <400000>; > > + > > + pmic: pmic@30 { > > + pinctrl-0 = <&irq0_pins>; > > + pinctrl-names = "default"; > > + > > + compatible = "rohm,bd9571mwv"; > > + reg = <0x30>; > > + interrupt-parent = <&intc_ex>; > > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + gpio-controller; > > + #gpio-cells = <2>; > > Just adding this node is not sufficient to make S2RAM work. > As per Documentation/devicetree/bindings/mfd/bd9571mwv.txt, you also have > to describe the DDR-Backup Power configuration. > > On the Ebisu-4D development board, only the DDR0 power rail is used, and > needs to be kept powered when backup mode is enabled. > > rohm,ddr-backup-power = <0x1>; > rohm,rstbmode-level; > > Unfortunately resume from s2ram doesn't work with this, probably due to an > issue in ATF. This may have been fixed in IPL and Secure Monitor Rev1.0.22, > which claims to add support for the Ebisu-4D board. Thanks, do you know of any information on how to get IPL and Secure Monitor running / updated on Ebisu-4D? > I don't know if plain Ebisu needs a different configuration. > > > + }; > > +}; > > + > > &lvds0 { > > status = "okay"; > > > > The rest is fine, hence with the above fixed and tested: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> I assume that working S2RAM is part of such testing. Is that correct?
WARNING: multiple messages have this Message-ID (diff)
From: Simon Horman <horms@verge.net.au> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>, Magnus Damm <magnus.damm@gmail.com>, Yoshihiro Kaneko <ykaneko0929@gmail.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Marek Vasut <marek.vasut@gmail.com> Subject: Re: [PATCH/RFT] arm64: dts: renesas: r8a77990-ebisu: Add BD9571 PMIC Date: Fri, 4 Jan 2019 14:26:56 +0100 [thread overview] Message-ID: <20190104132655.usp2mjyh2sdqds4w@verge.net.au> (raw) In-Reply-To: <CAMuHMdXvGEZpuDr6oWH0QGxVtfx-EUiQJ+_Jt33dZhn_Lw4EYQ@mail.gmail.com> On Mon, Dec 03, 2018 at 09:25:30AM +0100, Geert Uytterhoeven wrote: > Hi Kaneko-san, > > On Sat, Dec 1, 2018 at 3:43 PM Yoshihiro Kaneko <ykaneko0929@gmail.com> wrote: > > From: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > > > This patch adds the regulator definition required for operation of > > S2RAM. > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com> > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com> > > Thanks for your patch! > > > --- a/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > +++ b/arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts > > @@ -425,6 +425,26 @@ > > }; > > }; > > > > +&i2c_dvfs { > > + status = "okay"; > > + > > + clock-frequency = <400000>; > > + > > + pmic: pmic@30 { > > + pinctrl-0 = <&irq0_pins>; > > + pinctrl-names = "default"; > > + > > + compatible = "rohm,bd9571mwv"; > > + reg = <0x30>; > > + interrupt-parent = <&intc_ex>; > > + interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > > + interrupt-controller; > > + #interrupt-cells = <2>; > > + gpio-controller; > > + #gpio-cells = <2>; > > Just adding this node is not sufficient to make S2RAM work. > As per Documentation/devicetree/bindings/mfd/bd9571mwv.txt, you also have > to describe the DDR-Backup Power configuration. > > On the Ebisu-4D development board, only the DDR0 power rail is used, and > needs to be kept powered when backup mode is enabled. > > rohm,ddr-backup-power = <0x1>; > rohm,rstbmode-level; > > Unfortunately resume from s2ram doesn't work with this, probably due to an > issue in ATF. This may have been fixed in IPL and Secure Monitor Rev1.0.22, > which claims to add support for the Ebisu-4D board. Thanks, do you know of any information on how to get IPL and Secure Monitor running / updated on Ebisu-4D? > I don't know if plain Ebisu needs a different configuration. > > > + }; > > +}; > > + > > &lvds0 { > > status = "okay"; > > > > The rest is fine, hence with the above fixed and tested: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> I assume that working S2RAM is part of such testing. Is that correct? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-04 13:27 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-12-01 14:43 [PATCH/RFT] arm64: dts: renesas: r8a77990-ebisu: Add BD9571 PMIC Yoshihiro Kaneko 2018-12-01 14:43 ` Yoshihiro Kaneko 2018-12-03 8:25 ` Geert Uytterhoeven 2018-12-03 8:25 ` Geert Uytterhoeven 2019-01-04 13:26 ` Simon Horman [this message] 2019-01-04 13:26 ` Simon Horman 2019-02-07 10:33 ` Geert Uytterhoeven 2019-02-07 10:33 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190104132655.usp2mjyh2sdqds4w@verge.net.au \ --to=horms@verge.net.au \ --cc=geert@linux-m68k.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=magnus.damm@gmail.com \ --cc=marek.vasut@gmail.com \ --cc=ykaneko0929@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.