* [PATCH] Revert "common/config: create $RESULT_BASE before dumping kmemleak leaks"
@ 2019-01-04 14:31 Nikolay Borisov
0 siblings, 0 replies; only message in thread
From: Nikolay Borisov @ 2019-01-04 14:31 UTC (permalink / raw)
To: fstests; +Cc: guaneryu, Nikolay Borisov
This commit tried to fix the brokennes of the kmemleak support but it
inadvertently broke the creation of the RESULT_BASE directory which lead to
problems creating check.time file. Turns out kmemleak support in xfstests has
more problems and it needs to be majorly refactor and this commit doesn't
really solve the problem. For the time being just revert to at least allow
older configuration files, which have explicitly set RESULT_BASE to work.
This reverts commit 7fc034868d5dce9aaf3517c9c2197221b9a772e4.
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
---
check | 7 +++++++
common/config | 5 -----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/check b/check
index e4d767375b57..77a06b00dbba 100755
--- a/check
+++ b/check
@@ -538,6 +538,13 @@ for section in $HOST_OPTIONS_SECTIONS; do
fi
fi
+ mkdir -p $RESULT_BASE
+ if [ ! -d $RESULT_BASE ]; then
+ echo "failed to create results directory $RESULT_BASE"
+ status=1
+ exit
+ fi
+
if $OPTIONS_HAVE_SECTIONS; then
echo "SECTION -- $section"
fi
diff --git a/common/config b/common/config
index fb664cf0a967..5b48e1e7323b 100644
--- a/common/config
+++ b/common/config
@@ -663,11 +663,6 @@ get_next_config() {
# set default RESULT_BASE
if [ -z "$RESULT_BASE" ]; then
export RESULT_BASE="$here/results/"
- mkdir -p ${RESULT_BASE}
- if [ ! -d ${RESULT_BASE} ]; then
- echo "failed to create results directory $RESULT_BASE"
- exit 1
- fi
fi
if [ "$FSTYP" == "tmpfs" ]; then
--
2.12.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-01-04 14:31 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-04 14:31 [PATCH] Revert "common/config: create $RESULT_BASE before dumping kmemleak leaks" Nikolay Borisov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.